secretsmanager.go 31 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981
  1. /*
  2. Copyright © The ESO Authors
  3. Licensed under the Apache License, Version 2.0 (the "License");
  4. you may not use this file except in compliance with the License.
  5. You may obtain a copy of the License at
  6. https://www.apache.org/licenses/LICENSE-2.0
  7. Unless required by applicable law or agreed to in writing, software
  8. distributed under the License is distributed on an "AS IS" BASIS,
  9. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  10. See the License for the specific language governing permissions and
  11. limitations under the License.
  12. */
  13. package secretsmanager
  14. import (
  15. "bytes"
  16. "context"
  17. "encoding/json"
  18. "errors"
  19. "fmt"
  20. "reflect"
  21. "slices"
  22. "strings"
  23. "github.com/aws/aws-sdk-go-v2/aws"
  24. awssm "github.com/aws/aws-sdk-go-v2/service/secretsmanager"
  25. "github.com/aws/aws-sdk-go-v2/service/secretsmanager/types"
  26. "github.com/aws/smithy-go"
  27. "github.com/google/uuid"
  28. "github.com/tidwall/gjson"
  29. "github.com/tidwall/sjson"
  30. corev1 "k8s.io/api/core/v1"
  31. apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
  32. ctrl "sigs.k8s.io/controller-runtime"
  33. "sigs.k8s.io/controller-runtime/pkg/client"
  34. esv1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1"
  35. awsutil "github.com/external-secrets/external-secrets/providers/v1/aws/util"
  36. "github.com/external-secrets/external-secrets/runtime/constants"
  37. "github.com/external-secrets/external-secrets/runtime/esutils"
  38. "github.com/external-secrets/external-secrets/runtime/esutils/metadata"
  39. "github.com/external-secrets/external-secrets/runtime/find"
  40. "github.com/external-secrets/external-secrets/runtime/metrics"
  41. )
  42. // PushSecretMetadataSpec contains metadata information for pushing secrets to AWS Secret Manager.
  43. type PushSecretMetadataSpec struct {
  44. Tags map[string]string `json:"tags,omitempty"`
  45. Description string `json:"description,omitempty"`
  46. SecretPushFormat string `json:"secretPushFormat,omitempty"`
  47. KMSKeyID string `json:"kmsKeyId,omitempty"`
  48. ResourcePolicy *ResourcePolicySpec `json:"resourcePolicy,omitempty"`
  49. }
  50. // ResourcePolicySpec defines the resource policy configuration using PolicySourceRef for AWS Secrets Manager.
  51. type ResourcePolicySpec struct {
  52. BlockPublicPolicy *bool `json:"blockPublicPolicy,omitempty"`
  53. PolicySourceRef *PolicySourceRef `json:"policySourceRef,omitempty"`
  54. }
  55. // PolicySourceRef defines the source reference for the resource policy.
  56. type PolicySourceRef struct {
  57. Kind string `json:"kind"`
  58. Name string `json:"name"`
  59. Key string `json:"key"`
  60. }
  61. // Declares metadata information for pushing secrets to AWS Secret Store.
  62. const (
  63. SecretPushFormatKey = "secretPushFormat"
  64. SecretPushFormatString = "string"
  65. SecretPushFormatBinary = "binary"
  66. ResourceNotFoundException = "ResourceNotFoundException"
  67. )
  68. // https://github.com/external-secrets/external-secrets/issues/644
  69. var _ esv1.SecretsClient = &SecretsManager{}
  70. // SecretsManager is a provider for AWS SecretsManager.
  71. type SecretsManager struct {
  72. cfg *aws.Config
  73. client SMInterface // Keep the interface
  74. referentAuth bool
  75. cache map[string]*awssm.GetSecretValueOutput
  76. config *esv1.SecretsManager
  77. prefix string
  78. newUUID func() string
  79. kube client.Client
  80. namespace string
  81. }
  82. // SMInterface is a subset of the smiface api.
  83. // see: https://docs.aws.amazon.com/sdk-for-go/api/service/secretsmanager/secretsmanageriface/
  84. type SMInterface interface {
  85. BatchGetSecretValue(ctx context.Context, params *awssm.BatchGetSecretValueInput, optFuncs ...func(*awssm.Options)) (*awssm.BatchGetSecretValueOutput, error)
  86. ListSecrets(ctx context.Context, params *awssm.ListSecretsInput, optFuncs ...func(*awssm.Options)) (*awssm.ListSecretsOutput, error)
  87. GetSecretValue(ctx context.Context, params *awssm.GetSecretValueInput, optFuncs ...func(*awssm.Options)) (*awssm.GetSecretValueOutput, error)
  88. CreateSecret(ctx context.Context, params *awssm.CreateSecretInput, optFuncs ...func(*awssm.Options)) (*awssm.CreateSecretOutput, error)
  89. PutSecretValue(ctx context.Context, params *awssm.PutSecretValueInput, optFuncs ...func(*awssm.Options)) (*awssm.PutSecretValueOutput, error)
  90. DescribeSecret(ctx context.Context, params *awssm.DescribeSecretInput, optFuncs ...func(*awssm.Options)) (*awssm.DescribeSecretOutput, error)
  91. DeleteSecret(ctx context.Context, params *awssm.DeleteSecretInput, optFuncs ...func(*awssm.Options)) (*awssm.DeleteSecretOutput, error)
  92. TagResource(ctx context.Context, params *awssm.TagResourceInput, optFuncs ...func(*awssm.Options)) (*awssm.TagResourceOutput, error)
  93. UntagResource(ctx context.Context, params *awssm.UntagResourceInput, optFuncs ...func(*awssm.Options)) (*awssm.UntagResourceOutput, error)
  94. PutResourcePolicy(ctx context.Context, params *awssm.PutResourcePolicyInput, optFuncs ...func(*awssm.Options)) (*awssm.PutResourcePolicyOutput, error)
  95. GetResourcePolicy(ctx context.Context, params *awssm.GetResourcePolicyInput, optFuncs ...func(*awssm.Options)) (*awssm.GetResourcePolicyOutput, error)
  96. DeleteResourcePolicy(ctx context.Context, params *awssm.DeleteResourcePolicyInput, optFuncs ...func(*awssm.Options)) (*awssm.DeleteResourcePolicyOutput, error)
  97. }
  98. const (
  99. errUnexpectedFindOperator = "unexpected find operator"
  100. managedBy = "managed-by"
  101. externalSecrets = "external-secrets"
  102. initialVersion = "00000000-0000-0000-0000-000000000001"
  103. )
  104. var log = ctrl.Log.WithName("provider").WithName("aws").WithName("secretsmanager")
  105. // New creates a new SecretsManager client.
  106. func New(_ context.Context, cfg *aws.Config, secretsManagerCfg *esv1.SecretsManager, prefix string, referentAuth bool, kube client.Client, namespace string) (*SecretsManager, error) {
  107. return &SecretsManager{
  108. cfg: cfg,
  109. client: awssm.NewFromConfig(*cfg, func(o *awssm.Options) {
  110. o.EndpointResolverV2 = customEndpointResolver{}
  111. }),
  112. referentAuth: referentAuth,
  113. cache: make(map[string]*awssm.GetSecretValueOutput),
  114. config: secretsManagerCfg,
  115. prefix: prefix,
  116. kube: kube,
  117. namespace: namespace,
  118. }, nil
  119. }
  120. func (sm *SecretsManager) fetch(ctx context.Context, ref esv1.ExternalSecretDataRemoteRef) (*awssm.GetSecretValueOutput, error) {
  121. ver := "AWSCURRENT"
  122. valueFrom := "SECRET"
  123. if ref.Version != "" {
  124. ver = ref.Version
  125. }
  126. if ref.MetadataPolicy == esv1.ExternalSecretMetadataPolicyFetch {
  127. valueFrom = "TAG"
  128. }
  129. key := sm.prefix + ref.Key
  130. log.Info("fetching secret value", "key", key, "version", ver, "value", valueFrom)
  131. cacheKey := fmt.Sprintf("%s#%s#%s", key, ver, valueFrom)
  132. if secretOut, found := sm.cache[cacheKey]; found {
  133. log.Info("found secret in cache", "key", key, "version", ver)
  134. return secretOut, nil
  135. }
  136. secretOut, err := sm.constructSecretValue(ctx, key, ver, ref.MetadataPolicy)
  137. if err != nil {
  138. return nil, err
  139. }
  140. sm.cache[cacheKey] = secretOut
  141. return secretOut, nil
  142. }
  143. // DeleteSecret deletes a secret from AWS Secrets Manager.
  144. func (sm *SecretsManager) DeleteSecret(ctx context.Context, remoteRef esv1.PushSecretRemoteRef) error {
  145. secretName := sm.prefix + remoteRef.GetRemoteKey()
  146. secretValue := awssm.GetSecretValueInput{
  147. SecretId: &secretName,
  148. }
  149. secretInput := awssm.DescribeSecretInput{
  150. SecretId: &secretName,
  151. }
  152. awsSecret, err := sm.client.GetSecretValue(ctx, &secretValue)
  153. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMGetSecretValue, err)
  154. var aerr smithy.APIError
  155. if err != nil {
  156. if ok := errors.As(err, &aerr); !ok {
  157. return err
  158. }
  159. if aerr.ErrorCode() == ResourceNotFoundException {
  160. return nil
  161. }
  162. return err
  163. }
  164. data, err := sm.client.DescribeSecret(ctx, &secretInput)
  165. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMDescribeSecret, err)
  166. if err != nil {
  167. return err
  168. }
  169. if !isManagedByESO(data) {
  170. return nil
  171. }
  172. deleteInput := &awssm.DeleteSecretInput{
  173. SecretId: awsSecret.ARN,
  174. }
  175. if sm.config != nil && sm.config.ForceDeleteWithoutRecovery {
  176. deleteInput.ForceDeleteWithoutRecovery = &sm.config.ForceDeleteWithoutRecovery
  177. }
  178. if sm.config != nil && sm.config.RecoveryWindowInDays > 0 {
  179. deleteInput.RecoveryWindowInDays = &sm.config.RecoveryWindowInDays
  180. }
  181. err = awsutil.ValidateDeleteSecretInput(*deleteInput)
  182. if err != nil {
  183. return err
  184. }
  185. _, err = sm.client.DeleteSecret(ctx, deleteInput)
  186. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMDeleteSecret, err)
  187. return err
  188. }
  189. // SecretExists checks if a secret exists in AWS Secrets Manager.
  190. func (sm *SecretsManager) SecretExists(ctx context.Context, pushSecretRef esv1.PushSecretRemoteRef) (bool, error) {
  191. secretName := sm.prefix + pushSecretRef.GetRemoteKey()
  192. secretValue := awssm.GetSecretValueInput{
  193. SecretId: &secretName,
  194. }
  195. _, err := sm.client.GetSecretValue(ctx, &secretValue)
  196. if err != nil {
  197. return sm.handleSecretError(err)
  198. }
  199. return true, nil
  200. }
  201. func (sm *SecretsManager) handleSecretError(err error) (bool, error) {
  202. var aerr smithy.APIError
  203. if ok := errors.As(err, &aerr); !ok {
  204. return false, err
  205. }
  206. if aerr.ErrorCode() == ResourceNotFoundException {
  207. return false, nil
  208. }
  209. return false, err
  210. }
  211. // PushSecret pushes a secret to AWS Secrets Manager.
  212. func (sm *SecretsManager) PushSecret(ctx context.Context, secret *corev1.Secret, psd esv1.PushSecretData) error {
  213. value, err := esutils.ExtractSecretData(psd, secret)
  214. if err != nil {
  215. return fmt.Errorf("failed to extract secret data: %w", err)
  216. }
  217. secretName := sm.prefix + psd.GetRemoteKey()
  218. describeSecretInput := awssm.DescribeSecretInput{SecretId: &secretName}
  219. describeSecretOutput, err := sm.client.DescribeSecret(ctx, &describeSecretInput)
  220. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMDescribeSecret, err)
  221. var aerr smithy.APIError
  222. if err != nil {
  223. if ok := errors.As(err, &aerr); !ok {
  224. return err
  225. }
  226. if aerr.ErrorCode() == ResourceNotFoundException {
  227. finalValue, err := sm.getNewSecretValue(value, psd.GetProperty(), nil)
  228. if err != nil {
  229. return err
  230. }
  231. return sm.createSecretWithContext(ctx, secretName, psd, finalValue)
  232. }
  233. return err
  234. } else if !isManagedByESO(describeSecretOutput) {
  235. return errors.New("secret not managed by external-secrets")
  236. }
  237. if len(describeSecretOutput.VersionIdsToStages) == 0 {
  238. finalValue, err := sm.getNewSecretValue(value, psd.GetProperty(), nil)
  239. if err != nil {
  240. return err
  241. }
  242. return sm.putSecretValueWithContext(ctx, secretName, nil, psd, finalValue, describeSecretOutput.Tags)
  243. }
  244. getSecretValueInput := awssm.GetSecretValueInput{SecretId: &secretName}
  245. getSecretValueOutput, err := sm.client.GetSecretValue(ctx, &getSecretValueInput)
  246. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMGetSecretValue, err)
  247. if err != nil {
  248. return err
  249. }
  250. finalValue, err := sm.getNewSecretValue(value, psd.GetProperty(), getSecretValueOutput)
  251. if err != nil {
  252. return err
  253. }
  254. return sm.putSecretValueWithContext(ctx, secretName, getSecretValueOutput, psd, finalValue, describeSecretOutput.Tags)
  255. }
  256. func (sm *SecretsManager) getNewSecretValue(value []byte, property string, existingSecret *awssm.GetSecretValueOutput) ([]byte, error) {
  257. if property == "" {
  258. return value, nil
  259. }
  260. if existingSecret == nil {
  261. value, _ = sjson.SetBytes([]byte{}, property, value)
  262. return value, nil
  263. }
  264. currentSecret := sm.retrievePayload(existingSecret)
  265. if currentSecret != "" && !gjson.Valid(currentSecret) {
  266. return nil, errors.New("PushSecret for aws secrets manager with a pushSecretData property requires a json secret")
  267. }
  268. value, _ = sjson.SetBytes([]byte(currentSecret), property, value)
  269. return value, nil
  270. }
  271. func isManagedByESO(data *awssm.DescribeSecretOutput) bool {
  272. managedBy := managedBy
  273. externalSecrets := externalSecrets
  274. for _, tag := range data.Tags {
  275. if *tag.Key == managedBy && *tag.Value == externalSecrets {
  276. return true
  277. }
  278. }
  279. return false
  280. }
  281. // GetAllSecrets syncs multiple secrets from aws provider into a single Kubernetes Secret.
  282. func (sm *SecretsManager) GetAllSecrets(ctx context.Context, ref esv1.ExternalSecretFind) (map[string][]byte, error) {
  283. hasName := ref.Name != nil
  284. hasTags := len(ref.Tags) > 0
  285. filters := make([]types.Filter, 0)
  286. switch {
  287. case !hasName && !hasTags:
  288. return nil, errors.New(errUnexpectedFindOperator)
  289. case hasName && !hasTags:
  290. return sm.findByName(ctx, ref, filters)
  291. case !hasName && hasTags:
  292. return sm.findByTags(ctx, ref)
  293. case hasName && hasTags:
  294. return sm.findByNameAndTags(ctx, ref, filters)
  295. default:
  296. return nil, errors.New(errUnexpectedFindOperator)
  297. }
  298. }
  299. func (sm *SecretsManager) findByNameAndTags(ctx context.Context, ref esv1.ExternalSecretFind, filters []types.Filter) (map[string][]byte, error) {
  300. for k, v := range ref.Tags {
  301. filters = append(filters, types.Filter{
  302. Key: types.FilterNameStringTypeTagKey,
  303. Values: []string{
  304. k,
  305. },
  306. }, types.Filter{
  307. Key: types.FilterNameStringTypeTagValue,
  308. Values: []string{
  309. v,
  310. },
  311. })
  312. }
  313. return sm.findByName(ctx, ref, filters)
  314. }
  315. func (sm *SecretsManager) findByName(ctx context.Context, ref esv1.ExternalSecretFind, filters []types.Filter) (map[string][]byte, error) {
  316. matcher, err := find.New(*ref.Name)
  317. if err != nil {
  318. return nil, err
  319. }
  320. if ref.Path != nil {
  321. filters = append(filters, types.Filter{
  322. Key: types.FilterNameStringTypeName,
  323. Values: []string{
  324. *ref.Path,
  325. },
  326. })
  327. return sm.fetchWithBatch(ctx, filters, matcher)
  328. }
  329. data := make(map[string][]byte)
  330. var nextToken *string
  331. for {
  332. // I put this into the for loop on purpose.
  333. log.V(0).Info("using ListSecret to fetch all secrets; this is a costly operations, please use batching by defining a _path_")
  334. it, err := sm.client.ListSecrets(ctx, &awssm.ListSecretsInput{
  335. Filters: filters,
  336. NextToken: nextToken,
  337. })
  338. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMListSecrets, err)
  339. if err != nil {
  340. return nil, err
  341. }
  342. log.V(1).Info("aws sm findByName found", "secrets", len(it.SecretList))
  343. for _, secret := range it.SecretList {
  344. if !matcher.MatchName(*secret.Name) {
  345. continue
  346. }
  347. log.V(1).Info("aws sm findByName matches", "name", *secret.Name)
  348. if err := sm.fetchAndSet(ctx, data, *secret.Name); err != nil {
  349. return nil, err
  350. }
  351. }
  352. nextToken = it.NextToken
  353. if nextToken == nil {
  354. break
  355. }
  356. }
  357. return data, nil
  358. }
  359. func (sm *SecretsManager) findByTags(ctx context.Context, ref esv1.ExternalSecretFind) (map[string][]byte, error) {
  360. filters := make([]types.Filter, 0)
  361. for k, v := range ref.Tags {
  362. filters = append(filters, types.Filter{
  363. Key: types.FilterNameStringTypeTagKey,
  364. Values: []string{
  365. k,
  366. },
  367. }, types.Filter{
  368. Key: types.FilterNameStringTypeTagValue,
  369. Values: []string{
  370. v,
  371. },
  372. })
  373. }
  374. if ref.Path != nil {
  375. filters = append(filters, types.Filter{
  376. Key: types.FilterNameStringTypeName,
  377. Values: []string{
  378. *ref.Path,
  379. },
  380. })
  381. }
  382. return sm.fetchWithBatch(ctx, filters, nil)
  383. }
  384. func (sm *SecretsManager) fetchAndSet(ctx context.Context, data map[string][]byte, name string) error {
  385. sec, err := sm.fetch(ctx, esv1.ExternalSecretDataRemoteRef{
  386. Key: name,
  387. })
  388. if err != nil {
  389. return err
  390. }
  391. if sec.SecretString != nil {
  392. data[name] = []byte(*sec.SecretString)
  393. }
  394. if sec.SecretBinary != nil {
  395. data[name] = sec.SecretBinary
  396. }
  397. return nil
  398. }
  399. // GetSecret returns a single secret from the provider.
  400. func (sm *SecretsManager) GetSecret(ctx context.Context, ref esv1.ExternalSecretDataRemoteRef) ([]byte, error) {
  401. secretOut, err := sm.fetch(ctx, ref)
  402. if errors.Is(err, esv1.NoSecretErr) {
  403. return nil, err
  404. }
  405. if err != nil {
  406. return nil, awsutil.SanitizeErr(err)
  407. }
  408. if ref.Property == "" {
  409. if secretOut.SecretString != nil {
  410. return []byte(*secretOut.SecretString), nil
  411. }
  412. if secretOut.SecretBinary != nil {
  413. return secretOut.SecretBinary, nil
  414. }
  415. return nil, fmt.Errorf("invalid secret received. no secret string nor binary for key: %s", ref.Key)
  416. }
  417. val := sm.mapSecretToGjson(secretOut, ref.Property)
  418. if !val.Exists() {
  419. return nil, fmt.Errorf("key %s does not exist in secret %s", ref.Property, ref.Key)
  420. }
  421. return []byte(val.String()), nil
  422. }
  423. func (sm *SecretsManager) mapSecretToGjson(secretOut *awssm.GetSecretValueOutput, property string) gjson.Result {
  424. payload := sm.retrievePayload(secretOut)
  425. refProperty := sm.escapeDotsIfRequired(property, payload)
  426. val := gjson.Get(payload, refProperty)
  427. return val
  428. }
  429. func (sm *SecretsManager) retrievePayload(secretOut *awssm.GetSecretValueOutput) string {
  430. if secretOut == nil {
  431. return ""
  432. }
  433. var payload string
  434. if secretOut.SecretString != nil {
  435. payload = *secretOut.SecretString
  436. }
  437. if secretOut.SecretBinary != nil {
  438. payload = string(secretOut.SecretBinary)
  439. }
  440. return payload
  441. }
  442. func (sm *SecretsManager) escapeDotsIfRequired(currentRefProperty, payload string) string {
  443. // We need to search if a given key with a . exists before using gjson operations.
  444. found := strings.Contains(currentRefProperty, ".")
  445. refProperty := currentRefProperty
  446. if found {
  447. refProperty = strings.ReplaceAll(currentRefProperty, ".", "\\.")
  448. val := gjson.Get(payload, refProperty)
  449. if !val.Exists() {
  450. refProperty = currentRefProperty
  451. }
  452. }
  453. return refProperty
  454. }
  455. // GetSecretMap returns multiple k/v pairs from the provider.
  456. func (sm *SecretsManager) GetSecretMap(ctx context.Context, ref esv1.ExternalSecretDataRemoteRef) (map[string][]byte, error) {
  457. log.Info("fetching secret map", "key", ref.Key)
  458. data, err := sm.GetSecret(ctx, ref)
  459. if err != nil {
  460. return nil, err
  461. }
  462. kv := make(map[string]json.RawMessage)
  463. err = json.Unmarshal(data, &kv)
  464. if err != nil {
  465. return nil, fmt.Errorf("unable to unmarshal secret %s: %w", ref.Key, err)
  466. }
  467. secretData := make(map[string][]byte)
  468. for k, v := range kv {
  469. var strVal string
  470. err = json.Unmarshal(v, &strVal)
  471. if err == nil {
  472. secretData[k] = []byte(strVal)
  473. } else {
  474. secretData[k] = v
  475. }
  476. }
  477. return secretData, nil
  478. }
  479. // Close closes the provider client connection.
  480. func (sm *SecretsManager) Close(_ context.Context) error {
  481. return nil
  482. }
  483. // Validate validates the provider configuration.
  484. func (sm *SecretsManager) Validate() (esv1.ValidationResult, error) {
  485. // skip validation stack because it depends on the namespace
  486. // of the ExternalSecret
  487. if sm.referentAuth {
  488. return esv1.ValidationResultUnknown, nil
  489. }
  490. _, err := sm.cfg.Credentials.Retrieve(context.Background())
  491. if err != nil {
  492. return esv1.ValidationResultError, awsutil.SanitizeErr(err)
  493. }
  494. return esv1.ValidationResultReady, nil
  495. }
  496. // Capabilities returns the provider's esv1.SecretStoreCapabilities.
  497. func (sm *SecretsManager) Capabilities() esv1.SecretStoreCapabilities {
  498. return esv1.SecretStoreReadWrite
  499. }
  500. func (sm *SecretsManager) createSecretWithContext(ctx context.Context, secretName string, psd esv1.PushSecretData, value []byte) error {
  501. mdata, err := sm.constructMetadataWithDefaults(psd.GetMetadata())
  502. if err != nil {
  503. return fmt.Errorf("failed to parse push secret metadata: %w", err)
  504. }
  505. tags := make([]types.Tag, 0)
  506. for k, v := range mdata.Spec.Tags {
  507. tags = append(tags, types.Tag{
  508. Key: new(k),
  509. Value: new(v),
  510. })
  511. }
  512. input := &awssm.CreateSecretInput{
  513. Name: &secretName,
  514. SecretBinary: value,
  515. Tags: tags,
  516. Description: new(mdata.Spec.Description),
  517. ClientRequestToken: new(initialVersion),
  518. KmsKeyId: new(mdata.Spec.KMSKeyID),
  519. }
  520. if mdata.Spec.SecretPushFormat == SecretPushFormatString {
  521. input.SecretBinary = nil
  522. input.SecretString = aws.String(string(value))
  523. }
  524. createOutput, err := sm.client.CreateSecret(ctx, input)
  525. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMCreateSecret, err)
  526. if err != nil {
  527. return err
  528. }
  529. // Apply resource policy if specified
  530. if mdata.Spec.ResourcePolicy != nil && mdata.Spec.ResourcePolicy.PolicySourceRef != nil {
  531. policyJSON, err := sm.resolveResourcePolicy(ctx, mdata.Spec.ResourcePolicy.PolicySourceRef)
  532. if err != nil {
  533. return fmt.Errorf("failed to resolve resource policy: %w", err)
  534. }
  535. putPolicyInput := &awssm.PutResourcePolicyInput{
  536. SecretId: createOutput.ARN,
  537. ResourcePolicy: aws.String(policyJSON),
  538. }
  539. if mdata.Spec.ResourcePolicy.BlockPublicPolicy != nil {
  540. putPolicyInput.BlockPublicPolicy = mdata.Spec.ResourcePolicy.BlockPublicPolicy
  541. }
  542. _, err = sm.client.PutResourcePolicy(ctx, putPolicyInput)
  543. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMPutResourcePolicy, err)
  544. if err != nil {
  545. return fmt.Errorf("failed to put resource policy: %w", err)
  546. }
  547. }
  548. return nil
  549. }
  550. func (sm *SecretsManager) putSecretValueWithContext(ctx context.Context, secretArn string, awsSecret *awssm.GetSecretValueOutput, psd esv1.PushSecretData, value []byte, tags []types.Tag) error {
  551. currentTags := make(map[string]string, len(tags))
  552. for _, tag := range tags {
  553. currentTags[*tag.Key] = *tag.Value
  554. }
  555. if err := sm.patchTags(ctx, psd.GetMetadata(), &secretArn, currentTags); err != nil {
  556. return err
  557. }
  558. if err := sm.manageResourcePolicy(ctx, psd.GetMetadata(), &secretArn); err != nil {
  559. return err
  560. }
  561. if awsSecret != nil && (bytes.Equal(awsSecret.SecretBinary, value) || esutils.CompareStringAndByteSlices(awsSecret.SecretString, value)) {
  562. return nil
  563. }
  564. newVersionNumber := initialVersion
  565. if awsSecret != nil {
  566. if sm.newUUID == nil {
  567. newVersionNumber = uuid.NewString()
  568. } else {
  569. newVersionNumber = sm.newUUID()
  570. }
  571. }
  572. input := &awssm.PutSecretValueInput{
  573. SecretId: &secretArn,
  574. SecretBinary: value,
  575. ClientRequestToken: aws.String(newVersionNumber),
  576. }
  577. secretPushFormat, err := esutils.FetchValueFromMetadata(SecretPushFormatKey, psd.GetMetadata(), SecretPushFormatBinary)
  578. if err != nil {
  579. return fmt.Errorf("failed to parse metadata: %w", err)
  580. }
  581. if secretPushFormat == SecretPushFormatString {
  582. input.SecretBinary = nil
  583. input.SecretString = aws.String(string(value))
  584. }
  585. _, err = sm.client.PutSecretValue(ctx, input)
  586. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMPutSecretValue, err)
  587. return err
  588. }
  589. func (sm *SecretsManager) patchTags(ctx context.Context, metadata *apiextensionsv1.JSON, secretID *string, tags map[string]string) error {
  590. meta, err := sm.constructMetadataWithDefaults(metadata)
  591. if err != nil {
  592. return err
  593. }
  594. tagKeysToRemove := awsutil.FindTagKeysToRemove(tags, meta.Spec.Tags)
  595. if len(tagKeysToRemove) > 0 {
  596. _, err = sm.client.UntagResource(ctx, &awssm.UntagResourceInput{
  597. SecretId: secretID,
  598. TagKeys: tagKeysToRemove,
  599. })
  600. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMUntagResource, err)
  601. if err != nil {
  602. return err
  603. }
  604. }
  605. tagsToUpdate, isModified := computeTagsToUpdate(tags, meta.Spec.Tags)
  606. if isModified {
  607. _, err = sm.client.TagResource(ctx, &awssm.TagResourceInput{
  608. SecretId: secretID,
  609. Tags: tagsToUpdate,
  610. })
  611. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMTagResource, err)
  612. if err != nil {
  613. return err
  614. }
  615. }
  616. return nil
  617. }
  618. func (sm *SecretsManager) fetchWithBatch(ctx context.Context, filters []types.Filter, matcher *find.Matcher) (map[string][]byte, error) {
  619. data := make(map[string][]byte)
  620. var nextToken *string
  621. for {
  622. it, err := sm.client.BatchGetSecretValue(ctx, &awssm.BatchGetSecretValueInput{
  623. Filters: filters,
  624. NextToken: nextToken,
  625. })
  626. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMBatchGetSecretValue, err)
  627. if err != nil {
  628. return nil, err
  629. }
  630. log.V(1).Info("aws sm findByName found", "secrets", len(it.SecretValues))
  631. for _, secret := range it.SecretValues {
  632. if matcher != nil && !matcher.MatchName(*secret.Name) {
  633. continue
  634. }
  635. log.V(1).Info("aws sm findByName matches", "name", *secret.Name)
  636. sm.setSecretValues(&secret, data)
  637. }
  638. nextToken = it.NextToken
  639. if nextToken == nil {
  640. break
  641. }
  642. }
  643. return data, nil
  644. }
  645. func (sm *SecretsManager) setSecretValues(secret *types.SecretValueEntry, data map[string][]byte) {
  646. if secret.SecretString != nil {
  647. data[*secret.Name] = []byte(*secret.SecretString)
  648. }
  649. if secret.SecretBinary != nil {
  650. data[*secret.Name] = secret.SecretBinary
  651. }
  652. }
  653. func (sm *SecretsManager) constructSecretValue(ctx context.Context, key, ver string, metadataPolicy esv1.ExternalSecretMetadataPolicy) (*awssm.GetSecretValueOutput, error) {
  654. if metadataPolicy == esv1.ExternalSecretMetadataPolicyFetch {
  655. describeSecretInput := &awssm.DescribeSecretInput{
  656. SecretId: &key,
  657. }
  658. descOutput, err := sm.client.DescribeSecret(ctx, describeSecretInput)
  659. if err != nil {
  660. return nil, err
  661. }
  662. log.Info("found metadata secret", "key", key, "output", descOutput)
  663. jsonTags, err := awsutil.SecretTagsToJSONString(descOutput.Tags)
  664. if err != nil {
  665. return nil, err
  666. }
  667. return &awssm.GetSecretValueOutput{
  668. ARN: descOutput.ARN,
  669. CreatedDate: descOutput.CreatedDate,
  670. Name: descOutput.Name,
  671. SecretString: &jsonTags,
  672. VersionId: &ver,
  673. }, nil
  674. }
  675. var getSecretValueInput *awssm.GetSecretValueInput
  676. if after, ok := strings.CutPrefix(ver, "uuid/"); ok {
  677. versionID := after
  678. getSecretValueInput = &awssm.GetSecretValueInput{
  679. SecretId: &key,
  680. VersionId: &versionID,
  681. }
  682. } else {
  683. getSecretValueInput = &awssm.GetSecretValueInput{
  684. SecretId: &key,
  685. VersionStage: &ver,
  686. }
  687. }
  688. secretOut, err := sm.client.GetSecretValue(ctx, getSecretValueInput)
  689. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMGetSecretValue, err)
  690. var (
  691. nf *types.ResourceNotFoundException
  692. ie *types.InvalidParameterException
  693. )
  694. if errors.As(err, &nf) {
  695. return nil, esv1.NoSecretErr
  696. }
  697. if errors.As(err, &ie) && strings.Contains(ie.Error(), "was marked for deletion") {
  698. return nil, esv1.NoSecretErr
  699. }
  700. return secretOut, err
  701. }
  702. func (sm *SecretsManager) constructMetadataWithDefaults(data *apiextensionsv1.JSON) (*metadata.PushSecretMetadata[PushSecretMetadataSpec], error) {
  703. var (
  704. meta *metadata.PushSecretMetadata[PushSecretMetadataSpec]
  705. err error
  706. )
  707. meta, err = metadata.ParseMetadataParameters[PushSecretMetadataSpec](data)
  708. if err != nil {
  709. return nil, fmt.Errorf("failed to parse metadata: %w", err)
  710. }
  711. if meta == nil {
  712. meta = &metadata.PushSecretMetadata[PushSecretMetadataSpec]{}
  713. }
  714. if meta.Spec.SecretPushFormat == "" {
  715. meta.Spec.SecretPushFormat = SecretPushFormatBinary
  716. } else if !slices.Contains([]string{SecretPushFormatBinary, SecretPushFormatString}, meta.Spec.SecretPushFormat) {
  717. return nil, fmt.Errorf("invalid secret push format: %s", meta.Spec.SecretPushFormat)
  718. }
  719. if meta.Spec.Description == "" {
  720. meta.Spec.Description = fmt.Sprintf("secret '%s:%s'", managedBy, externalSecrets)
  721. }
  722. if meta.Spec.KMSKeyID == "" {
  723. meta.Spec.KMSKeyID = "alias/aws/secretsmanager"
  724. }
  725. if len(meta.Spec.Tags) > 0 {
  726. if _, exists := meta.Spec.Tags[managedBy]; exists {
  727. return nil, fmt.Errorf("error parsing tags in metadata: Cannot specify a '%s' tag", managedBy)
  728. }
  729. } else {
  730. meta.Spec.Tags = make(map[string]string)
  731. }
  732. meta.Spec.Tags[managedBy] = externalSecrets
  733. return meta, nil
  734. }
  735. // resolveResourcePolicy resolves the policy JSON from the PolicySourceRef.
  736. func (sm *SecretsManager) resolveResourcePolicy(ctx context.Context, policyRef *PolicySourceRef) (string, error) {
  737. if policyRef == nil {
  738. return "", errors.New("policySourceRef is nil")
  739. }
  740. switch policyRef.Kind {
  741. case "ConfigMap":
  742. cm := &corev1.ConfigMap{}
  743. if err := sm.kube.Get(ctx, client.ObjectKey{
  744. Namespace: sm.namespace,
  745. Name: policyRef.Name,
  746. }, cm); err != nil {
  747. return "", fmt.Errorf("failed to get ConfigMap %s/%s: %w", sm.namespace, policyRef.Name, err)
  748. }
  749. policy, ok := cm.Data[policyRef.Key]
  750. if !ok {
  751. return "", fmt.Errorf("key %s not found in ConfigMap %s/%s", policyRef.Key, sm.namespace, policyRef.Name)
  752. }
  753. return policy, nil
  754. case "Secret":
  755. secret := &corev1.Secret{}
  756. if err := sm.kube.Get(ctx, client.ObjectKey{
  757. Namespace: sm.namespace,
  758. Name: policyRef.Name,
  759. }, secret); err != nil {
  760. return "", fmt.Errorf("failed to get Secret %s/%s: %w", sm.namespace, policyRef.Name, err)
  761. }
  762. policyBytes, ok := secret.Data[policyRef.Key]
  763. if !ok {
  764. return "", fmt.Errorf("key %s not found in Secret %s/%s", policyRef.Key, sm.namespace, policyRef.Name)
  765. }
  766. return string(policyBytes), nil
  767. default:
  768. return "", fmt.Errorf("unsupported PolicySourceRef kind: %s (must be ConfigMap or Secret)", policyRef.Kind)
  769. }
  770. }
  771. // unmarshalPolicyJSON parses a JSON policy string into a map.
  772. // Returns nil map for empty input, allowing comparison with a populated policy.
  773. func unmarshalPolicyJSON(policy string) (map[string]any, error) {
  774. if policy == "" {
  775. return nil, nil
  776. }
  777. var m map[string]any
  778. if err := json.Unmarshal([]byte(policy), &m); err != nil {
  779. return nil, err
  780. }
  781. return m, nil
  782. }
  783. func (sm *SecretsManager) deleteResourcePolicy(ctx context.Context, secretID *string) error {
  784. deletePolicyInput := &awssm.DeleteResourcePolicyInput{
  785. SecretId: secretID,
  786. }
  787. _, err := sm.client.DeleteResourcePolicy(ctx, deletePolicyInput)
  788. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMDeleteResourcePolicy, err)
  789. var nf *types.ResourceNotFoundException
  790. if err != nil && !errors.As(err, &nf) {
  791. return fmt.Errorf("failed to delete resource policy: %w", err)
  792. }
  793. return nil
  794. }
  795. // manageResourcePolicy applies or removes the resource policy based on metadata.
  796. func (sm *SecretsManager) manageResourcePolicy(ctx context.Context, metadata *apiextensionsv1.JSON, secretID *string) error {
  797. meta, err := sm.constructMetadataWithDefaults(metadata)
  798. if err != nil {
  799. return err
  800. }
  801. // Delete policy if policyRef is nil and the policy exists.
  802. if meta.Spec.ResourcePolicy == nil {
  803. return sm.deleteResourcePolicy(ctx, secretID)
  804. }
  805. // Normal flow, is to create the policy.
  806. policyJSON, err := sm.resolveResourcePolicy(ctx, meta.Spec.ResourcePolicy.PolicySourceRef)
  807. if err != nil {
  808. return fmt.Errorf("failed to resolve resource policy: %w", err)
  809. }
  810. if policyJSON == "" {
  811. return sm.deleteResourcePolicy(ctx, secretID)
  812. }
  813. getCurrentPolicyInput := &awssm.GetResourcePolicyInput{
  814. SecretId: secretID,
  815. }
  816. currentPolicyOutput, err := sm.client.GetResourcePolicy(ctx, getCurrentPolicyInput)
  817. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMGetResourcePolicy, err)
  818. var nf *types.ResourceNotFoundException
  819. if err != nil && !errors.As(err, &nf) {
  820. return fmt.Errorf("failed to get current resource policy: %w", err)
  821. }
  822. currentPolicy := ""
  823. if currentPolicyOutput != nil && currentPolicyOutput.ResourcePolicy != nil {
  824. currentPolicy = *currentPolicyOutput.ResourcePolicy
  825. }
  826. currentPolicyMap, err := unmarshalPolicyJSON(currentPolicy)
  827. if err != nil {
  828. return fmt.Errorf("failed to unmarshal current resource policy: %w", err)
  829. }
  830. desiredPolicyMap, err := unmarshalPolicyJSON(policyJSON)
  831. if err != nil {
  832. return fmt.Errorf("failed to unmarshal desired resource policy: %w", err)
  833. }
  834. if reflect.DeepEqual(currentPolicyMap, desiredPolicyMap) {
  835. return nil
  836. }
  837. putPolicyInput := &awssm.PutResourcePolicyInput{
  838. SecretId: secretID,
  839. ResourcePolicy: aws.String(policyJSON),
  840. }
  841. if meta.Spec.ResourcePolicy.BlockPublicPolicy != nil {
  842. putPolicyInput.BlockPublicPolicy = meta.Spec.ResourcePolicy.BlockPublicPolicy
  843. }
  844. _, err = sm.client.PutResourcePolicy(ctx, putPolicyInput)
  845. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMPutResourcePolicy, err)
  846. if err != nil {
  847. return fmt.Errorf("failed to put resource policy: %w", err)
  848. }
  849. return nil
  850. }
  851. // computeTagsToUpdate compares the current tags with the desired metaTags and returns a slice of ssmTypes.Tag
  852. // that should be set on the resource. It also returns a boolean indicating if any tag was added or modified.
  853. func computeTagsToUpdate(tags, metaTags map[string]string) ([]types.Tag, bool) {
  854. result := make([]types.Tag, 0, len(metaTags))
  855. modified := false
  856. for k, v := range metaTags {
  857. if _, exists := tags[k]; !exists || tags[k] != v {
  858. if k != managedBy {
  859. modified = true
  860. }
  861. }
  862. result = append(result, types.Tag{
  863. Key: new(k),
  864. Value: new(v),
  865. })
  866. }
  867. return result, modified
  868. }