secretsmanager.go 14 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470
  1. /*
  2. Licensed under the Apache License, Version 2.0 (the "License");
  3. you may not use this file except in compliance with the License.
  4. You may obtain a copy of the License at
  5. http://www.apache.org/licenses/LICENSE-2.0
  6. Unless required by applicable law or agreed to in writing, software
  7. distributed under the License is distributed on an "AS IS" BASIS,
  8. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  9. See the License for the specific language governing permissions and
  10. limitations under the License.
  11. */
  12. package secretsmanager
  13. import (
  14. "bytes"
  15. "context"
  16. "encoding/json"
  17. "errors"
  18. "fmt"
  19. "strings"
  20. "github.com/aws/aws-sdk-go/aws"
  21. "github.com/aws/aws-sdk-go/aws/awserr"
  22. "github.com/aws/aws-sdk-go/aws/request"
  23. "github.com/aws/aws-sdk-go/aws/session"
  24. awssm "github.com/aws/aws-sdk-go/service/secretsmanager"
  25. "github.com/tidwall/gjson"
  26. utilpointer "k8s.io/utils/pointer"
  27. ctrl "sigs.k8s.io/controller-runtime"
  28. esv1beta1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1beta1"
  29. "github.com/external-secrets/external-secrets/pkg/constants"
  30. "github.com/external-secrets/external-secrets/pkg/find"
  31. "github.com/external-secrets/external-secrets/pkg/metrics"
  32. "github.com/external-secrets/external-secrets/pkg/provider/aws/util"
  33. )
  34. // https://github.com/external-secrets/external-secrets/issues/644
  35. var _ esv1beta1.SecretsClient = &SecretsManager{}
  36. // SecretsManager is a provider for AWS SecretsManager.
  37. type SecretsManager struct {
  38. sess *session.Session
  39. client SMInterface
  40. referentAuth bool
  41. cache map[string]*awssm.GetSecretValueOutput
  42. }
  43. // SMInterface is a subset of the smiface api.
  44. // see: https://docs.aws.amazon.com/sdk-for-go/api/service/secretsmanager/secretsmanageriface/
  45. type SMInterface interface {
  46. ListSecrets(*awssm.ListSecretsInput) (*awssm.ListSecretsOutput, error)
  47. GetSecretValue(*awssm.GetSecretValueInput) (*awssm.GetSecretValueOutput, error)
  48. CreateSecretWithContext(aws.Context, *awssm.CreateSecretInput, ...request.Option) (*awssm.CreateSecretOutput, error)
  49. GetSecretValueWithContext(aws.Context, *awssm.GetSecretValueInput, ...request.Option) (*awssm.GetSecretValueOutput, error)
  50. PutSecretValueWithContext(aws.Context, *awssm.PutSecretValueInput, ...request.Option) (*awssm.PutSecretValueOutput, error)
  51. DescribeSecretWithContext(aws.Context, *awssm.DescribeSecretInput, ...request.Option) (*awssm.DescribeSecretOutput, error)
  52. DeleteSecretWithContext(ctx aws.Context, input *awssm.DeleteSecretInput, opts ...request.Option) (*awssm.DeleteSecretOutput, error)
  53. }
  54. const (
  55. errUnexpectedFindOperator = "unexpected find operator"
  56. managedBy = "managed-by"
  57. externalSecrets = "external-secrets"
  58. )
  59. var log = ctrl.Log.WithName("provider").WithName("aws").WithName("secretsmanager")
  60. // New creates a new SecretsManager client.
  61. func New(sess *session.Session, cfg *aws.Config, referentAuth bool) (*SecretsManager, error) {
  62. return &SecretsManager{
  63. sess: sess,
  64. client: awssm.New(sess, cfg),
  65. referentAuth: referentAuth,
  66. cache: make(map[string]*awssm.GetSecretValueOutput),
  67. }, nil
  68. }
  69. func (sm *SecretsManager) fetch(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) (*awssm.GetSecretValueOutput, error) {
  70. ver := "AWSCURRENT"
  71. valueFrom := "SECRET"
  72. if ref.Version != "" {
  73. ver = ref.Version
  74. }
  75. if ref.MetadataPolicy == esv1beta1.ExternalSecretMetadataPolicyFetch {
  76. valueFrom = "TAG"
  77. }
  78. log.Info("fetching secret value", "key", ref.Key, "version", ver, "value", valueFrom)
  79. cacheKey := fmt.Sprintf("%s#%s#%s", ref.Key, ver, valueFrom)
  80. if secretOut, found := sm.cache[cacheKey]; found {
  81. log.Info("found secret in cache", "key", ref.Key, "version", ver)
  82. return secretOut, nil
  83. }
  84. var secretOut *awssm.GetSecretValueOutput
  85. var err error
  86. if ref.MetadataPolicy == esv1beta1.ExternalSecretMetadataPolicyFetch {
  87. describeSecretInput := &awssm.DescribeSecretInput{
  88. SecretId: &ref.Key,
  89. }
  90. descOutput, err := sm.client.DescribeSecretWithContext(ctx, describeSecretInput)
  91. if err != nil {
  92. return nil, err
  93. }
  94. log.Info("found metadata secret", "key", ref.Key, "output", descOutput)
  95. jsonTags, err := util.SecretTagsToJSONString(descOutput.Tags)
  96. if err != nil {
  97. return nil, err
  98. }
  99. secretOut = &awssm.GetSecretValueOutput{
  100. ARN: descOutput.ARN,
  101. CreatedDate: descOutput.CreatedDate,
  102. Name: descOutput.Name,
  103. SecretString: &jsonTags,
  104. VersionId: &ver,
  105. }
  106. } else {
  107. var getSecretValueInput *awssm.GetSecretValueInput
  108. if strings.HasPrefix(ver, "uuid/") {
  109. versionID := strings.TrimPrefix(ver, "uuid/")
  110. getSecretValueInput = &awssm.GetSecretValueInput{
  111. SecretId: &ref.Key,
  112. VersionId: &versionID,
  113. }
  114. } else {
  115. getSecretValueInput = &awssm.GetSecretValueInput{
  116. SecretId: &ref.Key,
  117. VersionStage: &ver,
  118. }
  119. }
  120. secretOut, err = sm.client.GetSecretValue(getSecretValueInput)
  121. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMGetSecretValue, err)
  122. var nf *awssm.ResourceNotFoundException
  123. if errors.As(err, &nf) {
  124. return nil, esv1beta1.NoSecretErr
  125. }
  126. if err != nil {
  127. return nil, err
  128. }
  129. }
  130. sm.cache[cacheKey] = secretOut
  131. return secretOut, nil
  132. }
  133. func (sm *SecretsManager) DeleteSecret(ctx context.Context, remoteRef esv1beta1.PushRemoteRef) error {
  134. secretName := remoteRef.GetRemoteKey()
  135. secretValue := awssm.GetSecretValueInput{
  136. SecretId: &secretName,
  137. }
  138. secretInput := awssm.DescribeSecretInput{
  139. SecretId: &secretName,
  140. }
  141. awsSecret, err := sm.client.GetSecretValueWithContext(ctx, &secretValue)
  142. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMGetSecretValue, err)
  143. var aerr awserr.Error
  144. if err != nil {
  145. if ok := errors.As(err, &aerr); !ok {
  146. return err
  147. }
  148. if aerr.Code() == awssm.ErrCodeResourceNotFoundException {
  149. return nil
  150. }
  151. return err
  152. }
  153. data, err := sm.client.DescribeSecretWithContext(ctx, &secretInput)
  154. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMDescribeSecret, err)
  155. if err != nil {
  156. return err
  157. }
  158. if !isManagedByESO(data) {
  159. return nil
  160. }
  161. deleteInput := &awssm.DeleteSecretInput{
  162. SecretId: awsSecret.ARN,
  163. }
  164. _, err = sm.client.DeleteSecretWithContext(ctx, deleteInput)
  165. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMDeleteSecret, err)
  166. return err
  167. }
  168. func (sm *SecretsManager) PushSecret(ctx context.Context, value []byte, remoteRef esv1beta1.PushRemoteRef) error {
  169. secretName := remoteRef.GetRemoteKey()
  170. managedBy := managedBy
  171. externalSecrets := externalSecrets
  172. externalSecretsTag := []*awssm.Tag{
  173. {
  174. Key: &managedBy,
  175. Value: &externalSecrets,
  176. },
  177. }
  178. secretRequest := awssm.CreateSecretInput{
  179. Name: &secretName,
  180. SecretBinary: value,
  181. Tags: externalSecretsTag,
  182. }
  183. secretValue := awssm.GetSecretValueInput{
  184. SecretId: &secretName,
  185. }
  186. secretInput := awssm.DescribeSecretInput{
  187. SecretId: &secretName,
  188. }
  189. awsSecret, err := sm.client.GetSecretValueWithContext(ctx, &secretValue)
  190. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMGetSecretValue, err)
  191. var aerr awserr.Error
  192. if err != nil {
  193. if ok := errors.As(err, &aerr); !ok {
  194. return err
  195. }
  196. if aerr.Code() == awssm.ErrCodeResourceNotFoundException {
  197. _, err = sm.client.CreateSecretWithContext(ctx, &secretRequest)
  198. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMCreateSecret, err)
  199. return err
  200. }
  201. return err
  202. }
  203. data, err := sm.client.DescribeSecretWithContext(ctx, &secretInput)
  204. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMDescribeSecret, err)
  205. if err != nil {
  206. return err
  207. }
  208. if !isManagedByESO(data) {
  209. return fmt.Errorf("secret not managed by external-secrets")
  210. }
  211. if awsSecret != nil && bytes.Equal(awsSecret.SecretBinary, value) {
  212. return nil
  213. }
  214. input := &awssm.PutSecretValueInput{
  215. SecretId: awsSecret.ARN,
  216. SecretBinary: value,
  217. }
  218. _, err = sm.client.PutSecretValueWithContext(ctx, input)
  219. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMPutSecretValue, err)
  220. return err
  221. }
  222. func isManagedByESO(data *awssm.DescribeSecretOutput) bool {
  223. managedBy := managedBy
  224. externalSecrets := externalSecrets
  225. for _, tag := range data.Tags {
  226. if *tag.Key == managedBy && *tag.Value == externalSecrets {
  227. return true
  228. }
  229. }
  230. return false
  231. }
  232. // GetAllSecrets syncs multiple secrets from aws provider into a single Kubernetes Secret.
  233. func (sm *SecretsManager) GetAllSecrets(ctx context.Context, ref esv1beta1.ExternalSecretFind) (map[string][]byte, error) {
  234. if ref.Name != nil {
  235. return sm.findByName(ctx, ref)
  236. }
  237. if len(ref.Tags) > 0 {
  238. return sm.findByTags(ctx, ref)
  239. }
  240. return nil, errors.New(errUnexpectedFindOperator)
  241. }
  242. func (sm *SecretsManager) findByName(ctx context.Context, ref esv1beta1.ExternalSecretFind) (map[string][]byte, error) {
  243. matcher, err := find.New(*ref.Name)
  244. if err != nil {
  245. return nil, err
  246. }
  247. filters := make([]*awssm.Filter, 0)
  248. if ref.Path != nil {
  249. filters = append(filters, &awssm.Filter{
  250. Key: utilpointer.String(awssm.FilterNameStringTypeName),
  251. Values: []*string{
  252. ref.Path,
  253. },
  254. })
  255. }
  256. data := make(map[string][]byte)
  257. var nextToken *string
  258. for {
  259. it, err := sm.client.ListSecrets(&awssm.ListSecretsInput{
  260. Filters: filters,
  261. NextToken: nextToken,
  262. })
  263. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMListSecrets, err)
  264. if err != nil {
  265. return nil, err
  266. }
  267. log.V(1).Info("aws sm findByName found", "secrets", len(it.SecretList))
  268. for _, secret := range it.SecretList {
  269. if !matcher.MatchName(*secret.Name) {
  270. continue
  271. }
  272. log.V(1).Info("aws sm findByName matches", "name", *secret.Name)
  273. err = sm.fetchAndSet(ctx, data, *secret.Name)
  274. if err != nil {
  275. return nil, err
  276. }
  277. }
  278. nextToken = it.NextToken
  279. if nextToken == nil {
  280. break
  281. }
  282. }
  283. return data, nil
  284. }
  285. func (sm *SecretsManager) findByTags(ctx context.Context, ref esv1beta1.ExternalSecretFind) (map[string][]byte, error) {
  286. filters := make([]*awssm.Filter, 0)
  287. for k, v := range ref.Tags {
  288. filters = append(filters, &awssm.Filter{
  289. Key: utilpointer.String(awssm.FilterNameStringTypeTagKey),
  290. Values: []*string{
  291. utilpointer.String(k),
  292. },
  293. }, &awssm.Filter{
  294. Key: utilpointer.String(awssm.FilterNameStringTypeTagValue),
  295. Values: []*string{
  296. utilpointer.String(v),
  297. },
  298. })
  299. }
  300. if ref.Path != nil {
  301. filters = append(filters, &awssm.Filter{
  302. Key: utilpointer.String(awssm.FilterNameStringTypeName),
  303. Values: []*string{
  304. ref.Path,
  305. },
  306. })
  307. }
  308. data := make(map[string][]byte)
  309. var nextToken *string
  310. for {
  311. log.V(1).Info("aws sm findByTag", "nextToken", nextToken)
  312. it, err := sm.client.ListSecrets(&awssm.ListSecretsInput{
  313. Filters: filters,
  314. NextToken: nextToken,
  315. })
  316. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMListSecrets, err)
  317. if err != nil {
  318. return nil, err
  319. }
  320. log.V(1).Info("aws sm findByTag found", "secrets", len(it.SecretList))
  321. for _, secret := range it.SecretList {
  322. err = sm.fetchAndSet(ctx, data, *secret.Name)
  323. if err != nil {
  324. return nil, err
  325. }
  326. }
  327. nextToken = it.NextToken
  328. if nextToken == nil {
  329. break
  330. }
  331. }
  332. return data, nil
  333. }
  334. func (sm *SecretsManager) fetchAndSet(ctx context.Context, data map[string][]byte, name string) error {
  335. sec, err := sm.fetch(ctx, esv1beta1.ExternalSecretDataRemoteRef{
  336. Key: name,
  337. })
  338. if err != nil {
  339. return err
  340. }
  341. if sec.SecretString != nil {
  342. data[name] = []byte(*sec.SecretString)
  343. }
  344. if sec.SecretBinary != nil {
  345. data[name] = sec.SecretBinary
  346. }
  347. return nil
  348. }
  349. // GetSecret returns a single secret from the provider.
  350. func (sm *SecretsManager) GetSecret(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) ([]byte, error) {
  351. secretOut, err := sm.fetch(ctx, ref)
  352. if errors.Is(err, esv1beta1.NoSecretErr) {
  353. return nil, err
  354. }
  355. if err != nil {
  356. return nil, util.SanitizeErr(err)
  357. }
  358. if ref.Property == "" {
  359. if secretOut.SecretString != nil {
  360. return []byte(*secretOut.SecretString), nil
  361. }
  362. if secretOut.SecretBinary != nil {
  363. return secretOut.SecretBinary, nil
  364. }
  365. return nil, fmt.Errorf("invalid secret received. no secret string nor binary for key: %s", ref.Key)
  366. }
  367. var payload string
  368. if secretOut.SecretString != nil {
  369. payload = *secretOut.SecretString
  370. }
  371. if secretOut.SecretBinary != nil {
  372. payload = string(secretOut.SecretBinary)
  373. }
  374. // We need to search if a given key with a . exists before using gjson operations.
  375. idx := strings.Index(ref.Property, ".")
  376. if idx > -1 {
  377. refProperty := strings.ReplaceAll(ref.Property, ".", "\\.")
  378. val := gjson.Get(payload, refProperty)
  379. if val.Exists() {
  380. return []byte(val.String()), nil
  381. }
  382. }
  383. val := gjson.Get(payload, ref.Property)
  384. if !val.Exists() {
  385. return nil, fmt.Errorf("key %s does not exist in secret %s", ref.Property, ref.Key)
  386. }
  387. return []byte(val.String()), nil
  388. }
  389. // GetSecretMap returns multiple k/v pairs from the provider.
  390. func (sm *SecretsManager) GetSecretMap(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) (map[string][]byte, error) {
  391. log.Info("fetching secret map", "key", ref.Key)
  392. data, err := sm.GetSecret(ctx, ref)
  393. if err != nil {
  394. return nil, err
  395. }
  396. kv := make(map[string]json.RawMessage)
  397. err = json.Unmarshal(data, &kv)
  398. if err != nil {
  399. return nil, fmt.Errorf("unable to unmarshal secret %s: %w", ref.Key, err)
  400. }
  401. secretData := make(map[string][]byte)
  402. for k, v := range kv {
  403. var strVal string
  404. err = json.Unmarshal(v, &strVal)
  405. if err == nil {
  406. secretData[k] = []byte(strVal)
  407. } else {
  408. secretData[k] = v
  409. }
  410. }
  411. return secretData, nil
  412. }
  413. func (sm *SecretsManager) Close(_ context.Context) error {
  414. return nil
  415. }
  416. func (sm *SecretsManager) Validate() (esv1beta1.ValidationResult, error) {
  417. // skip validation stack because it depends on the namespace
  418. // of the ExternalSecret
  419. if sm.referentAuth {
  420. return esv1beta1.ValidationResultUnknown, nil
  421. }
  422. _, err := sm.sess.Config.Credentials.Get()
  423. if err != nil {
  424. return esv1beta1.ValidationResultError, err
  425. }
  426. return esv1beta1.ValidationResultReady, nil
  427. }
  428. func (sm *SecretsManager) Capabilities() esv1beta1.SecretStoreCapabilities {
  429. return esv1beta1.SecretStoreReadWrite
  430. }