secretsmanager.go 16 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544
  1. /*
  2. Licensed under the Apache License, Version 2.0 (the "License");
  3. you may not use this file except in compliance with the License.
  4. You may obtain a copy of the License at
  5. http://www.apache.org/licenses/LICENSE-2.0
  6. Unless required by applicable law or agreed to in writing, software
  7. distributed under the License is distributed on an "AS IS" BASIS,
  8. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  9. See the License for the specific language governing permissions and
  10. limitations under the License.
  11. */
  12. package secretsmanager
  13. import (
  14. "bytes"
  15. "context"
  16. "encoding/json"
  17. "errors"
  18. "fmt"
  19. "math/big"
  20. "strings"
  21. "github.com/aws/aws-sdk-go/aws"
  22. "github.com/aws/aws-sdk-go/aws/awserr"
  23. "github.com/aws/aws-sdk-go/aws/request"
  24. "github.com/aws/aws-sdk-go/aws/session"
  25. awssm "github.com/aws/aws-sdk-go/service/secretsmanager"
  26. "github.com/google/uuid"
  27. "github.com/tidwall/gjson"
  28. "github.com/tidwall/sjson"
  29. corev1 "k8s.io/api/core/v1"
  30. utilpointer "k8s.io/utils/ptr"
  31. ctrl "sigs.k8s.io/controller-runtime"
  32. esv1beta1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1beta1"
  33. "github.com/external-secrets/external-secrets/pkg/constants"
  34. "github.com/external-secrets/external-secrets/pkg/find"
  35. "github.com/external-secrets/external-secrets/pkg/metrics"
  36. "github.com/external-secrets/external-secrets/pkg/provider/aws/util"
  37. )
  38. // https://github.com/external-secrets/external-secrets/issues/644
  39. var _ esv1beta1.SecretsClient = &SecretsManager{}
  40. // SecretsManager is a provider for AWS SecretsManager.
  41. type SecretsManager struct {
  42. sess *session.Session
  43. client SMInterface
  44. referentAuth bool
  45. cache map[string]*awssm.GetSecretValueOutput
  46. }
  47. // SMInterface is a subset of the smiface api.
  48. // see: https://docs.aws.amazon.com/sdk-for-go/api/service/secretsmanager/secretsmanageriface/
  49. type SMInterface interface {
  50. ListSecrets(*awssm.ListSecretsInput) (*awssm.ListSecretsOutput, error)
  51. GetSecretValue(*awssm.GetSecretValueInput) (*awssm.GetSecretValueOutput, error)
  52. CreateSecretWithContext(aws.Context, *awssm.CreateSecretInput, ...request.Option) (*awssm.CreateSecretOutput, error)
  53. GetSecretValueWithContext(aws.Context, *awssm.GetSecretValueInput, ...request.Option) (*awssm.GetSecretValueOutput, error)
  54. PutSecretValueWithContext(aws.Context, *awssm.PutSecretValueInput, ...request.Option) (*awssm.PutSecretValueOutput, error)
  55. DescribeSecretWithContext(aws.Context, *awssm.DescribeSecretInput, ...request.Option) (*awssm.DescribeSecretOutput, error)
  56. DeleteSecretWithContext(ctx aws.Context, input *awssm.DeleteSecretInput, opts ...request.Option) (*awssm.DeleteSecretOutput, error)
  57. }
  58. const (
  59. errUnexpectedFindOperator = "unexpected find operator"
  60. managedBy = "managed-by"
  61. externalSecrets = "external-secrets"
  62. initialVersion = "00000000-0000-0000-0000-000000000001"
  63. )
  64. var log = ctrl.Log.WithName("provider").WithName("aws").WithName("secretsmanager")
  65. // New creates a new SecretsManager client.
  66. func New(sess *session.Session, cfg *aws.Config, referentAuth bool) (*SecretsManager, error) {
  67. return &SecretsManager{
  68. sess: sess,
  69. client: awssm.New(sess, cfg),
  70. referentAuth: referentAuth,
  71. cache: make(map[string]*awssm.GetSecretValueOutput),
  72. }, nil
  73. }
  74. func (sm *SecretsManager) fetch(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) (*awssm.GetSecretValueOutput, error) {
  75. ver := "AWSCURRENT"
  76. valueFrom := "SECRET"
  77. if ref.Version != "" {
  78. ver = ref.Version
  79. }
  80. if ref.MetadataPolicy == esv1beta1.ExternalSecretMetadataPolicyFetch {
  81. valueFrom = "TAG"
  82. }
  83. log.Info("fetching secret value", "key", ref.Key, "version", ver, "value", valueFrom)
  84. cacheKey := fmt.Sprintf("%s#%s#%s", ref.Key, ver, valueFrom)
  85. if secretOut, found := sm.cache[cacheKey]; found {
  86. log.Info("found secret in cache", "key", ref.Key, "version", ver)
  87. return secretOut, nil
  88. }
  89. var secretOut *awssm.GetSecretValueOutput
  90. var err error
  91. if ref.MetadataPolicy == esv1beta1.ExternalSecretMetadataPolicyFetch {
  92. describeSecretInput := &awssm.DescribeSecretInput{
  93. SecretId: &ref.Key,
  94. }
  95. descOutput, err := sm.client.DescribeSecretWithContext(ctx, describeSecretInput)
  96. if err != nil {
  97. return nil, err
  98. }
  99. log.Info("found metadata secret", "key", ref.Key, "output", descOutput)
  100. jsonTags, err := util.SecretTagsToJSONString(descOutput.Tags)
  101. if err != nil {
  102. return nil, err
  103. }
  104. secretOut = &awssm.GetSecretValueOutput{
  105. ARN: descOutput.ARN,
  106. CreatedDate: descOutput.CreatedDate,
  107. Name: descOutput.Name,
  108. SecretString: &jsonTags,
  109. VersionId: &ver,
  110. }
  111. } else {
  112. var getSecretValueInput *awssm.GetSecretValueInput
  113. if strings.HasPrefix(ver, "uuid/") {
  114. versionID := strings.TrimPrefix(ver, "uuid/")
  115. getSecretValueInput = &awssm.GetSecretValueInput{
  116. SecretId: &ref.Key,
  117. VersionId: &versionID,
  118. }
  119. } else {
  120. getSecretValueInput = &awssm.GetSecretValueInput{
  121. SecretId: &ref.Key,
  122. VersionStage: &ver,
  123. }
  124. }
  125. secretOut, err = sm.client.GetSecretValue(getSecretValueInput)
  126. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMGetSecretValue, err)
  127. var nf *awssm.ResourceNotFoundException
  128. if errors.As(err, &nf) {
  129. return nil, esv1beta1.NoSecretErr
  130. }
  131. if err != nil {
  132. return nil, err
  133. }
  134. }
  135. sm.cache[cacheKey] = secretOut
  136. return secretOut, nil
  137. }
  138. func (sm *SecretsManager) DeleteSecret(ctx context.Context, remoteRef esv1beta1.PushSecretRemoteRef) error {
  139. secretName := remoteRef.GetRemoteKey()
  140. secretValue := awssm.GetSecretValueInput{
  141. SecretId: &secretName,
  142. }
  143. secretInput := awssm.DescribeSecretInput{
  144. SecretId: &secretName,
  145. }
  146. awsSecret, err := sm.client.GetSecretValueWithContext(ctx, &secretValue)
  147. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMGetSecretValue, err)
  148. var aerr awserr.Error
  149. if err != nil {
  150. if ok := errors.As(err, &aerr); !ok {
  151. return err
  152. }
  153. if aerr.Code() == awssm.ErrCodeResourceNotFoundException {
  154. return nil
  155. }
  156. return err
  157. }
  158. data, err := sm.client.DescribeSecretWithContext(ctx, &secretInput)
  159. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMDescribeSecret, err)
  160. if err != nil {
  161. return err
  162. }
  163. if !isManagedByESO(data) {
  164. return nil
  165. }
  166. deleteInput := &awssm.DeleteSecretInput{
  167. SecretId: awsSecret.ARN,
  168. }
  169. _, err = sm.client.DeleteSecretWithContext(ctx, deleteInput)
  170. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMDeleteSecret, err)
  171. return err
  172. }
  173. func (sm *SecretsManager) PushSecret(ctx context.Context, secret *corev1.Secret, psd esv1beta1.PushSecretData) error {
  174. secretName := psd.GetRemoteKey()
  175. value := secret.Data[psd.GetSecretKey()]
  176. managedBy := managedBy
  177. externalSecrets := externalSecrets
  178. externalSecretsTag := []*awssm.Tag{
  179. {
  180. Key: &managedBy,
  181. Value: &externalSecrets,
  182. },
  183. }
  184. secretValue := awssm.GetSecretValueInput{
  185. SecretId: &secretName,
  186. }
  187. secretInput := awssm.DescribeSecretInput{
  188. SecretId: &secretName,
  189. }
  190. awsSecret, err := sm.client.GetSecretValueWithContext(ctx, &secretValue)
  191. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMGetSecretValue, err)
  192. if psd.GetProperty() != "" {
  193. currentSecret := sm.retrievePayload(awsSecret)
  194. if currentSecret != "" && !gjson.Valid(currentSecret) {
  195. return errors.New("PushSecret for aws secrets manager with a pushSecretData property requires a json secret")
  196. }
  197. value, _ = sjson.SetBytes([]byte(currentSecret), psd.GetProperty(), value)
  198. }
  199. var aerr awserr.Error
  200. if err != nil {
  201. if ok := errors.As(err, &aerr); !ok {
  202. return err
  203. }
  204. if aerr.Code() == awssm.ErrCodeResourceNotFoundException {
  205. secretVersion := initialVersion
  206. secretRequest := awssm.CreateSecretInput{
  207. Name: &secretName,
  208. SecretBinary: value,
  209. Tags: externalSecretsTag,
  210. ClientRequestToken: &secretVersion,
  211. }
  212. _, err = sm.client.CreateSecretWithContext(ctx, &secretRequest)
  213. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMCreateSecret, err)
  214. return err
  215. }
  216. return err
  217. }
  218. data, err := sm.client.DescribeSecretWithContext(ctx, &secretInput)
  219. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMDescribeSecret, err)
  220. if err != nil {
  221. return err
  222. }
  223. if !isManagedByESO(data) {
  224. return fmt.Errorf("secret not managed by external-secrets")
  225. }
  226. if awsSecret != nil && bytes.Equal(awsSecret.SecretBinary, value) {
  227. return nil
  228. }
  229. newVersionNumber, err := bumpVersionNumber(awsSecret.VersionId)
  230. if err != nil {
  231. return err
  232. }
  233. input := &awssm.PutSecretValueInput{
  234. SecretId: awsSecret.ARN,
  235. SecretBinary: value,
  236. ClientRequestToken: newVersionNumber,
  237. }
  238. _, err = sm.client.PutSecretValueWithContext(ctx, input)
  239. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMPutSecretValue, err)
  240. return err
  241. }
  242. func padOrTrim(b []byte) []byte {
  243. l := len(b)
  244. size := 16
  245. if l == size {
  246. return b
  247. }
  248. if l > size {
  249. return b[l-size:]
  250. }
  251. tmp := make([]byte, size)
  252. copy(tmp[size-l:], b)
  253. return tmp
  254. }
  255. func bumpVersionNumber(id *string) (*string, error) {
  256. if id == nil {
  257. output := initialVersion
  258. return &output, nil
  259. }
  260. n := new(big.Int)
  261. oldVersion, ok := n.SetString(strings.ReplaceAll(*id, "-", ""), 16)
  262. if !ok {
  263. return nil, fmt.Errorf("expected secret version in AWS SSM to be a UUID but got '%s'", *id)
  264. }
  265. newVersionRaw := oldVersion.Add(oldVersion, big.NewInt(1)).Bytes()
  266. newVersion, err := uuid.FromBytes(padOrTrim(newVersionRaw))
  267. if err != nil {
  268. return nil, err
  269. }
  270. s := newVersion.String()
  271. return &s, nil
  272. }
  273. func isManagedByESO(data *awssm.DescribeSecretOutput) bool {
  274. managedBy := managedBy
  275. externalSecrets := externalSecrets
  276. for _, tag := range data.Tags {
  277. if *tag.Key == managedBy && *tag.Value == externalSecrets {
  278. return true
  279. }
  280. }
  281. return false
  282. }
  283. // GetAllSecrets syncs multiple secrets from aws provider into a single Kubernetes Secret.
  284. func (sm *SecretsManager) GetAllSecrets(ctx context.Context, ref esv1beta1.ExternalSecretFind) (map[string][]byte, error) {
  285. if ref.Name != nil {
  286. return sm.findByName(ctx, ref)
  287. }
  288. if len(ref.Tags) > 0 {
  289. return sm.findByTags(ctx, ref)
  290. }
  291. return nil, errors.New(errUnexpectedFindOperator)
  292. }
  293. func (sm *SecretsManager) findByName(ctx context.Context, ref esv1beta1.ExternalSecretFind) (map[string][]byte, error) {
  294. matcher, err := find.New(*ref.Name)
  295. if err != nil {
  296. return nil, err
  297. }
  298. filters := make([]*awssm.Filter, 0)
  299. if ref.Path != nil {
  300. filters = append(filters, &awssm.Filter{
  301. Key: utilpointer.To(awssm.FilterNameStringTypeName),
  302. Values: []*string{
  303. ref.Path,
  304. },
  305. })
  306. }
  307. data := make(map[string][]byte)
  308. var nextToken *string
  309. for {
  310. it, err := sm.client.ListSecrets(&awssm.ListSecretsInput{
  311. Filters: filters,
  312. NextToken: nextToken,
  313. })
  314. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMListSecrets, err)
  315. if err != nil {
  316. return nil, err
  317. }
  318. log.V(1).Info("aws sm findByName found", "secrets", len(it.SecretList))
  319. for _, secret := range it.SecretList {
  320. if !matcher.MatchName(*secret.Name) {
  321. continue
  322. }
  323. log.V(1).Info("aws sm findByName matches", "name", *secret.Name)
  324. err = sm.fetchAndSet(ctx, data, *secret.Name)
  325. if err != nil {
  326. return nil, err
  327. }
  328. }
  329. nextToken = it.NextToken
  330. if nextToken == nil {
  331. break
  332. }
  333. }
  334. return data, nil
  335. }
  336. func (sm *SecretsManager) findByTags(ctx context.Context, ref esv1beta1.ExternalSecretFind) (map[string][]byte, error) {
  337. filters := make([]*awssm.Filter, 0)
  338. for k, v := range ref.Tags {
  339. filters = append(filters, &awssm.Filter{
  340. Key: utilpointer.To(awssm.FilterNameStringTypeTagKey),
  341. Values: []*string{
  342. utilpointer.To(k),
  343. },
  344. }, &awssm.Filter{
  345. Key: utilpointer.To(awssm.FilterNameStringTypeTagValue),
  346. Values: []*string{
  347. utilpointer.To(v),
  348. },
  349. })
  350. }
  351. if ref.Path != nil {
  352. filters = append(filters, &awssm.Filter{
  353. Key: utilpointer.To(awssm.FilterNameStringTypeName),
  354. Values: []*string{
  355. ref.Path,
  356. },
  357. })
  358. }
  359. data := make(map[string][]byte)
  360. var nextToken *string
  361. for {
  362. log.V(1).Info("aws sm findByTag", "nextToken", nextToken)
  363. it, err := sm.client.ListSecrets(&awssm.ListSecretsInput{
  364. Filters: filters,
  365. NextToken: nextToken,
  366. })
  367. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMListSecrets, err)
  368. if err != nil {
  369. return nil, err
  370. }
  371. log.V(1).Info("aws sm findByTag found", "secrets", len(it.SecretList))
  372. for _, secret := range it.SecretList {
  373. err = sm.fetchAndSet(ctx, data, *secret.Name)
  374. if err != nil {
  375. return nil, err
  376. }
  377. }
  378. nextToken = it.NextToken
  379. if nextToken == nil {
  380. break
  381. }
  382. }
  383. return data, nil
  384. }
  385. func (sm *SecretsManager) fetchAndSet(ctx context.Context, data map[string][]byte, name string) error {
  386. sec, err := sm.fetch(ctx, esv1beta1.ExternalSecretDataRemoteRef{
  387. Key: name,
  388. })
  389. if err != nil {
  390. return err
  391. }
  392. if sec.SecretString != nil {
  393. data[name] = []byte(*sec.SecretString)
  394. }
  395. if sec.SecretBinary != nil {
  396. data[name] = sec.SecretBinary
  397. }
  398. return nil
  399. }
  400. // GetSecret returns a single secret from the provider.
  401. func (sm *SecretsManager) GetSecret(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) ([]byte, error) {
  402. secretOut, err := sm.fetch(ctx, ref)
  403. if errors.Is(err, esv1beta1.NoSecretErr) {
  404. return nil, err
  405. }
  406. if err != nil {
  407. return nil, util.SanitizeErr(err)
  408. }
  409. if ref.Property == "" {
  410. if secretOut.SecretString != nil {
  411. return []byte(*secretOut.SecretString), nil
  412. }
  413. if secretOut.SecretBinary != nil {
  414. return secretOut.SecretBinary, nil
  415. }
  416. return nil, fmt.Errorf("invalid secret received. no secret string nor binary for key: %s", ref.Key)
  417. }
  418. val := sm.mapSecretToGjson(secretOut, ref.Property)
  419. if !val.Exists() {
  420. return nil, fmt.Errorf("key %s does not exist in secret %s", ref.Property, ref.Key)
  421. }
  422. return []byte(val.String()), nil
  423. }
  424. func (sm *SecretsManager) mapSecretToGjson(secretOut *awssm.GetSecretValueOutput, property string) gjson.Result {
  425. payload := sm.retrievePayload(secretOut)
  426. refProperty := sm.escapeDotsIfRequired(property, payload)
  427. val := gjson.Get(payload, refProperty)
  428. return val
  429. }
  430. func (sm *SecretsManager) retrievePayload(secretOut *awssm.GetSecretValueOutput) string {
  431. var payload string
  432. if secretOut.SecretString != nil {
  433. payload = *secretOut.SecretString
  434. }
  435. if secretOut.SecretBinary != nil {
  436. payload = string(secretOut.SecretBinary)
  437. }
  438. return payload
  439. }
  440. func (sm *SecretsManager) escapeDotsIfRequired(currentRefProperty, payload string) string {
  441. // We need to search if a given key with a . exists before using gjson operations.
  442. idx := strings.Index(currentRefProperty, ".")
  443. refProperty := currentRefProperty
  444. if idx > -1 {
  445. refProperty = strings.ReplaceAll(currentRefProperty, ".", "\\.")
  446. val := gjson.Get(payload, refProperty)
  447. if !val.Exists() {
  448. refProperty = currentRefProperty
  449. }
  450. }
  451. return refProperty
  452. }
  453. // GetSecretMap returns multiple k/v pairs from the provider.
  454. func (sm *SecretsManager) GetSecretMap(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) (map[string][]byte, error) {
  455. log.Info("fetching secret map", "key", ref.Key)
  456. data, err := sm.GetSecret(ctx, ref)
  457. if err != nil {
  458. return nil, err
  459. }
  460. kv := make(map[string]json.RawMessage)
  461. err = json.Unmarshal(data, &kv)
  462. if err != nil {
  463. return nil, fmt.Errorf("unable to unmarshal secret %s: %w", ref.Key, err)
  464. }
  465. secretData := make(map[string][]byte)
  466. for k, v := range kv {
  467. var strVal string
  468. err = json.Unmarshal(v, &strVal)
  469. if err == nil {
  470. secretData[k] = []byte(strVal)
  471. } else {
  472. secretData[k] = v
  473. }
  474. }
  475. return secretData, nil
  476. }
  477. func (sm *SecretsManager) Close(_ context.Context) error {
  478. return nil
  479. }
  480. func (sm *SecretsManager) Validate() (esv1beta1.ValidationResult, error) {
  481. // skip validation stack because it depends on the namespace
  482. // of the ExternalSecret
  483. if sm.referentAuth {
  484. return esv1beta1.ValidationResultUnknown, nil
  485. }
  486. _, err := sm.sess.Config.Credentials.Get()
  487. if err != nil {
  488. return esv1beta1.ValidationResultError, util.SanitizeErr(err)
  489. }
  490. return esv1beta1.ValidationResultReady, nil
  491. }
  492. func (sm *SecretsManager) Capabilities() esv1beta1.SecretStoreCapabilities {
  493. return esv1beta1.SecretStoreReadWrite
  494. }