pushsecret_controller.go 14 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414
  1. /*
  2. Licensed under the Apache License, Version 2.0 (the "License");
  3. you may not use this file except in compliance with the License.
  4. You may obtain a copy of the License at
  5. http://www.apache.org/licenses/LICENSE-2.0
  6. Unless required by applicable law or agreed to in writing, software
  7. distributed under the License is distributed on an "AS IS" BASIS,
  8. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  9. See the License for the specific language governing permissions and
  10. limitations under the License.
  11. */
  12. package pushsecret
  13. import (
  14. "context"
  15. "fmt"
  16. "strings"
  17. "time"
  18. "github.com/go-logr/logr"
  19. v1 "k8s.io/api/core/v1"
  20. apierrors "k8s.io/apimachinery/pkg/api/errors"
  21. metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
  22. "k8s.io/apimachinery/pkg/runtime"
  23. "k8s.io/apimachinery/pkg/types"
  24. "k8s.io/client-go/tools/record"
  25. ctrl "sigs.k8s.io/controller-runtime"
  26. "sigs.k8s.io/controller-runtime/pkg/client"
  27. "sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
  28. esapi "github.com/external-secrets/external-secrets/apis/externalsecrets/v1alpha1"
  29. v1beta1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1beta1"
  30. )
  31. const (
  32. errFailedGetSecret = "could not get source secret"
  33. errPatchStatus = "error merging"
  34. errGetSecretStore = "could not get SecretStore %q, %w"
  35. errGetClusterSecretStore = "could not get ClusterSecretStore %q, %w"
  36. errGetProviderFailed = "could not start provider"
  37. errGetSecretsClientFailed = "could not start secrets client"
  38. errCloseStoreClient = "error when calling provider close method"
  39. errSetSecretFailed = "could not write remote ref %v to target secretstore %v: %v"
  40. errFailedSetSecret = "set secret failed: %v"
  41. pushSecretFinalizer = "pushsecret.externalsecrets.io/finalizer"
  42. )
  43. type Reconciler struct {
  44. client.Client
  45. Log logr.Logger
  46. Scheme *runtime.Scheme
  47. recorder record.EventRecorder
  48. RequeueInterval time.Duration
  49. ControllerClass string
  50. }
  51. func (r *Reconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
  52. log := r.Log.WithValues("pushsecret", req.NamespacedName)
  53. var ps esapi.PushSecret
  54. err := r.Get(ctx, req.NamespacedName, &ps)
  55. if apierrors.IsNotFound(err) {
  56. return ctrl.Result{}, nil
  57. } else if err != nil {
  58. msg := "unable to get PushSecret"
  59. r.recorder.Event(&ps, v1.EventTypeWarning, esapi.ReasonErrored, msg)
  60. log.Error(err, msg)
  61. return ctrl.Result{}, fmt.Errorf("get resource: %w", err)
  62. }
  63. refreshInt := r.RequeueInterval
  64. if ps.Spec.RefreshInterval != nil {
  65. refreshInt = ps.Spec.RefreshInterval.Duration
  66. }
  67. p := client.MergeFrom(ps.DeepCopy())
  68. defer func() {
  69. err := r.Client.Status().Patch(ctx, &ps, p)
  70. if err != nil {
  71. log.Error(err, errPatchStatus)
  72. }
  73. }()
  74. switch ps.Spec.DeletionPolicy {
  75. case esapi.PushSecretDeletionPolicyDelete:
  76. // finalizer logic. Only added if we should delete the secrets
  77. if ps.ObjectMeta.DeletionTimestamp.IsZero() {
  78. if !controllerutil.ContainsFinalizer(&ps, pushSecretFinalizer) {
  79. controllerutil.AddFinalizer(&ps, pushSecretFinalizer)
  80. err := r.Client.Update(ctx, &ps, &client.UpdateOptions{})
  81. if err != nil {
  82. return ctrl.Result{}, fmt.Errorf("could not update finalizers: %w", err)
  83. }
  84. return ctrl.Result{}, nil
  85. }
  86. } else {
  87. if controllerutil.ContainsFinalizer(&ps, pushSecretFinalizer) {
  88. // trigger a cleanup with no Synced Map
  89. badState, err := r.DeleteSecretFromProviders(ctx, &ps, esapi.SyncedPushSecretsMap{})
  90. if err != nil {
  91. msg := fmt.Sprintf("Failed to Delete Secrets from Provider: %v", err)
  92. cond := NewPushSecretCondition(esapi.PushSecretReady, v1.ConditionFalse, esapi.ReasonErrored, msg)
  93. ps = SetPushSecretCondition(ps, *cond)
  94. r.SetSyncedSecrets(&ps, badState)
  95. r.recorder.Event(&ps, v1.EventTypeWarning, esapi.ReasonErrored, msg)
  96. return ctrl.Result{}, err
  97. }
  98. controllerutil.RemoveFinalizer(&ps, pushSecretFinalizer)
  99. err = r.Client.Update(ctx, &ps, &client.UpdateOptions{})
  100. if err != nil {
  101. return ctrl.Result{}, fmt.Errorf("could not update finalizers: %w", err)
  102. }
  103. return ctrl.Result{}, nil
  104. }
  105. }
  106. case esapi.PushSecretDeletionPolicyNone:
  107. default:
  108. }
  109. secret, err := r.GetSecret(ctx, ps)
  110. if err != nil {
  111. cond := NewPushSecretCondition(esapi.PushSecretReady, v1.ConditionFalse, esapi.ReasonErrored, errFailedGetSecret)
  112. ps = SetPushSecretCondition(ps, *cond)
  113. r.recorder.Event(&ps, v1.EventTypeWarning, esapi.ReasonErrored, errFailedGetSecret)
  114. return ctrl.Result{}, err
  115. }
  116. secretStores, err := r.GetSecretStores(ctx, ps)
  117. if err != nil {
  118. cond := NewPushSecretCondition(esapi.PushSecretReady, v1.ConditionFalse, esapi.ReasonErrored, err.Error())
  119. ps = SetPushSecretCondition(ps, *cond)
  120. r.recorder.Event(&ps, v1.EventTypeWarning, esapi.ReasonErrored, err.Error())
  121. return ctrl.Result{}, err
  122. }
  123. syncedSecrets, err := r.PushSecretToProviders(ctx, secretStores, ps, secret)
  124. if err != nil {
  125. msg := fmt.Sprintf(errFailedSetSecret, err)
  126. cond := NewPushSecretCondition(esapi.PushSecretReady, v1.ConditionFalse, esapi.ReasonErrored, msg)
  127. ps = SetPushSecretCondition(ps, *cond)
  128. r.SetSyncedSecrets(&ps, syncedSecrets)
  129. r.recorder.Event(&ps, v1.EventTypeWarning, esapi.ReasonErrored, msg)
  130. return ctrl.Result{}, err
  131. }
  132. switch ps.Spec.DeletionPolicy {
  133. case esapi.PushSecretDeletionPolicyDelete:
  134. badSyncState, err := r.DeleteSecretFromProviders(ctx, &ps, syncedSecrets)
  135. if err != nil {
  136. msg := fmt.Sprintf("Failed to Delete Secrets from Provider: %v", err)
  137. cond := NewPushSecretCondition(esapi.PushSecretReady, v1.ConditionFalse, esapi.ReasonErrored, msg)
  138. ps = SetPushSecretCondition(ps, *cond)
  139. r.SetSyncedSecrets(&ps, badSyncState)
  140. r.recorder.Event(&ps, v1.EventTypeWarning, esapi.ReasonErrored, msg)
  141. return ctrl.Result{}, err
  142. }
  143. case esapi.PushSecretDeletionPolicyNone:
  144. default:
  145. }
  146. msg := "PushSecret synced successfully"
  147. cond := NewPushSecretCondition(esapi.PushSecretReady, v1.ConditionTrue, esapi.ReasonSynced, msg)
  148. ps = SetPushSecretCondition(ps, *cond)
  149. r.SetSyncedSecrets(&ps, syncedSecrets)
  150. r.recorder.Event(&ps, v1.EventTypeNormal, esapi.ReasonSynced, msg)
  151. return ctrl.Result{RequeueAfter: refreshInt}, nil
  152. }
  153. func (r *Reconciler) SetSyncedSecrets(ps *esapi.PushSecret, status esapi.SyncedPushSecretsMap) {
  154. ps.Status.SyncedPushSecrets = status
  155. }
  156. func (r *Reconciler) DeleteSecretFromProviders(ctx context.Context, ps *esapi.PushSecret, newMap esapi.SyncedPushSecretsMap) (esapi.SyncedPushSecretsMap, error) {
  157. out := newMap.DeepCopy()
  158. for k, v := range ps.Status.SyncedPushSecrets {
  159. _, ok := out[k]
  160. if !ok {
  161. out[k] = make(map[string]esapi.PushSecretData)
  162. }
  163. for kk, vv := range v {
  164. out[k][kk] = vv
  165. }
  166. }
  167. for storeName, oldData := range ps.Status.SyncedPushSecrets {
  168. storeRef := esapi.PushSecretStoreRef{
  169. Name: strings.Split(storeName, "/")[1],
  170. Kind: strings.Split(storeName, "/")[0],
  171. }
  172. store, err := r.getSecretStoreFromName(ctx, storeRef, ps.Namespace)
  173. if err != nil {
  174. return out, err
  175. }
  176. client, err := r.getClientFromStore(ctx, store, ps)
  177. if err != nil {
  178. return out, fmt.Errorf("could not get secrets client for store %v: %w", store.GetName(), err)
  179. }
  180. defer func() { //nolint
  181. err := client.Close(ctx)
  182. if err != nil {
  183. r.Log.Error(err, errCloseStoreClient)
  184. }
  185. }()
  186. newData, ok := newMap[storeName]
  187. if !ok {
  188. err = r.DeleteAllSecretsFromStore(ctx, client, oldData)
  189. if err != nil {
  190. return out, err
  191. }
  192. delete(out, storeName)
  193. continue
  194. }
  195. for oldEntry, oldRef := range oldData {
  196. _, ok := newData[oldEntry]
  197. if !ok {
  198. err = r.DeleteSecretFromStore(ctx, client, oldRef)
  199. if err != nil {
  200. return out, err
  201. }
  202. delete(out[storeName], oldRef.Match.RemoteRef.RemoteKey)
  203. }
  204. }
  205. }
  206. return out, nil
  207. }
  208. func (r *Reconciler) DeleteAllSecretsFromStore(ctx context.Context, client v1beta1.SecretsClient, data map[string]esapi.PushSecretData) error {
  209. for _, v := range data {
  210. err := r.DeleteSecretFromStore(ctx, client, v)
  211. if err != nil {
  212. return err
  213. }
  214. }
  215. return nil
  216. }
  217. func (r *Reconciler) DeleteSecretFromStore(ctx context.Context, client v1beta1.SecretsClient, data esapi.PushSecretData) error {
  218. return client.DeleteSecret(ctx, data.Match.RemoteRef)
  219. }
  220. func (r *Reconciler) getClientFromStore(ctx context.Context, store v1beta1.GenericStore, ps *esapi.PushSecret) (v1beta1.SecretsClient, error) {
  221. provider, err := v1beta1.GetProvider(store)
  222. if err != nil {
  223. return nil, fmt.Errorf(errGetProviderFailed)
  224. }
  225. client, err := provider.NewClient(ctx, store, r.Client, ps.Namespace)
  226. if err != nil {
  227. return nil, fmt.Errorf(errGetSecretsClientFailed)
  228. }
  229. return client, nil
  230. }
  231. func (r *Reconciler) PushSecretToProviders(ctx context.Context, stores map[esapi.PushSecretStoreRef]v1beta1.GenericStore, ps esapi.PushSecret, secret *v1.Secret) (esapi.SyncedPushSecretsMap, error) {
  232. out := esapi.SyncedPushSecretsMap{}
  233. for ref, store := range stores {
  234. storeKey := fmt.Sprintf("%v/%v", ref.Kind, store.GetName())
  235. out[storeKey] = make(map[string]esapi.PushSecretData)
  236. client, err := r.getClientFromStore(ctx, store, &ps)
  237. if err != nil {
  238. return out, fmt.Errorf("could not get secrets client for store %v: %w", store.GetName(), err)
  239. }
  240. defer func() { //nolint
  241. err := client.Close(ctx)
  242. if err != nil {
  243. r.Log.Error(err, errCloseStoreClient)
  244. }
  245. }()
  246. for _, ref := range ps.Spec.Data {
  247. secretValue, ok := secret.Data[ref.Match.SecretKey]
  248. if !ok {
  249. return out, fmt.Errorf("secret key %v does not exist", ref.Match.SecretKey)
  250. }
  251. err := client.SetSecret(ctx, secretValue, ref.Match.RemoteRef)
  252. if err != nil {
  253. return out, fmt.Errorf(errSetSecretFailed, ref.Match.SecretKey, store.GetName(), err)
  254. }
  255. out[storeKey][ref.Match.RemoteRef.RemoteKey] = ref
  256. }
  257. }
  258. return out, nil
  259. }
  260. func (r *Reconciler) GetSecret(ctx context.Context, ps esapi.PushSecret) (*v1.Secret, error) {
  261. secretName := types.NamespacedName{Name: ps.Spec.Selector.Secret.Name, Namespace: ps.Namespace}
  262. secret := &v1.Secret{}
  263. err := r.Client.Get(ctx, secretName, secret)
  264. if err != nil {
  265. return nil, err
  266. }
  267. return secret, nil
  268. }
  269. func (r *Reconciler) GetSecretStores(ctx context.Context, ps esapi.PushSecret) (map[esapi.PushSecretStoreRef]v1beta1.GenericStore, error) {
  270. stores := make(map[esapi.PushSecretStoreRef]v1beta1.GenericStore)
  271. for _, refStore := range ps.Spec.SecretStoreRefs {
  272. if refStore.LabelSelector != nil {
  273. labelSelector, err := metav1.LabelSelectorAsSelector(refStore.LabelSelector)
  274. if err != nil {
  275. return nil, fmt.Errorf("could not convert labels: %w", err)
  276. }
  277. if refStore.Kind == v1beta1.ClusterSecretStoreKind {
  278. clusterSecretStoreList := v1beta1.ClusterSecretStoreList{}
  279. err = r.List(ctx, &clusterSecretStoreList, &client.ListOptions{LabelSelector: labelSelector})
  280. if err != nil {
  281. return nil, fmt.Errorf("could not list cluster Secret Stores: %w", err)
  282. }
  283. for k, v := range clusterSecretStoreList.Items {
  284. key := esapi.PushSecretStoreRef{
  285. Name: v.Name,
  286. Kind: v1beta1.ClusterSecretStoreKind,
  287. }
  288. stores[key] = &clusterSecretStoreList.Items[k]
  289. }
  290. } else {
  291. secretStoreList := v1beta1.SecretStoreList{}
  292. err = r.List(ctx, &secretStoreList, &client.ListOptions{LabelSelector: labelSelector})
  293. if err != nil {
  294. return nil, fmt.Errorf("could not list Secret Stores: %w", err)
  295. }
  296. for k, v := range secretStoreList.Items {
  297. key := esapi.PushSecretStoreRef{
  298. Name: v.Name,
  299. Kind: v1beta1.SecretStoreKind,
  300. }
  301. stores[key] = &secretStoreList.Items[k]
  302. }
  303. }
  304. } else {
  305. store, err := r.getSecretStoreFromName(ctx, refStore, ps.Namespace)
  306. if err != nil {
  307. return nil, err
  308. }
  309. stores[refStore] = store
  310. }
  311. }
  312. return stores, nil
  313. }
  314. func (r *Reconciler) getSecretStoreFromName(ctx context.Context, refStore esapi.PushSecretStoreRef, ns string) (v1beta1.GenericStore, error) {
  315. if refStore.Name == "" {
  316. return nil, fmt.Errorf("refStore Name must be provided")
  317. }
  318. ref := types.NamespacedName{
  319. Name: refStore.Name,
  320. }
  321. if refStore.Kind == v1beta1.ClusterSecretStoreKind {
  322. var store v1beta1.ClusterSecretStore
  323. err := r.Get(ctx, ref, &store)
  324. if err != nil {
  325. return nil, fmt.Errorf(errGetClusterSecretStore, ref.Name, err)
  326. }
  327. return &store, nil
  328. }
  329. ref.Namespace = ns
  330. var store v1beta1.SecretStore
  331. err := r.Get(ctx, ref, &store)
  332. if err != nil {
  333. return nil, fmt.Errorf(errGetSecretStore, ref.Name, err)
  334. }
  335. return &store, nil
  336. }
  337. func (r *Reconciler) SetupWithManager(mgr ctrl.Manager) error {
  338. r.recorder = mgr.GetEventRecorderFor("pushsecret")
  339. return ctrl.NewControllerManagedBy(mgr).
  340. For(&esapi.PushSecret{}).
  341. Complete(r)
  342. }
  343. func NewPushSecretCondition(condType esapi.PushSecretConditionType, status v1.ConditionStatus, reason, message string) *esapi.PushSecretStatusCondition {
  344. return &esapi.PushSecretStatusCondition{
  345. Type: condType,
  346. Status: status,
  347. LastTransitionTime: metav1.Now(),
  348. Reason: reason,
  349. Message: message,
  350. }
  351. }
  352. func SetPushSecretCondition(gs esapi.PushSecret, condition esapi.PushSecretStatusCondition) esapi.PushSecret {
  353. status := gs.Status
  354. currentCond := GetPushSecretCondition(status, condition.Type)
  355. if currentCond != nil && currentCond.Status == condition.Status &&
  356. currentCond.Reason == condition.Reason && currentCond.Message == condition.Message {
  357. return gs
  358. }
  359. // Do not update lastTransitionTime if the status of the condition doesn't change.
  360. if currentCond != nil && currentCond.Status == condition.Status {
  361. condition.LastTransitionTime = currentCond.LastTransitionTime
  362. }
  363. status.Conditions = append(filterOutCondition(status.Conditions, condition.Type), condition)
  364. gs.Status = status
  365. return gs
  366. }
  367. // filterOutCondition returns an empty set of conditions with the provided type.
  368. func filterOutCondition(conditions []esapi.PushSecretStatusCondition, condType esapi.PushSecretConditionType) []esapi.PushSecretStatusCondition {
  369. newConditions := make([]esapi.PushSecretStatusCondition, 0, len(conditions))
  370. for _, c := range conditions {
  371. if c.Type == condType {
  372. continue
  373. }
  374. newConditions = append(newConditions, c)
  375. }
  376. return newConditions
  377. }
  378. // GetSecretStoreCondition returns the condition with the provided type.
  379. func GetPushSecretCondition(status esapi.PushSecretStatus, condType esapi.PushSecretConditionType) *esapi.PushSecretStatusCondition {
  380. for i := range status.Conditions {
  381. c := status.Conditions[i]
  382. if c.Type == condType {
  383. return &c
  384. }
  385. }
  386. return nil
  387. }