secretsmanager.go 30 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942
  1. /*
  2. Copyright © 2025 ESO Maintainer Team
  3. Licensed under the Apache License, Version 2.0 (the "License");
  4. you may not use this file except in compliance with the License.
  5. You may obtain a copy of the License at
  6. https://www.apache.org/licenses/LICENSE-2.0
  7. Unless required by applicable law or agreed to in writing, software
  8. distributed under the License is distributed on an "AS IS" BASIS,
  9. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  10. See the License for the specific language governing permissions and
  11. limitations under the License.
  12. */
  13. package secretsmanager
  14. import (
  15. "bytes"
  16. "context"
  17. "encoding/json"
  18. "errors"
  19. "fmt"
  20. "maps"
  21. "slices"
  22. "strings"
  23. "github.com/aws/aws-sdk-go-v2/aws"
  24. awssm "github.com/aws/aws-sdk-go-v2/service/secretsmanager"
  25. "github.com/aws/aws-sdk-go-v2/service/secretsmanager/types"
  26. "github.com/aws/smithy-go"
  27. "github.com/external-secrets/external-secrets/pkg/esutils/metadata"
  28. "github.com/google/uuid"
  29. "github.com/tidwall/gjson"
  30. "github.com/tidwall/sjson"
  31. corev1 "k8s.io/api/core/v1"
  32. apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
  33. utilpointer "k8s.io/utils/ptr"
  34. ctrl "sigs.k8s.io/controller-runtime"
  35. "sigs.k8s.io/controller-runtime/pkg/client"
  36. esv1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1"
  37. "github.com/external-secrets/external-secrets/pkg/constants"
  38. "github.com/external-secrets/external-secrets/pkg/esutils"
  39. "github.com/external-secrets/external-secrets/pkg/find"
  40. "github.com/external-secrets/external-secrets/pkg/metrics"
  41. "github.com/external-secrets/external-secrets/pkg/provider/aws/util"
  42. )
  43. // PushSecretMetadataSpec contains metadata information for pushing secrets to AWS Secret Manager.
  44. type PushSecretMetadataSpec struct {
  45. Tags map[string]string `json:"tags,omitempty"`
  46. Description string `json:"description,omitempty"`
  47. SecretPushFormat string `json:"secretPushFormat,omitempty"`
  48. KMSKeyID string `json:"kmsKeyId,omitempty"`
  49. ResourcePolicy *ResourcePolicySpec `json:"resourcePolicy,omitempty"`
  50. }
  51. // ResourcePolicySpec defines the resource policy configuration using PolicySourceRef for AWS Secrets Manager.
  52. type ResourcePolicySpec struct {
  53. BlockPublicPolicy *bool `json:"blockPublicPolicy,omitempty"`
  54. PolicySourceRef *PolicySourceRef `json:"policySourceRef,omitempty"`
  55. }
  56. // PolicySourceRef defines the source reference for the resource policy.
  57. type PolicySourceRef struct {
  58. Kind string `json:"kind"`
  59. Name string `json:"name"`
  60. Key string `json:"key"`
  61. }
  62. // Declares metadata information for pushing secrets to AWS Secret Store.
  63. const (
  64. SecretPushFormatKey = "secretPushFormat"
  65. SecretPushFormatString = "string"
  66. SecretPushFormatBinary = "binary"
  67. ResourceNotFoundException = "ResourceNotFoundException"
  68. )
  69. // https://github.com/external-secrets/external-secrets/issues/644
  70. var _ esv1.SecretsClient = &SecretsManager{}
  71. // SecretsManager is a provider for AWS SecretsManager.
  72. type SecretsManager struct {
  73. cfg *aws.Config
  74. client SMInterface // Keep the interface
  75. referentAuth bool
  76. cache map[string]*awssm.GetSecretValueOutput
  77. config *esv1.SecretsManager
  78. prefix string
  79. newUUID func() string
  80. kube client.Client
  81. namespace string
  82. }
  83. // SMInterface is a subset of the smiface api.
  84. // see: https://docs.aws.amazon.com/sdk-for-go/api/service/secretsmanager/secretsmanageriface/
  85. type SMInterface interface {
  86. BatchGetSecretValue(ctx context.Context, params *awssm.BatchGetSecretValueInput, optFuncs ...func(*awssm.Options)) (*awssm.BatchGetSecretValueOutput, error)
  87. ListSecrets(ctx context.Context, params *awssm.ListSecretsInput, optFuncs ...func(*awssm.Options)) (*awssm.ListSecretsOutput, error)
  88. GetSecretValue(ctx context.Context, params *awssm.GetSecretValueInput, optFuncs ...func(*awssm.Options)) (*awssm.GetSecretValueOutput, error)
  89. CreateSecret(ctx context.Context, params *awssm.CreateSecretInput, optFuncs ...func(*awssm.Options)) (*awssm.CreateSecretOutput, error)
  90. PutSecretValue(ctx context.Context, params *awssm.PutSecretValueInput, optFuncs ...func(*awssm.Options)) (*awssm.PutSecretValueOutput, error)
  91. DescribeSecret(ctx context.Context, params *awssm.DescribeSecretInput, optFuncs ...func(*awssm.Options)) (*awssm.DescribeSecretOutput, error)
  92. DeleteSecret(ctx context.Context, params *awssm.DeleteSecretInput, optFuncs ...func(*awssm.Options)) (*awssm.DeleteSecretOutput, error)
  93. TagResource(ctx context.Context, params *awssm.TagResourceInput, optFuncs ...func(*awssm.Options)) (*awssm.TagResourceOutput, error)
  94. UntagResource(ctx context.Context, params *awssm.UntagResourceInput, optFuncs ...func(*awssm.Options)) (*awssm.UntagResourceOutput, error)
  95. PutResourcePolicy(ctx context.Context, params *awssm.PutResourcePolicyInput, optFuncs ...func(*awssm.Options)) (*awssm.PutResourcePolicyOutput, error)
  96. GetResourcePolicy(ctx context.Context, params *awssm.GetResourcePolicyInput, optFuncs ...func(*awssm.Options)) (*awssm.GetResourcePolicyOutput, error)
  97. DeleteResourcePolicy(ctx context.Context, params *awssm.DeleteResourcePolicyInput, optFuncs ...func(*awssm.Options)) (*awssm.DeleteResourcePolicyOutput, error)
  98. }
  99. const (
  100. errUnexpectedFindOperator = "unexpected find operator"
  101. managedBy = "managed-by"
  102. externalSecrets = "external-secrets"
  103. initialVersion = "00000000-0000-0000-0000-000000000001"
  104. )
  105. var log = ctrl.Log.WithName("provider").WithName("aws").WithName("secretsmanager")
  106. // New creates a new SecretsManager client.
  107. func New(_ context.Context, cfg *aws.Config, secretsManagerCfg *esv1.SecretsManager, prefix string, referentAuth bool, kube client.Client, namespace string) (*SecretsManager, error) {
  108. return &SecretsManager{
  109. cfg: cfg,
  110. client: awssm.NewFromConfig(*cfg, func(o *awssm.Options) {
  111. o.EndpointResolverV2 = customEndpointResolver{}
  112. }),
  113. referentAuth: referentAuth,
  114. cache: make(map[string]*awssm.GetSecretValueOutput),
  115. config: secretsManagerCfg,
  116. prefix: prefix,
  117. kube: kube,
  118. namespace: namespace,
  119. }, nil
  120. }
  121. func (sm *SecretsManager) fetch(ctx context.Context, ref esv1.ExternalSecretDataRemoteRef) (*awssm.GetSecretValueOutput, error) {
  122. ver := "AWSCURRENT"
  123. valueFrom := "SECRET"
  124. if ref.Version != "" {
  125. ver = ref.Version
  126. }
  127. if ref.MetadataPolicy == esv1.ExternalSecretMetadataPolicyFetch {
  128. valueFrom = "TAG"
  129. }
  130. key := sm.prefix + ref.Key
  131. log.Info("fetching secret value", "key", key, "version", ver, "value", valueFrom)
  132. cacheKey := fmt.Sprintf("%s#%s#%s", key, ver, valueFrom)
  133. if secretOut, found := sm.cache[cacheKey]; found {
  134. log.Info("found secret in cache", "key", key, "version", ver)
  135. return secretOut, nil
  136. }
  137. secretOut, err := sm.constructSecretValue(ctx, key, ver, ref.MetadataPolicy)
  138. if err != nil {
  139. return nil, err
  140. }
  141. sm.cache[cacheKey] = secretOut
  142. return secretOut, nil
  143. }
  144. // DeleteSecret deletes a secret from AWS Secrets Manager.
  145. func (sm *SecretsManager) DeleteSecret(ctx context.Context, remoteRef esv1.PushSecretRemoteRef) error {
  146. secretName := sm.prefix + remoteRef.GetRemoteKey()
  147. secretValue := awssm.GetSecretValueInput{
  148. SecretId: &secretName,
  149. }
  150. secretInput := awssm.DescribeSecretInput{
  151. SecretId: &secretName,
  152. }
  153. awsSecret, err := sm.client.GetSecretValue(ctx, &secretValue)
  154. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMGetSecretValue, err)
  155. var aerr smithy.APIError
  156. if err != nil {
  157. if ok := errors.As(err, &aerr); !ok {
  158. return err
  159. }
  160. if aerr.ErrorCode() == ResourceNotFoundException {
  161. return nil
  162. }
  163. return err
  164. }
  165. data, err := sm.client.DescribeSecret(ctx, &secretInput)
  166. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMDescribeSecret, err)
  167. if err != nil {
  168. return err
  169. }
  170. if !isManagedByESO(data) {
  171. return nil
  172. }
  173. deleteInput := &awssm.DeleteSecretInput{
  174. SecretId: awsSecret.ARN,
  175. }
  176. if sm.config != nil && sm.config.ForceDeleteWithoutRecovery {
  177. deleteInput.ForceDeleteWithoutRecovery = &sm.config.ForceDeleteWithoutRecovery
  178. }
  179. if sm.config != nil && sm.config.RecoveryWindowInDays > 0 {
  180. deleteInput.RecoveryWindowInDays = &sm.config.RecoveryWindowInDays
  181. }
  182. err = awsutil.ValidateDeleteSecretInput(*deleteInput)
  183. if err != nil {
  184. return err
  185. }
  186. _, err = sm.client.DeleteSecret(ctx, deleteInput)
  187. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMDeleteSecret, err)
  188. return err
  189. }
  190. // SecretExists checks if a secret exists in AWS Secrets Manager.
  191. func (sm *SecretsManager) SecretExists(ctx context.Context, pushSecretRef esv1.PushSecretRemoteRef) (bool, error) {
  192. secretName := sm.prefix + pushSecretRef.GetRemoteKey()
  193. secretValue := awssm.GetSecretValueInput{
  194. SecretId: &secretName,
  195. }
  196. _, err := sm.client.GetSecretValue(ctx, &secretValue)
  197. if err != nil {
  198. return sm.handleSecretError(err)
  199. }
  200. return true, nil
  201. }
  202. func (sm *SecretsManager) handleSecretError(err error) (bool, error) {
  203. var aerr smithy.APIError
  204. if ok := errors.As(err, &aerr); !ok {
  205. return false, err
  206. }
  207. if aerr.ErrorCode() == ResourceNotFoundException {
  208. return false, nil
  209. }
  210. return false, err
  211. }
  212. // PushSecret pushes a secret to AWS Secrets Manager.
  213. func (sm *SecretsManager) PushSecret(ctx context.Context, secret *corev1.Secret, psd esv1.PushSecretData) error {
  214. value, err := esutils.ExtractSecretData(psd, secret)
  215. if err != nil {
  216. return fmt.Errorf("failed to extract secret data: %w", err)
  217. }
  218. secretName := sm.prefix + psd.GetRemoteKey()
  219. describeSecretInput := awssm.DescribeSecretInput{SecretId: &secretName}
  220. describeSecretOutput, err := sm.client.DescribeSecret(ctx, &describeSecretInput)
  221. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMDescribeSecret, err)
  222. var aerr smithy.APIError
  223. if err != nil {
  224. if ok := errors.As(err, &aerr); !ok {
  225. return err
  226. }
  227. if aerr.ErrorCode() == ResourceNotFoundException {
  228. finalValue, err := sm.getNewSecretValue(value, psd.GetProperty(), nil)
  229. if err != nil {
  230. return err
  231. }
  232. return sm.createSecretWithContext(ctx, secretName, psd, finalValue)
  233. }
  234. return err
  235. } else if !isManagedByESO(describeSecretOutput) {
  236. return errors.New("secret not managed by external-secrets")
  237. }
  238. if len(describeSecretOutput.VersionIdsToStages) == 0 {
  239. finalValue, err := sm.getNewSecretValue(value, psd.GetProperty(), nil)
  240. if err != nil {
  241. return err
  242. }
  243. return sm.putSecretValueWithContext(ctx, secretName, nil, psd, finalValue, describeSecretOutput.Tags)
  244. }
  245. getSecretValueInput := awssm.GetSecretValueInput{SecretId: &secretName}
  246. getSecretValueOutput, err := sm.client.GetSecretValue(ctx, &getSecretValueInput)
  247. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMGetSecretValue, err)
  248. if err != nil {
  249. return err
  250. }
  251. finalValue, err := sm.getNewSecretValue(value, psd.GetProperty(), getSecretValueOutput)
  252. if err != nil {
  253. return err
  254. }
  255. return sm.putSecretValueWithContext(ctx, secretName, getSecretValueOutput, psd, finalValue, describeSecretOutput.Tags)
  256. }
  257. func (sm *SecretsManager) getNewSecretValue(value []byte, property string, existingSecret *awssm.GetSecretValueOutput) ([]byte, error) {
  258. if property == "" {
  259. return value, nil
  260. }
  261. if existingSecret == nil {
  262. value, _ = sjson.SetBytes([]byte{}, property, value)
  263. return value, nil
  264. }
  265. currentSecret := sm.retrievePayload(existingSecret)
  266. if currentSecret != "" && !gjson.Valid(currentSecret) {
  267. return nil, errors.New("PushSecret for aws secrets manager with a pushSecretData property requires a json secret")
  268. }
  269. value, _ = sjson.SetBytes([]byte(currentSecret), property, value)
  270. return value, nil
  271. }
  272. func isManagedByESO(data *awssm.DescribeSecretOutput) bool {
  273. managedBy := managedBy
  274. externalSecrets := externalSecrets
  275. for _, tag := range data.Tags {
  276. if *tag.Key == managedBy && *tag.Value == externalSecrets {
  277. return true
  278. }
  279. }
  280. return false
  281. }
  282. // GetAllSecrets syncs multiple secrets from aws provider into a single Kubernetes Secret.
  283. func (sm *SecretsManager) GetAllSecrets(ctx context.Context, ref esv1.ExternalSecretFind) (map[string][]byte, error) {
  284. if ref.Name != nil {
  285. return sm.findByName(ctx, ref)
  286. }
  287. if len(ref.Tags) > 0 {
  288. return sm.findByTags(ctx, ref)
  289. }
  290. return nil, errors.New(errUnexpectedFindOperator)
  291. }
  292. func (sm *SecretsManager) findByName(ctx context.Context, ref esv1.ExternalSecretFind) (map[string][]byte, error) {
  293. matcher, err := find.New(*ref.Name)
  294. if err != nil {
  295. return nil, err
  296. }
  297. filters := make([]types.Filter, 0)
  298. if ref.Path != nil {
  299. filters = append(filters, types.Filter{
  300. Key: types.FilterNameStringTypeName,
  301. Values: []string{
  302. *ref.Path,
  303. },
  304. })
  305. return sm.fetchWithBatch(ctx, filters, matcher)
  306. }
  307. data := make(map[string][]byte)
  308. var nextToken *string
  309. for {
  310. // I put this into the for loop on purpose.
  311. log.V(0).Info("using ListSecret to fetch all secrets; this is a costly operations, please use batching by defining a _path_")
  312. it, err := sm.client.ListSecrets(ctx, &awssm.ListSecretsInput{
  313. Filters: filters,
  314. NextToken: nextToken,
  315. })
  316. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMListSecrets, err)
  317. if err != nil {
  318. return nil, err
  319. }
  320. log.V(1).Info("aws sm findByName found", "secrets", len(it.SecretList))
  321. for _, secret := range it.SecretList {
  322. if !matcher.MatchName(*secret.Name) {
  323. continue
  324. }
  325. log.V(1).Info("aws sm findByName matches", "name", *secret.Name)
  326. if err := sm.fetchAndSet(ctx, data, *secret.Name); err != nil {
  327. return nil, err
  328. }
  329. }
  330. nextToken = it.NextToken
  331. if nextToken == nil {
  332. break
  333. }
  334. }
  335. return data, nil
  336. }
  337. func (sm *SecretsManager) findByTags(ctx context.Context, ref esv1.ExternalSecretFind) (map[string][]byte, error) {
  338. filters := make([]types.Filter, 0)
  339. for k, v := range ref.Tags {
  340. filters = append(filters, types.Filter{
  341. Key: types.FilterNameStringTypeTagKey,
  342. Values: []string{
  343. k,
  344. },
  345. }, types.Filter{
  346. Key: types.FilterNameStringTypeTagValue,
  347. Values: []string{
  348. v,
  349. },
  350. })
  351. }
  352. if ref.Path != nil {
  353. filters = append(filters, types.Filter{
  354. Key: types.FilterNameStringTypeName,
  355. Values: []string{
  356. *ref.Path,
  357. },
  358. })
  359. }
  360. return sm.fetchWithBatch(ctx, filters, nil)
  361. }
  362. func (sm *SecretsManager) fetchAndSet(ctx context.Context, data map[string][]byte, name string) error {
  363. sec, err := sm.fetch(ctx, esv1.ExternalSecretDataRemoteRef{
  364. Key: name,
  365. })
  366. if err != nil {
  367. return err
  368. }
  369. if sec.SecretString != nil {
  370. data[name] = []byte(*sec.SecretString)
  371. }
  372. if sec.SecretBinary != nil {
  373. data[name] = sec.SecretBinary
  374. }
  375. return nil
  376. }
  377. // GetSecret returns a single secret from the provider.
  378. func (sm *SecretsManager) GetSecret(ctx context.Context, ref esv1.ExternalSecretDataRemoteRef) ([]byte, error) {
  379. secretOut, err := sm.fetch(ctx, ref)
  380. if errors.Is(err, esv1.NoSecretErr) {
  381. return nil, err
  382. }
  383. if err != nil {
  384. return nil, awsutil.SanitizeErr(err)
  385. }
  386. if ref.Property == "" {
  387. if secretOut.SecretString != nil {
  388. return []byte(*secretOut.SecretString), nil
  389. }
  390. if secretOut.SecretBinary != nil {
  391. return secretOut.SecretBinary, nil
  392. }
  393. return nil, fmt.Errorf("invalid secret received. no secret string nor binary for key: %s", ref.Key)
  394. }
  395. val := sm.mapSecretToGjson(secretOut, ref.Property)
  396. if !val.Exists() {
  397. return nil, fmt.Errorf("key %s does not exist in secret %s", ref.Property, ref.Key)
  398. }
  399. return []byte(val.String()), nil
  400. }
  401. func (sm *SecretsManager) mapSecretToGjson(secretOut *awssm.GetSecretValueOutput, property string) gjson.Result {
  402. payload := sm.retrievePayload(secretOut)
  403. refProperty := sm.escapeDotsIfRequired(property, payload)
  404. val := gjson.Get(payload, refProperty)
  405. return val
  406. }
  407. func (sm *SecretsManager) retrievePayload(secretOut *awssm.GetSecretValueOutput) string {
  408. if secretOut == nil {
  409. return ""
  410. }
  411. var payload string
  412. if secretOut.SecretString != nil {
  413. payload = *secretOut.SecretString
  414. }
  415. if secretOut.SecretBinary != nil {
  416. payload = string(secretOut.SecretBinary)
  417. }
  418. return payload
  419. }
  420. func (sm *SecretsManager) escapeDotsIfRequired(currentRefProperty, payload string) string {
  421. // We need to search if a given key with a . exists before using gjson operations.
  422. idx := strings.Index(currentRefProperty, ".")
  423. refProperty := currentRefProperty
  424. if idx > -1 {
  425. refProperty = strings.ReplaceAll(currentRefProperty, ".", "\\.")
  426. val := gjson.Get(payload, refProperty)
  427. if !val.Exists() {
  428. refProperty = currentRefProperty
  429. }
  430. }
  431. return refProperty
  432. }
  433. // GetSecretMap returns multiple k/v pairs from the provider.
  434. func (sm *SecretsManager) GetSecretMap(ctx context.Context, ref esv1.ExternalSecretDataRemoteRef) (map[string][]byte, error) {
  435. log.Info("fetching secret map", "key", ref.Key)
  436. data, err := sm.GetSecret(ctx, ref)
  437. if err != nil {
  438. return nil, err
  439. }
  440. kv := make(map[string]json.RawMessage)
  441. err = json.Unmarshal(data, &kv)
  442. if err != nil {
  443. return nil, fmt.Errorf("unable to unmarshal secret %s: %w", ref.Key, err)
  444. }
  445. secretData := make(map[string][]byte)
  446. for k, v := range kv {
  447. var strVal string
  448. err = json.Unmarshal(v, &strVal)
  449. if err == nil {
  450. secretData[k] = []byte(strVal)
  451. } else {
  452. secretData[k] = v
  453. }
  454. }
  455. return secretData, nil
  456. }
  457. // Close closes the provider client connection.
  458. func (sm *SecretsManager) Close(_ context.Context) error {
  459. return nil
  460. }
  461. // Validate validates the provider configuration.
  462. func (sm *SecretsManager) Validate() (esv1.ValidationResult, error) {
  463. // skip validation stack because it depends on the namespace
  464. // of the ExternalSecret
  465. if sm.referentAuth {
  466. return esv1.ValidationResultUnknown, nil
  467. }
  468. _, err := sm.cfg.Credentials.Retrieve(context.Background())
  469. if err != nil {
  470. return esv1.ValidationResultError, awsutil.SanitizeErr(err)
  471. }
  472. return esv1.ValidationResultReady, nil
  473. }
  474. // Capabilities returns the provider's esv1.SecretStoreCapabilities.
  475. func (sm *SecretsManager) Capabilities() esv1.SecretStoreCapabilities {
  476. return esv1.SecretStoreReadWrite
  477. }
  478. func (sm *SecretsManager) createSecretWithContext(ctx context.Context, secretName string, psd esv1.PushSecretData, value []byte) error {
  479. mdata, err := sm.constructMetadataWithDefaults(psd.GetMetadata())
  480. if err != nil {
  481. return fmt.Errorf("failed to parse push secret metadata: %w", err)
  482. }
  483. tags := make([]types.Tag, 0)
  484. for k, v := range mdata.Spec.Tags {
  485. tags = append(tags, types.Tag{
  486. Key: utilpointer.To(k),
  487. Value: utilpointer.To(v),
  488. })
  489. }
  490. input := &awssm.CreateSecretInput{
  491. Name: &secretName,
  492. SecretBinary: value,
  493. Tags: tags,
  494. Description: utilpointer.To(mdata.Spec.Description),
  495. ClientRequestToken: utilpointer.To(initialVersion),
  496. KmsKeyId: utilpointer.To(mdata.Spec.KMSKeyID),
  497. }
  498. if mdata.Spec.SecretPushFormat == SecretPushFormatString {
  499. input.SecretBinary = nil
  500. input.SecretString = aws.String(string(value))
  501. }
  502. createOutput, err := sm.client.CreateSecret(ctx, input)
  503. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMCreateSecret, err)
  504. if err != nil {
  505. return err
  506. }
  507. // Apply resource policy if specified
  508. if mdata.Spec.ResourcePolicy != nil && mdata.Spec.ResourcePolicy.PolicySourceRef != nil {
  509. policyJSON, err := sm.resolveResourcePolicy(ctx, mdata.Spec.ResourcePolicy.PolicySourceRef)
  510. if err != nil {
  511. return fmt.Errorf("failed to resolve resource policy: %w", err)
  512. }
  513. putPolicyInput := &awssm.PutResourcePolicyInput{
  514. SecretId: createOutput.ARN,
  515. ResourcePolicy: aws.String(policyJSON),
  516. }
  517. if mdata.Spec.ResourcePolicy.BlockPublicPolicy != nil {
  518. putPolicyInput.BlockPublicPolicy = mdata.Spec.ResourcePolicy.BlockPublicPolicy
  519. }
  520. _, err = sm.client.PutResourcePolicy(ctx, putPolicyInput)
  521. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMPutResourcePolicy, err)
  522. if err != nil {
  523. return fmt.Errorf("failed to put resource policy: %w", err)
  524. }
  525. }
  526. return nil
  527. }
  528. func (sm *SecretsManager) putSecretValueWithContext(ctx context.Context, secretArn string, awsSecret *awssm.GetSecretValueOutput, psd esv1.PushSecretData, value []byte, tags []types.Tag) error {
  529. if awsSecret != nil && (bytes.Equal(awsSecret.SecretBinary, value) || esutils.CompareStringAndByteSlices(awsSecret.SecretString, value)) {
  530. return nil
  531. }
  532. newVersionNumber := initialVersion
  533. if awsSecret != nil {
  534. if sm.newUUID == nil {
  535. newVersionNumber = uuid.NewString()
  536. } else {
  537. newVersionNumber = sm.newUUID()
  538. }
  539. }
  540. input := &awssm.PutSecretValueInput{
  541. SecretId: &secretArn,
  542. SecretBinary: value,
  543. ClientRequestToken: aws.String(newVersionNumber),
  544. }
  545. secretPushFormat, err := esutils.FetchValueFromMetadata(SecretPushFormatKey, psd.GetMetadata(), SecretPushFormatBinary)
  546. if err != nil {
  547. return fmt.Errorf("failed to parse metadata: %w", err)
  548. }
  549. if secretPushFormat == SecretPushFormatString {
  550. input.SecretBinary = nil
  551. input.SecretString = aws.String(string(value))
  552. }
  553. _, err = sm.client.PutSecretValue(ctx, input)
  554. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMPutSecretValue, err)
  555. if err != nil {
  556. return err
  557. }
  558. currentTags := make(map[string]string, len(tags))
  559. for _, tag := range tags {
  560. currentTags[*tag.Key] = *tag.Value
  561. }
  562. if err := sm.patchTags(ctx, psd.GetMetadata(), &secretArn, currentTags); err != nil {
  563. return err
  564. }
  565. // Manage resource policy if specified in metadata
  566. return sm.manageResourcePolicy(ctx, psd.GetMetadata(), &secretArn)
  567. }
  568. func (sm *SecretsManager) patchTags(ctx context.Context, metadata *apiextensionsv1.JSON, secretID *string, tags map[string]string) error {
  569. meta, err := sm.constructMetadataWithDefaults(metadata)
  570. if err != nil {
  571. return err
  572. }
  573. tagKeysToRemove := awsutil.FindTagKeysToRemove(tags, meta.Spec.Tags)
  574. if len(tagKeysToRemove) > 0 {
  575. _, err = sm.client.UntagResource(ctx, &awssm.UntagResourceInput{
  576. SecretId: secretID,
  577. TagKeys: tagKeysToRemove,
  578. })
  579. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMUntagResource, err)
  580. if err != nil {
  581. return err
  582. }
  583. }
  584. tagsToUpdate, isModified := computeTagsToUpdate(tags, meta.Spec.Tags)
  585. if isModified {
  586. _, err = sm.client.TagResource(ctx, &awssm.TagResourceInput{
  587. SecretId: secretID,
  588. Tags: tagsToUpdate,
  589. })
  590. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMTagResource, err)
  591. if err != nil {
  592. return err
  593. }
  594. }
  595. return nil
  596. }
  597. func (sm *SecretsManager) fetchWithBatch(ctx context.Context, filters []types.Filter, matcher *find.Matcher) (map[string][]byte, error) {
  598. data := make(map[string][]byte)
  599. var nextToken *string
  600. for {
  601. it, err := sm.client.BatchGetSecretValue(ctx, &awssm.BatchGetSecretValueInput{
  602. Filters: filters,
  603. NextToken: nextToken,
  604. })
  605. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMBatchGetSecretValue, err)
  606. if err != nil {
  607. return nil, err
  608. }
  609. log.V(1).Info("aws sm findByName found", "secrets", len(it.SecretValues))
  610. for _, secret := range it.SecretValues {
  611. if matcher != nil && !matcher.MatchName(*secret.Name) {
  612. continue
  613. }
  614. log.V(1).Info("aws sm findByName matches", "name", *secret.Name)
  615. sm.setSecretValues(&secret, data)
  616. }
  617. nextToken = it.NextToken
  618. if nextToken == nil {
  619. break
  620. }
  621. }
  622. return data, nil
  623. }
  624. func (sm *SecretsManager) setSecretValues(secret *types.SecretValueEntry, data map[string][]byte) {
  625. if secret.SecretString != nil {
  626. data[*secret.Name] = []byte(*secret.SecretString)
  627. }
  628. if secret.SecretBinary != nil {
  629. data[*secret.Name] = secret.SecretBinary
  630. }
  631. }
  632. func (sm *SecretsManager) constructSecretValue(ctx context.Context, key, ver string, metadataPolicy esv1.ExternalSecretMetadataPolicy) (*awssm.GetSecretValueOutput, error) {
  633. if metadataPolicy == esv1.ExternalSecretMetadataPolicyFetch {
  634. describeSecretInput := &awssm.DescribeSecretInput{
  635. SecretId: &key,
  636. }
  637. descOutput, err := sm.client.DescribeSecret(ctx, describeSecretInput)
  638. if err != nil {
  639. return nil, err
  640. }
  641. log.Info("found metadata secret", "key", key, "output", descOutput)
  642. jsonTags, err := awsutil.SecretTagsToJSONString(descOutput.Tags)
  643. if err != nil {
  644. return nil, err
  645. }
  646. return &awssm.GetSecretValueOutput{
  647. ARN: descOutput.ARN,
  648. CreatedDate: descOutput.CreatedDate,
  649. Name: descOutput.Name,
  650. SecretString: &jsonTags,
  651. VersionId: &ver,
  652. }, nil
  653. }
  654. var getSecretValueInput *awssm.GetSecretValueInput
  655. if strings.HasPrefix(ver, "uuid/") {
  656. versionID := strings.TrimPrefix(ver, "uuid/")
  657. getSecretValueInput = &awssm.GetSecretValueInput{
  658. SecretId: &key,
  659. VersionId: &versionID,
  660. }
  661. } else {
  662. getSecretValueInput = &awssm.GetSecretValueInput{
  663. SecretId: &key,
  664. VersionStage: &ver,
  665. }
  666. }
  667. secretOut, err := sm.client.GetSecretValue(ctx, getSecretValueInput)
  668. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMGetSecretValue, err)
  669. var (
  670. nf *types.ResourceNotFoundException
  671. ie *types.InvalidParameterException
  672. )
  673. if errors.As(err, &nf) {
  674. return nil, esv1.NoSecretErr
  675. }
  676. if errors.As(err, &ie) && strings.Contains(ie.Error(), "was marked for deletion") {
  677. return nil, esv1.NoSecretErr
  678. }
  679. return secretOut, err
  680. }
  681. func (sm *SecretsManager) constructMetadataWithDefaults(data *apiextensionsv1.JSON) (*metadata.PushSecretMetadata[PushSecretMetadataSpec], error) {
  682. var (
  683. meta *metadata.PushSecretMetadata[PushSecretMetadataSpec]
  684. err error
  685. )
  686. meta, err = metadata.ParseMetadataParameters[PushSecretMetadataSpec](data)
  687. if err != nil {
  688. return nil, fmt.Errorf("failed to parse metadata: %w", err)
  689. }
  690. if meta == nil {
  691. meta = &metadata.PushSecretMetadata[PushSecretMetadataSpec]{}
  692. }
  693. if meta.Spec.SecretPushFormat == "" {
  694. meta.Spec.SecretPushFormat = SecretPushFormatBinary
  695. } else if !slices.Contains([]string{SecretPushFormatBinary, SecretPushFormatString}, meta.Spec.SecretPushFormat) {
  696. return nil, fmt.Errorf("invalid secret push format: %s", meta.Spec.SecretPushFormat)
  697. }
  698. if meta.Spec.Description == "" {
  699. meta.Spec.Description = fmt.Sprintf("secret '%s:%s'", managedBy, externalSecrets)
  700. }
  701. if meta.Spec.KMSKeyID == "" {
  702. meta.Spec.KMSKeyID = "alias/aws/secretsmanager"
  703. }
  704. if len(meta.Spec.Tags) > 0 {
  705. if _, exists := meta.Spec.Tags[managedBy]; exists {
  706. return nil, fmt.Errorf("error parsing tags in metadata: Cannot specify a '%s' tag", managedBy)
  707. }
  708. } else {
  709. meta.Spec.Tags = make(map[string]string)
  710. }
  711. meta.Spec.Tags[managedBy] = externalSecrets
  712. return meta, nil
  713. }
  714. // resolveResourcePolicy resolves the policy JSON from the PolicySourceRef.
  715. func (sm *SecretsManager) resolveResourcePolicy(ctx context.Context, policyRef *PolicySourceRef) (string, error) {
  716. if policyRef == nil {
  717. return "", errors.New("policySourceRef is nil")
  718. }
  719. switch policyRef.Kind {
  720. case "ConfigMap":
  721. cm := &corev1.ConfigMap{}
  722. if err := sm.kube.Get(ctx, client.ObjectKey{
  723. Namespace: sm.namespace,
  724. Name: policyRef.Name,
  725. }, cm); err != nil {
  726. return "", fmt.Errorf("failed to get ConfigMap %s/%s: %w", sm.namespace, policyRef.Name, err)
  727. }
  728. policy, ok := cm.Data[policyRef.Key]
  729. if !ok {
  730. return "", fmt.Errorf("key %s not found in ConfigMap %s/%s", policyRef.Key, sm.namespace, policyRef.Name)
  731. }
  732. return policy, nil
  733. case "Secret":
  734. secret := &corev1.Secret{}
  735. if err := sm.kube.Get(ctx, client.ObjectKey{
  736. Namespace: sm.namespace,
  737. Name: policyRef.Name,
  738. }, secret); err != nil {
  739. return "", fmt.Errorf("failed to get Secret %s/%s: %w", sm.namespace, policyRef.Name, err)
  740. }
  741. policyBytes, ok := secret.Data[policyRef.Key]
  742. if !ok {
  743. return "", fmt.Errorf("key %s not found in Secret %s/%s", policyRef.Key, sm.namespace, policyRef.Name)
  744. }
  745. return string(policyBytes), nil
  746. default:
  747. return "", fmt.Errorf("unsupported PolicySourceRef kind: %s (must be ConfigMap or Secret)", policyRef.Kind)
  748. }
  749. }
  750. // manageResourcePolicy applies or removes the resource policy based on metadata.
  751. func (sm *SecretsManager) manageResourcePolicy(ctx context.Context, metadata *apiextensionsv1.JSON, secretID *string) error {
  752. meta, err := sm.constructMetadataWithDefaults(metadata)
  753. if err != nil {
  754. return err
  755. }
  756. // Delete policy if policyRef is nil and the policy exists.
  757. if meta.Spec.ResourcePolicy == nil {
  758. deletePolicyInput := &awssm.DeleteResourcePolicyInput{
  759. SecretId: secretID,
  760. }
  761. _, err = sm.client.DeleteResourcePolicy(ctx, deletePolicyInput)
  762. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMDeleteResourcePolicy, err)
  763. var nf *types.ResourceNotFoundException
  764. if err != nil && !errors.As(err, &nf) {
  765. return fmt.Errorf("failed to delete resource policy: %w", err)
  766. }
  767. return nil
  768. }
  769. // Normal flow, is to create the policy.
  770. policyJSON, err := sm.resolveResourcePolicy(ctx, meta.Spec.ResourcePolicy.PolicySourceRef)
  771. if err != nil {
  772. return fmt.Errorf("failed to resolve resource policy: %w", err)
  773. }
  774. getCurrentPolicyInput := &awssm.GetResourcePolicyInput{
  775. SecretId: secretID,
  776. }
  777. currentPolicyOutput, err := sm.client.GetResourcePolicy(ctx, getCurrentPolicyInput)
  778. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMGetResourcePolicy, err)
  779. var nf *types.ResourceNotFoundException
  780. if err != nil && !errors.As(err, &nf) {
  781. return fmt.Errorf("failed to get current resource policy: %w", err)
  782. }
  783. currentPolicy := ""
  784. if currentPolicyOutput != nil && currentPolicyOutput.ResourcePolicy != nil {
  785. currentPolicy = *currentPolicyOutput.ResourcePolicy
  786. }
  787. // convert to maps so we can do a stable comparison.
  788. var (
  789. currentPolicyMap map[string]any
  790. policyJSONMaps map[string]any
  791. )
  792. if err := json.Unmarshal([]byte(currentPolicy), &currentPolicyMap); err != nil {
  793. return fmt.Errorf("failed to unmarshal current resource policy: %w", err)
  794. }
  795. if err := json.Unmarshal([]byte(policyJSON), &policyJSONMaps); err != nil {
  796. return fmt.Errorf("failed to unmarshal current resource policy: %w", err)
  797. }
  798. if maps.Equal(currentPolicyMap, policyJSONMaps) {
  799. return nil
  800. }
  801. putPolicyInput := &awssm.PutResourcePolicyInput{
  802. SecretId: secretID,
  803. ResourcePolicy: aws.String(policyJSON),
  804. }
  805. if meta.Spec.ResourcePolicy.BlockPublicPolicy != nil {
  806. putPolicyInput.BlockPublicPolicy = meta.Spec.ResourcePolicy.BlockPublicPolicy
  807. }
  808. _, err = sm.client.PutResourcePolicy(ctx, putPolicyInput)
  809. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMPutResourcePolicy, err)
  810. if err != nil {
  811. return fmt.Errorf("failed to put resource policy: %w", err)
  812. }
  813. return nil
  814. }
  815. // computeTagsToUpdate compares the current tags with the desired metaTags and returns a slice of ssmTypes.Tag
  816. // that should be set on the resource. It also returns a boolean indicating if any tag was added or modified.
  817. func computeTagsToUpdate(tags, metaTags map[string]string) ([]types.Tag, bool) {
  818. result := make([]types.Tag, 0, len(metaTags))
  819. modified := false
  820. for k, v := range metaTags {
  821. if _, exists := tags[k]; !exists || tags[k] != v {
  822. if k != managedBy {
  823. modified = true
  824. }
  825. }
  826. result = append(result, types.Tag{
  827. Key: utilpointer.To(k),
  828. Value: utilpointer.To(v),
  829. })
  830. }
  831. return result, modified
  832. }