secretsmanager.go 14 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471
  1. /*
  2. Licensed under the Apache License, Version 2.0 (the "License");
  3. you may not use this file except in compliance with the License.
  4. You may obtain a copy of the License at
  5. http://www.apache.org/licenses/LICENSE-2.0
  6. Unless required by applicable law or agreed to in writing, software
  7. distributed under the License is distributed on an "AS IS" BASIS,
  8. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  9. See the License for the specific language governing permissions and
  10. limitations under the License.
  11. */
  12. package secretsmanager
  13. import (
  14. "bytes"
  15. "context"
  16. "encoding/json"
  17. "errors"
  18. "fmt"
  19. "strings"
  20. "github.com/aws/aws-sdk-go/aws"
  21. "github.com/aws/aws-sdk-go/aws/awserr"
  22. "github.com/aws/aws-sdk-go/aws/request"
  23. "github.com/aws/aws-sdk-go/aws/session"
  24. awssm "github.com/aws/aws-sdk-go/service/secretsmanager"
  25. "github.com/tidwall/gjson"
  26. apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
  27. utilpointer "k8s.io/utils/ptr"
  28. ctrl "sigs.k8s.io/controller-runtime"
  29. esv1beta1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1beta1"
  30. "github.com/external-secrets/external-secrets/pkg/constants"
  31. "github.com/external-secrets/external-secrets/pkg/find"
  32. "github.com/external-secrets/external-secrets/pkg/metrics"
  33. "github.com/external-secrets/external-secrets/pkg/provider/aws/util"
  34. )
  35. // https://github.com/external-secrets/external-secrets/issues/644
  36. var _ esv1beta1.SecretsClient = &SecretsManager{}
  37. // SecretsManager is a provider for AWS SecretsManager.
  38. type SecretsManager struct {
  39. sess *session.Session
  40. client SMInterface
  41. referentAuth bool
  42. cache map[string]*awssm.GetSecretValueOutput
  43. }
  44. // SMInterface is a subset of the smiface api.
  45. // see: https://docs.aws.amazon.com/sdk-for-go/api/service/secretsmanager/secretsmanageriface/
  46. type SMInterface interface {
  47. ListSecrets(*awssm.ListSecretsInput) (*awssm.ListSecretsOutput, error)
  48. GetSecretValue(*awssm.GetSecretValueInput) (*awssm.GetSecretValueOutput, error)
  49. CreateSecretWithContext(aws.Context, *awssm.CreateSecretInput, ...request.Option) (*awssm.CreateSecretOutput, error)
  50. GetSecretValueWithContext(aws.Context, *awssm.GetSecretValueInput, ...request.Option) (*awssm.GetSecretValueOutput, error)
  51. PutSecretValueWithContext(aws.Context, *awssm.PutSecretValueInput, ...request.Option) (*awssm.PutSecretValueOutput, error)
  52. DescribeSecretWithContext(aws.Context, *awssm.DescribeSecretInput, ...request.Option) (*awssm.DescribeSecretOutput, error)
  53. DeleteSecretWithContext(ctx aws.Context, input *awssm.DeleteSecretInput, opts ...request.Option) (*awssm.DeleteSecretOutput, error)
  54. }
  55. const (
  56. errUnexpectedFindOperator = "unexpected find operator"
  57. managedBy = "managed-by"
  58. externalSecrets = "external-secrets"
  59. )
  60. var log = ctrl.Log.WithName("provider").WithName("aws").WithName("secretsmanager")
  61. // New creates a new SecretsManager client.
  62. func New(sess *session.Session, cfg *aws.Config, referentAuth bool) (*SecretsManager, error) {
  63. return &SecretsManager{
  64. sess: sess,
  65. client: awssm.New(sess, cfg),
  66. referentAuth: referentAuth,
  67. cache: make(map[string]*awssm.GetSecretValueOutput),
  68. }, nil
  69. }
  70. func (sm *SecretsManager) fetch(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) (*awssm.GetSecretValueOutput, error) {
  71. ver := "AWSCURRENT"
  72. valueFrom := "SECRET"
  73. if ref.Version != "" {
  74. ver = ref.Version
  75. }
  76. if ref.MetadataPolicy == esv1beta1.ExternalSecretMetadataPolicyFetch {
  77. valueFrom = "TAG"
  78. }
  79. log.Info("fetching secret value", "key", ref.Key, "version", ver, "value", valueFrom)
  80. cacheKey := fmt.Sprintf("%s#%s#%s", ref.Key, ver, valueFrom)
  81. if secretOut, found := sm.cache[cacheKey]; found {
  82. log.Info("found secret in cache", "key", ref.Key, "version", ver)
  83. return secretOut, nil
  84. }
  85. var secretOut *awssm.GetSecretValueOutput
  86. var err error
  87. if ref.MetadataPolicy == esv1beta1.ExternalSecretMetadataPolicyFetch {
  88. describeSecretInput := &awssm.DescribeSecretInput{
  89. SecretId: &ref.Key,
  90. }
  91. descOutput, err := sm.client.DescribeSecretWithContext(ctx, describeSecretInput)
  92. if err != nil {
  93. return nil, err
  94. }
  95. log.Info("found metadata secret", "key", ref.Key, "output", descOutput)
  96. jsonTags, err := util.SecretTagsToJSONString(descOutput.Tags)
  97. if err != nil {
  98. return nil, err
  99. }
  100. secretOut = &awssm.GetSecretValueOutput{
  101. ARN: descOutput.ARN,
  102. CreatedDate: descOutput.CreatedDate,
  103. Name: descOutput.Name,
  104. SecretString: &jsonTags,
  105. VersionId: &ver,
  106. }
  107. } else {
  108. var getSecretValueInput *awssm.GetSecretValueInput
  109. if strings.HasPrefix(ver, "uuid/") {
  110. versionID := strings.TrimPrefix(ver, "uuid/")
  111. getSecretValueInput = &awssm.GetSecretValueInput{
  112. SecretId: &ref.Key,
  113. VersionId: &versionID,
  114. }
  115. } else {
  116. getSecretValueInput = &awssm.GetSecretValueInput{
  117. SecretId: &ref.Key,
  118. VersionStage: &ver,
  119. }
  120. }
  121. secretOut, err = sm.client.GetSecretValue(getSecretValueInput)
  122. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMGetSecretValue, err)
  123. var nf *awssm.ResourceNotFoundException
  124. if errors.As(err, &nf) {
  125. return nil, esv1beta1.NoSecretErr
  126. }
  127. if err != nil {
  128. return nil, err
  129. }
  130. }
  131. sm.cache[cacheKey] = secretOut
  132. return secretOut, nil
  133. }
  134. func (sm *SecretsManager) DeleteSecret(ctx context.Context, remoteRef esv1beta1.PushRemoteRef) error {
  135. secretName := remoteRef.GetRemoteKey()
  136. secretValue := awssm.GetSecretValueInput{
  137. SecretId: &secretName,
  138. }
  139. secretInput := awssm.DescribeSecretInput{
  140. SecretId: &secretName,
  141. }
  142. awsSecret, err := sm.client.GetSecretValueWithContext(ctx, &secretValue)
  143. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMGetSecretValue, err)
  144. var aerr awserr.Error
  145. if err != nil {
  146. if ok := errors.As(err, &aerr); !ok {
  147. return err
  148. }
  149. if aerr.Code() == awssm.ErrCodeResourceNotFoundException {
  150. return nil
  151. }
  152. return err
  153. }
  154. data, err := sm.client.DescribeSecretWithContext(ctx, &secretInput)
  155. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMDescribeSecret, err)
  156. if err != nil {
  157. return err
  158. }
  159. if !isManagedByESO(data) {
  160. return nil
  161. }
  162. deleteInput := &awssm.DeleteSecretInput{
  163. SecretId: awsSecret.ARN,
  164. }
  165. _, err = sm.client.DeleteSecretWithContext(ctx, deleteInput)
  166. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMDeleteSecret, err)
  167. return err
  168. }
  169. func (sm *SecretsManager) PushSecret(ctx context.Context, value []byte, _ *apiextensionsv1.JSON, remoteRef esv1beta1.PushRemoteRef) error {
  170. secretName := remoteRef.GetRemoteKey()
  171. managedBy := managedBy
  172. externalSecrets := externalSecrets
  173. externalSecretsTag := []*awssm.Tag{
  174. {
  175. Key: &managedBy,
  176. Value: &externalSecrets,
  177. },
  178. }
  179. secretRequest := awssm.CreateSecretInput{
  180. Name: &secretName,
  181. SecretBinary: value,
  182. Tags: externalSecretsTag,
  183. }
  184. secretValue := awssm.GetSecretValueInput{
  185. SecretId: &secretName,
  186. }
  187. secretInput := awssm.DescribeSecretInput{
  188. SecretId: &secretName,
  189. }
  190. awsSecret, err := sm.client.GetSecretValueWithContext(ctx, &secretValue)
  191. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMGetSecretValue, err)
  192. var aerr awserr.Error
  193. if err != nil {
  194. if ok := errors.As(err, &aerr); !ok {
  195. return err
  196. }
  197. if aerr.Code() == awssm.ErrCodeResourceNotFoundException {
  198. _, err = sm.client.CreateSecretWithContext(ctx, &secretRequest)
  199. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMCreateSecret, err)
  200. return err
  201. }
  202. return err
  203. }
  204. data, err := sm.client.DescribeSecretWithContext(ctx, &secretInput)
  205. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMDescribeSecret, err)
  206. if err != nil {
  207. return err
  208. }
  209. if !isManagedByESO(data) {
  210. return fmt.Errorf("secret not managed by external-secrets")
  211. }
  212. if awsSecret != nil && bytes.Equal(awsSecret.SecretBinary, value) {
  213. return nil
  214. }
  215. input := &awssm.PutSecretValueInput{
  216. SecretId: awsSecret.ARN,
  217. SecretBinary: value,
  218. }
  219. _, err = sm.client.PutSecretValueWithContext(ctx, input)
  220. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMPutSecretValue, err)
  221. return err
  222. }
  223. func isManagedByESO(data *awssm.DescribeSecretOutput) bool {
  224. managedBy := managedBy
  225. externalSecrets := externalSecrets
  226. for _, tag := range data.Tags {
  227. if *tag.Key == managedBy && *tag.Value == externalSecrets {
  228. return true
  229. }
  230. }
  231. return false
  232. }
  233. // GetAllSecrets syncs multiple secrets from aws provider into a single Kubernetes Secret.
  234. func (sm *SecretsManager) GetAllSecrets(ctx context.Context, ref esv1beta1.ExternalSecretFind) (map[string][]byte, error) {
  235. if ref.Name != nil {
  236. return sm.findByName(ctx, ref)
  237. }
  238. if len(ref.Tags) > 0 {
  239. return sm.findByTags(ctx, ref)
  240. }
  241. return nil, errors.New(errUnexpectedFindOperator)
  242. }
  243. func (sm *SecretsManager) findByName(ctx context.Context, ref esv1beta1.ExternalSecretFind) (map[string][]byte, error) {
  244. matcher, err := find.New(*ref.Name)
  245. if err != nil {
  246. return nil, err
  247. }
  248. filters := make([]*awssm.Filter, 0)
  249. if ref.Path != nil {
  250. filters = append(filters, &awssm.Filter{
  251. Key: utilpointer.To(awssm.FilterNameStringTypeName),
  252. Values: []*string{
  253. ref.Path,
  254. },
  255. })
  256. }
  257. data := make(map[string][]byte)
  258. var nextToken *string
  259. for {
  260. it, err := sm.client.ListSecrets(&awssm.ListSecretsInput{
  261. Filters: filters,
  262. NextToken: nextToken,
  263. })
  264. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMListSecrets, err)
  265. if err != nil {
  266. return nil, err
  267. }
  268. log.V(1).Info("aws sm findByName found", "secrets", len(it.SecretList))
  269. for _, secret := range it.SecretList {
  270. if !matcher.MatchName(*secret.Name) {
  271. continue
  272. }
  273. log.V(1).Info("aws sm findByName matches", "name", *secret.Name)
  274. err = sm.fetchAndSet(ctx, data, *secret.Name)
  275. if err != nil {
  276. return nil, err
  277. }
  278. }
  279. nextToken = it.NextToken
  280. if nextToken == nil {
  281. break
  282. }
  283. }
  284. return data, nil
  285. }
  286. func (sm *SecretsManager) findByTags(ctx context.Context, ref esv1beta1.ExternalSecretFind) (map[string][]byte, error) {
  287. filters := make([]*awssm.Filter, 0)
  288. for k, v := range ref.Tags {
  289. filters = append(filters, &awssm.Filter{
  290. Key: utilpointer.To(awssm.FilterNameStringTypeTagKey),
  291. Values: []*string{
  292. utilpointer.To(k),
  293. },
  294. }, &awssm.Filter{
  295. Key: utilpointer.To(awssm.FilterNameStringTypeTagValue),
  296. Values: []*string{
  297. utilpointer.To(v),
  298. },
  299. })
  300. }
  301. if ref.Path != nil {
  302. filters = append(filters, &awssm.Filter{
  303. Key: utilpointer.To(awssm.FilterNameStringTypeName),
  304. Values: []*string{
  305. ref.Path,
  306. },
  307. })
  308. }
  309. data := make(map[string][]byte)
  310. var nextToken *string
  311. for {
  312. log.V(1).Info("aws sm findByTag", "nextToken", nextToken)
  313. it, err := sm.client.ListSecrets(&awssm.ListSecretsInput{
  314. Filters: filters,
  315. NextToken: nextToken,
  316. })
  317. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMListSecrets, err)
  318. if err != nil {
  319. return nil, err
  320. }
  321. log.V(1).Info("aws sm findByTag found", "secrets", len(it.SecretList))
  322. for _, secret := range it.SecretList {
  323. err = sm.fetchAndSet(ctx, data, *secret.Name)
  324. if err != nil {
  325. return nil, err
  326. }
  327. }
  328. nextToken = it.NextToken
  329. if nextToken == nil {
  330. break
  331. }
  332. }
  333. return data, nil
  334. }
  335. func (sm *SecretsManager) fetchAndSet(ctx context.Context, data map[string][]byte, name string) error {
  336. sec, err := sm.fetch(ctx, esv1beta1.ExternalSecretDataRemoteRef{
  337. Key: name,
  338. })
  339. if err != nil {
  340. return err
  341. }
  342. if sec.SecretString != nil {
  343. data[name] = []byte(*sec.SecretString)
  344. }
  345. if sec.SecretBinary != nil {
  346. data[name] = sec.SecretBinary
  347. }
  348. return nil
  349. }
  350. // GetSecret returns a single secret from the provider.
  351. func (sm *SecretsManager) GetSecret(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) ([]byte, error) {
  352. secretOut, err := sm.fetch(ctx, ref)
  353. if errors.Is(err, esv1beta1.NoSecretErr) {
  354. return nil, err
  355. }
  356. if err != nil {
  357. return nil, util.SanitizeErr(err)
  358. }
  359. if ref.Property == "" {
  360. if secretOut.SecretString != nil {
  361. return []byte(*secretOut.SecretString), nil
  362. }
  363. if secretOut.SecretBinary != nil {
  364. return secretOut.SecretBinary, nil
  365. }
  366. return nil, fmt.Errorf("invalid secret received. no secret string nor binary for key: %s", ref.Key)
  367. }
  368. var payload string
  369. if secretOut.SecretString != nil {
  370. payload = *secretOut.SecretString
  371. }
  372. if secretOut.SecretBinary != nil {
  373. payload = string(secretOut.SecretBinary)
  374. }
  375. // We need to search if a given key with a . exists before using gjson operations.
  376. idx := strings.Index(ref.Property, ".")
  377. if idx > -1 {
  378. refProperty := strings.ReplaceAll(ref.Property, ".", "\\.")
  379. val := gjson.Get(payload, refProperty)
  380. if val.Exists() {
  381. return []byte(val.String()), nil
  382. }
  383. }
  384. val := gjson.Get(payload, ref.Property)
  385. if !val.Exists() {
  386. return nil, fmt.Errorf("key %s does not exist in secret %s", ref.Property, ref.Key)
  387. }
  388. return []byte(val.String()), nil
  389. }
  390. // GetSecretMap returns multiple k/v pairs from the provider.
  391. func (sm *SecretsManager) GetSecretMap(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) (map[string][]byte, error) {
  392. log.Info("fetching secret map", "key", ref.Key)
  393. data, err := sm.GetSecret(ctx, ref)
  394. if err != nil {
  395. return nil, err
  396. }
  397. kv := make(map[string]json.RawMessage)
  398. err = json.Unmarshal(data, &kv)
  399. if err != nil {
  400. return nil, fmt.Errorf("unable to unmarshal secret %s: %w", ref.Key, err)
  401. }
  402. secretData := make(map[string][]byte)
  403. for k, v := range kv {
  404. var strVal string
  405. err = json.Unmarshal(v, &strVal)
  406. if err == nil {
  407. secretData[k] = []byte(strVal)
  408. } else {
  409. secretData[k] = v
  410. }
  411. }
  412. return secretData, nil
  413. }
  414. func (sm *SecretsManager) Close(_ context.Context) error {
  415. return nil
  416. }
  417. func (sm *SecretsManager) Validate() (esv1beta1.ValidationResult, error) {
  418. // skip validation stack because it depends on the namespace
  419. // of the ExternalSecret
  420. if sm.referentAuth {
  421. return esv1beta1.ValidationResultUnknown, nil
  422. }
  423. _, err := sm.sess.Config.Credentials.Get()
  424. if err != nil {
  425. return esv1beta1.ValidationResultError, util.SanitizeErr(err)
  426. }
  427. return esv1beta1.ValidationResultReady, nil
  428. }
  429. func (sm *SecretsManager) Capabilities() esv1beta1.SecretStoreCapabilities {
  430. return esv1beta1.SecretStoreReadWrite
  431. }