validate.go 7.8 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189
  1. /*
  2. Licensed under the Apache License, Version 2.0 (the "License");
  3. you may not use this file except in compliance with the License.
  4. You may obtain a copy of the License at
  5. http://www.apache.org/licenses/LICENSE-2.0
  6. Unless required by applicable law or agreed to in writing, software
  7. distributed under the License is distributed on an "AS IS" BASIS,
  8. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  9. See the License for the specific language governing permissions and
  10. limitations under the License.
  11. */
  12. package vault
  13. import (
  14. "context"
  15. "errors"
  16. "fmt"
  17. "sigs.k8s.io/controller-runtime/pkg/webhook/admission"
  18. esv1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1"
  19. "github.com/external-secrets/external-secrets/pkg/utils"
  20. )
  21. const (
  22. errInvalidCredentials = "invalid vault credentials: %w"
  23. errInvalidStore = "invalid store"
  24. errInvalidStoreSpec = "invalid store spec"
  25. errInvalidStoreProv = "invalid store provider"
  26. errInvalidVaultProv = "invalid vault provider"
  27. errInvalidAppRoleRef = "invalid Auth.AppRole.RoleRef: %w"
  28. errInvalidAppRoleSec = "invalid Auth.AppRole.SecretRef: %w"
  29. errInvalidClientCert = "invalid Auth.Cert.ClientCert: %w"
  30. errInvalidCertSec = "invalid Auth.Cert.SecretRef: %w"
  31. errInvalidJwtSec = "invalid Auth.Jwt.SecretRef: %w"
  32. errInvalidJwtK8sSA = "invalid Auth.Jwt.KubernetesServiceAccountToken.ServiceAccountRef: %w"
  33. errInvalidKubeSA = "invalid Auth.Kubernetes.ServiceAccountRef: %w"
  34. errInvalidKubeSec = "invalid Auth.Kubernetes.SecretRef: %w"
  35. errInvalidLdapSec = "invalid Auth.Ldap.SecretRef: %w"
  36. errInvalidTokenRef = "invalid Auth.TokenSecretRef: %w"
  37. errInvalidUserPassSec = "invalid Auth.UserPass.SecretRef: %w"
  38. errInvalidClientTLSCert = "invalid ClientTLS.ClientCert: %w"
  39. errInvalidClientTLSSecret = "invalid ClientTLS.SecretRef: %w"
  40. errInvalidClientTLS = "when provided, both ClientTLS.ClientCert and ClientTLS.SecretRef should be provided"
  41. errCASNotSupportedInKVv1 = "checkAndSet is not supported with Vault KV version v1"
  42. )
  43. func (p *Provider) ValidateStore(store esv1.GenericStore) (admission.Warnings, error) {
  44. if store == nil {
  45. return nil, errors.New(errInvalidStore)
  46. }
  47. spc := store.GetSpec()
  48. if spc == nil {
  49. return nil, errors.New(errInvalidStoreSpec)
  50. }
  51. if spc.Provider == nil {
  52. return nil, errors.New(errInvalidStoreProv)
  53. }
  54. vaultProvider := spc.Provider.Vault
  55. if vaultProvider == nil {
  56. return nil, errors.New(errInvalidVaultProv)
  57. }
  58. if vaultProvider.Auth != nil {
  59. if vaultProvider.Auth.AppRole != nil {
  60. // check SecretRef for valid configuration
  61. if err := utils.ValidateReferentSecretSelector(store, vaultProvider.Auth.AppRole.SecretRef); err != nil {
  62. return nil, fmt.Errorf(errInvalidAppRoleSec, err)
  63. }
  64. // prefer .auth.appRole.roleId, fallback to .auth.appRole.roleRef, give up after that.
  65. if vaultProvider.Auth.AppRole.RoleID == "" { // prevents further RoleID tests if .auth.appRole.roleId is given
  66. if vaultProvider.Auth.AppRole.RoleRef != nil { // check RoleRef for valid configuration
  67. if err := utils.ValidateReferentSecretSelector(store, *vaultProvider.Auth.AppRole.RoleRef); err != nil {
  68. return nil, fmt.Errorf(errInvalidAppRoleRef, err)
  69. }
  70. } else { // we ran out of ways to get RoleID. return an appropriate error
  71. return nil, errors.New(errInvalidAppRoleID)
  72. }
  73. }
  74. }
  75. if vaultProvider.Auth.Cert != nil {
  76. if err := utils.ValidateReferentSecretSelector(store, vaultProvider.Auth.Cert.ClientCert); err != nil {
  77. return nil, fmt.Errorf(errInvalidClientCert, err)
  78. }
  79. if err := utils.ValidateReferentSecretSelector(store, vaultProvider.Auth.Cert.SecretRef); err != nil {
  80. return nil, fmt.Errorf(errInvalidCertSec, err)
  81. }
  82. }
  83. if vaultProvider.Auth.Jwt != nil {
  84. if vaultProvider.Auth.Jwt.SecretRef != nil {
  85. if err := utils.ValidateReferentSecretSelector(store, *vaultProvider.Auth.Jwt.SecretRef); err != nil {
  86. return nil, fmt.Errorf(errInvalidJwtSec, err)
  87. }
  88. } else if vaultProvider.Auth.Jwt.KubernetesServiceAccountToken != nil {
  89. if err := utils.ValidateReferentServiceAccountSelector(store, vaultProvider.Auth.Jwt.KubernetesServiceAccountToken.ServiceAccountRef); err != nil {
  90. return nil, fmt.Errorf(errInvalidJwtK8sSA, err)
  91. }
  92. } else {
  93. return nil, errors.New(errJwtNoTokenSource)
  94. }
  95. }
  96. if vaultProvider.Auth.Kubernetes != nil {
  97. if vaultProvider.Auth.Kubernetes.ServiceAccountRef != nil {
  98. if err := utils.ValidateReferentServiceAccountSelector(store, *vaultProvider.Auth.Kubernetes.ServiceAccountRef); err != nil {
  99. return nil, fmt.Errorf(errInvalidKubeSA, err)
  100. }
  101. }
  102. if vaultProvider.Auth.Kubernetes.SecretRef != nil {
  103. if err := utils.ValidateReferentSecretSelector(store, *vaultProvider.Auth.Kubernetes.SecretRef); err != nil {
  104. return nil, fmt.Errorf(errInvalidKubeSec, err)
  105. }
  106. }
  107. }
  108. if vaultProvider.Auth.Ldap != nil {
  109. if err := utils.ValidateReferentSecretSelector(store, vaultProvider.Auth.Ldap.SecretRef); err != nil {
  110. return nil, fmt.Errorf(errInvalidLdapSec, err)
  111. }
  112. }
  113. if vaultProvider.Auth.UserPass != nil {
  114. if err := utils.ValidateReferentSecretSelector(store, vaultProvider.Auth.UserPass.SecretRef); err != nil {
  115. return nil, fmt.Errorf(errInvalidUserPassSec, err)
  116. }
  117. }
  118. if vaultProvider.Auth.TokenSecretRef != nil {
  119. if err := utils.ValidateReferentSecretSelector(store, *vaultProvider.Auth.TokenSecretRef); err != nil {
  120. return nil, fmt.Errorf(errInvalidTokenRef, err)
  121. }
  122. }
  123. if vaultProvider.Auth.Iam != nil {
  124. if vaultProvider.Auth.Iam.JWTAuth != nil {
  125. if vaultProvider.Auth.Iam.JWTAuth.ServiceAccountRef != nil {
  126. if err := utils.ValidateReferentServiceAccountSelector(store, *vaultProvider.Auth.Iam.JWTAuth.ServiceAccountRef); err != nil {
  127. return nil, fmt.Errorf(errInvalidTokenRef, err)
  128. }
  129. }
  130. }
  131. if vaultProvider.Auth.Iam.SecretRef != nil {
  132. if err := utils.ValidateReferentSecretSelector(store, vaultProvider.Auth.Iam.SecretRef.AccessKeyID); err != nil {
  133. return nil, fmt.Errorf(errInvalidTokenRef, err)
  134. }
  135. if err := utils.ValidateReferentSecretSelector(store, vaultProvider.Auth.Iam.SecretRef.SecretAccessKey); err != nil {
  136. return nil, fmt.Errorf(errInvalidTokenRef, err)
  137. }
  138. if vaultProvider.Auth.Iam.SecretRef.SessionToken != nil {
  139. if err := utils.ValidateReferentSecretSelector(store, *vaultProvider.Auth.Iam.SecretRef.SessionToken); err != nil {
  140. return nil, fmt.Errorf(errInvalidTokenRef, err)
  141. }
  142. }
  143. }
  144. }
  145. }
  146. if vaultProvider.ClientTLS.CertSecretRef != nil && vaultProvider.ClientTLS.KeySecretRef != nil {
  147. if err := utils.ValidateReferentSecretSelector(store, *vaultProvider.ClientTLS.CertSecretRef); err != nil {
  148. return nil, fmt.Errorf(errInvalidClientTLSCert, err)
  149. }
  150. if err := utils.ValidateReferentSecretSelector(store, *vaultProvider.ClientTLS.KeySecretRef); err != nil {
  151. return nil, fmt.Errorf(errInvalidClientTLSSecret, err)
  152. }
  153. } else if vaultProvider.ClientTLS.CertSecretRef != nil || vaultProvider.ClientTLS.KeySecretRef != nil {
  154. return nil, errors.New(errInvalidClientTLS)
  155. }
  156. // Validate CAS configuration
  157. if vaultProvider.CheckAndSet != nil && vaultProvider.CheckAndSet.Required {
  158. if vaultProvider.Version == esv1.VaultKVStoreV1 {
  159. return nil, errors.New(errCASNotSupportedInKVv1)
  160. }
  161. }
  162. return nil, nil
  163. }
  164. func (c *client) Validate() (esv1.ValidationResult, error) {
  165. // when using referent namespace we can not validate the token
  166. // because the namespace is not known yet when Validate() is called
  167. // from the SecretStore controller.
  168. if c.storeKind == esv1.ClusterSecretStoreKind && isReferentSpec(c.store) {
  169. return esv1.ValidationResultUnknown, nil
  170. }
  171. _, err := checkToken(context.Background(), c.token)
  172. if err != nil {
  173. return esv1.ValidationResultError, fmt.Errorf(errInvalidCredentials, err)
  174. }
  175. return esv1.ValidationResultReady, nil
  176. }