pushsecret_controller.go 14 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409
  1. /*
  2. Licensed under the Apache License, Version 2.0 (the "License");
  3. you may not use this file except in compliance with the License.
  4. You may obtain a copy of the License at
  5. http://www.apache.org/licenses/LICENSE-2.0
  6. Unless required by applicable law or agreed to in writing, software
  7. distributed under the License is distributed on an "AS IS" BASIS,
  8. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  9. See the License for the specific language governing permissions and
  10. limitations under the License.
  11. */
  12. package pushsecret
  13. import (
  14. "context"
  15. "fmt"
  16. "strings"
  17. "time"
  18. "github.com/go-logr/logr"
  19. v1 "k8s.io/api/core/v1"
  20. apierrors "k8s.io/apimachinery/pkg/api/errors"
  21. metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
  22. "k8s.io/apimachinery/pkg/runtime"
  23. "k8s.io/apimachinery/pkg/types"
  24. "k8s.io/client-go/tools/record"
  25. ctrl "sigs.k8s.io/controller-runtime"
  26. "sigs.k8s.io/controller-runtime/pkg/client"
  27. "sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
  28. esapi "github.com/external-secrets/external-secrets/apis/externalsecrets/v1alpha1"
  29. v1beta1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1beta1"
  30. )
  31. const (
  32. errFailedGetSecret = "could not get source secret"
  33. errPatchStatus = "error merging"
  34. errGetSecretStore = "could not get SecretStore %q, %w"
  35. errGetClusterSecretStore = "could not get ClusterSecretStore %q, %w"
  36. errGetProviderFailed = "could not start provider"
  37. errGetSecretsClientFailed = "could not start secrets client"
  38. errCloseStoreClient = "error when calling provider close method"
  39. errSetSecretFailed = "could not write remote ref %v to target secretstore %v: %v"
  40. errFailedSetSecret = "set secret failed: %v"
  41. pushSecretFinalizer = "pushsecret.externalsecrets.io/finalizer"
  42. )
  43. type Reconciler struct {
  44. client.Client
  45. Log logr.Logger
  46. Scheme *runtime.Scheme
  47. recorder record.EventRecorder
  48. RequeueInterval time.Duration
  49. ControllerClass string
  50. }
  51. func (r *Reconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
  52. log := r.Log.WithValues("pushsecret", req.NamespacedName)
  53. var ps esapi.PushSecret
  54. err := r.Get(ctx, req.NamespacedName, &ps)
  55. if apierrors.IsNotFound(err) {
  56. return ctrl.Result{}, nil
  57. } else if err != nil {
  58. msg := "unable to get PushSecret"
  59. r.recorder.Event(&ps, v1.EventTypeWarning, esapi.ReasonErrored, msg)
  60. log.Error(err, msg)
  61. return ctrl.Result{}, fmt.Errorf("get resource: %w", err)
  62. }
  63. refreshInt := r.RequeueInterval
  64. if ps.Spec.RefreshInterval != nil {
  65. refreshInt = ps.Spec.RefreshInterval.Duration
  66. }
  67. p := client.MergeFrom(ps.DeepCopy())
  68. defer func() {
  69. err := r.Client.Status().Patch(ctx, &ps, p)
  70. if err != nil {
  71. log.Error(err, errPatchStatus)
  72. }
  73. }()
  74. // finalizer logic
  75. if ps.ObjectMeta.DeletionTimestamp.IsZero() {
  76. if !controllerutil.ContainsFinalizer(&ps, pushSecretFinalizer) {
  77. controllerutil.AddFinalizer(&ps, pushSecretFinalizer)
  78. err := r.Client.Update(ctx, &ps, &client.UpdateOptions{})
  79. if err != nil {
  80. return ctrl.Result{}, fmt.Errorf("could not update finalizers: %w", err)
  81. }
  82. return ctrl.Result{}, nil
  83. }
  84. } else {
  85. if controllerutil.ContainsFinalizer(&ps, pushSecretFinalizer) {
  86. // trigger a cleanup with no Synced Map
  87. badState, err := r.DeleteSecretFromProviders(ctx, &ps, esapi.SyncedPushSecretsMap{})
  88. if err != nil {
  89. msg := fmt.Sprintf("Failed to Delete Secrets from Provider: %v", err)
  90. cond := NewPushSecretCondition(esapi.PushSecretReady, v1.ConditionFalse, esapi.ReasonErrored, msg)
  91. ps = SetPushSecretCondition(ps, *cond)
  92. r.SetSyncedSecrets(&ps, badState)
  93. r.recorder.Event(&ps, v1.EventTypeWarning, esapi.ReasonErrored, msg)
  94. return ctrl.Result{}, err
  95. }
  96. controllerutil.RemoveFinalizer(&ps, pushSecretFinalizer)
  97. err = r.Client.Update(ctx, &ps, &client.UpdateOptions{})
  98. if err != nil {
  99. return ctrl.Result{}, fmt.Errorf("could not update finalizers: %w", err)
  100. }
  101. return ctrl.Result{}, nil
  102. }
  103. }
  104. secret, err := r.GetSecret(ctx, ps)
  105. if err != nil {
  106. cond := NewPushSecretCondition(esapi.PushSecretReady, v1.ConditionFalse, esapi.ReasonErrored, errFailedGetSecret)
  107. ps = SetPushSecretCondition(ps, *cond)
  108. r.recorder.Event(&ps, v1.EventTypeWarning, esapi.ReasonErrored, errFailedGetSecret)
  109. return ctrl.Result{}, err
  110. }
  111. secretStores, err := r.GetSecretStores(ctx, ps)
  112. if err != nil {
  113. cond := NewPushSecretCondition(esapi.PushSecretReady, v1.ConditionFalse, esapi.ReasonErrored, err.Error())
  114. ps = SetPushSecretCondition(ps, *cond)
  115. r.recorder.Event(&ps, v1.EventTypeWarning, esapi.ReasonErrored, err.Error())
  116. return ctrl.Result{}, err
  117. }
  118. syncedSecrets, err := r.PushSecretToProviders(ctx, secretStores, ps, secret)
  119. if err != nil {
  120. msg := fmt.Sprintf(errFailedSetSecret, err)
  121. cond := NewPushSecretCondition(esapi.PushSecretReady, v1.ConditionFalse, esapi.ReasonErrored, msg)
  122. ps = SetPushSecretCondition(ps, *cond)
  123. r.SetSyncedSecrets(&ps, syncedSecrets)
  124. r.recorder.Event(&ps, v1.EventTypeWarning, esapi.ReasonErrored, msg)
  125. return ctrl.Result{}, err
  126. }
  127. switch ps.Spec.DeletionPolicy {
  128. case esapi.PushSecretDeletionPolicyDelete:
  129. badSyncState, err := r.DeleteSecretFromProviders(ctx, &ps, syncedSecrets)
  130. if err != nil {
  131. msg := fmt.Sprintf("Failed to Delete Secrets from Provider: %v", err)
  132. cond := NewPushSecretCondition(esapi.PushSecretReady, v1.ConditionFalse, esapi.ReasonErrored, msg)
  133. ps = SetPushSecretCondition(ps, *cond)
  134. r.SetSyncedSecrets(&ps, badSyncState)
  135. r.recorder.Event(&ps, v1.EventTypeWarning, esapi.ReasonErrored, msg)
  136. return ctrl.Result{}, err
  137. }
  138. case esapi.PushSecretDeletionPolicyNone:
  139. default:
  140. }
  141. msg := "PushSecret synced successfully"
  142. cond := NewPushSecretCondition(esapi.PushSecretReady, v1.ConditionTrue, esapi.ReasonSynced, msg)
  143. ps = SetPushSecretCondition(ps, *cond)
  144. r.SetSyncedSecrets(&ps, syncedSecrets)
  145. r.recorder.Event(&ps, v1.EventTypeNormal, esapi.ReasonSynced, msg)
  146. return ctrl.Result{RequeueAfter: refreshInt}, nil
  147. }
  148. func (r *Reconciler) SetSyncedSecrets(ps *esapi.PushSecret, status esapi.SyncedPushSecretsMap) {
  149. ps.Status.SyncedPushSecrets = status
  150. }
  151. func (r *Reconciler) DeleteSecretFromProviders(ctx context.Context, ps *esapi.PushSecret, newMap esapi.SyncedPushSecretsMap) (esapi.SyncedPushSecretsMap, error) {
  152. out := newMap.DeepCopy()
  153. for k, v := range ps.Status.SyncedPushSecrets {
  154. _, ok := out[k]
  155. if !ok {
  156. out[k] = make(map[string]esapi.PushSecretData)
  157. }
  158. for kk, vv := range v {
  159. out[k][kk] = vv
  160. }
  161. }
  162. for storeName, oldData := range ps.Status.SyncedPushSecrets {
  163. storeRef := esapi.PushSecretStoreRef{
  164. Name: strings.Split(storeName, "/")[1],
  165. Kind: strings.Split(storeName, "/")[0],
  166. }
  167. store, err := r.getSecretStoreFromName(ctx, storeRef, ps.Namespace)
  168. if err != nil {
  169. return out, err
  170. }
  171. client, err := r.getClientFromStore(ctx, store, ps)
  172. if err != nil {
  173. return out, fmt.Errorf("could not get secrets client for store %v: %w", store.GetName(), err)
  174. }
  175. defer func() { //nolint
  176. err := client.Close(ctx)
  177. if err != nil {
  178. r.Log.Error(err, errCloseStoreClient)
  179. }
  180. }()
  181. newData, ok := newMap[storeName]
  182. if !ok {
  183. err = r.DeleteAllSecretsFromStore(ctx, client, oldData)
  184. if err != nil {
  185. return out, err
  186. }
  187. delete(out, storeName)
  188. continue
  189. }
  190. for oldEntry, oldRef := range oldData {
  191. _, ok := newData[oldEntry]
  192. if !ok {
  193. err = r.DeleteSecretFromStore(ctx, client, oldRef)
  194. if err != nil {
  195. return out, err
  196. }
  197. delete(out[storeName], oldRef.Match.RemoteRef.RemoteKey)
  198. }
  199. }
  200. }
  201. return out, nil
  202. }
  203. func (r *Reconciler) DeleteAllSecretsFromStore(ctx context.Context, client v1beta1.SecretsClient, data map[string]esapi.PushSecretData) error {
  204. for _, v := range data {
  205. err := r.DeleteSecretFromStore(ctx, client, v)
  206. if err != nil {
  207. return err
  208. }
  209. }
  210. return nil
  211. }
  212. func (r *Reconciler) DeleteSecretFromStore(ctx context.Context, client v1beta1.SecretsClient, data esapi.PushSecretData) error {
  213. return client.DeleteSecret(ctx, data.Match.RemoteRef)
  214. }
  215. func (r *Reconciler) getClientFromStore(ctx context.Context, store v1beta1.GenericStore, ps *esapi.PushSecret) (v1beta1.SecretsClient, error) {
  216. provider, err := v1beta1.GetProvider(store)
  217. if err != nil {
  218. return nil, fmt.Errorf(errGetProviderFailed)
  219. }
  220. client, err := provider.NewClient(ctx, store, r.Client, ps.Namespace)
  221. if err != nil {
  222. return nil, fmt.Errorf(errGetSecretsClientFailed)
  223. }
  224. return client, nil
  225. }
  226. func (r *Reconciler) PushSecretToProviders(ctx context.Context, stores map[esapi.PushSecretStoreRef]v1beta1.GenericStore, ps esapi.PushSecret, secret *v1.Secret) (esapi.SyncedPushSecretsMap, error) {
  227. out := esapi.SyncedPushSecretsMap{}
  228. for ref, store := range stores {
  229. storeKey := fmt.Sprintf("%v/%v", ref.Kind, store.GetName())
  230. out[storeKey] = make(map[string]esapi.PushSecretData)
  231. client, err := r.getClientFromStore(ctx, store, &ps)
  232. if err != nil {
  233. return out, fmt.Errorf("could not get secrets client for store %v: %w", store.GetName(), err)
  234. }
  235. defer func() { //nolint
  236. err := client.Close(ctx)
  237. if err != nil {
  238. r.Log.Error(err, errCloseStoreClient)
  239. }
  240. }()
  241. for _, ref := range ps.Spec.Data {
  242. secretValue, ok := secret.Data[ref.Match.SecretKey]
  243. if !ok {
  244. return out, fmt.Errorf("secret key %v does not exist", ref.Match.SecretKey)
  245. }
  246. err := client.SetSecret(ctx, secretValue, ref.Match.RemoteRef)
  247. if err != nil {
  248. return out, fmt.Errorf(errSetSecretFailed, ref.Match.SecretKey, store.GetName(), err)
  249. }
  250. out[storeKey][ref.Match.RemoteRef.RemoteKey] = ref
  251. }
  252. }
  253. return out, nil
  254. }
  255. func (r *Reconciler) GetSecret(ctx context.Context, ps esapi.PushSecret) (*v1.Secret, error) {
  256. secretName := types.NamespacedName{Name: ps.Spec.Selector.Secret.Name, Namespace: ps.Namespace}
  257. secret := &v1.Secret{}
  258. err := r.Client.Get(ctx, secretName, secret)
  259. if err != nil {
  260. return nil, err
  261. }
  262. return secret, nil
  263. }
  264. func (r *Reconciler) GetSecretStores(ctx context.Context, ps esapi.PushSecret) (map[esapi.PushSecretStoreRef]v1beta1.GenericStore, error) {
  265. stores := make(map[esapi.PushSecretStoreRef]v1beta1.GenericStore)
  266. for _, refStore := range ps.Spec.SecretStoreRefs {
  267. if refStore.LabelSelector != nil {
  268. labelSelector, err := metav1.LabelSelectorAsSelector(refStore.LabelSelector)
  269. if err != nil {
  270. return nil, fmt.Errorf("could not convert labels: %w", err)
  271. }
  272. if refStore.Kind == v1beta1.ClusterSecretStoreKind {
  273. clusterSecretStoreList := v1beta1.ClusterSecretStoreList{}
  274. err = r.List(ctx, &clusterSecretStoreList, &client.ListOptions{LabelSelector: labelSelector})
  275. if err != nil {
  276. return nil, fmt.Errorf("could not list cluster Secret Stores: %w", err)
  277. }
  278. for k, v := range clusterSecretStoreList.Items {
  279. key := esapi.PushSecretStoreRef{
  280. Name: v.Name,
  281. Kind: v1beta1.ClusterSecretStoreKind,
  282. }
  283. stores[key] = &clusterSecretStoreList.Items[k]
  284. }
  285. } else {
  286. secretStoreList := v1beta1.SecretStoreList{}
  287. err = r.List(ctx, &secretStoreList, &client.ListOptions{LabelSelector: labelSelector})
  288. if err != nil {
  289. return nil, fmt.Errorf("could not list Secret Stores: %w", err)
  290. }
  291. for k, v := range secretStoreList.Items {
  292. key := esapi.PushSecretStoreRef{
  293. Name: v.Name,
  294. Kind: v1beta1.SecretStoreKind,
  295. }
  296. stores[key] = &secretStoreList.Items[k]
  297. }
  298. }
  299. } else {
  300. store, err := r.getSecretStoreFromName(ctx, refStore, ps.Namespace)
  301. if err != nil {
  302. return nil, err
  303. }
  304. stores[refStore] = store
  305. }
  306. }
  307. return stores, nil
  308. }
  309. func (r *Reconciler) getSecretStoreFromName(ctx context.Context, refStore esapi.PushSecretStoreRef, ns string) (v1beta1.GenericStore, error) {
  310. if refStore.Name == "" {
  311. return nil, fmt.Errorf("refStore Name must be provided")
  312. }
  313. ref := types.NamespacedName{
  314. Name: refStore.Name,
  315. }
  316. if refStore.Kind == v1beta1.ClusterSecretStoreKind {
  317. var store v1beta1.ClusterSecretStore
  318. err := r.Get(ctx, ref, &store)
  319. if err != nil {
  320. return nil, fmt.Errorf(errGetClusterSecretStore, ref.Name, err)
  321. }
  322. return &store, nil
  323. }
  324. ref.Namespace = ns
  325. var store v1beta1.SecretStore
  326. err := r.Get(ctx, ref, &store)
  327. if err != nil {
  328. return nil, fmt.Errorf(errGetSecretStore, ref.Name, err)
  329. }
  330. return &store, nil
  331. }
  332. func (r *Reconciler) SetupWithManager(mgr ctrl.Manager) error {
  333. r.recorder = mgr.GetEventRecorderFor("pushsecret")
  334. return ctrl.NewControllerManagedBy(mgr).
  335. For(&esapi.PushSecret{}).
  336. Complete(r)
  337. }
  338. func NewPushSecretCondition(condType esapi.PushSecretConditionType, status v1.ConditionStatus, reason, message string) *esapi.PushSecretStatusCondition {
  339. return &esapi.PushSecretStatusCondition{
  340. Type: condType,
  341. Status: status,
  342. LastTransitionTime: metav1.Now(),
  343. Reason: reason,
  344. Message: message,
  345. }
  346. }
  347. func SetPushSecretCondition(gs esapi.PushSecret, condition esapi.PushSecretStatusCondition) esapi.PushSecret {
  348. status := gs.Status
  349. currentCond := GetPushSecretCondition(status, condition.Type)
  350. if currentCond != nil && currentCond.Status == condition.Status &&
  351. currentCond.Reason == condition.Reason && currentCond.Message == condition.Message {
  352. return gs
  353. }
  354. // Do not update lastTransitionTime if the status of the condition doesn't change.
  355. if currentCond != nil && currentCond.Status == condition.Status {
  356. condition.LastTransitionTime = currentCond.LastTransitionTime
  357. }
  358. status.Conditions = append(filterOutCondition(status.Conditions, condition.Type), condition)
  359. gs.Status = status
  360. return gs
  361. }
  362. // filterOutCondition returns an empty set of conditions with the provided type.
  363. func filterOutCondition(conditions []esapi.PushSecretStatusCondition, condType esapi.PushSecretConditionType) []esapi.PushSecretStatusCondition {
  364. newConditions := make([]esapi.PushSecretStatusCondition, 0, len(conditions))
  365. for _, c := range conditions {
  366. if c.Type == condType {
  367. continue
  368. }
  369. newConditions = append(newConditions, c)
  370. }
  371. return newConditions
  372. }
  373. // GetSecretStoreCondition returns the condition with the provided type.
  374. func GetPushSecretCondition(status esapi.PushSecretStatus, condType esapi.PushSecretConditionType) *esapi.PushSecretStatusCondition {
  375. for i := range status.Conditions {
  376. c := status.Conditions[i]
  377. if c.Type == condType {
  378. return &c
  379. }
  380. }
  381. return nil
  382. }