secretsmanager.go 14 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469
  1. /*
  2. Licensed under the Apache License, Version 2.0 (the "License");
  3. you may not use this file except in compliance with the License.
  4. You may obtain a copy of the License at
  5. http://www.apache.org/licenses/LICENSE-2.0
  6. Unless required by applicable law or agreed to in writing, software
  7. distributed under the License is distributed on an "AS IS" BASIS,
  8. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  9. See the License for the specific language governing permissions and
  10. limitations under the License.
  11. */
  12. package secretsmanager
  13. import (
  14. "bytes"
  15. "context"
  16. "encoding/json"
  17. "errors"
  18. "fmt"
  19. "strings"
  20. "github.com/aws/aws-sdk-go/aws"
  21. "github.com/aws/aws-sdk-go/aws/awserr"
  22. "github.com/aws/aws-sdk-go/aws/request"
  23. "github.com/aws/aws-sdk-go/aws/session"
  24. awssm "github.com/aws/aws-sdk-go/service/secretsmanager"
  25. "github.com/tidwall/gjson"
  26. utilpointer "k8s.io/utils/pointer"
  27. ctrl "sigs.k8s.io/controller-runtime"
  28. esv1beta1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1beta1"
  29. "github.com/external-secrets/external-secrets/pkg/find"
  30. "github.com/external-secrets/external-secrets/pkg/provider/aws/util"
  31. "github.com/external-secrets/external-secrets/pkg/provider/metrics"
  32. )
  33. // https://github.com/external-secrets/external-secrets/issues/644
  34. var _ esv1beta1.SecretsClient = &SecretsManager{}
  35. // SecretsManager is a provider for AWS SecretsManager.
  36. type SecretsManager struct {
  37. sess *session.Session
  38. client SMInterface
  39. referentAuth bool
  40. cache map[string]*awssm.GetSecretValueOutput
  41. }
  42. // SMInterface is a subset of the smiface api.
  43. // see: https://docs.aws.amazon.com/sdk-for-go/api/service/secretsmanager/secretsmanageriface/
  44. type SMInterface interface {
  45. ListSecrets(*awssm.ListSecretsInput) (*awssm.ListSecretsOutput, error)
  46. GetSecretValue(*awssm.GetSecretValueInput) (*awssm.GetSecretValueOutput, error)
  47. CreateSecretWithContext(aws.Context, *awssm.CreateSecretInput, ...request.Option) (*awssm.CreateSecretOutput, error)
  48. GetSecretValueWithContext(aws.Context, *awssm.GetSecretValueInput, ...request.Option) (*awssm.GetSecretValueOutput, error)
  49. PutSecretValueWithContext(aws.Context, *awssm.PutSecretValueInput, ...request.Option) (*awssm.PutSecretValueOutput, error)
  50. DescribeSecretWithContext(aws.Context, *awssm.DescribeSecretInput, ...request.Option) (*awssm.DescribeSecretOutput, error)
  51. DeleteSecretWithContext(ctx aws.Context, input *awssm.DeleteSecretInput, opts ...request.Option) (*awssm.DeleteSecretOutput, error)
  52. }
  53. const (
  54. errUnexpectedFindOperator = "unexpected find operator"
  55. managedBy = "managed-by"
  56. externalSecrets = "external-secrets"
  57. )
  58. var log = ctrl.Log.WithName("provider").WithName("aws").WithName("secretsmanager")
  59. // New creates a new SecretsManager client.
  60. func New(sess *session.Session, cfg *aws.Config, referentAuth bool) (*SecretsManager, error) {
  61. return &SecretsManager{
  62. sess: sess,
  63. client: awssm.New(sess, cfg),
  64. referentAuth: referentAuth,
  65. cache: make(map[string]*awssm.GetSecretValueOutput),
  66. }, nil
  67. }
  68. func (sm *SecretsManager) fetch(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) (*awssm.GetSecretValueOutput, error) {
  69. ver := "AWSCURRENT"
  70. valueFrom := "SECRET"
  71. if ref.Version != "" {
  72. ver = ref.Version
  73. }
  74. if ref.MetadataPolicy == esv1beta1.ExternalSecretMetadataPolicyFetch {
  75. valueFrom = "TAG"
  76. }
  77. log.Info("fetching secret value", "key", ref.Key, "version", ver, "value", valueFrom)
  78. cacheKey := fmt.Sprintf("%s#%s#%s", ref.Key, ver, valueFrom)
  79. if secretOut, found := sm.cache[cacheKey]; found {
  80. log.Info("found secret in cache", "key", ref.Key, "version", ver)
  81. return secretOut, nil
  82. }
  83. var secretOut *awssm.GetSecretValueOutput
  84. var err error
  85. if ref.MetadataPolicy == esv1beta1.ExternalSecretMetadataPolicyFetch {
  86. describeSecretInput := &awssm.DescribeSecretInput{
  87. SecretId: &ref.Key,
  88. }
  89. descOutput, err := sm.client.DescribeSecretWithContext(ctx, describeSecretInput)
  90. if err != nil {
  91. return nil, err
  92. }
  93. log.Info("found metadata secret", "key", ref.Key, "output", descOutput)
  94. jsonTags, err := util.SecretTagsToJSONString(descOutput.Tags)
  95. if err != nil {
  96. return nil, err
  97. }
  98. secretOut = &awssm.GetSecretValueOutput{
  99. ARN: descOutput.ARN,
  100. CreatedDate: descOutput.CreatedDate,
  101. Name: descOutput.Name,
  102. SecretString: &jsonTags,
  103. VersionId: &ver,
  104. }
  105. } else {
  106. var getSecretValueInput *awssm.GetSecretValueInput
  107. if strings.HasPrefix(ver, "uuid/") {
  108. versionID := strings.TrimPrefix(ver, "uuid/")
  109. getSecretValueInput = &awssm.GetSecretValueInput{
  110. SecretId: &ref.Key,
  111. VersionId: &versionID,
  112. }
  113. } else {
  114. getSecretValueInput = &awssm.GetSecretValueInput{
  115. SecretId: &ref.Key,
  116. VersionStage: &ver,
  117. }
  118. }
  119. secretOut, err = sm.client.GetSecretValue(getSecretValueInput)
  120. metrics.ObserveAPICall(metrics.ProviderAWSSM, metrics.CallAWSSMGetSecretValue, err)
  121. var nf *awssm.ResourceNotFoundException
  122. if errors.As(err, &nf) {
  123. return nil, esv1beta1.NoSecretErr
  124. }
  125. if err != nil {
  126. return nil, err
  127. }
  128. }
  129. sm.cache[cacheKey] = secretOut
  130. return secretOut, nil
  131. }
  132. func (sm *SecretsManager) DeleteSecret(ctx context.Context, remoteRef esv1beta1.PushRemoteRef) error {
  133. secretName := remoteRef.GetRemoteKey()
  134. secretValue := awssm.GetSecretValueInput{
  135. SecretId: &secretName,
  136. }
  137. secretInput := awssm.DescribeSecretInput{
  138. SecretId: &secretName,
  139. }
  140. awsSecret, err := sm.client.GetSecretValueWithContext(ctx, &secretValue)
  141. metrics.ObserveAPICall(metrics.ProviderAWSSM, metrics.CallAWSSMGetSecretValue, err)
  142. var aerr awserr.Error
  143. if err != nil {
  144. if ok := errors.As(err, &aerr); !ok {
  145. return err
  146. }
  147. if aerr.Code() == awssm.ErrCodeResourceNotFoundException {
  148. return nil
  149. }
  150. return err
  151. }
  152. data, err := sm.client.DescribeSecretWithContext(ctx, &secretInput)
  153. metrics.ObserveAPICall(metrics.ProviderAWSSM, metrics.CallAWSSMDescribeSecret, err)
  154. if err != nil {
  155. return err
  156. }
  157. if !isManagedByESO(data) {
  158. return nil
  159. }
  160. deleteInput := &awssm.DeleteSecretInput{
  161. SecretId: awsSecret.ARN,
  162. }
  163. _, err = sm.client.DeleteSecretWithContext(ctx, deleteInput)
  164. metrics.ObserveAPICall(metrics.ProviderAWSSM, metrics.CallAWSSMDeleteSecret, err)
  165. return err
  166. }
  167. func (sm *SecretsManager) PushSecret(ctx context.Context, value []byte, remoteRef esv1beta1.PushRemoteRef) error {
  168. secretName := remoteRef.GetRemoteKey()
  169. managedBy := managedBy
  170. externalSecrets := externalSecrets
  171. externalSecretsTag := []*awssm.Tag{
  172. {
  173. Key: &managedBy,
  174. Value: &externalSecrets,
  175. },
  176. }
  177. secretRequest := awssm.CreateSecretInput{
  178. Name: &secretName,
  179. SecretBinary: value,
  180. Tags: externalSecretsTag,
  181. }
  182. secretValue := awssm.GetSecretValueInput{
  183. SecretId: &secretName,
  184. }
  185. secretInput := awssm.DescribeSecretInput{
  186. SecretId: &secretName,
  187. }
  188. awsSecret, err := sm.client.GetSecretValueWithContext(ctx, &secretValue)
  189. metrics.ObserveAPICall(metrics.ProviderAWSSM, metrics.CallAWSSMGetSecretValue, err)
  190. var aerr awserr.Error
  191. if err != nil {
  192. if ok := errors.As(err, &aerr); !ok {
  193. return err
  194. }
  195. if aerr.Code() == awssm.ErrCodeResourceNotFoundException {
  196. _, err = sm.client.CreateSecretWithContext(ctx, &secretRequest)
  197. metrics.ObserveAPICall(metrics.ProviderAWSSM, metrics.CallAWSSMCreateSecret, err)
  198. return err
  199. }
  200. return err
  201. }
  202. data, err := sm.client.DescribeSecretWithContext(ctx, &secretInput)
  203. metrics.ObserveAPICall(metrics.ProviderAWSSM, metrics.CallAWSSMDescribeSecret, err)
  204. if err != nil {
  205. return err
  206. }
  207. if !isManagedByESO(data) {
  208. return fmt.Errorf("secret not managed by external-secrets")
  209. }
  210. if awsSecret != nil && bytes.Equal(awsSecret.SecretBinary, value) {
  211. return nil
  212. }
  213. input := &awssm.PutSecretValueInput{
  214. SecretId: awsSecret.ARN,
  215. SecretBinary: value,
  216. }
  217. _, err = sm.client.PutSecretValueWithContext(ctx, input)
  218. metrics.ObserveAPICall(metrics.ProviderAWSSM, metrics.CallAWSSMPutSecretValue, err)
  219. return err
  220. }
  221. func isManagedByESO(data *awssm.DescribeSecretOutput) bool {
  222. managedBy := managedBy
  223. externalSecrets := externalSecrets
  224. for _, tag := range data.Tags {
  225. if *tag.Key == managedBy && *tag.Value == externalSecrets {
  226. return true
  227. }
  228. }
  229. return false
  230. }
  231. // GetAllSecrets syncs multiple secrets from aws provider into a single Kubernetes Secret.
  232. func (sm *SecretsManager) GetAllSecrets(ctx context.Context, ref esv1beta1.ExternalSecretFind) (map[string][]byte, error) {
  233. if ref.Name != nil {
  234. return sm.findByName(ctx, ref)
  235. }
  236. if len(ref.Tags) > 0 {
  237. return sm.findByTags(ctx, ref)
  238. }
  239. return nil, errors.New(errUnexpectedFindOperator)
  240. }
  241. func (sm *SecretsManager) findByName(ctx context.Context, ref esv1beta1.ExternalSecretFind) (map[string][]byte, error) {
  242. matcher, err := find.New(*ref.Name)
  243. if err != nil {
  244. return nil, err
  245. }
  246. filters := make([]*awssm.Filter, 0)
  247. if ref.Path != nil {
  248. filters = append(filters, &awssm.Filter{
  249. Key: utilpointer.String(awssm.FilterNameStringTypeName),
  250. Values: []*string{
  251. ref.Path,
  252. },
  253. })
  254. }
  255. data := make(map[string][]byte)
  256. var nextToken *string
  257. for {
  258. it, err := sm.client.ListSecrets(&awssm.ListSecretsInput{
  259. Filters: filters,
  260. NextToken: nextToken,
  261. })
  262. metrics.ObserveAPICall(metrics.ProviderAWSSM, metrics.CallAWSSMListSecrets, err)
  263. if err != nil {
  264. return nil, err
  265. }
  266. log.V(1).Info("aws sm findByName found", "secrets", len(it.SecretList))
  267. for _, secret := range it.SecretList {
  268. if !matcher.MatchName(*secret.Name) {
  269. continue
  270. }
  271. log.V(1).Info("aws sm findByName matches", "name", *secret.Name)
  272. err = sm.fetchAndSet(ctx, data, *secret.Name)
  273. if err != nil {
  274. return nil, err
  275. }
  276. }
  277. nextToken = it.NextToken
  278. if nextToken == nil {
  279. break
  280. }
  281. }
  282. return data, nil
  283. }
  284. func (sm *SecretsManager) findByTags(ctx context.Context, ref esv1beta1.ExternalSecretFind) (map[string][]byte, error) {
  285. filters := make([]*awssm.Filter, 0)
  286. for k, v := range ref.Tags {
  287. filters = append(filters, &awssm.Filter{
  288. Key: utilpointer.String(awssm.FilterNameStringTypeTagKey),
  289. Values: []*string{
  290. utilpointer.String(k),
  291. },
  292. }, &awssm.Filter{
  293. Key: utilpointer.String(awssm.FilterNameStringTypeTagValue),
  294. Values: []*string{
  295. utilpointer.String(v),
  296. },
  297. })
  298. }
  299. if ref.Path != nil {
  300. filters = append(filters, &awssm.Filter{
  301. Key: utilpointer.String(awssm.FilterNameStringTypeName),
  302. Values: []*string{
  303. ref.Path,
  304. },
  305. })
  306. }
  307. data := make(map[string][]byte)
  308. var nextToken *string
  309. for {
  310. log.V(1).Info("aws sm findByTag", "nextToken", nextToken)
  311. it, err := sm.client.ListSecrets(&awssm.ListSecretsInput{
  312. Filters: filters,
  313. NextToken: nextToken,
  314. })
  315. metrics.ObserveAPICall(metrics.ProviderAWSSM, metrics.CallAWSSMListSecrets, err)
  316. if err != nil {
  317. return nil, err
  318. }
  319. log.V(1).Info("aws sm findByTag found", "secrets", len(it.SecretList))
  320. for _, secret := range it.SecretList {
  321. err = sm.fetchAndSet(ctx, data, *secret.Name)
  322. if err != nil {
  323. return nil, err
  324. }
  325. }
  326. nextToken = it.NextToken
  327. if nextToken == nil {
  328. break
  329. }
  330. }
  331. return data, nil
  332. }
  333. func (sm *SecretsManager) fetchAndSet(ctx context.Context, data map[string][]byte, name string) error {
  334. sec, err := sm.fetch(ctx, esv1beta1.ExternalSecretDataRemoteRef{
  335. Key: name,
  336. })
  337. if err != nil {
  338. return err
  339. }
  340. if sec.SecretString != nil {
  341. data[name] = []byte(*sec.SecretString)
  342. }
  343. if sec.SecretBinary != nil {
  344. data[name] = sec.SecretBinary
  345. }
  346. return nil
  347. }
  348. // GetSecret returns a single secret from the provider.
  349. func (sm *SecretsManager) GetSecret(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) ([]byte, error) {
  350. secretOut, err := sm.fetch(ctx, ref)
  351. if errors.Is(err, esv1beta1.NoSecretErr) {
  352. return nil, err
  353. }
  354. if err != nil {
  355. return nil, util.SanitizeErr(err)
  356. }
  357. if ref.Property == "" {
  358. if secretOut.SecretString != nil {
  359. return []byte(*secretOut.SecretString), nil
  360. }
  361. if secretOut.SecretBinary != nil {
  362. return secretOut.SecretBinary, nil
  363. }
  364. return nil, fmt.Errorf("invalid secret received. no secret string nor binary for key: %s", ref.Key)
  365. }
  366. var payload string
  367. if secretOut.SecretString != nil {
  368. payload = *secretOut.SecretString
  369. }
  370. if secretOut.SecretBinary != nil {
  371. payload = string(secretOut.SecretBinary)
  372. }
  373. // We need to search if a given key with a . exists before using gjson operations.
  374. idx := strings.Index(ref.Property, ".")
  375. if idx > -1 {
  376. refProperty := strings.ReplaceAll(ref.Property, ".", "\\.")
  377. val := gjson.Get(payload, refProperty)
  378. if val.Exists() {
  379. return []byte(val.String()), nil
  380. }
  381. }
  382. val := gjson.Get(payload, ref.Property)
  383. if !val.Exists() {
  384. return nil, fmt.Errorf("key %s does not exist in secret %s", ref.Property, ref.Key)
  385. }
  386. return []byte(val.String()), nil
  387. }
  388. // GetSecretMap returns multiple k/v pairs from the provider.
  389. func (sm *SecretsManager) GetSecretMap(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) (map[string][]byte, error) {
  390. log.Info("fetching secret map", "key", ref.Key)
  391. data, err := sm.GetSecret(ctx, ref)
  392. if err != nil {
  393. return nil, err
  394. }
  395. kv := make(map[string]json.RawMessage)
  396. err = json.Unmarshal(data, &kv)
  397. if err != nil {
  398. return nil, fmt.Errorf("unable to unmarshal secret %s: %w", ref.Key, err)
  399. }
  400. secretData := make(map[string][]byte)
  401. for k, v := range kv {
  402. var strVal string
  403. err = json.Unmarshal(v, &strVal)
  404. if err == nil {
  405. secretData[k] = []byte(strVal)
  406. } else {
  407. secretData[k] = v
  408. }
  409. }
  410. return secretData, nil
  411. }
  412. func (sm *SecretsManager) Close(ctx context.Context) error {
  413. return nil
  414. }
  415. func (sm *SecretsManager) Validate() (esv1beta1.ValidationResult, error) {
  416. // skip validation stack because it depends on the namespace
  417. // of the ExternalSecret
  418. if sm.referentAuth {
  419. return esv1beta1.ValidationResultUnknown, nil
  420. }
  421. _, err := sm.sess.Config.Credentials.Get()
  422. if err != nil {
  423. return esv1beta1.ValidationResultError, err
  424. }
  425. return esv1beta1.ValidationResultReady, nil
  426. }
  427. func (sm *SecretsManager) Capabilities() esv1beta1.SecretStoreCapabilities {
  428. return esv1beta1.SecretStoreReadWrite
  429. }