onepassword.go 25 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862
  1. /*
  2. Copyright © The ESO Authors
  3. Licensed under the Apache License, Version 2.0 (the "License");
  4. you may not use this file except in compliance with the License.
  5. You may obtain a copy of the License at
  6. https://www.apache.org/licenses/LICENSE-2.0
  7. Unless required by applicable law or agreed to in writing, software
  8. distributed under the License is distributed on an "AS IS" BASIS,
  9. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  10. See the License for the specific language governing permissions and
  11. limitations under the License.
  12. */
  13. // Package onepassword implements a 1Password provider for External Secrets.
  14. package onepassword
  15. import (
  16. "context"
  17. "errors"
  18. "fmt"
  19. "net/url"
  20. "regexp"
  21. "slices"
  22. "sort"
  23. "strings"
  24. "sync"
  25. "time"
  26. "github.com/1Password/connect-sdk-go/connect"
  27. "github.com/1Password/connect-sdk-go/onepassword"
  28. corev1 "k8s.io/api/core/v1"
  29. kclient "sigs.k8s.io/controller-runtime/pkg/client"
  30. "sigs.k8s.io/controller-runtime/pkg/webhook/admission"
  31. esv1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1"
  32. "github.com/external-secrets/external-secrets/runtime/esutils"
  33. "github.com/external-secrets/external-secrets/runtime/esutils/metadata"
  34. "github.com/external-secrets/external-secrets/runtime/esutils/resolvers"
  35. "github.com/external-secrets/external-secrets/runtime/find"
  36. )
  37. const (
  38. userAgent = "external-secrets"
  39. errOnePasswordStore = "received invalid 1Password SecretStore resource: %w"
  40. errOnePasswordStoreNilSpec = "nil spec"
  41. errOnePasswordStoreNilSpecProvider = "nil spec.provider"
  42. errOnePasswordStoreNilSpecProviderOnePassword = "nil spec.provider.onepassword"
  43. errOnePasswordStoreMissingRefName = "missing: spec.provider.onepassword.auth.secretRef.connectTokenSecretRef.name"
  44. errOnePasswordStoreMissingRefKey = "missing: spec.provider.onepassword.auth.secretRef.connectTokenSecretRef.key"
  45. errOnePasswordStoreAtLeastOneVault = "must be at least one vault: spec.provider.onepassword.vaults"
  46. errOnePasswordStoreInvalidConnectHost = "unable to parse URL: spec.provider.onepassword.connectHost: %w"
  47. errOnePasswordStoreNonUniqueVaultNumbers = "vault order numbers must be unique"
  48. errGetVault = "error finding 1Password Vault: %w"
  49. errGetItem = "error finding 1Password Item: %w"
  50. errUpdateItem = "error updating 1Password Item: %w"
  51. errDocumentNotFound = "error finding 1Password Document: %w"
  52. errTagsNotImplemented = "'find.tags' is not implemented in the 1Password provider"
  53. errVersionNotImplemented = "'remoteRef.version' is not implemented in the 1Password provider"
  54. errCreateItem = "error creating 1Password Item: %w"
  55. errDeleteItem = "error deleting 1Password Item: %w"
  56. // custom error messages.
  57. errKeyNotFoundMsg = "key not found in 1Password Vaults"
  58. errNoVaultsMsg = "no vaults found"
  59. errMetadataVaultNotinProvider = "metadata vault '%s' not in provider vaults"
  60. errExpectedOneItemMsg = "expected one 1Password Item matching"
  61. errExpectedOneFieldMsg = "expected one 1Password ItemField matching"
  62. errExpectedOneFieldMsgF = "%w: '%s' in '%s', got %d"
  63. documentCategory = "DOCUMENT"
  64. fieldPrefix = "field"
  65. filePrefix = "file"
  66. prefixSplitter = "/"
  67. )
  68. // Custom Errors //.
  69. var (
  70. // ErrKeyNotFound is returned when a key is not found in the 1Password Vaults.
  71. ErrKeyNotFound = errors.New(errKeyNotFoundMsg)
  72. // ErrNoVaults is returned when no vaults are found in the 1Password provider.
  73. ErrNoVaults = errors.New(errNoVaultsMsg)
  74. // ErrExpectedOneField is returned when more than 1 field is found in the 1Password Vaults.
  75. ErrExpectedOneField = errors.New(errExpectedOneFieldMsg)
  76. // ErrExpectedOneItem is returned when more than 1 item is found in the 1Password Vaults.
  77. ErrExpectedOneItem = errors.New(errExpectedOneItemMsg)
  78. )
  79. // ProviderOnePassword is a provider for 1Password.
  80. type ProviderOnePassword struct {
  81. vaults map[string]int
  82. client connect.Client
  83. mu sync.Mutex
  84. }
  85. // PushSecretMetadataSpec defines metadata for pushing secrets to 1Password.
  86. type PushSecretMetadataSpec struct {
  87. Tags []string `json:"tags,omitempty"`
  88. Vault string `json:"vault,omitempty"`
  89. }
  90. // https://github.com/external-secrets/external-secrets/issues/644
  91. var (
  92. _ esv1.SecretsClient = &ProviderOnePassword{}
  93. _ esv1.Provider = &ProviderOnePassword{}
  94. )
  95. // Capabilities return the provider supported capabilities (ReadOnly, WriteOnly, ReadWrite).
  96. func (provider *ProviderOnePassword) Capabilities() esv1.SecretStoreCapabilities {
  97. return esv1.SecretStoreReadWrite
  98. }
  99. // NewClient constructs a 1Password Provider.
  100. func (provider *ProviderOnePassword) NewClient(ctx context.Context, store esv1.GenericStore, kube kclient.Client, namespace string) (esv1.SecretsClient, error) {
  101. config := store.GetSpec().Provider.OnePassword
  102. token, err := resolvers.SecretKeyRef(
  103. ctx,
  104. kube,
  105. store.GetKind(),
  106. namespace,
  107. &config.Auth.SecretRef.ConnectToken,
  108. )
  109. if err != nil {
  110. return nil, err
  111. }
  112. return &ProviderOnePassword{
  113. client: newRetryClient(connect.NewClientWithUserAgent(config.ConnectHost, token, userAgent)),
  114. vaults: config.Vaults,
  115. }, nil
  116. }
  117. // ValidateStore checks if the provided store is valid.
  118. func (provider *ProviderOnePassword) ValidateStore(store esv1.GenericStore) (admission.Warnings, error) {
  119. return nil, validateStore(store)
  120. }
  121. func validateStore(store esv1.GenericStore) error {
  122. // check nils
  123. storeSpec := store.GetSpec()
  124. if storeSpec == nil {
  125. return fmt.Errorf(errOnePasswordStore, errors.New(errOnePasswordStoreNilSpec))
  126. }
  127. if storeSpec.Provider == nil {
  128. return fmt.Errorf(errOnePasswordStore, errors.New(errOnePasswordStoreNilSpecProvider))
  129. }
  130. if storeSpec.Provider.OnePassword == nil {
  131. return fmt.Errorf(errOnePasswordStore, errors.New(errOnePasswordStoreNilSpecProviderOnePassword))
  132. }
  133. // check mandatory fields
  134. config := storeSpec.Provider.OnePassword
  135. if config.Auth.SecretRef.ConnectToken.Name == "" {
  136. return fmt.Errorf(errOnePasswordStore, errors.New(errOnePasswordStoreMissingRefName))
  137. }
  138. if config.Auth.SecretRef.ConnectToken.Key == "" {
  139. return fmt.Errorf(errOnePasswordStore, errors.New(errOnePasswordStoreMissingRefKey))
  140. }
  141. // check namespace compared to kind
  142. if err := esutils.ValidateSecretSelector(store, config.Auth.SecretRef.ConnectToken); err != nil {
  143. return fmt.Errorf(errOnePasswordStore, err)
  144. }
  145. // check at least one vault
  146. if len(config.Vaults) == 0 {
  147. return fmt.Errorf(errOnePasswordStore, errors.New(errOnePasswordStoreAtLeastOneVault))
  148. }
  149. // ensure vault numbers are unique
  150. if !hasUniqueVaultNumbers(config.Vaults) {
  151. return fmt.Errorf(errOnePasswordStore, errors.New(errOnePasswordStoreNonUniqueVaultNumbers))
  152. }
  153. // check valid URL
  154. if _, err := url.Parse(config.ConnectHost); err != nil {
  155. return fmt.Errorf(errOnePasswordStore, fmt.Errorf(errOnePasswordStoreInvalidConnectHost, err))
  156. }
  157. return nil
  158. }
  159. func deleteField(fields []*onepassword.ItemField, label string) ([]*onepassword.ItemField, error) {
  160. // This will always iterate over all items
  161. // but its done to ensure that two fields with the same label
  162. // exist resulting in undefined behavior
  163. var (
  164. found bool
  165. fieldsF = make([]*onepassword.ItemField, 0, len(fields))
  166. )
  167. for _, item := range fields {
  168. if item.Label == label {
  169. if found {
  170. return nil, ErrExpectedOneField
  171. }
  172. found = true
  173. continue
  174. }
  175. fieldsF = append(fieldsF, item)
  176. }
  177. return fieldsF, nil
  178. }
  179. // DeleteSecret removes a secret from 1Password.
  180. func (provider *ProviderOnePassword) DeleteSecret(_ context.Context, ref esv1.PushSecretRemoteRef) error {
  181. provider.mu.Lock()
  182. defer provider.mu.Unlock()
  183. providerItem, err := provider.findItem(ref.GetRemoteKey())
  184. if err != nil {
  185. if errors.Is(err, ErrKeyNotFound) {
  186. return nil
  187. }
  188. return err
  189. }
  190. providerItem.Fields, err = deleteField(providerItem.Fields, ref.GetProperty())
  191. if err != nil {
  192. return fmt.Errorf(errUpdateItem, err)
  193. }
  194. if len(providerItem.Sections) == 1 && providerItem.Sections[0].ID == "" && providerItem.Sections[0].Label == "" {
  195. providerItem.Sections = nil
  196. }
  197. if len(providerItem.Fields) == 0 && len(providerItem.Files) == 0 && len(providerItem.Sections) == 0 {
  198. // Delete the item if there are no fields, files or sections
  199. if err = provider.client.DeleteItem(providerItem, providerItem.Vault.ID); err != nil {
  200. return fmt.Errorf(errDeleteItem, err)
  201. }
  202. return nil
  203. }
  204. if _, err = provider.client.UpdateItem(providerItem, providerItem.Vault.ID); err != nil {
  205. return fmt.Errorf(errDeleteItem, err)
  206. }
  207. return nil
  208. }
  209. // SecretExists checks if a secret exists in 1Password.
  210. func (provider *ProviderOnePassword) SecretExists(_ context.Context, ref esv1.PushSecretRemoteRef) (bool, error) {
  211. provider.mu.Lock()
  212. defer provider.mu.Unlock()
  213. item, err := provider.findItem(ref.GetRemoteKey())
  214. if errors.Is(err, ErrKeyNotFound) {
  215. return false, nil
  216. }
  217. if err != nil {
  218. return false, err
  219. }
  220. property := ref.GetProperty()
  221. if property == "" {
  222. return true, nil
  223. }
  224. for _, field := range item.Fields {
  225. if field.Label == property {
  226. return true, nil
  227. }
  228. }
  229. return false, nil
  230. }
  231. const (
  232. passwordLabel = "password"
  233. )
  234. // createItem creates a new item in the first vault. If no vaults exist, it returns an error.
  235. func (provider *ProviderOnePassword) createItem(val []byte, ref esv1.PushSecretData) error {
  236. // Get the metadata
  237. metadata, err := metadata.ParseMetadataParameters[PushSecretMetadataSpec](ref.GetMetadata())
  238. if err != nil {
  239. return fmt.Errorf("failed to parse push secret metadata: %w", err)
  240. }
  241. // Check if there is a vault is specified in the metadata
  242. vaultID := ""
  243. if metadata != nil && metadata.Spec.Vault != "" {
  244. // check if metadata.Spec.Vault is in provider.vaults
  245. if _, ok := provider.vaults[metadata.Spec.Vault]; !ok {
  246. return fmt.Errorf(errMetadataVaultNotinProvider, metadata.Spec.Vault)
  247. }
  248. vaultID = metadata.Spec.Vault
  249. } else {
  250. // Get the first vault from the provider
  251. sortedVaults := sortVaults(provider.vaults)
  252. if len(sortedVaults) == 0 {
  253. return ErrNoVaults
  254. }
  255. vaultID = sortedVaults[0]
  256. }
  257. // Get the label
  258. label := ref.GetProperty()
  259. if label == "" {
  260. label = passwordLabel
  261. }
  262. var tags []string
  263. if metadata != nil && metadata.Spec.Tags != nil {
  264. tags = metadata.Spec.Tags
  265. }
  266. // Create the item
  267. item := &onepassword.Item{
  268. Title: ref.GetRemoteKey(),
  269. Category: onepassword.Server,
  270. Vault: onepassword.ItemVault{
  271. ID: vaultID,
  272. },
  273. Fields: []*onepassword.ItemField{
  274. generateNewItemField(label, string(val)),
  275. },
  276. Tags: tags,
  277. }
  278. _, err = provider.client.CreateItem(item, vaultID)
  279. return err
  280. }
  281. // updateFieldValue updates the fields value of an item with the given label.
  282. // If the label does not exist, a new field is created. If the label exists but
  283. // the value is different, the value is updated. If the label exists and the
  284. // value is the same, nothing is done.
  285. func updateFieldValue(fields []*onepassword.ItemField, label, newVal string) ([]*onepassword.ItemField, error) {
  286. // This will always iterate over all items.
  287. // This is done to ensure that two fields with the same label
  288. // exist resulting in undefined behavior.
  289. var (
  290. found bool
  291. index int
  292. )
  293. for i, item := range fields {
  294. if item.Label == label {
  295. if found {
  296. return nil, ErrExpectedOneField
  297. }
  298. found = true
  299. index = i
  300. }
  301. }
  302. if !found {
  303. return append(fields, generateNewItemField(label, newVal)), nil
  304. }
  305. if fields[index].Value != newVal {
  306. fields[index].Value = newVal
  307. }
  308. return fields, nil
  309. }
  310. // generateNewItemField generates a new item field with the given label and value.
  311. func generateNewItemField(label, newVal string) *onepassword.ItemField {
  312. field := &onepassword.ItemField{
  313. Label: label,
  314. Value: newVal,
  315. Type: onepassword.FieldTypeConcealed,
  316. }
  317. return field
  318. }
  319. // PushSecret creates or updates a secret in 1Password.
  320. func (provider *ProviderOnePassword) PushSecret(ctx context.Context, secret *corev1.Secret, ref esv1.PushSecretData) error {
  321. provider.mu.Lock()
  322. defer provider.mu.Unlock()
  323. val, ok := secret.Data[ref.GetSecretKey()]
  324. if !ok {
  325. return ErrKeyNotFound
  326. }
  327. title := ref.GetRemoteKey()
  328. providerItem, err := provider.findItem(title)
  329. if errors.Is(err, ErrKeyNotFound) {
  330. if err = provider.createItem(val, ref); err != nil {
  331. return fmt.Errorf(errCreateItem, err)
  332. }
  333. err = provider.waitForFunc(ctx, provider.waitForItemToExist(title))
  334. return err
  335. } else if err != nil {
  336. return err
  337. }
  338. label := ref.GetProperty()
  339. if label == "" {
  340. label = passwordLabel
  341. }
  342. metadata, err := metadata.ParseMetadataParameters[PushSecretMetadataSpec](ref.GetMetadata())
  343. if err != nil {
  344. return fmt.Errorf("failed to parse push secret metadata: %w", err)
  345. }
  346. if metadata != nil && metadata.Spec.Tags != nil {
  347. providerItem.Tags = metadata.Spec.Tags
  348. }
  349. providerItem.Fields, err = updateFieldValue(providerItem.Fields, label, string(val))
  350. if err != nil {
  351. return fmt.Errorf(errUpdateItem, err)
  352. }
  353. if _, err = provider.client.UpdateItem(providerItem, providerItem.Vault.ID); err != nil {
  354. return fmt.Errorf(errUpdateItem, err)
  355. }
  356. if err := provider.waitForFunc(ctx, provider.waitForLabelToBeUpdated(title, label, val)); err != nil {
  357. return fmt.Errorf("failed waiting for label update: %w", err)
  358. }
  359. return nil
  360. }
  361. // Clean property string by removing property prefix if needed.
  362. func getObjType(documentType onepassword.ItemCategory, property string) (string, string) {
  363. if strings.HasPrefix(property, fieldPrefix+prefixSplitter) {
  364. return fieldPrefix, property[6:]
  365. }
  366. if strings.HasPrefix(property, filePrefix+prefixSplitter) {
  367. return filePrefix, property[5:]
  368. }
  369. if documentType == documentCategory {
  370. return filePrefix, property
  371. }
  372. return fieldPrefix, property
  373. }
  374. // GetSecret returns a single secret from the provider.
  375. func (provider *ProviderOnePassword) GetSecret(_ context.Context, ref esv1.ExternalSecretDataRemoteRef) ([]byte, error) {
  376. provider.mu.Lock()
  377. defer provider.mu.Unlock()
  378. if ref.Version != "" {
  379. return nil, errors.New(errVersionNotImplemented)
  380. }
  381. item, err := provider.findItem(ref.Key)
  382. if err != nil {
  383. return nil, err
  384. }
  385. propertyType, property := getObjType(item.Category, ref.Property)
  386. if propertyType == filePrefix {
  387. return provider.getFile(item, property)
  388. }
  389. return provider.getField(item, property)
  390. }
  391. // Validate checks if the client is configured correctly
  392. // to be able to retrieve secrets from the provider.
  393. func (provider *ProviderOnePassword) Validate() (esv1.ValidationResult, error) {
  394. provider.mu.Lock()
  395. defer provider.mu.Unlock()
  396. for vaultName := range provider.vaults {
  397. _, err := provider.client.GetVault(vaultName)
  398. if err != nil {
  399. return esv1.ValidationResultError, err
  400. }
  401. }
  402. return esv1.ValidationResultReady, nil
  403. }
  404. // GetSecretMap returns multiple k/v pairs from the provider, for dataFrom.extract.
  405. func (provider *ProviderOnePassword) GetSecretMap(_ context.Context, ref esv1.ExternalSecretDataRemoteRef) (map[string][]byte, error) {
  406. provider.mu.Lock()
  407. defer provider.mu.Unlock()
  408. if ref.Version != "" {
  409. return nil, errors.New(errVersionNotImplemented)
  410. }
  411. item, err := provider.findItem(ref.Key)
  412. if err != nil {
  413. return nil, err
  414. }
  415. propertyType, property := getObjType(item.Category, ref.Property)
  416. if propertyType == filePrefix {
  417. return provider.getFiles(item, property)
  418. }
  419. return provider.getFields(item, property)
  420. }
  421. // GetAllSecrets syncs multiple 1Password Items into a single Kubernetes Secret, for dataFrom.find.
  422. func (provider *ProviderOnePassword) GetAllSecrets(_ context.Context, ref esv1.ExternalSecretFind) (map[string][]byte, error) {
  423. provider.mu.Lock()
  424. defer provider.mu.Unlock()
  425. secretData := make(map[string][]byte)
  426. sortedVaults := sortVaults(provider.vaults)
  427. for _, vaultName := range sortedVaults {
  428. vault, err := provider.client.GetVault(vaultName)
  429. if err != nil {
  430. return nil, fmt.Errorf(errGetVault, err)
  431. }
  432. if ref.Tags != nil {
  433. err = provider.getAllByTags(vault.ID, ref, secretData)
  434. if err != nil {
  435. return nil, err
  436. }
  437. return secretData, nil
  438. }
  439. err = provider.getAllForVault(vault.ID, ref, secretData)
  440. if err != nil {
  441. return nil, err
  442. }
  443. }
  444. return secretData, nil
  445. }
  446. // Close closes the client connection.
  447. func (provider *ProviderOnePassword) Close(_ context.Context) error {
  448. provider.mu.Lock()
  449. defer provider.mu.Unlock()
  450. return nil
  451. }
  452. // nativeItemIDPattern matches a 1Password item ID per the Connect
  453. // server OpenAPI spec (^[\da-z]{26}$). Despite being called "UUIDs"
  454. // in 1Password's SDK and docs, they are not RFC 4122 UUIDs.
  455. // https://github.com/1Password/connect/blob/7485a59/docs/openapi/spec.yaml#L73-L75
  456. var nativeItemIDPattern = regexp.MustCompile(`^[\da-z]{26}$`)
  457. func isNativeItemID(s string) bool {
  458. return nativeItemIDPattern.MatchString(s)
  459. }
  460. func (provider *ProviderOnePassword) findItem(name string) (*onepassword.Item, error) {
  461. sortedVaults := sortVaults(provider.vaults)
  462. for _, vaultName := range sortedVaults {
  463. vault, err := provider.client.GetVault(vaultName)
  464. if err != nil {
  465. return nil, fmt.Errorf(errGetVault, err)
  466. }
  467. if isNativeItemID(name) {
  468. return provider.client.GetItem(name, vault.ID)
  469. }
  470. items, err := provider.client.GetItemsByTitle(name, vault.ID)
  471. if err != nil {
  472. return nil, fmt.Errorf(errGetItem, err)
  473. }
  474. switch {
  475. case len(items) == 1:
  476. return provider.client.GetItemByUUID(items[0].ID, items[0].Vault.ID)
  477. case len(items) > 1:
  478. return nil, fmt.Errorf("%w: '%s', got %d", ErrExpectedOneItem, name, len(items))
  479. }
  480. }
  481. return nil, fmt.Errorf("%w: %s in: %v", ErrKeyNotFound, name, provider.vaults)
  482. }
  483. func (provider *ProviderOnePassword) getField(item *onepassword.Item, property string) ([]byte, error) {
  484. // default to a field labeled "password"
  485. fieldLabel := "password"
  486. if property != "" {
  487. fieldLabel = property
  488. }
  489. if length := countFieldsWithLabel(fieldLabel, item.Fields); length != 1 {
  490. return nil, fmt.Errorf("%w: '%s' in '%s', got %d", ErrExpectedOneField, fieldLabel, item.Title, length)
  491. }
  492. // caution: do not use client.GetValue here because it has undesirable behavior on keys with a dot in them
  493. value := ""
  494. for _, field := range item.Fields {
  495. if field.Label == fieldLabel {
  496. value = field.Value
  497. break
  498. }
  499. }
  500. return []byte(value), nil
  501. }
  502. func (provider *ProviderOnePassword) getFields(item *onepassword.Item, property string) (map[string][]byte, error) {
  503. secretData := make(map[string][]byte)
  504. for _, field := range item.Fields {
  505. if property != "" && field.Label != property {
  506. continue
  507. }
  508. if length := countFieldsWithLabel(field.Label, item.Fields); length != 1 {
  509. return nil, fmt.Errorf(errExpectedOneFieldMsgF, ErrExpectedOneField, field.Label, item.Title, length)
  510. }
  511. // caution: do not use client.GetValue here because it has undesirable behavior on keys with a dot in them
  512. secretData[field.Label] = []byte(field.Value)
  513. }
  514. return secretData, nil
  515. }
  516. func (provider *ProviderOnePassword) getAllFields(item onepassword.Item, ref esv1.ExternalSecretFind, secretData map[string][]byte) error {
  517. i, err := provider.client.GetItemByUUID(item.ID, item.Vault.ID)
  518. if err != nil {
  519. return fmt.Errorf(errGetItem, err)
  520. }
  521. item = *i
  522. for _, field := range item.Fields {
  523. if length := countFieldsWithLabel(field.Label, item.Fields); length != 1 {
  524. return fmt.Errorf(errExpectedOneFieldMsgF, ErrExpectedOneField, field.Label, item.Title, length)
  525. }
  526. if ref.Name != nil {
  527. matcher, err := find.New(*ref.Name)
  528. if err != nil {
  529. return err
  530. }
  531. if !matcher.MatchName(field.Label) {
  532. continue
  533. }
  534. }
  535. if _, ok := secretData[field.Label]; !ok {
  536. secretData[field.Label] = []byte(field.Value)
  537. }
  538. }
  539. return nil
  540. }
  541. func (provider *ProviderOnePassword) getFile(item *onepassword.Item, property string) ([]byte, error) {
  542. for _, file := range item.Files {
  543. // default to the first file when ref.Property is empty
  544. if file.Name == property || property == "" {
  545. contents, err := provider.client.GetFileContent(file)
  546. if err != nil {
  547. return nil, err
  548. }
  549. return contents, nil
  550. }
  551. }
  552. return nil, fmt.Errorf(errDocumentNotFound, fmt.Errorf("'%s', '%s'", item.Title, property))
  553. }
  554. func (provider *ProviderOnePassword) getFiles(item *onepassword.Item, property string) (map[string][]byte, error) {
  555. secretData := make(map[string][]byte)
  556. for _, file := range item.Files {
  557. if property != "" && file.Name != property {
  558. continue
  559. }
  560. contents, err := provider.client.GetFileContent(file)
  561. if err != nil {
  562. return nil, err
  563. }
  564. secretData[file.Name] = contents
  565. }
  566. return secretData, nil
  567. }
  568. func (provider *ProviderOnePassword) getAllFiles(item onepassword.Item, ref esv1.ExternalSecretFind, secretData map[string][]byte) error {
  569. for _, file := range item.Files {
  570. if ref.Name != nil {
  571. matcher, err := find.New(*ref.Name)
  572. if err != nil {
  573. return err
  574. }
  575. if !matcher.MatchName(file.Name) {
  576. continue
  577. }
  578. }
  579. if _, ok := secretData[file.Name]; !ok {
  580. contents, err := provider.client.GetFileContent(file)
  581. if err != nil {
  582. return err
  583. }
  584. secretData[file.Name] = contents
  585. }
  586. }
  587. return nil
  588. }
  589. func (provider *ProviderOnePassword) getAllByTags(vaultID string, ref esv1.ExternalSecretFind, secretData map[string][]byte) error {
  590. items, err := provider.client.GetItems(vaultID)
  591. if err != nil {
  592. return fmt.Errorf(errGetItem, err)
  593. }
  594. for _, item := range items {
  595. if !checkTags(ref.Tags, item.Tags) {
  596. continue
  597. }
  598. // handle files
  599. err = provider.getAllFiles(item, ref, secretData)
  600. if err != nil {
  601. return err
  602. }
  603. // handle fields
  604. err = provider.getAllFields(item, ref, secretData)
  605. if err != nil {
  606. return err
  607. }
  608. }
  609. return nil
  610. }
  611. // checkTags verifies that all elements in source are present in target.
  612. func checkTags(source map[string]string, target []string) bool {
  613. for s := range source {
  614. if !slices.Contains(target, s) {
  615. return false
  616. }
  617. }
  618. return true
  619. }
  620. func (provider *ProviderOnePassword) getAllForVault(vaultID string, ref esv1.ExternalSecretFind, secretData map[string][]byte) error {
  621. items, err := provider.client.GetItems(vaultID)
  622. if err != nil {
  623. return fmt.Errorf(errGetItem, err)
  624. }
  625. for _, item := range items {
  626. if ref.Path != nil && *ref.Path != item.Title {
  627. continue
  628. }
  629. // handle files
  630. err = provider.getAllFiles(item, ref, secretData)
  631. if err != nil {
  632. return err
  633. }
  634. // handle fields
  635. err = provider.getAllFields(item, ref, secretData)
  636. if err != nil {
  637. return err
  638. }
  639. }
  640. return nil
  641. }
  642. // waitForFunc will wait for OnePassword to _actually_ create/update the secret. OnePassword returns immediately after
  643. // the initial create/update which makes the next call for the same item create/update a new item with the same name. Hence, we'll
  644. // wait for the item to exist or be updated on OnePassword's side as well.
  645. // Ideally we could do bulk operations and handle data with one submit, but that would require re-writing the entire
  646. // push secret controller. For now, this is sufficient.
  647. func (provider *ProviderOnePassword) waitForFunc(ctx context.Context, fn func() error) error {
  648. // check every .5 seconds
  649. tick := time.NewTicker(500 * time.Millisecond)
  650. defer tick.Stop()
  651. done, cancel := context.WithTimeout(ctx, 5*time.Second)
  652. defer cancel()
  653. var err error
  654. for {
  655. select {
  656. case <-tick.C:
  657. if err = fn(); err == nil {
  658. return nil
  659. }
  660. case <-done.Done():
  661. return fmt.Errorf("timeout to wait for function to run successfully; last error was: %w", err)
  662. }
  663. }
  664. }
  665. func (provider *ProviderOnePassword) waitForItemToExist(title string) func() error {
  666. return func() error {
  667. _, err := provider.findItem(title)
  668. return err
  669. }
  670. }
  671. func (provider *ProviderOnePassword) waitForLabelToBeUpdated(title, label string, val []byte) func() error {
  672. return func() error {
  673. item, err := provider.findItem(title)
  674. if err != nil {
  675. return err
  676. }
  677. for _, field := range item.Fields {
  678. // we found the label with the right value
  679. if field.Label == label && field.Value == string(val) {
  680. return nil
  681. }
  682. }
  683. return fmt.Errorf("label %s no found on value with title %s", title, label)
  684. }
  685. }
  686. func countFieldsWithLabel(fieldLabel string, fields []*onepassword.ItemField) int {
  687. count := 0
  688. for _, field := range fields {
  689. if field.Label == fieldLabel {
  690. count++
  691. }
  692. }
  693. return count
  694. }
  695. type orderedVault struct {
  696. Name string
  697. Order int
  698. }
  699. type orderedVaultList []orderedVault
  700. func (list orderedVaultList) Len() int { return len(list) }
  701. func (list orderedVaultList) Swap(i, j int) { list[i], list[j] = list[j], list[i] }
  702. func (list orderedVaultList) Less(i, j int) bool { return list[i].Order < list[j].Order }
  703. func sortVaults(vaults map[string]int) []string {
  704. list := make(orderedVaultList, len(vaults))
  705. index := 0
  706. for key, value := range vaults {
  707. list[index] = orderedVault{key, value}
  708. index++
  709. }
  710. sort.Sort(list)
  711. sortedVaults := make([]string, 0, len(list))
  712. for _, item := range list {
  713. sortedVaults = append(sortedVaults, item.Name)
  714. }
  715. return sortedVaults
  716. }
  717. func hasUniqueVaultNumbers(vaults map[string]int) bool {
  718. unique := make([]int, 0, len(vaults))
  719. tracker := make(map[int]bool)
  720. for _, number := range vaults {
  721. if _, ok := tracker[number]; !ok {
  722. tracker[number] = true
  723. unique = append(unique, number)
  724. }
  725. }
  726. return len(vaults) == len(unique)
  727. }
  728. // NewProvider creates a new Provider instance.
  729. func NewProvider() esv1.Provider {
  730. return &ProviderOnePassword{}
  731. }
  732. // ProviderSpec returns the provider specification for registration.
  733. func ProviderSpec() *esv1.SecretStoreProvider {
  734. return &esv1.SecretStoreProvider{
  735. OnePassword: &esv1.OnePasswordProvider{},
  736. }
  737. }
  738. // MaintenanceStatus returns the maintenance status of the provider.
  739. func MaintenanceStatus() esv1.MaintenanceStatus {
  740. return esv1.MaintenanceStatusMaintained
  741. }