secretsmanager.go 24 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761
  1. /*
  2. Licensed under the Apache License, Version 2.0 (the "License");
  3. you may not use this file except in compliance with the License.
  4. You may obtain a copy of the License at
  5. http://www.apache.org/licenses/LICENSE-2.0
  6. Unless required by applicable law or agreed to in writing, software
  7. distributed under the License is distributed on an "AS IS" BASIS,
  8. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  9. See the License for the specific language governing permissions and
  10. limitations under the License.
  11. */
  12. package secretsmanager
  13. import (
  14. "bytes"
  15. "context"
  16. "encoding/json"
  17. "errors"
  18. "fmt"
  19. "slices"
  20. "strings"
  21. "github.com/aws/aws-sdk-go-v2/aws"
  22. awssm "github.com/aws/aws-sdk-go-v2/service/secretsmanager"
  23. "github.com/aws/aws-sdk-go-v2/service/secretsmanager/types"
  24. "github.com/aws/smithy-go"
  25. "github.com/google/uuid"
  26. "github.com/tidwall/gjson"
  27. "github.com/tidwall/sjson"
  28. corev1 "k8s.io/api/core/v1"
  29. apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
  30. utilpointer "k8s.io/utils/ptr"
  31. ctrl "sigs.k8s.io/controller-runtime"
  32. esv1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1"
  33. "github.com/external-secrets/external-secrets/pkg/constants"
  34. "github.com/external-secrets/external-secrets/pkg/find"
  35. "github.com/external-secrets/external-secrets/pkg/metrics"
  36. "github.com/external-secrets/external-secrets/pkg/provider/aws/util"
  37. "github.com/external-secrets/external-secrets/pkg/utils"
  38. "github.com/external-secrets/external-secrets/pkg/utils/metadata"
  39. )
  40. type PushSecretMetadataSpec struct {
  41. Tags map[string]string `json:"tags,omitempty"`
  42. Description string `json:"description,omitempty"`
  43. SecretPushFormat string `json:"secretPushFormat,omitempty"`
  44. KMSKeyID string `json:"kmsKeyId,omitempty"`
  45. }
  46. // Declares metadata information for pushing secrets to AWS Secret Store.
  47. const (
  48. SecretPushFormatKey = "secretPushFormat"
  49. SecretPushFormatString = "string"
  50. SecretPushFormatBinary = "binary"
  51. ResourceNotFoundException = "ResourceNotFoundException"
  52. )
  53. // https://github.com/external-secrets/external-secrets/issues/644
  54. var _ esv1.SecretsClient = &SecretsManager{}
  55. // SecretsManager is a provider for AWS SecretsManager.
  56. type SecretsManager struct {
  57. cfg *aws.Config
  58. client SMInterface // Keep the interface
  59. referentAuth bool
  60. cache map[string]*awssm.GetSecretValueOutput
  61. config *esv1.SecretsManager
  62. prefix string
  63. newUUID func() string
  64. }
  65. // SMInterface is a subset of the smiface api.
  66. // see: https://docs.aws.amazon.com/sdk-for-go/api/service/secretsmanager/secretsmanageriface/
  67. type SMInterface interface {
  68. BatchGetSecretValue(ctx context.Context, params *awssm.BatchGetSecretValueInput, optFuncs ...func(*awssm.Options)) (*awssm.BatchGetSecretValueOutput, error)
  69. ListSecrets(ctx context.Context, params *awssm.ListSecretsInput, optFuncs ...func(*awssm.Options)) (*awssm.ListSecretsOutput, error)
  70. GetSecretValue(ctx context.Context, params *awssm.GetSecretValueInput, optFuncs ...func(*awssm.Options)) (*awssm.GetSecretValueOutput, error)
  71. CreateSecret(ctx context.Context, params *awssm.CreateSecretInput, optFuncs ...func(*awssm.Options)) (*awssm.CreateSecretOutput, error)
  72. PutSecretValue(ctx context.Context, params *awssm.PutSecretValueInput, optFuncs ...func(*awssm.Options)) (*awssm.PutSecretValueOutput, error)
  73. DescribeSecret(ctx context.Context, params *awssm.DescribeSecretInput, optFuncs ...func(*awssm.Options)) (*awssm.DescribeSecretOutput, error)
  74. DeleteSecret(ctx context.Context, params *awssm.DeleteSecretInput, optFuncs ...func(*awssm.Options)) (*awssm.DeleteSecretOutput, error)
  75. TagResource(ctx context.Context, params *awssm.TagResourceInput, optFuncs ...func(*awssm.Options)) (*awssm.TagResourceOutput, error)
  76. UntagResource(ctx context.Context, params *awssm.UntagResourceInput, optFuncs ...func(*awssm.Options)) (*awssm.UntagResourceOutput, error)
  77. }
  78. const (
  79. errUnexpectedFindOperator = "unexpected find operator"
  80. managedBy = "managed-by"
  81. externalSecrets = "external-secrets"
  82. initialVersion = "00000000-0000-0000-0000-000000000001"
  83. )
  84. var log = ctrl.Log.WithName("provider").WithName("aws").WithName("secretsmanager")
  85. // New creates a new SecretsManager client.
  86. func New(_ context.Context, cfg *aws.Config, secretsManagerCfg *esv1.SecretsManager, prefix string, referentAuth bool) (*SecretsManager, error) {
  87. return &SecretsManager{
  88. cfg: cfg,
  89. client: awssm.NewFromConfig(*cfg, func(o *awssm.Options) {
  90. o.EndpointResolverV2 = customEndpointResolver{}
  91. }),
  92. referentAuth: referentAuth,
  93. cache: make(map[string]*awssm.GetSecretValueOutput),
  94. config: secretsManagerCfg,
  95. prefix: prefix,
  96. }, nil
  97. }
  98. func (sm *SecretsManager) fetch(ctx context.Context, ref esv1.ExternalSecretDataRemoteRef) (*awssm.GetSecretValueOutput, error) {
  99. ver := "AWSCURRENT"
  100. valueFrom := "SECRET"
  101. if ref.Version != "" {
  102. ver = ref.Version
  103. }
  104. if ref.MetadataPolicy == esv1.ExternalSecretMetadataPolicyFetch {
  105. valueFrom = "TAG"
  106. }
  107. key := sm.prefix + ref.Key
  108. log.Info("fetching secret value", "key", key, "version", ver, "value", valueFrom)
  109. cacheKey := fmt.Sprintf("%s#%s#%s", key, ver, valueFrom)
  110. if secretOut, found := sm.cache[cacheKey]; found {
  111. log.Info("found secret in cache", "key", key, "version", ver)
  112. return secretOut, nil
  113. }
  114. secretOut, err := sm.constructSecretValue(ctx, key, ver, ref.MetadataPolicy)
  115. if err != nil {
  116. return nil, err
  117. }
  118. sm.cache[cacheKey] = secretOut
  119. return secretOut, nil
  120. }
  121. func (sm *SecretsManager) DeleteSecret(ctx context.Context, remoteRef esv1.PushSecretRemoteRef) error {
  122. secretName := sm.prefix + remoteRef.GetRemoteKey()
  123. secretValue := awssm.GetSecretValueInput{
  124. SecretId: &secretName,
  125. }
  126. secretInput := awssm.DescribeSecretInput{
  127. SecretId: &secretName,
  128. }
  129. awsSecret, err := sm.client.GetSecretValue(ctx, &secretValue)
  130. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMGetSecretValue, err)
  131. var aerr smithy.APIError
  132. if err != nil {
  133. if ok := errors.As(err, &aerr); !ok {
  134. return err
  135. }
  136. if aerr.ErrorCode() == ResourceNotFoundException {
  137. return nil
  138. }
  139. return err
  140. }
  141. data, err := sm.client.DescribeSecret(ctx, &secretInput)
  142. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMDescribeSecret, err)
  143. if err != nil {
  144. return err
  145. }
  146. if !isManagedByESO(data) {
  147. return nil
  148. }
  149. deleteInput := &awssm.DeleteSecretInput{
  150. SecretId: awsSecret.ARN,
  151. }
  152. if sm.config != nil && sm.config.ForceDeleteWithoutRecovery {
  153. deleteInput.ForceDeleteWithoutRecovery = &sm.config.ForceDeleteWithoutRecovery
  154. }
  155. if sm.config != nil && sm.config.RecoveryWindowInDays > 0 {
  156. deleteInput.RecoveryWindowInDays = &sm.config.RecoveryWindowInDays
  157. }
  158. err = util.ValidateDeleteSecretInput(*deleteInput)
  159. if err != nil {
  160. return err
  161. }
  162. _, err = sm.client.DeleteSecret(ctx, deleteInput)
  163. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMDeleteSecret, err)
  164. return err
  165. }
  166. func (sm *SecretsManager) SecretExists(ctx context.Context, pushSecretRef esv1.PushSecretRemoteRef) (bool, error) {
  167. secretName := sm.prefix + pushSecretRef.GetRemoteKey()
  168. secretValue := awssm.GetSecretValueInput{
  169. SecretId: &secretName,
  170. }
  171. _, err := sm.client.GetSecretValue(ctx, &secretValue)
  172. if err != nil {
  173. return sm.handleSecretError(err)
  174. }
  175. return true, nil
  176. }
  177. func (sm *SecretsManager) handleSecretError(err error) (bool, error) {
  178. var aerr smithy.APIError
  179. if ok := errors.As(err, &aerr); !ok {
  180. return false, err
  181. }
  182. if aerr.ErrorCode() == ResourceNotFoundException {
  183. return false, nil
  184. }
  185. return false, err
  186. }
  187. func (sm *SecretsManager) PushSecret(ctx context.Context, secret *corev1.Secret, psd esv1.PushSecretData) error {
  188. value, err := utils.ExtractSecretData(psd, secret)
  189. if err != nil {
  190. return fmt.Errorf("failed to extract secret data: %w", err)
  191. }
  192. secretName := sm.prefix + psd.GetRemoteKey()
  193. describeSecretInput := awssm.DescribeSecretInput{SecretId: &secretName}
  194. describeSecretOutput, err := sm.client.DescribeSecret(ctx, &describeSecretInput)
  195. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMDescribeSecret, err)
  196. var aerr smithy.APIError
  197. if err != nil {
  198. if ok := errors.As(err, &aerr); !ok {
  199. return err
  200. }
  201. if aerr.ErrorCode() == ResourceNotFoundException {
  202. finalValue, err := sm.getNewSecretValue(value, psd.GetProperty(), nil)
  203. if err != nil {
  204. return err
  205. }
  206. return sm.createSecretWithContext(ctx, secretName, psd, finalValue)
  207. }
  208. return err
  209. } else if !isManagedByESO(describeSecretOutput) {
  210. return errors.New("secret not managed by external-secrets")
  211. }
  212. if len(describeSecretOutput.VersionIdsToStages) == 0 {
  213. finalValue, err := sm.getNewSecretValue(value, psd.GetProperty(), nil)
  214. if err != nil {
  215. return err
  216. }
  217. return sm.putSecretValueWithContext(ctx, secretName, nil, psd, finalValue, describeSecretOutput.Tags)
  218. }
  219. getSecretValueInput := awssm.GetSecretValueInput{SecretId: &secretName}
  220. getSecretValueOutput, err := sm.client.GetSecretValue(ctx, &getSecretValueInput)
  221. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMGetSecretValue, err)
  222. if err != nil {
  223. return err
  224. }
  225. finalValue, err := sm.getNewSecretValue(value, psd.GetProperty(), getSecretValueOutput)
  226. if err != nil {
  227. return err
  228. }
  229. return sm.putSecretValueWithContext(ctx, secretName, getSecretValueOutput, psd, finalValue, describeSecretOutput.Tags)
  230. }
  231. func (sm *SecretsManager) getNewSecretValue(value []byte, property string, existingSecret *awssm.GetSecretValueOutput) ([]byte, error) {
  232. if property == "" {
  233. return value, nil
  234. }
  235. if existingSecret == nil {
  236. value, _ = sjson.SetBytes([]byte{}, property, value)
  237. return value, nil
  238. }
  239. currentSecret := sm.retrievePayload(existingSecret)
  240. if currentSecret != "" && !gjson.Valid(currentSecret) {
  241. return nil, errors.New("PushSecret for aws secrets manager with a pushSecretData property requires a json secret")
  242. }
  243. value, _ = sjson.SetBytes([]byte(currentSecret), property, value)
  244. return value, nil
  245. }
  246. func isManagedByESO(data *awssm.DescribeSecretOutput) bool {
  247. managedBy := managedBy
  248. externalSecrets := externalSecrets
  249. for _, tag := range data.Tags {
  250. if *tag.Key == managedBy && *tag.Value == externalSecrets {
  251. return true
  252. }
  253. }
  254. return false
  255. }
  256. // GetAllSecrets syncs multiple secrets from aws provider into a single Kubernetes Secret.
  257. func (sm *SecretsManager) GetAllSecrets(ctx context.Context, ref esv1.ExternalSecretFind) (map[string][]byte, error) {
  258. if ref.Name != nil {
  259. return sm.findByName(ctx, ref)
  260. }
  261. if len(ref.Tags) > 0 {
  262. return sm.findByTags(ctx, ref)
  263. }
  264. return nil, errors.New(errUnexpectedFindOperator)
  265. }
  266. func (sm *SecretsManager) findByName(ctx context.Context, ref esv1.ExternalSecretFind) (map[string][]byte, error) {
  267. matcher, err := find.New(*ref.Name)
  268. if err != nil {
  269. return nil, err
  270. }
  271. filters := make([]types.Filter, 0)
  272. if ref.Path != nil {
  273. filters = append(filters, types.Filter{
  274. Key: types.FilterNameStringTypeName,
  275. Values: []string{
  276. *ref.Path,
  277. },
  278. })
  279. return sm.fetchWithBatch(ctx, filters, matcher)
  280. }
  281. data := make(map[string][]byte)
  282. var nextToken *string
  283. for {
  284. // I put this into the for loop on purpose.
  285. log.V(0).Info("using ListSecret to fetch all secrets; this is a costly operations, please use batching by defining a _path_")
  286. it, err := sm.client.ListSecrets(ctx, &awssm.ListSecretsInput{
  287. Filters: filters,
  288. NextToken: nextToken,
  289. })
  290. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMListSecrets, err)
  291. if err != nil {
  292. return nil, err
  293. }
  294. log.V(1).Info("aws sm findByName found", "secrets", len(it.SecretList))
  295. for _, secret := range it.SecretList {
  296. if !matcher.MatchName(*secret.Name) {
  297. continue
  298. }
  299. log.V(1).Info("aws sm findByName matches", "name", *secret.Name)
  300. if err := sm.fetchAndSet(ctx, data, *secret.Name); err != nil {
  301. return nil, err
  302. }
  303. }
  304. nextToken = it.NextToken
  305. if nextToken == nil {
  306. break
  307. }
  308. }
  309. return data, nil
  310. }
  311. func (sm *SecretsManager) findByTags(ctx context.Context, ref esv1.ExternalSecretFind) (map[string][]byte, error) {
  312. filters := make([]types.Filter, 0)
  313. for k, v := range ref.Tags {
  314. filters = append(filters, types.Filter{
  315. Key: types.FilterNameStringTypeTagKey,
  316. Values: []string{
  317. k,
  318. },
  319. }, types.Filter{
  320. Key: types.FilterNameStringTypeTagValue,
  321. Values: []string{
  322. v,
  323. },
  324. })
  325. }
  326. if ref.Path != nil {
  327. filters = append(filters, types.Filter{
  328. Key: types.FilterNameStringTypeName,
  329. Values: []string{
  330. *ref.Path,
  331. },
  332. })
  333. }
  334. return sm.fetchWithBatch(ctx, filters, nil)
  335. }
  336. func (sm *SecretsManager) fetchAndSet(ctx context.Context, data map[string][]byte, name string) error {
  337. sec, err := sm.fetch(ctx, esv1.ExternalSecretDataRemoteRef{
  338. Key: name,
  339. })
  340. if err != nil {
  341. return err
  342. }
  343. if sec.SecretString != nil {
  344. data[name] = []byte(*sec.SecretString)
  345. }
  346. if sec.SecretBinary != nil {
  347. data[name] = sec.SecretBinary
  348. }
  349. return nil
  350. }
  351. // GetSecret returns a single secret from the provider.
  352. func (sm *SecretsManager) GetSecret(ctx context.Context, ref esv1.ExternalSecretDataRemoteRef) ([]byte, error) {
  353. secretOut, err := sm.fetch(ctx, ref)
  354. if errors.Is(err, esv1.NoSecretErr) {
  355. return nil, err
  356. }
  357. if err != nil {
  358. return nil, util.SanitizeErr(err)
  359. }
  360. if ref.Property == "" {
  361. if secretOut.SecretString != nil {
  362. return []byte(*secretOut.SecretString), nil
  363. }
  364. if secretOut.SecretBinary != nil {
  365. return secretOut.SecretBinary, nil
  366. }
  367. return nil, fmt.Errorf("invalid secret received. no secret string nor binary for key: %s", ref.Key)
  368. }
  369. val := sm.mapSecretToGjson(secretOut, ref.Property)
  370. if !val.Exists() {
  371. return nil, fmt.Errorf("key %s does not exist in secret %s", ref.Property, ref.Key)
  372. }
  373. return []byte(val.String()), nil
  374. }
  375. func (sm *SecretsManager) mapSecretToGjson(secretOut *awssm.GetSecretValueOutput, property string) gjson.Result {
  376. payload := sm.retrievePayload(secretOut)
  377. refProperty := sm.escapeDotsIfRequired(property, payload)
  378. val := gjson.Get(payload, refProperty)
  379. return val
  380. }
  381. func (sm *SecretsManager) retrievePayload(secretOut *awssm.GetSecretValueOutput) string {
  382. if secretOut == nil {
  383. return ""
  384. }
  385. var payload string
  386. if secretOut.SecretString != nil {
  387. payload = *secretOut.SecretString
  388. }
  389. if secretOut.SecretBinary != nil {
  390. payload = string(secretOut.SecretBinary)
  391. }
  392. return payload
  393. }
  394. func (sm *SecretsManager) escapeDotsIfRequired(currentRefProperty, payload string) string {
  395. // We need to search if a given key with a . exists before using gjson operations.
  396. idx := strings.Index(currentRefProperty, ".")
  397. refProperty := currentRefProperty
  398. if idx > -1 {
  399. refProperty = strings.ReplaceAll(currentRefProperty, ".", "\\.")
  400. val := gjson.Get(payload, refProperty)
  401. if !val.Exists() {
  402. refProperty = currentRefProperty
  403. }
  404. }
  405. return refProperty
  406. }
  407. // GetSecretMap returns multiple k/v pairs from the provider.
  408. func (sm *SecretsManager) GetSecretMap(ctx context.Context, ref esv1.ExternalSecretDataRemoteRef) (map[string][]byte, error) {
  409. log.Info("fetching secret map", "key", ref.Key)
  410. data, err := sm.GetSecret(ctx, ref)
  411. if err != nil {
  412. return nil, err
  413. }
  414. kv := make(map[string]json.RawMessage)
  415. err = json.Unmarshal(data, &kv)
  416. if err != nil {
  417. return nil, fmt.Errorf("unable to unmarshal secret %s: %w", ref.Key, err)
  418. }
  419. secretData := make(map[string][]byte)
  420. for k, v := range kv {
  421. var strVal string
  422. err = json.Unmarshal(v, &strVal)
  423. if err == nil {
  424. secretData[k] = []byte(strVal)
  425. } else {
  426. secretData[k] = v
  427. }
  428. }
  429. return secretData, nil
  430. }
  431. func (sm *SecretsManager) Close(_ context.Context) error {
  432. return nil
  433. }
  434. func (sm *SecretsManager) Validate() (esv1.ValidationResult, error) {
  435. // skip validation stack because it depends on the namespace
  436. // of the ExternalSecret
  437. if sm.referentAuth {
  438. return esv1.ValidationResultUnknown, nil
  439. }
  440. _, err := sm.cfg.Credentials.Retrieve(context.Background())
  441. if err != nil {
  442. return esv1.ValidationResultError, util.SanitizeErr(err)
  443. }
  444. return esv1.ValidationResultReady, nil
  445. }
  446. func (sm *SecretsManager) Capabilities() esv1.SecretStoreCapabilities {
  447. return esv1.SecretStoreReadWrite
  448. }
  449. func (sm *SecretsManager) createSecretWithContext(ctx context.Context, secretName string, psd esv1.PushSecretData, value []byte) error {
  450. mdata, err := sm.constructMetadataWithDefaults(psd.GetMetadata())
  451. if err != nil {
  452. return fmt.Errorf("failed to parse push secret metadata: %w", err)
  453. }
  454. tags := make([]types.Tag, 0)
  455. for k, v := range mdata.Spec.Tags {
  456. tags = append(tags, types.Tag{
  457. Key: utilpointer.To(k),
  458. Value: utilpointer.To(v),
  459. })
  460. }
  461. input := &awssm.CreateSecretInput{
  462. Name: &secretName,
  463. SecretBinary: value,
  464. Tags: tags,
  465. Description: utilpointer.To(mdata.Spec.Description),
  466. ClientRequestToken: utilpointer.To(initialVersion),
  467. KmsKeyId: utilpointer.To(mdata.Spec.KMSKeyID),
  468. }
  469. if mdata.Spec.SecretPushFormat == SecretPushFormatString {
  470. input.SecretBinary = nil
  471. input.SecretString = aws.String(string(value))
  472. }
  473. _, err = sm.client.CreateSecret(ctx, input)
  474. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMCreateSecret, err)
  475. return err
  476. }
  477. func (sm *SecretsManager) putSecretValueWithContext(ctx context.Context, secretArn string, awsSecret *awssm.GetSecretValueOutput, psd esv1.PushSecretData, value []byte, tags []types.Tag) error {
  478. if awsSecret != nil && (bytes.Equal(awsSecret.SecretBinary, value) || utils.CompareStringAndByteSlices(awsSecret.SecretString, value)) {
  479. return nil
  480. }
  481. newVersionNumber := initialVersion
  482. if awsSecret != nil {
  483. if sm.newUUID == nil {
  484. newVersionNumber = uuid.NewString()
  485. } else {
  486. newVersionNumber = sm.newUUID()
  487. }
  488. }
  489. input := &awssm.PutSecretValueInput{
  490. SecretId: &secretArn,
  491. SecretBinary: value,
  492. ClientRequestToken: aws.String(newVersionNumber),
  493. }
  494. secretPushFormat, err := utils.FetchValueFromMetadata(SecretPushFormatKey, psd.GetMetadata(), SecretPushFormatBinary)
  495. if err != nil {
  496. return fmt.Errorf("failed to parse metadata: %w", err)
  497. }
  498. if secretPushFormat == SecretPushFormatString {
  499. input.SecretBinary = nil
  500. input.SecretString = aws.String(string(value))
  501. }
  502. _, err = sm.client.PutSecretValue(ctx, input)
  503. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMPutSecretValue, err)
  504. if err != nil {
  505. return err
  506. }
  507. currentTags := make(map[string]string, len(tags))
  508. for _, tag := range tags {
  509. currentTags[*tag.Key] = *tag.Value
  510. }
  511. return sm.patchTags(ctx, psd.GetMetadata(), &secretArn, currentTags)
  512. }
  513. func (sm *SecretsManager) patchTags(ctx context.Context, metadata *apiextensionsv1.JSON, secretId *string, tags map[string]string) error {
  514. meta, err := sm.constructMetadataWithDefaults(metadata)
  515. if err != nil {
  516. return err
  517. }
  518. tagKeysToRemove := util.FindTagKeysToRemove(tags, meta.Spec.Tags)
  519. if len(tagKeysToRemove) > 0 {
  520. _, err = sm.client.UntagResource(ctx, &awssm.UntagResourceInput{
  521. SecretId: secretId,
  522. TagKeys: tagKeysToRemove,
  523. })
  524. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMUntagResource, err)
  525. if err != nil {
  526. return err
  527. }
  528. }
  529. tagsToUpdate, isModified := computeTagsToUpdate(tags, meta.Spec.Tags)
  530. if isModified {
  531. _, err = sm.client.TagResource(ctx, &awssm.TagResourceInput{
  532. SecretId: secretId,
  533. Tags: tagsToUpdate,
  534. })
  535. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMTagResource, err)
  536. if err != nil {
  537. return err
  538. }
  539. }
  540. return nil
  541. }
  542. func (sm *SecretsManager) fetchWithBatch(ctx context.Context, filters []types.Filter, matcher *find.Matcher) (map[string][]byte, error) {
  543. data := make(map[string][]byte)
  544. var nextToken *string
  545. for {
  546. it, err := sm.client.BatchGetSecretValue(ctx, &awssm.BatchGetSecretValueInput{
  547. Filters: filters,
  548. NextToken: nextToken,
  549. })
  550. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMBatchGetSecretValue, err)
  551. if err != nil {
  552. return nil, err
  553. }
  554. log.V(1).Info("aws sm findByName found", "secrets", len(it.SecretValues))
  555. for _, secret := range it.SecretValues {
  556. if matcher != nil && !matcher.MatchName(*secret.Name) {
  557. continue
  558. }
  559. log.V(1).Info("aws sm findByName matches", "name", *secret.Name)
  560. sm.setSecretValues(&secret, data)
  561. }
  562. nextToken = it.NextToken
  563. if nextToken == nil {
  564. break
  565. }
  566. }
  567. return data, nil
  568. }
  569. func (sm *SecretsManager) setSecretValues(secret *types.SecretValueEntry, data map[string][]byte) {
  570. if secret.SecretString != nil {
  571. data[*secret.Name] = []byte(*secret.SecretString)
  572. }
  573. if secret.SecretBinary != nil {
  574. data[*secret.Name] = secret.SecretBinary
  575. }
  576. }
  577. func (sm *SecretsManager) constructSecretValue(ctx context.Context, key, ver string, metadataPolicy esv1.ExternalSecretMetadataPolicy) (*awssm.GetSecretValueOutput, error) {
  578. if metadataPolicy == esv1.ExternalSecretMetadataPolicyFetch {
  579. describeSecretInput := &awssm.DescribeSecretInput{
  580. SecretId: &key,
  581. }
  582. descOutput, err := sm.client.DescribeSecret(ctx, describeSecretInput)
  583. if err != nil {
  584. return nil, err
  585. }
  586. log.Info("found metadata secret", "key", key, "output", descOutput)
  587. jsonTags, err := util.SecretTagsToJSONString(descOutput.Tags)
  588. if err != nil {
  589. return nil, err
  590. }
  591. return &awssm.GetSecretValueOutput{
  592. ARN: descOutput.ARN,
  593. CreatedDate: descOutput.CreatedDate,
  594. Name: descOutput.Name,
  595. SecretString: &jsonTags,
  596. VersionId: &ver,
  597. }, nil
  598. }
  599. var getSecretValueInput *awssm.GetSecretValueInput
  600. if strings.HasPrefix(ver, "uuid/") {
  601. versionID := strings.TrimPrefix(ver, "uuid/")
  602. getSecretValueInput = &awssm.GetSecretValueInput{
  603. SecretId: &key,
  604. VersionId: &versionID,
  605. }
  606. } else {
  607. getSecretValueInput = &awssm.GetSecretValueInput{
  608. SecretId: &key,
  609. VersionStage: &ver,
  610. }
  611. }
  612. secretOut, err := sm.client.GetSecretValue(ctx, getSecretValueInput)
  613. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMGetSecretValue, err)
  614. var (
  615. nf *types.ResourceNotFoundException
  616. ie *types.InvalidParameterException
  617. )
  618. if errors.As(err, &nf) {
  619. return nil, esv1.NoSecretErr
  620. }
  621. if errors.As(err, &ie) && strings.Contains(ie.Error(), "was marked for deletion") {
  622. return nil, esv1.NoSecretErr
  623. }
  624. return secretOut, err
  625. }
  626. func (sm *SecretsManager) constructMetadataWithDefaults(data *apiextensionsv1.JSON) (*metadata.PushSecretMetadata[PushSecretMetadataSpec], error) {
  627. var (
  628. meta *metadata.PushSecretMetadata[PushSecretMetadataSpec]
  629. err error
  630. )
  631. meta, err = metadata.ParseMetadataParameters[PushSecretMetadataSpec](data)
  632. if err != nil {
  633. return nil, fmt.Errorf("failed to parse metadata: %w", err)
  634. }
  635. if meta == nil {
  636. meta = &metadata.PushSecretMetadata[PushSecretMetadataSpec]{}
  637. }
  638. if meta.Spec.SecretPushFormat == "" {
  639. meta.Spec.SecretPushFormat = SecretPushFormatBinary
  640. } else if !slices.Contains([]string{SecretPushFormatBinary, SecretPushFormatString}, meta.Spec.SecretPushFormat) {
  641. return nil, fmt.Errorf("invalid secret push format: %s", meta.Spec.SecretPushFormat)
  642. }
  643. if meta.Spec.Description == "" {
  644. meta.Spec.Description = fmt.Sprintf("secret '%s:%s'", managedBy, externalSecrets)
  645. }
  646. if meta.Spec.KMSKeyID == "" {
  647. meta.Spec.KMSKeyID = "alias/aws/secretsmanager"
  648. }
  649. if len(meta.Spec.Tags) > 0 {
  650. if _, exists := meta.Spec.Tags[managedBy]; exists {
  651. return nil, fmt.Errorf("error parsing tags in metadata: Cannot specify a '%s' tag", managedBy)
  652. }
  653. } else {
  654. meta.Spec.Tags = make(map[string]string)
  655. }
  656. meta.Spec.Tags[managedBy] = externalSecrets
  657. return meta, nil
  658. }
  659. // computeTagsToUpdate compares the current tags with the desired metaTags and returns a slice of ssmTypes.Tag
  660. // that should be set on the resource. It also returns a boolean indicating if any tag was added or modified.
  661. func computeTagsToUpdate(tags, metaTags map[string]string) ([]types.Tag, bool) {
  662. result := make([]types.Tag, 0, len(metaTags))
  663. modified := false
  664. for k, v := range metaTags {
  665. if _, exists := tags[k]; !exists || tags[k] != v {
  666. if k != managedBy {
  667. modified = true
  668. }
  669. }
  670. result = append(result, types.Tag{
  671. Key: utilpointer.To(k),
  672. Value: utilpointer.To(v),
  673. })
  674. }
  675. return result, modified
  676. }