lockbox_test.go 42 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112
  1. /*
  2. Licensed under the Apache License, Version 2.0 (the "License");
  3. you may not use this file except in compliance with the License.
  4. You may obtain a copy of the License at
  5. http://www.apache.org/licenses/LICENSE-2.0
  6. Unless required by applicable law or agreed to in writing, software
  7. distributed under the License is distributed on an "AS IS" BASIS,
  8. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  9. See the License for the specific language governing permissions and
  10. limitations under the License.
  11. */
  12. package lockbox
  13. import (
  14. "context"
  15. b64 "encoding/base64"
  16. "encoding/json"
  17. "testing"
  18. "time"
  19. "github.com/google/uuid"
  20. tassert "github.com/stretchr/testify/assert"
  21. "github.com/yandex-cloud/go-genproto/yandex/cloud/lockbox/v1"
  22. "github.com/yandex-cloud/go-sdk/iamkey"
  23. corev1 "k8s.io/api/core/v1"
  24. metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
  25. ctrl "sigs.k8s.io/controller-runtime"
  26. k8sclient "sigs.k8s.io/controller-runtime/pkg/client"
  27. clientfake "sigs.k8s.io/controller-runtime/pkg/client/fake"
  28. esv1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1"
  29. esmeta "github.com/external-secrets/external-secrets/apis/meta/v1"
  30. "github.com/external-secrets/external-secrets/pkg/provider/yandex/common"
  31. "github.com/external-secrets/external-secrets/pkg/provider/yandex/common/clock"
  32. "github.com/external-secrets/external-secrets/pkg/provider/yandex/lockbox/client"
  33. )
  34. const (
  35. errMissingKey = "invalid Yandex Lockbox SecretStore resource: missing AuthorizedKey Name"
  36. errSecretPayloadPermissionDenied = "unable to request secret payload to get secret: permission denied"
  37. errSecretPayloadNotFound = "unable to request secret payload to get secret: secret not found"
  38. errSecretPayloadVersionNotFound = "unable to request secret payload to get secret: version not found"
  39. )
  40. func TestNewClient(t *testing.T) {
  41. ctx := context.Background()
  42. const namespace = "namespace"
  43. const authorizedKeySecretName = "authorizedKeySecretName"
  44. const authorizedKeySecretKey = "authorizedKeySecretKey"
  45. store := &esv1.SecretStore{
  46. ObjectMeta: metav1.ObjectMeta{
  47. Namespace: namespace,
  48. },
  49. Spec: esv1.SecretStoreSpec{
  50. Provider: &esv1.SecretStoreProvider{
  51. YandexLockbox: &esv1.YandexLockboxProvider{
  52. Auth: esv1.YandexAuth{
  53. AuthorizedKey: esmeta.SecretKeySelector{
  54. Key: authorizedKeySecretKey,
  55. Name: authorizedKeySecretName,
  56. },
  57. },
  58. },
  59. },
  60. },
  61. }
  62. provider, err := esv1.GetProvider(store)
  63. tassert.Nil(t, err)
  64. k8sClient := clientfake.NewClientBuilder().Build()
  65. secretClient, err := provider.NewClient(context.Background(), store, k8sClient, namespace)
  66. tassert.EqualError(t, err, "cannot get Kubernetes secret \"authorizedKeySecretName\" from namespace \"namespace\": secrets \"authorizedKeySecretName\" not found")
  67. tassert.Nil(t, secretClient)
  68. err = createK8sSecret(ctx, t, k8sClient, namespace, authorizedKeySecretName, authorizedKeySecretKey, toJSON(t, newFakeAuthorizedKey()))
  69. tassert.Nil(t, err)
  70. const caCertificateSecretName = "caCertificateSecretName"
  71. const caCertificateSecretKey = "caCertificateSecretKey"
  72. store.Spec.Provider.YandexLockbox.CAProvider = &esv1.YandexCAProvider{
  73. Certificate: esmeta.SecretKeySelector{
  74. Key: caCertificateSecretKey,
  75. Name: caCertificateSecretName,
  76. },
  77. }
  78. secretClient, err = provider.NewClient(context.Background(), store, k8sClient, namespace)
  79. tassert.EqualError(t, err, "cannot get Kubernetes secret \"caCertificateSecretName\" from namespace \"namespace\": secrets \"caCertificateSecretName\" not found")
  80. tassert.Nil(t, secretClient)
  81. err = createK8sSecret(ctx, t, k8sClient, namespace, caCertificateSecretName, caCertificateSecretKey, []byte("it-is-not-a-certificate"))
  82. tassert.Nil(t, err)
  83. secretClient, err = provider.NewClient(context.Background(), store, k8sClient, namespace)
  84. tassert.EqualError(t, err, "failed to create Yandex.Cloud client: unable to read trusted CA certificates")
  85. tassert.Nil(t, secretClient)
  86. }
  87. func TestGetSecretForAllEntries(t *testing.T) {
  88. ctx := context.Background()
  89. namespace := uuid.NewString()
  90. authorizedKey := newFakeAuthorizedKey()
  91. fakeClock := clock.NewFakeClock()
  92. fakeLockboxServer := client.NewFakeLockboxServer(fakeClock, time.Hour)
  93. k1, v1 := "k1", "v1"
  94. k2, v2 := "k2", []byte("v2")
  95. secretID, _ := fakeLockboxServer.CreateSecret(authorizedKey,
  96. "folderId", "secretName",
  97. textEntry(k1, v1),
  98. binaryEntry(k2, v2),
  99. )
  100. k8sClient := clientfake.NewClientBuilder().Build()
  101. const authorizedKeySecretName = "authorizedKeySecretName"
  102. const authorizedKeySecretKey = "authorizedKeySecretKey"
  103. err := createK8sSecret(ctx, t, k8sClient, namespace, authorizedKeySecretName, authorizedKeySecretKey, toJSON(t, authorizedKey))
  104. tassert.Nil(t, err)
  105. store := newYandexLockboxSecretStore("", namespace, authorizedKeySecretName, authorizedKeySecretKey)
  106. provider := newLockboxProvider(fakeClock, fakeLockboxServer)
  107. secretsClient, err := provider.NewClient(ctx, store, k8sClient, namespace)
  108. tassert.Nil(t, err)
  109. data, err := secretsClient.GetSecret(ctx, esv1.ExternalSecretDataRemoteRef{Key: secretID})
  110. tassert.Nil(t, err)
  111. tassert.Equal(
  112. t,
  113. map[string]string{
  114. k1: v1,
  115. k2: base64(v2),
  116. },
  117. unmarshalStringMap(t, data),
  118. )
  119. }
  120. func TestGetSecretForTextEntry(t *testing.T) {
  121. ctx := context.Background()
  122. namespace := uuid.NewString()
  123. authorizedKey := newFakeAuthorizedKey()
  124. fakeClock := clock.NewFakeClock()
  125. fakeLockboxServer := client.NewFakeLockboxServer(fakeClock, time.Hour)
  126. k1, v1 := "k1", "v1"
  127. k2, v2 := "k2", []byte("v2")
  128. secretID, _ := fakeLockboxServer.CreateSecret(authorizedKey,
  129. "folderId", "secretName",
  130. textEntry(k1, v1),
  131. binaryEntry(k2, v2),
  132. )
  133. k8sClient := clientfake.NewClientBuilder().Build()
  134. const authorizedKeySecretName = "authorizedKeySecretName"
  135. const authorizedKeySecretKey = "authorizedKeySecretKey"
  136. err := createK8sSecret(ctx, t, k8sClient, namespace, authorizedKeySecretName, authorizedKeySecretKey, toJSON(t, authorizedKey))
  137. tassert.Nil(t, err)
  138. store := newYandexLockboxSecretStore("", namespace, authorizedKeySecretName, authorizedKeySecretKey)
  139. provider := newLockboxProvider(fakeClock, fakeLockboxServer)
  140. secretsClient, err := provider.NewClient(ctx, store, k8sClient, namespace)
  141. tassert.Nil(t, err)
  142. data, err := secretsClient.GetSecret(ctx, esv1.ExternalSecretDataRemoteRef{Key: secretID, Property: k1})
  143. tassert.Nil(t, err)
  144. tassert.Equal(t, v1, string(data))
  145. }
  146. func TestGetSecretForBinaryEntry(t *testing.T) {
  147. ctx := context.Background()
  148. namespace := uuid.NewString()
  149. authorizedKey := newFakeAuthorizedKey()
  150. fakeClock := clock.NewFakeClock()
  151. fakeLockboxServer := client.NewFakeLockboxServer(fakeClock, time.Hour)
  152. k1, v1 := "k1", "v1"
  153. k2, v2 := "k2", []byte("v2")
  154. secretID, _ := fakeLockboxServer.CreateSecret(authorizedKey,
  155. "folderId", "secretName",
  156. textEntry(k1, v1),
  157. binaryEntry(k2, v2),
  158. )
  159. k8sClient := clientfake.NewClientBuilder().Build()
  160. const authorizedKeySecretName = "authorizedKeySecretName"
  161. const authorizedKeySecretKey = "authorizedKeySecretKey"
  162. err := createK8sSecret(ctx, t, k8sClient, namespace, authorizedKeySecretName, authorizedKeySecretKey, toJSON(t, authorizedKey))
  163. tassert.Nil(t, err)
  164. store := newYandexLockboxSecretStore("", namespace, authorizedKeySecretName, authorizedKeySecretKey)
  165. provider := newLockboxProvider(fakeClock, fakeLockboxServer)
  166. secretsClient, err := provider.NewClient(ctx, store, k8sClient, namespace)
  167. tassert.Nil(t, err)
  168. data, err := secretsClient.GetSecret(ctx, esv1.ExternalSecretDataRemoteRef{Key: secretID, Property: k2})
  169. tassert.Nil(t, err)
  170. tassert.Equal(t, v2, data)
  171. }
  172. func TestGetSecretByVersionID(t *testing.T) {
  173. ctx := context.Background()
  174. namespace := uuid.NewString()
  175. authorizedKey := newFakeAuthorizedKey()
  176. fakeClock := clock.NewFakeClock()
  177. fakeLockboxServer := client.NewFakeLockboxServer(fakeClock, time.Hour)
  178. const oldKey, oldVal = "oldKey", "oldVal"
  179. secretID, oldVersionID := fakeLockboxServer.CreateSecret(authorizedKey,
  180. "folderId", "secretName",
  181. textEntry(oldKey, oldVal),
  182. )
  183. k8sClient := clientfake.NewClientBuilder().Build()
  184. const authorizedKeySecretName = "authorizedKeySecretName"
  185. const authorizedKeySecretKey = "authorizedKeySecretKey"
  186. err := createK8sSecret(ctx, t, k8sClient, namespace, authorizedKeySecretName, authorizedKeySecretKey, toJSON(t, authorizedKey))
  187. tassert.Nil(t, err)
  188. store := newYandexLockboxSecretStore("", namespace, authorizedKeySecretName, authorizedKeySecretKey)
  189. provider := newLockboxProvider(fakeClock, fakeLockboxServer)
  190. secretsClient, err := provider.NewClient(ctx, store, k8sClient, namespace)
  191. tassert.Nil(t, err)
  192. data, err := secretsClient.GetSecret(ctx, esv1.ExternalSecretDataRemoteRef{Key: secretID, Version: oldVersionID})
  193. tassert.Nil(t, err)
  194. tassert.Equal(t, map[string]string{oldKey: oldVal}, unmarshalStringMap(t, data))
  195. const newKey, newVal = "newKey", "newVal"
  196. newVersionID := fakeLockboxServer.AddVersion(secretID, textEntry(newKey, newVal))
  197. data, err = secretsClient.GetSecret(ctx, esv1.ExternalSecretDataRemoteRef{Key: secretID, Version: oldVersionID})
  198. tassert.Nil(t, err)
  199. tassert.Equal(t, map[string]string{oldKey: oldVal}, unmarshalStringMap(t, data))
  200. data, err = secretsClient.GetSecret(ctx, esv1.ExternalSecretDataRemoteRef{Key: secretID, Version: newVersionID})
  201. tassert.Nil(t, err)
  202. tassert.Equal(t, map[string]string{newKey: newVal}, unmarshalStringMap(t, data))
  203. }
  204. func TestGetSecretUnauthorized(t *testing.T) {
  205. ctx := context.Background()
  206. namespace := uuid.NewString()
  207. authorizedKeyA := newFakeAuthorizedKey()
  208. authorizedKeyB := newFakeAuthorizedKey()
  209. fakeClock := clock.NewFakeClock()
  210. fakeLockboxServer := client.NewFakeLockboxServer(fakeClock, time.Hour)
  211. secretID, _ := fakeLockboxServer.CreateSecret(authorizedKeyA,
  212. "folderId", "secretName",
  213. textEntry("k1", "v1"),
  214. )
  215. k8sClient := clientfake.NewClientBuilder().Build()
  216. const authorizedKeySecretName = "authorizedKeySecretName"
  217. const authorizedKeySecretKey = "authorizedKeySecretKey"
  218. err := createK8sSecret(ctx, t, k8sClient, namespace, authorizedKeySecretName, authorizedKeySecretKey, toJSON(t, authorizedKeyB))
  219. tassert.Nil(t, err)
  220. store := newYandexLockboxSecretStore("", namespace, authorizedKeySecretName, authorizedKeySecretKey)
  221. provider := newLockboxProvider(fakeClock, fakeLockboxServer)
  222. secretsClient, err := provider.NewClient(ctx, store, k8sClient, namespace)
  223. tassert.Nil(t, err)
  224. _, err = secretsClient.GetSecret(ctx, esv1.ExternalSecretDataRemoteRef{Key: secretID})
  225. tassert.EqualError(t, err, errSecretPayloadPermissionDenied)
  226. }
  227. func TestGetSecretNotFound(t *testing.T) {
  228. ctx := context.Background()
  229. namespace := uuid.NewString()
  230. authorizedKey := newFakeAuthorizedKey()
  231. fakeClock := clock.NewFakeClock()
  232. fakeLockboxServer := client.NewFakeLockboxServer(fakeClock, time.Hour)
  233. k8sClient := clientfake.NewClientBuilder().Build()
  234. const authorizedKeySecretName = "authorizedKeySecretName"
  235. const authorizedKeySecretKey = "authorizedKeySecretKey"
  236. err := createK8sSecret(ctx, t, k8sClient, namespace, authorizedKeySecretName, authorizedKeySecretKey, toJSON(t, authorizedKey))
  237. tassert.Nil(t, err)
  238. store := newYandexLockboxSecretStore("", namespace, authorizedKeySecretName, authorizedKeySecretKey)
  239. provider := newLockboxProvider(fakeClock, fakeLockboxServer)
  240. secretsClient, err := provider.NewClient(ctx, store, k8sClient, namespace)
  241. tassert.Nil(t, err)
  242. _, err = secretsClient.GetSecret(ctx, esv1.ExternalSecretDataRemoteRef{Key: "no-secret-with-this-id"})
  243. tassert.EqualError(t, err, errSecretPayloadNotFound)
  244. secretID, _ := fakeLockboxServer.CreateSecret(authorizedKey,
  245. "folderId", "secretName",
  246. textEntry("k1", "v1"),
  247. )
  248. _, err = secretsClient.GetSecret(ctx, esv1.ExternalSecretDataRemoteRef{Key: secretID, Version: "no-version-with-this-id"})
  249. tassert.EqualError(t, err, errSecretPayloadVersionNotFound)
  250. }
  251. func TestGetSecretWithTwoNamespaces(t *testing.T) {
  252. ctx := context.Background()
  253. namespace1 := uuid.NewString()
  254. namespace2 := uuid.NewString()
  255. authorizedKey1 := newFakeAuthorizedKey()
  256. authorizedKey2 := newFakeAuthorizedKey()
  257. fakeClock := clock.NewFakeClock()
  258. fakeLockboxServer := client.NewFakeLockboxServer(fakeClock, time.Hour)
  259. k1, v1 := "k1", "v1"
  260. secretID1, _ := fakeLockboxServer.CreateSecret(authorizedKey1,
  261. "folderId", "secretName1",
  262. textEntry(k1, v1),
  263. )
  264. k2, v2 := "k2", "v2"
  265. secretID2, _ := fakeLockboxServer.CreateSecret(authorizedKey2,
  266. "folderId", "secretName2",
  267. textEntry(k2, v2),
  268. textEntry(k2, v2),
  269. )
  270. k8sClient := clientfake.NewClientBuilder().Build()
  271. const authorizedKeySecretName = "authorizedKeySecretName"
  272. const authorizedKeySecretKey = "authorizedKeySecretKey"
  273. err := createK8sSecret(ctx, t, k8sClient, namespace1, authorizedKeySecretName, authorizedKeySecretKey, toJSON(t, authorizedKey1))
  274. tassert.Nil(t, err)
  275. err = createK8sSecret(ctx, t, k8sClient, namespace2, authorizedKeySecretName, authorizedKeySecretKey, toJSON(t, authorizedKey2))
  276. tassert.Nil(t, err)
  277. store1 := newYandexLockboxSecretStore("", namespace1, authorizedKeySecretName, authorizedKeySecretKey)
  278. store2 := newYandexLockboxSecretStore("", namespace2, authorizedKeySecretName, authorizedKeySecretKey)
  279. provider := newLockboxProvider(fakeClock, fakeLockboxServer)
  280. secretsClient1, err := provider.NewClient(ctx, store1, k8sClient, namespace1)
  281. tassert.Nil(t, err)
  282. secretsClient2, err := provider.NewClient(ctx, store2, k8sClient, namespace2)
  283. tassert.Nil(t, err)
  284. data, err := secretsClient1.GetSecret(ctx, esv1.ExternalSecretDataRemoteRef{Key: secretID1, Property: k1})
  285. tassert.Equal(t, v1, string(data))
  286. tassert.Nil(t, err)
  287. data, err = secretsClient1.GetSecret(ctx, esv1.ExternalSecretDataRemoteRef{Key: secretID2, Property: k2})
  288. tassert.Nil(t, data)
  289. tassert.EqualError(t, err, errSecretPayloadPermissionDenied)
  290. data, err = secretsClient2.GetSecret(ctx, esv1.ExternalSecretDataRemoteRef{Key: secretID1, Property: k1})
  291. tassert.Nil(t, data)
  292. tassert.EqualError(t, err, errSecretPayloadPermissionDenied)
  293. data, err = secretsClient2.GetSecret(ctx, esv1.ExternalSecretDataRemoteRef{Key: secretID2, Property: k2})
  294. tassert.Equal(t, v2, string(data))
  295. tassert.Nil(t, err)
  296. }
  297. func TestGetSecretWithTwoApiEndpoints(t *testing.T) {
  298. ctx := context.Background()
  299. apiEndpoint1 := uuid.NewString()
  300. apiEndpoint2 := uuid.NewString()
  301. namespace := uuid.NewString()
  302. authorizedKey1 := newFakeAuthorizedKey()
  303. authorizedKey2 := newFakeAuthorizedKey()
  304. fakeClock := clock.NewFakeClock()
  305. fakeLockboxServer1 := client.NewFakeLockboxServer(fakeClock, time.Hour)
  306. k1, v1 := "k1", "v1"
  307. secretID1, _ := fakeLockboxServer1.CreateSecret(authorizedKey1,
  308. "folderId", "secretName",
  309. textEntry(k1, v1),
  310. )
  311. fakeLockboxServer2 := client.NewFakeLockboxServer(fakeClock, time.Hour)
  312. k2, v2 := "k2", "v2"
  313. secretID2, _ := fakeLockboxServer2.CreateSecret(authorizedKey2,
  314. "folderId", "secretName",
  315. textEntry(k2, v2),
  316. )
  317. k8sClient := clientfake.NewClientBuilder().Build()
  318. const authorizedKeySecretName1 = "authorizedKeySecretName1"
  319. const authorizedKeySecretKey1 = "authorizedKeySecretKey1"
  320. err := createK8sSecret(ctx, t, k8sClient, namespace, authorizedKeySecretName1, authorizedKeySecretKey1, toJSON(t, authorizedKey1))
  321. tassert.Nil(t, err)
  322. const authorizedKeySecretName2 = "authorizedKeySecretName2"
  323. const authorizedKeySecretKey2 = "authorizedKeySecretKey2"
  324. err = createK8sSecret(ctx, t, k8sClient, namespace, authorizedKeySecretName2, authorizedKeySecretKey2, toJSON(t, authorizedKey2))
  325. tassert.Nil(t, err)
  326. store1 := newYandexLockboxSecretStore(apiEndpoint1, namespace, authorizedKeySecretName1, authorizedKeySecretKey1)
  327. store2 := newYandexLockboxSecretStore(apiEndpoint2, namespace, authorizedKeySecretName2, authorizedKeySecretKey2)
  328. provider1 := newLockboxProvider(fakeClock, fakeLockboxServer1)
  329. provider2 := newLockboxProvider(fakeClock, fakeLockboxServer2)
  330. secretsClient1, err := provider1.NewClient(ctx, store1, k8sClient, namespace)
  331. tassert.Nil(t, err)
  332. secretsClient2, err := provider2.NewClient(ctx, store2, k8sClient, namespace)
  333. tassert.Nil(t, err)
  334. var data []byte
  335. data, err = secretsClient1.GetSecret(ctx, esv1.ExternalSecretDataRemoteRef{Key: secretID1, Property: k1})
  336. tassert.Equal(t, v1, string(data))
  337. tassert.Nil(t, err)
  338. data, err = secretsClient1.GetSecret(ctx, esv1.ExternalSecretDataRemoteRef{Key: secretID2, Property: k2})
  339. tassert.Nil(t, data)
  340. tassert.EqualError(t, err, errSecretPayloadNotFound)
  341. data, err = secretsClient2.GetSecret(ctx, esv1.ExternalSecretDataRemoteRef{Key: secretID1, Property: k1})
  342. tassert.Nil(t, data)
  343. tassert.EqualError(t, err, errSecretPayloadNotFound)
  344. data, err = secretsClient2.GetSecret(ctx, esv1.ExternalSecretDataRemoteRef{Key: secretID2, Property: k2})
  345. tassert.Equal(t, v2, string(data))
  346. tassert.Nil(t, err)
  347. }
  348. func TestGetSecretWithIamTokenExpiration(t *testing.T) {
  349. ctx := context.Background()
  350. namespace := uuid.NewString()
  351. authorizedKey := newFakeAuthorizedKey()
  352. fakeClock := clock.NewFakeClock()
  353. tokenExpirationTime := time.Hour
  354. fakeLockboxServer := client.NewFakeLockboxServer(fakeClock, tokenExpirationTime)
  355. k1, v1 := "k1", "v1"
  356. secretID, _ := fakeLockboxServer.CreateSecret(authorizedKey,
  357. "folderId", "secretName",
  358. textEntry(k1, v1),
  359. )
  360. k8sClient := clientfake.NewClientBuilder().Build()
  361. const authorizedKeySecretName = "authorizedKeySecretName"
  362. const authorizedKeySecretKey = "authorizedKeySecretKey"
  363. err := createK8sSecret(ctx, t, k8sClient, namespace, authorizedKeySecretName, authorizedKeySecretKey, toJSON(t, authorizedKey))
  364. tassert.Nil(t, err)
  365. store := newYandexLockboxSecretStore("", namespace, authorizedKeySecretName, authorizedKeySecretKey)
  366. provider := newLockboxProvider(fakeClock, fakeLockboxServer)
  367. var data []byte
  368. oldSecretsClient, err := provider.NewClient(ctx, store, k8sClient, namespace)
  369. tassert.Nil(t, err)
  370. data, err = oldSecretsClient.GetSecret(ctx, esv1.ExternalSecretDataRemoteRef{Key: secretID, Property: k1})
  371. tassert.Equal(t, v1, string(data))
  372. tassert.Nil(t, err)
  373. fakeClock.AddDuration(2 * tokenExpirationTime)
  374. data, err = oldSecretsClient.GetSecret(ctx, esv1.ExternalSecretDataRemoteRef{Key: secretID, Property: k1})
  375. tassert.Nil(t, data)
  376. tassert.EqualError(t, err, "unable to request secret payload to get secret: iam token expired")
  377. newSecretsClient, err := provider.NewClient(ctx, store, k8sClient, namespace)
  378. tassert.Nil(t, err)
  379. data, err = newSecretsClient.GetSecret(ctx, esv1.ExternalSecretDataRemoteRef{Key: secretID, Property: k1})
  380. tassert.Equal(t, v1, string(data))
  381. tassert.Nil(t, err)
  382. }
  383. func TestGetSecretWithIamTokenCleanup(t *testing.T) {
  384. ctx := context.Background()
  385. namespace := uuid.NewString()
  386. authorizedKey1 := newFakeAuthorizedKey()
  387. authorizedKey2 := newFakeAuthorizedKey()
  388. fakeClock := clock.NewFakeClock()
  389. tokenExpirationDuration := time.Hour
  390. fakeLockboxServer := client.NewFakeLockboxServer(fakeClock, tokenExpirationDuration)
  391. secretID1, _ := fakeLockboxServer.CreateSecret(authorizedKey1,
  392. "folderId", "secretName1",
  393. textEntry("k1", "v1"),
  394. )
  395. secretID2, _ := fakeLockboxServer.CreateSecret(authorizedKey2,
  396. "folderId", "secretName2",
  397. textEntry("k2", "v2"),
  398. )
  399. var err error
  400. k8sClient := clientfake.NewClientBuilder().Build()
  401. const authorizedKeySecretName1 = "authorizedKeySecretName1"
  402. const authorizedKeySecretKey1 = "authorizedKeySecretKey1"
  403. err = createK8sSecret(ctx, t, k8sClient, namespace, authorizedKeySecretName1, authorizedKeySecretKey1, toJSON(t, authorizedKey1))
  404. tassert.Nil(t, err)
  405. const authorizedKeySecretName2 = "authorizedKeySecretName2"
  406. const authorizedKeySecretKey2 = "authorizedKeySecretKey2"
  407. err = createK8sSecret(ctx, t, k8sClient, namespace, authorizedKeySecretName2, authorizedKeySecretKey2, toJSON(t, authorizedKey2))
  408. tassert.Nil(t, err)
  409. store1 := newYandexLockboxSecretStore("", namespace, authorizedKeySecretName1, authorizedKeySecretKey1)
  410. store2 := newYandexLockboxSecretStore("", namespace, authorizedKeySecretName2, authorizedKeySecretKey2)
  411. provider := newLockboxProvider(fakeClock, fakeLockboxServer)
  412. tassert.False(t, provider.IsIamTokenCached(authorizedKey1))
  413. tassert.False(t, provider.IsIamTokenCached(authorizedKey2))
  414. // Access secretID1 with authorizedKey1, IAM token for authorizedKey1 should be cached
  415. secretsClient, err := provider.NewClient(ctx, store1, k8sClient, namespace)
  416. tassert.Nil(t, err)
  417. _, err = secretsClient.GetSecret(ctx, esv1.ExternalSecretDataRemoteRef{Key: secretID1})
  418. tassert.Nil(t, err)
  419. tassert.True(t, provider.IsIamTokenCached(authorizedKey1))
  420. tassert.False(t, provider.IsIamTokenCached(authorizedKey2))
  421. fakeClock.AddDuration(tokenExpirationDuration * 2)
  422. // Access secretID2 with authorizedKey2, IAM token for authorizedKey2 should be cached
  423. secretsClient, err = provider.NewClient(ctx, store2, k8sClient, namespace)
  424. tassert.Nil(t, err)
  425. _, err = secretsClient.GetSecret(ctx, esv1.ExternalSecretDataRemoteRef{Key: secretID2})
  426. tassert.Nil(t, err)
  427. tassert.True(t, provider.IsIamTokenCached(authorizedKey1))
  428. tassert.True(t, provider.IsIamTokenCached(authorizedKey2))
  429. fakeClock.AddDuration(tokenExpirationDuration)
  430. tassert.True(t, provider.IsIamTokenCached(authorizedKey1))
  431. tassert.True(t, provider.IsIamTokenCached(authorizedKey2))
  432. provider.CleanUpIamTokenMap()
  433. tassert.False(t, provider.IsIamTokenCached(authorizedKey1))
  434. tassert.True(t, provider.IsIamTokenCached(authorizedKey2))
  435. fakeClock.AddDuration(tokenExpirationDuration)
  436. tassert.False(t, provider.IsIamTokenCached(authorizedKey1))
  437. tassert.True(t, provider.IsIamTokenCached(authorizedKey2))
  438. provider.CleanUpIamTokenMap()
  439. tassert.False(t, provider.IsIamTokenCached(authorizedKey1))
  440. tassert.False(t, provider.IsIamTokenCached(authorizedKey2))
  441. }
  442. func TestGetSecretMap(t *testing.T) {
  443. ctx := context.Background()
  444. namespace := uuid.NewString()
  445. authorizedKey := newFakeAuthorizedKey()
  446. fakeClock := clock.NewFakeClock()
  447. fakeLockboxServer := client.NewFakeLockboxServer(fakeClock, time.Hour)
  448. k1, v1 := "k1", "v1"
  449. k2, v2 := "k2", []byte("v2")
  450. secretID, _ := fakeLockboxServer.CreateSecret(authorizedKey,
  451. "folderId", "secretName",
  452. textEntry(k1, v1),
  453. binaryEntry(k2, v2),
  454. )
  455. k8sClient := clientfake.NewClientBuilder().Build()
  456. const authorizedKeySecretName = "authorizedKeySecretName"
  457. const authorizedKeySecretKey = "authorizedKeySecretKey"
  458. err := createK8sSecret(ctx, t, k8sClient, namespace, authorizedKeySecretName, authorizedKeySecretKey, toJSON(t, authorizedKey))
  459. tassert.Nil(t, err)
  460. store := newYandexLockboxSecretStore("", namespace, authorizedKeySecretName, authorizedKeySecretKey)
  461. provider := newLockboxProvider(fakeClock, fakeLockboxServer)
  462. secretsClient, err := provider.NewClient(ctx, store, k8sClient, namespace)
  463. tassert.Nil(t, err)
  464. data, err := secretsClient.GetSecretMap(ctx, esv1.ExternalSecretDataRemoteRef{Key: secretID})
  465. tassert.Nil(t, err)
  466. tassert.Equal(
  467. t,
  468. map[string][]byte{
  469. k1: []byte(v1),
  470. k2: v2,
  471. },
  472. data,
  473. )
  474. }
  475. func TestGetSecretMapByVersionID(t *testing.T) {
  476. ctx := context.Background()
  477. namespace := uuid.NewString()
  478. authorizedKey := newFakeAuthorizedKey()
  479. fakeClock := clock.NewFakeClock()
  480. fakeLockboxServer := client.NewFakeLockboxServer(fakeClock, time.Hour)
  481. oldKey, oldVal := "oldKey", "oldVal"
  482. secretID, oldVersionID := fakeLockboxServer.CreateSecret(authorizedKey,
  483. "folderId", "secretName",
  484. textEntry(oldKey, oldVal),
  485. )
  486. k8sClient := clientfake.NewClientBuilder().Build()
  487. const authorizedKeySecretName = "authorizedKeySecretName"
  488. const authorizedKeySecretKey = "authorizedKeySecretKey"
  489. err := createK8sSecret(ctx, t, k8sClient, namespace, authorizedKeySecretName, authorizedKeySecretKey, toJSON(t, authorizedKey))
  490. tassert.Nil(t, err)
  491. store := newYandexLockboxSecretStore("", namespace, authorizedKeySecretName, authorizedKeySecretKey)
  492. provider := newLockboxProvider(fakeClock, fakeLockboxServer)
  493. secretsClient, err := provider.NewClient(ctx, store, k8sClient, namespace)
  494. tassert.Nil(t, err)
  495. data, err := secretsClient.GetSecretMap(ctx, esv1.ExternalSecretDataRemoteRef{Key: secretID, Version: oldVersionID})
  496. tassert.Nil(t, err)
  497. tassert.Equal(t, map[string][]byte{oldKey: []byte(oldVal)}, data)
  498. newKey, newVal := "newKey", "newVal"
  499. newVersionID := fakeLockboxServer.AddVersion(secretID, textEntry(newKey, newVal))
  500. data, err = secretsClient.GetSecretMap(ctx, esv1.ExternalSecretDataRemoteRef{Key: secretID, Version: oldVersionID})
  501. tassert.Nil(t, err)
  502. tassert.Equal(t, map[string][]byte{oldKey: []byte(oldVal)}, data)
  503. data, err = secretsClient.GetSecretMap(ctx, esv1.ExternalSecretDataRemoteRef{Key: secretID, Version: newVersionID})
  504. tassert.Nil(t, err)
  505. tassert.Equal(t, map[string][]byte{newKey: []byte(newVal)}, data)
  506. }
  507. func TestGetSecretWithByNameFetchingPolicyForAllEntries(t *testing.T) {
  508. ctx := context.Background()
  509. namespace := uuid.NewString()
  510. authorizedKey := newFakeAuthorizedKey()
  511. fakeClock := clock.NewFakeClock()
  512. fakeLockboxServer := client.NewFakeLockboxServer(fakeClock, time.Hour)
  513. folderId := uuid.NewString()
  514. const secretName = "secretName"
  515. k1, v1 := "k1", "v1"
  516. k2, v2 := "k2", []byte("v2")
  517. _, _ = fakeLockboxServer.CreateSecret(
  518. authorizedKey,
  519. folderId, secretName,
  520. textEntry(k1, v1),
  521. binaryEntry(k2, v2),
  522. )
  523. k8sClient := clientfake.NewClientBuilder().Build()
  524. const authorizedKeySecretName = "authorizedKeySecretName"
  525. const authorizedKeySecretKey = "authorizedKeySecretKey"
  526. err := createK8sSecret(ctx, t, k8sClient, namespace, authorizedKeySecretName, authorizedKeySecretKey, toJSON(t, authorizedKey))
  527. tassert.Nil(t, err)
  528. store := newYandexLockboxSecretStoreWithFetchByName("", namespace, authorizedKeySecretName, authorizedKeySecretKey, folderId)
  529. provider := newLockboxProvider(fakeClock, fakeLockboxServer)
  530. secretsClient, err := provider.NewClient(ctx, store, k8sClient, namespace)
  531. tassert.Nil(t, err)
  532. data, err := secretsClient.GetSecret(ctx, esv1.ExternalSecretDataRemoteRef{Key: secretName})
  533. tassert.Nil(t, err)
  534. expected := map[string]string{
  535. k1: base64([]byte(v1)),
  536. k2: base64(v2),
  537. }
  538. tassert.Equal(t, expected, unmarshalStringMap(t, data))
  539. }
  540. func TestGetSecretWithByNameFetchingPolicyAndVersionID(t *testing.T) {
  541. ctx := context.Background()
  542. namespace := uuid.NewString()
  543. authorizedKey := newFakeAuthorizedKey()
  544. fakeClock := clock.NewFakeClock()
  545. fakeLockboxServer := client.NewFakeLockboxServer(fakeClock, time.Hour)
  546. folderId := uuid.NewString()
  547. const secretName = "secretName"
  548. oldKey, oldVal := "oldKey", "oldVal"
  549. secretID, oldVersionID := fakeLockboxServer.CreateSecret(authorizedKey,
  550. folderId, secretName,
  551. textEntry(oldKey, oldVal),
  552. )
  553. k8sClient := clientfake.NewClientBuilder().Build()
  554. const authorizedKeySecretName = "authorizedKeySecretName"
  555. const authorizedKeySecretKey = "authorizedKeySecretKey"
  556. err := createK8sSecret(ctx, t, k8sClient, namespace, authorizedKeySecretName, authorizedKeySecretKey, toJSON(t, authorizedKey))
  557. tassert.Nil(t, err)
  558. store := newYandexLockboxSecretStoreWithFetchByName("", namespace, authorizedKeySecretName, authorizedKeySecretKey, folderId)
  559. provider := newLockboxProvider(fakeClock, fakeLockboxServer)
  560. secretsClient, err := provider.NewClient(ctx, store, k8sClient, namespace)
  561. tassert.Nil(t, err)
  562. data, err := secretsClient.GetSecret(ctx, esv1.ExternalSecretDataRemoteRef{Key: secretName, Version: oldVersionID})
  563. tassert.Nil(t, err)
  564. tassert.Equal(t, map[string]string{oldKey: base64([]byte(oldVal))}, unmarshalStringMap(t, data))
  565. newKey, newVal := "newKey", "newVal"
  566. newVersionID := fakeLockboxServer.AddVersion(secretID, textEntry(newKey, newVal))
  567. data, err = secretsClient.GetSecret(ctx, esv1.ExternalSecretDataRemoteRef{Key: secretName, Version: oldVersionID})
  568. tassert.Nil(t, err)
  569. tassert.Equal(t, map[string]string{oldKey: base64([]byte(oldVal))}, unmarshalStringMap(t, data))
  570. data, err = secretsClient.GetSecret(ctx, esv1.ExternalSecretDataRemoteRef{Key: secretName, Version: newVersionID})
  571. tassert.Nil(t, err)
  572. tassert.Equal(t, map[string]string{newKey: base64([]byte(newVal))}, unmarshalStringMap(t, data))
  573. }
  574. func TestGetSecretWithByNameFetchingPolicyForTextEntry(t *testing.T) {
  575. ctx := context.Background()
  576. namespace := uuid.NewString()
  577. authorizedKey := newFakeAuthorizedKey()
  578. fakeClock := clock.NewFakeClock()
  579. fakeLockboxServer := client.NewFakeLockboxServer(fakeClock, time.Hour)
  580. folderId := uuid.NewString()
  581. const secretName = "secretName"
  582. k1, v1 := "k1", "v1"
  583. k2, v2 := "k2", []byte("v2")
  584. _, _ = fakeLockboxServer.CreateSecret(authorizedKey,
  585. folderId, secretName,
  586. textEntry(k1, v1),
  587. binaryEntry(k2, v2),
  588. )
  589. k8sClient := clientfake.NewClientBuilder().Build()
  590. const authorizedKeySecretName = "authorizedKeySecretName"
  591. const authorizedKeySecretKey = "authorizedKeySecretKey"
  592. err := createK8sSecret(ctx, t, k8sClient, namespace, authorizedKeySecretName, authorizedKeySecretKey, toJSON(t, authorizedKey))
  593. tassert.Nil(t, err)
  594. store := newYandexLockboxSecretStoreWithFetchByName("", namespace, authorizedKeySecretName, authorizedKeySecretKey, folderId)
  595. provider := newLockboxProvider(fakeClock, fakeLockboxServer)
  596. secretsClient, err := provider.NewClient(ctx, store, k8sClient, namespace)
  597. tassert.Nil(t, err)
  598. data, err := secretsClient.GetSecret(ctx, esv1.ExternalSecretDataRemoteRef{Key: secretName, Property: k1})
  599. tassert.Nil(t, err)
  600. tassert.Equal(t, v1, string(data))
  601. }
  602. func TestGetSecretWithByNameFetchingPolicyForBinaryEntry(t *testing.T) {
  603. ctx := context.Background()
  604. namespace := uuid.NewString()
  605. authorizedKey := newFakeAuthorizedKey()
  606. fakeClock := clock.NewFakeClock()
  607. fakeLockboxServer := client.NewFakeLockboxServer(fakeClock, time.Hour)
  608. folderId := uuid.NewString()
  609. const secretName = "secretName"
  610. k1, v1 := "k1", "v1"
  611. k2, v2 := "k2", []byte("v2")
  612. _, _ = fakeLockboxServer.CreateSecret(authorizedKey,
  613. folderId, secretName,
  614. textEntry(k1, v1),
  615. binaryEntry(k2, v2),
  616. )
  617. k8sClient := clientfake.NewClientBuilder().Build()
  618. const authorizedKeySecretName = "authorizedKeySecretName"
  619. const authorizedKeySecretKey = "authorizedKeySecretKey"
  620. err := createK8sSecret(ctx, t, k8sClient, namespace, authorizedKeySecretName, authorizedKeySecretKey, toJSON(t, authorizedKey))
  621. tassert.Nil(t, err)
  622. store := newYandexLockboxSecretStoreWithFetchByName("", namespace, authorizedKeySecretName, authorizedKeySecretKey, folderId)
  623. provider := newLockboxProvider(fakeClock, fakeLockboxServer)
  624. secretsClient, err := provider.NewClient(ctx, store, k8sClient, namespace)
  625. tassert.Nil(t, err)
  626. data, err := secretsClient.GetSecret(ctx, esv1.ExternalSecretDataRemoteRef{Key: secretName, Property: k2})
  627. tassert.Nil(t, err)
  628. tassert.Equal(t, v2, data)
  629. }
  630. func TestGetSecretWithByNameFetchingPolicyNotFound(t *testing.T) {
  631. ctx := context.Background()
  632. namespace := uuid.NewString()
  633. authorizedKey := newFakeAuthorizedKey()
  634. fakeClock := clock.NewFakeClock()
  635. fakeLockboxServer := client.NewFakeLockboxServer(fakeClock, time.Hour)
  636. folderId := uuid.NewString()
  637. k8sClient := clientfake.NewClientBuilder().Build()
  638. const authorizedKeySecretName = "authorizedKeySecretName"
  639. const authorizedKeySecretKey = "authorizedKeySecretKey"
  640. err := createK8sSecret(ctx, t, k8sClient, namespace, authorizedKeySecretName, authorizedKeySecretKey, toJSON(t, authorizedKey))
  641. tassert.Nil(t, err)
  642. store := newYandexLockboxSecretStoreWithFetchByName("", namespace, authorizedKeySecretName, authorizedKeySecretKey, folderId)
  643. provider := newLockboxProvider(fakeClock, fakeLockboxServer)
  644. secretsClient, err := provider.NewClient(ctx, store, k8sClient, namespace)
  645. tassert.Nil(t, err)
  646. _, err = secretsClient.GetSecret(ctx, esv1.ExternalSecretDataRemoteRef{Key: "no-secret-with-such-name"})
  647. tassert.EqualError(t, err, errSecretPayloadNotFound)
  648. secretName := "secretName"
  649. _, _ = fakeLockboxServer.CreateSecret(
  650. authorizedKey,
  651. folderId, secretName,
  652. textEntry("k1", "v1"),
  653. )
  654. _, err = secretsClient.GetSecret(ctx, esv1.ExternalSecretDataRemoteRef{Key: secretName, Version: "no-version-with-such-id"})
  655. tassert.EqualError(t, err, errSecretPayloadVersionNotFound)
  656. }
  657. func TestGetSecretWithByNameFetchingPolicyUnauthorized(t *testing.T) {
  658. ctx := context.Background()
  659. namespace := uuid.NewString()
  660. authorizedKeyA := newFakeAuthorizedKey()
  661. authorizedKeyB := newFakeAuthorizedKey()
  662. fakeClock := clock.NewFakeClock()
  663. fakeLockboxServer := client.NewFakeLockboxServer(fakeClock, time.Hour)
  664. folderId := uuid.NewString()
  665. secretName := "secretName"
  666. _, _ = fakeLockboxServer.CreateSecret(authorizedKeyA,
  667. folderId, secretName,
  668. textEntry("k1", "v1"),
  669. )
  670. k8sClient := clientfake.NewClientBuilder().Build()
  671. const authorizedKeySecretName = "authorizedKeySecretName"
  672. const authorizedKeySecretKey = "authorizedKeySecretKey"
  673. err := createK8sSecret(ctx, t, k8sClient, namespace, authorizedKeySecretName, authorizedKeySecretKey, toJSON(t, authorizedKeyB))
  674. tassert.Nil(t, err)
  675. store := newYandexLockboxSecretStoreWithFetchByName("", namespace, authorizedKeySecretName, authorizedKeySecretKey, folderId)
  676. provider := newLockboxProvider(fakeClock, fakeLockboxServer)
  677. secretsClient, err := provider.NewClient(ctx, store, k8sClient, namespace)
  678. tassert.Nil(t, err)
  679. _, err = secretsClient.GetSecret(ctx, esv1.ExternalSecretDataRemoteRef{Key: secretName})
  680. tassert.EqualError(t, err, errSecretPayloadPermissionDenied)
  681. }
  682. func TestGetSecretWithByNameFetchingPolicyWithoutFolderID(t *testing.T) {
  683. ctx := context.Background()
  684. namespace := uuid.NewString()
  685. authorizedKey := newFakeAuthorizedKey()
  686. fakeClock := clock.NewFakeClock()
  687. fakeLockboxServer := client.NewFakeLockboxServer(fakeClock, time.Hour)
  688. k8sClient := clientfake.NewClientBuilder().Build()
  689. const authorizedKeySecretName = "authorizedKeySecretName"
  690. const authorizedKeySecretKey = "authorizedKeySecretKey"
  691. err := createK8sSecret(ctx, t, k8sClient, namespace, authorizedKeySecretName, authorizedKeySecretKey, toJSON(t, authorizedKey))
  692. tassert.Nil(t, err)
  693. store := newYandexLockboxSecretStoreWithFetchByName("", namespace, authorizedKeySecretName, authorizedKeySecretKey, "")
  694. provider := newLockboxProvider(fakeClock, fakeLockboxServer)
  695. _, err = provider.NewClient(ctx, store, k8sClient, namespace)
  696. tassert.EqualError(t, err, "folderID is required when fetching policy is 'byName'")
  697. }
  698. func TesGetSecretWithByIDFetchingPolicyForAllEntries(t *testing.T) {
  699. ctx := context.Background()
  700. namespace := uuid.NewString()
  701. authorizedKey := newFakeAuthorizedKey()
  702. fakeClock := clock.NewFakeClock()
  703. fakeLockboxServer := client.NewFakeLockboxServer(fakeClock, time.Hour)
  704. k1, v1 := "k1", "v1"
  705. k2, v2 := "k2", []byte("v2")
  706. secretID, _ := fakeLockboxServer.CreateSecret(authorizedKey,
  707. "folderId", "secret",
  708. textEntry(k1, v1),
  709. binaryEntry(k2, v2),
  710. )
  711. k8sClient := clientfake.NewClientBuilder().Build()
  712. const authorizedKeySecretName = "authorizedKeySecretName"
  713. const authorizedKeySecretKey = "authorizedKeySecretKey"
  714. err := createK8sSecret(ctx, t, k8sClient, namespace, authorizedKeySecretName, authorizedKeySecretKey, toJSON(t, authorizedKey))
  715. tassert.Nil(t, err)
  716. store := newYandexLockboxSecretStoreWithFetchByID("", namespace, authorizedKeySecretName, authorizedKeySecretKey)
  717. provider := newLockboxProvider(fakeClock, fakeLockboxServer)
  718. secretsClient, err := provider.NewClient(ctx, store, k8sClient, namespace)
  719. tassert.Nil(t, err)
  720. data, err := secretsClient.GetSecret(ctx, esv1.ExternalSecretDataRemoteRef{Key: secretID})
  721. tassert.Nil(t, err)
  722. expected := map[string]string{
  723. k1: v1,
  724. k2: base64(v2),
  725. }
  726. tassert.Equal(t, expected, unmarshalStringMap(t, data))
  727. }
  728. func TestGetSecretWithByIDFetchingPolicyForTextEntry(t *testing.T) {
  729. ctx := context.Background()
  730. namespace := uuid.NewString()
  731. authorizedKey := newFakeAuthorizedKey()
  732. fakeClock := clock.NewFakeClock()
  733. fakeLockboxServer := client.NewFakeLockboxServer(fakeClock, time.Hour)
  734. k1, v1 := "k1", "v1"
  735. k2, v2 := "k2", []byte("v2")
  736. secretID, _ := fakeLockboxServer.CreateSecret(authorizedKey,
  737. "folderId", "secret",
  738. textEntry(k1, v1),
  739. binaryEntry(k2, v2),
  740. )
  741. k8sClient := clientfake.NewClientBuilder().Build()
  742. const authorizedKeySecretName = "authorizedKeySecretName"
  743. const authorizedKeySecretKey = "authorizedKeySecretKey"
  744. err := createK8sSecret(ctx, t, k8sClient, namespace, authorizedKeySecretName, authorizedKeySecretKey, toJSON(t, authorizedKey))
  745. tassert.Nil(t, err)
  746. store := newYandexLockboxSecretStoreWithFetchByID("", namespace, authorizedKeySecretName, authorizedKeySecretKey)
  747. provider := newLockboxProvider(fakeClock, fakeLockboxServer)
  748. secretsClient, err := provider.NewClient(ctx, store, k8sClient, namespace)
  749. tassert.Nil(t, err)
  750. data, err := secretsClient.GetSecret(ctx, esv1.ExternalSecretDataRemoteRef{Key: secretID, Property: k1})
  751. tassert.Nil(t, err)
  752. tassert.Equal(t, v1, string(data))
  753. }
  754. func TestGetSecretWithByIDFetchingPolicyForBinaryEntry(t *testing.T) {
  755. ctx := context.Background()
  756. namespace := uuid.NewString()
  757. authorizedKey := newFakeAuthorizedKey()
  758. fakeClock := clock.NewFakeClock()
  759. fakeLockboxServer := client.NewFakeLockboxServer(fakeClock, time.Hour)
  760. k1, v1 := "k1", "v1"
  761. k2, v2 := "k2", []byte("v2")
  762. secretID, _ := fakeLockboxServer.CreateSecret(authorizedKey,
  763. "folderId", "secret",
  764. textEntry(k1, v1),
  765. binaryEntry(k2, v2),
  766. )
  767. k8sClient := clientfake.NewClientBuilder().Build()
  768. const authorizedKeySecretName = "authorizedKeySecretName"
  769. const authorizedKeySecretKey = "authorizedKeySecretKey"
  770. err := createK8sSecret(ctx, t, k8sClient, namespace, authorizedKeySecretName, authorizedKeySecretKey, toJSON(t, authorizedKey))
  771. tassert.Nil(t, err)
  772. store := newYandexLockboxSecretStoreWithFetchByID("", namespace, authorizedKeySecretName, authorizedKeySecretKey)
  773. provider := newLockboxProvider(fakeClock, fakeLockboxServer)
  774. secretsClient, err := provider.NewClient(ctx, store, k8sClient, namespace)
  775. tassert.Nil(t, err)
  776. data, err := secretsClient.GetSecret(ctx, esv1.ExternalSecretDataRemoteRef{Key: secretID, Property: k2})
  777. tassert.Nil(t, err)
  778. tassert.Equal(t, v2, data)
  779. }
  780. func TestGetSecretWithInvalidFetchingPolicy(t *testing.T) {
  781. ctx := context.Background()
  782. namespace := uuid.NewString()
  783. authorizedKey := newFakeAuthorizedKey()
  784. fakeClock := clock.NewFakeClock()
  785. fakeLockboxServer := client.NewFakeLockboxServer(fakeClock, time.Hour)
  786. k8sClient := clientfake.NewClientBuilder().Build()
  787. const authorizedKeySecretName = "authorizedKeySecretName"
  788. const authorizedKeySecretKey = "authorizedKeySecretKey"
  789. err := createK8sSecret(
  790. ctx, t, k8sClient, namespace,
  791. authorizedKeySecretName, authorizedKeySecretKey,
  792. toJSON(t, authorizedKey),
  793. )
  794. tassert.Nil(t, err)
  795. store := &esv1.SecretStore{
  796. ObjectMeta: metav1.ObjectMeta{Namespace: namespace},
  797. Spec: esv1.SecretStoreSpec{
  798. Provider: &esv1.SecretStoreProvider{
  799. YandexLockbox: &esv1.YandexLockboxProvider{
  800. Auth: esv1.YandexAuth{
  801. AuthorizedKey: esmeta.SecretKeySelector{
  802. Name: authorizedKeySecretName,
  803. Key: authorizedKeySecretKey,
  804. },
  805. },
  806. FetchingPolicy: &esv1.FetchingPolicy{
  807. ByID: nil,
  808. ByName: nil,
  809. },
  810. },
  811. },
  812. },
  813. }
  814. provider := newLockboxProvider(fakeClock, fakeLockboxServer)
  815. _, err = provider.NewClient(ctx, store, k8sClient, namespace)
  816. tassert.EqualError(
  817. t,
  818. err,
  819. "invalid Yandex Lockbox SecretStore: requires either 'byName' or 'byID' policy",
  820. )
  821. }
  822. // helper fuxnctions
  823. func newLockboxProvider(clock clock.Clock, fakeLockboxServer *client.FakeLockboxServer) *common.YandexCloudProvider {
  824. return common.InitYandexCloudProvider(
  825. ctrl.Log.WithName("provider").WithName("yandex").WithName("lockbox"),
  826. clock,
  827. adaptInput,
  828. func(ctx context.Context, apiEndpoint string, authorizedKey *iamkey.Key, caCertificate []byte) (common.SecretGetter, error) {
  829. return newLockboxSecretGetter(client.NewFakeLockboxClient(fakeLockboxServer))
  830. },
  831. func(ctx context.Context, apiEndpoint string, authorizedKey *iamkey.Key, caCertificate []byte) (*common.IamToken, error) {
  832. return fakeLockboxServer.NewIamToken(authorizedKey), nil
  833. },
  834. 0,
  835. )
  836. }
  837. func newYandexLockboxSecretStore(apiEndpoint, namespace, authorizedKeySecretName, authorizedKeySecretKey string) esv1.GenericStore {
  838. return &esv1.SecretStore{
  839. ObjectMeta: metav1.ObjectMeta{
  840. Namespace: namespace,
  841. },
  842. Spec: esv1.SecretStoreSpec{
  843. Provider: &esv1.SecretStoreProvider{
  844. YandexLockbox: &esv1.YandexLockboxProvider{
  845. APIEndpoint: apiEndpoint,
  846. Auth: esv1.YandexAuth{
  847. AuthorizedKey: esmeta.SecretKeySelector{
  848. Name: authorizedKeySecretName,
  849. Key: authorizedKeySecretKey,
  850. },
  851. },
  852. },
  853. },
  854. },
  855. }
  856. }
  857. func newYandexLockboxSecretStoreWithFetchByName(apiEndpoint, namespace, authorizedKeySecretName, authorizedKeySecretKey, folderID string) esv1.GenericStore {
  858. return &esv1.SecretStore{
  859. ObjectMeta: metav1.ObjectMeta{
  860. Namespace: namespace,
  861. },
  862. Spec: esv1.SecretStoreSpec{
  863. Provider: &esv1.SecretStoreProvider{
  864. YandexLockbox: &esv1.YandexLockboxProvider{
  865. APIEndpoint: apiEndpoint,
  866. Auth: esv1.YandexAuth{
  867. AuthorizedKey: esmeta.SecretKeySelector{
  868. Name: authorizedKeySecretName,
  869. Key: authorizedKeySecretKey,
  870. },
  871. },
  872. FetchingPolicy: &esv1.FetchingPolicy{
  873. ByName: &esv1.ByName{
  874. FolderID: folderID,
  875. },
  876. },
  877. },
  878. },
  879. },
  880. }
  881. }
  882. func newYandexLockboxSecretStoreWithFetchByID(apiEndpoint, namespace, authorizedKeySecretName, authorizedKeySecretKey string) esv1.GenericStore {
  883. return &esv1.SecretStore{
  884. ObjectMeta: metav1.ObjectMeta{
  885. Namespace: namespace,
  886. },
  887. Spec: esv1.SecretStoreSpec{
  888. Provider: &esv1.SecretStoreProvider{
  889. YandexLockbox: &esv1.YandexLockboxProvider{
  890. APIEndpoint: apiEndpoint,
  891. Auth: esv1.YandexAuth{
  892. AuthorizedKey: esmeta.SecretKeySelector{
  893. Name: authorizedKeySecretName,
  894. Key: authorizedKeySecretKey,
  895. },
  896. },
  897. FetchingPolicy: &esv1.FetchingPolicy{
  898. ByID: &esv1.ByID{},
  899. },
  900. },
  901. },
  902. },
  903. }
  904. }
  905. func toJSON(t *testing.T, v any) []byte {
  906. jsonBytes, err := json.Marshal(v)
  907. tassert.Nil(t, err)
  908. return jsonBytes
  909. }
  910. func createK8sSecret(ctx context.Context, t *testing.T, k8sClient k8sclient.Client, namespace, secretName, secretKey string, secretValue []byte) error {
  911. err := k8sClient.Create(ctx, &corev1.Secret{
  912. ObjectMeta: metav1.ObjectMeta{
  913. Namespace: namespace,
  914. Name: secretName,
  915. },
  916. Data: map[string][]byte{secretKey: secretValue},
  917. })
  918. tassert.Nil(t, err)
  919. return nil
  920. }
  921. func newFakeAuthorizedKey() *iamkey.Key {
  922. uniqueLabel := uuid.NewString()
  923. return &iamkey.Key{
  924. Id: uniqueLabel,
  925. Subject: &iamkey.Key_ServiceAccountId{
  926. ServiceAccountId: uniqueLabel,
  927. },
  928. PrivateKey: uniqueLabel,
  929. }
  930. }
  931. func textEntry(key, value string) *lockbox.Payload_Entry {
  932. return &lockbox.Payload_Entry{
  933. Key: key,
  934. Value: &lockbox.Payload_Entry_TextValue{
  935. TextValue: value,
  936. },
  937. }
  938. }
  939. func binaryEntry(key string, value []byte) *lockbox.Payload_Entry {
  940. return &lockbox.Payload_Entry{
  941. Key: key,
  942. Value: &lockbox.Payload_Entry_BinaryValue{
  943. BinaryValue: value,
  944. },
  945. }
  946. }
  947. func unmarshalStringMap(t *testing.T, data []byte) map[string]string {
  948. stringMap := make(map[string]string)
  949. err := json.Unmarshal(data, &stringMap)
  950. tassert.Nil(t, err)
  951. return stringMap
  952. }
  953. func base64(data []byte) string {
  954. return b64.StdEncoding.EncodeToString(data)
  955. }