vault.go 34 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188
  1. /*
  2. Licensed under the Apache License, Version 2.0 (the "License");
  3. you may not use this file except in compliance with the License.
  4. You may obtain a copy of the License at
  5. http://www.apache.org/licenses/LICENSE-2.0
  6. Unless required by applicable law or agreed to in writing, software
  7. distributed under the License is distributed on an "AS IS" BASIS,
  8. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  9. See the License for the specific language governing permissions and
  10. limitations under the License.
  11. */
  12. package vault
  13. import (
  14. "context"
  15. "crypto/tls"
  16. "crypto/x509"
  17. "encoding/json"
  18. "errors"
  19. "fmt"
  20. "net/http"
  21. "os"
  22. "strconv"
  23. "strings"
  24. "github.com/go-logr/logr"
  25. vault "github.com/hashicorp/vault/api"
  26. approle "github.com/hashicorp/vault/api/auth/approle"
  27. authkubernetes "github.com/hashicorp/vault/api/auth/kubernetes"
  28. authldap "github.com/hashicorp/vault/api/auth/ldap"
  29. "github.com/tidwall/gjson"
  30. authenticationv1 "k8s.io/api/authentication/v1"
  31. corev1 "k8s.io/api/core/v1"
  32. metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
  33. "k8s.io/apimachinery/pkg/types"
  34. "k8s.io/client-go/kubernetes"
  35. typedcorev1 "k8s.io/client-go/kubernetes/typed/core/v1"
  36. ctrl "sigs.k8s.io/controller-runtime"
  37. kclient "sigs.k8s.io/controller-runtime/pkg/client"
  38. ctrlcfg "sigs.k8s.io/controller-runtime/pkg/client/config"
  39. esv1beta1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1beta1"
  40. esmeta "github.com/external-secrets/external-secrets/apis/meta/v1"
  41. "github.com/external-secrets/external-secrets/pkg/find"
  42. "github.com/external-secrets/external-secrets/pkg/utils"
  43. )
  44. var (
  45. _ esv1beta1.Provider = &connector{}
  46. _ esv1beta1.SecretsClient = &client{}
  47. )
  48. const (
  49. serviceAccTokenPath = "/var/run/secrets/kubernetes.io/serviceaccount/token"
  50. errVaultStore = "received invalid Vault SecretStore resource: %w"
  51. errVaultClient = "cannot setup new vault client: %w"
  52. errVaultCert = "cannot set Vault CA certificate: %w"
  53. errReadSecret = "cannot read secret data from Vault: %w"
  54. errAuthFormat = "cannot initialize Vault client: no valid auth method specified"
  55. errInvalidCredentials = "invalid vault credentials: %w"
  56. errDataField = "failed to find data field"
  57. errJSONUnmarshall = "failed to unmarshall JSON"
  58. errPathInvalid = "provided Path isn't a valid kv v2 path"
  59. errSecretFormat = "secret data not in expected format"
  60. errUnexpectedKey = "unexpected key in data: %s"
  61. errVaultToken = "cannot parse Vault authentication token: %w"
  62. errVaultRequest = "error from Vault request: %w"
  63. errServiceAccount = "cannot read Kubernetes service account token from file system: %w"
  64. errJwtNoTokenSource = "neither `secretRef` nor `kubernetesServiceAccountToken` was supplied as token source for jwt authentication"
  65. errUnsupportedKvVersion = "cannot perform find operations with kv version v1"
  66. errNotFound = "secret not found"
  67. errGetKubeSA = "cannot get Kubernetes service account %q: %w"
  68. errGetKubeSASecrets = "cannot find secrets bound to service account: %q"
  69. errGetKubeSANoToken = "cannot find token in secrets bound to service account: %q"
  70. errGetKubeSATokenRequest = "cannot request Kubernetes service account token for service account %q: %w"
  71. errGetKubeSecret = "cannot get Kubernetes secret %q: %w"
  72. errSecretKeyFmt = "cannot find secret data for key: %q"
  73. errConfigMapFmt = "cannot find config map data for key: %q"
  74. errClientTLSAuth = "error from Client TLS Auth: %q"
  75. errVaultRevokeToken = "error while revoking token: %w"
  76. errUnknownCAProvider = "unknown caProvider type given"
  77. errCANamespace = "cannot read secret for CAProvider due to missing namespace on kind ClusterSecretStore"
  78. errInvalidStore = "invalid store"
  79. errInvalidStoreSpec = "invalid store spec"
  80. errInvalidStoreProv = "invalid store provider"
  81. errInvalidVaultProv = "invalid vault provider"
  82. errInvalidAppRoleSec = "invalid Auth.AppRole.SecretRef: %w"
  83. errInvalidClientCert = "invalid Auth.Cert.ClientCert: %w"
  84. errInvalidCertSec = "invalid Auth.Cert.SecretRef: %w"
  85. errInvalidJwtSec = "invalid Auth.Jwt.SecretRef: %w"
  86. errInvalidJwtK8sSA = "invalid Auth.Jwt.KubernetesServiceAccountToken.ServiceAccountRef: %w"
  87. errInvalidKubeSA = "invalid Auth.Kubernetes.ServiceAccountRef: %w"
  88. errInvalidKubeSec = "invalid Auth.Kubernetes.SecretRef: %w"
  89. errInvalidLdapSec = "invalid Auth.Ldap.SecretRef: %w"
  90. errInvalidTokenRef = "invalid Auth.TokenSecretRef: %w"
  91. )
  92. // https://github.com/external-secrets/external-secrets/issues/644
  93. var _ esv1beta1.SecretsClient = &client{}
  94. var _ esv1beta1.Provider = &connector{}
  95. type Auth interface {
  96. Login(ctx context.Context, authMethod vault.AuthMethod) (*vault.Secret, error)
  97. }
  98. type Token interface {
  99. RevokeSelfWithContext(ctx context.Context, token string) error
  100. LookupSelfWithContext(ctx context.Context) (*vault.Secret, error)
  101. }
  102. type Logical interface {
  103. ReadWithDataWithContext(ctx context.Context, path string, data map[string][]string) (*vault.Secret, error)
  104. ListWithContext(ctx context.Context, path string) (*vault.Secret, error)
  105. WriteWithContext(ctx context.Context, path string, data map[string]interface{}) (*vault.Secret, error)
  106. }
  107. type Client interface {
  108. SetToken(v string)
  109. Token() string
  110. ClearToken()
  111. Auth() Auth
  112. Logical() Logical
  113. AuthToken() Token
  114. SetNamespace(namespace string)
  115. AddHeader(key, value string)
  116. }
  117. type VClient struct {
  118. setToken func(v string)
  119. token func() string
  120. clearToken func()
  121. auth Auth
  122. logical Logical
  123. authToken Token
  124. setNamespace func(namespace string)
  125. addHeader func(key, value string)
  126. }
  127. func (v VClient) AddHeader(key, value string) {
  128. v.addHeader(key, value)
  129. }
  130. func (v VClient) SetNamespace(namespace string) {
  131. v.setNamespace(namespace)
  132. }
  133. func (v VClient) ClearToken() {
  134. v.clearToken()
  135. }
  136. func (v VClient) Token() string {
  137. return v.token()
  138. }
  139. func (v VClient) SetToken(token string) {
  140. v.setToken(token)
  141. }
  142. func (v VClient) Auth() Auth {
  143. return v.auth
  144. }
  145. func (v VClient) AuthToken() Token {
  146. return v.authToken
  147. }
  148. func (v VClient) Logical() Logical {
  149. return v.logical
  150. }
  151. type client struct {
  152. kube kclient.Client
  153. store *esv1beta1.VaultProvider
  154. log logr.Logger
  155. corev1 typedcorev1.CoreV1Interface
  156. client Client
  157. auth Auth
  158. logical Logical
  159. token Token
  160. namespace string
  161. storeKind string
  162. }
  163. func init() {
  164. esv1beta1.Register(&connector{
  165. newVaultClient: newVaultClient,
  166. }, &esv1beta1.SecretStoreProvider{
  167. Vault: &esv1beta1.VaultProvider{},
  168. })
  169. }
  170. func newVaultClient(c *vault.Config) (Client, error) {
  171. cl, err := vault.NewClient(c)
  172. if err != nil {
  173. return nil, err
  174. }
  175. auth := cl.Auth()
  176. logical := cl.Logical()
  177. token := cl.Auth().Token()
  178. out := VClient{
  179. setToken: cl.SetToken,
  180. token: cl.Token,
  181. clearToken: cl.ClearToken,
  182. auth: auth,
  183. authToken: token,
  184. logical: logical,
  185. setNamespace: cl.SetNamespace,
  186. addHeader: cl.AddHeader,
  187. }
  188. return out, nil
  189. }
  190. type connector struct {
  191. newVaultClient func(c *vault.Config) (Client, error)
  192. }
  193. func (c *connector) NewClient(ctx context.Context, store esv1beta1.GenericStore, kube kclient.Client, namespace string) (esv1beta1.SecretsClient, error) {
  194. // controller-runtime/client does not support TokenRequest or other subresource APIs
  195. // so we need to construct our own client and use it to fetch tokens
  196. // (for Kubernetes service account token auth)
  197. restCfg, err := ctrlcfg.GetConfig()
  198. if err != nil {
  199. return nil, err
  200. }
  201. clientset, err := kubernetes.NewForConfig(restCfg)
  202. if err != nil {
  203. return nil, err
  204. }
  205. return c.newClient(ctx, store, kube, clientset.CoreV1(), namespace)
  206. }
  207. func (c *connector) newClient(ctx context.Context, store esv1beta1.GenericStore, kube kclient.Client, corev1 typedcorev1.CoreV1Interface, namespace string) (esv1beta1.SecretsClient, error) {
  208. storeSpec := store.GetSpec()
  209. if storeSpec == nil || storeSpec.Provider == nil || storeSpec.Provider.Vault == nil {
  210. return nil, errors.New(errVaultStore)
  211. }
  212. vaultSpec := storeSpec.Provider.Vault
  213. vStore := &client{
  214. kube: kube,
  215. corev1: corev1,
  216. store: vaultSpec,
  217. log: ctrl.Log.WithName("provider").WithName("vault"),
  218. namespace: namespace,
  219. storeKind: store.GetObjectKind().GroupVersionKind().Kind,
  220. }
  221. cfg, err := vStore.newConfig()
  222. if err != nil {
  223. return nil, err
  224. }
  225. client, err := c.newVaultClient(cfg)
  226. if err != nil {
  227. return nil, fmt.Errorf(errVaultClient, err)
  228. }
  229. if vaultSpec.Namespace != nil {
  230. client.SetNamespace(*vaultSpec.Namespace)
  231. }
  232. if vaultSpec.ReadYourWrites && vaultSpec.ForwardInconsistent {
  233. client.AddHeader("X-Vault-Inconsistent", "forward-active-node")
  234. }
  235. vStore.client = client
  236. vStore.auth = client.Auth()
  237. vStore.logical = client.Logical()
  238. vStore.token = client.AuthToken()
  239. // allow SecretStore controller validation to pass
  240. // when using referent namespace.
  241. if vStore.storeKind == esv1beta1.ClusterSecretStoreKind && vStore.namespace == "" && isReferentSpec(vaultSpec) {
  242. return vStore, nil
  243. }
  244. if err := vStore.setAuth(ctx, cfg); err != nil {
  245. return nil, err
  246. }
  247. return vStore, nil
  248. }
  249. func (c *connector) ValidateStore(store esv1beta1.GenericStore) error {
  250. if store == nil {
  251. return fmt.Errorf(errInvalidStore)
  252. }
  253. spc := store.GetSpec()
  254. if spc == nil {
  255. return fmt.Errorf(errInvalidStoreSpec)
  256. }
  257. if spc.Provider == nil {
  258. return fmt.Errorf(errInvalidStoreProv)
  259. }
  260. p := spc.Provider.Vault
  261. if p == nil {
  262. return fmt.Errorf(errInvalidVaultProv)
  263. }
  264. if p.Auth.AppRole != nil {
  265. if err := utils.ValidateReferentSecretSelector(store, p.Auth.AppRole.SecretRef); err != nil {
  266. return fmt.Errorf(errInvalidAppRoleSec, err)
  267. }
  268. }
  269. if p.Auth.Cert != nil {
  270. if err := utils.ValidateReferentSecretSelector(store, p.Auth.Cert.ClientCert); err != nil {
  271. return fmt.Errorf(errInvalidClientCert, err)
  272. }
  273. if err := utils.ValidateReferentSecretSelector(store, p.Auth.Cert.SecretRef); err != nil {
  274. return fmt.Errorf(errInvalidCertSec, err)
  275. }
  276. }
  277. if p.Auth.Jwt != nil {
  278. if p.Auth.Jwt.SecretRef != nil {
  279. if err := utils.ValidateReferentSecretSelector(store, *p.Auth.Jwt.SecretRef); err != nil {
  280. return fmt.Errorf(errInvalidJwtSec, err)
  281. }
  282. } else if p.Auth.Jwt.KubernetesServiceAccountToken != nil {
  283. if err := utils.ValidateReferentServiceAccountSelector(store, p.Auth.Jwt.KubernetesServiceAccountToken.ServiceAccountRef); err != nil {
  284. return fmt.Errorf(errInvalidJwtK8sSA, err)
  285. }
  286. } else {
  287. return fmt.Errorf(errJwtNoTokenSource)
  288. }
  289. }
  290. if p.Auth.Kubernetes != nil {
  291. if p.Auth.Kubernetes.ServiceAccountRef != nil {
  292. if err := utils.ValidateReferentServiceAccountSelector(store, *p.Auth.Kubernetes.ServiceAccountRef); err != nil {
  293. return fmt.Errorf(errInvalidKubeSA, err)
  294. }
  295. }
  296. if p.Auth.Kubernetes.SecretRef != nil {
  297. if err := utils.ValidateReferentSecretSelector(store, *p.Auth.Kubernetes.SecretRef); err != nil {
  298. return fmt.Errorf(errInvalidKubeSec, err)
  299. }
  300. }
  301. }
  302. if p.Auth.Ldap != nil {
  303. if err := utils.ValidateReferentSecretSelector(store, p.Auth.Ldap.SecretRef); err != nil {
  304. return fmt.Errorf(errInvalidLdapSec, err)
  305. }
  306. }
  307. if p.Auth.TokenSecretRef != nil {
  308. if err := utils.ValidateReferentSecretSelector(store, *p.Auth.TokenSecretRef); err != nil {
  309. return fmt.Errorf(errInvalidTokenRef, err)
  310. }
  311. }
  312. return nil
  313. }
  314. // Empty GetAllSecrets.
  315. // GetAllSecrets
  316. // First load all secrets from secretStore path configuration.
  317. // Then, gets secrets from a matching name or matching custom_metadata.
  318. func (v *client) GetAllSecrets(ctx context.Context, ref esv1beta1.ExternalSecretFind) (map[string][]byte, error) {
  319. if v.store.Version == esv1beta1.VaultKVStoreV1 {
  320. return nil, errors.New(errUnsupportedKvVersion)
  321. }
  322. searchPath := ""
  323. if ref.Path != nil {
  324. searchPath = *ref.Path + "/"
  325. }
  326. potentialSecrets, err := v.listSecrets(ctx, searchPath)
  327. if err != nil {
  328. return nil, err
  329. }
  330. if ref.Name != nil {
  331. return v.findSecretsFromName(ctx, potentialSecrets, *ref.Name)
  332. }
  333. return v.findSecretsFromTags(ctx, potentialSecrets, ref.Tags)
  334. }
  335. func (v *client) findSecretsFromTags(ctx context.Context, candidates []string, tags map[string]string) (map[string][]byte, error) {
  336. secrets := make(map[string][]byte)
  337. for _, name := range candidates {
  338. match := true
  339. metadata, err := v.readSecretMetadata(ctx, name)
  340. if err != nil {
  341. return nil, err
  342. }
  343. for tk, tv := range tags {
  344. p, ok := metadata[tk]
  345. if !ok || p != tv {
  346. match = false
  347. break
  348. }
  349. }
  350. if match {
  351. secret, err := v.GetSecret(ctx, esv1beta1.ExternalSecretDataRemoteRef{Key: name})
  352. if err != nil {
  353. return nil, err
  354. }
  355. secrets[name] = secret
  356. }
  357. }
  358. return secrets, nil
  359. }
  360. func (v *client) findSecretsFromName(ctx context.Context, candidates []string, ref esv1beta1.FindName) (map[string][]byte, error) {
  361. secrets := make(map[string][]byte)
  362. matcher, err := find.New(ref)
  363. if err != nil {
  364. return nil, err
  365. }
  366. for _, name := range candidates {
  367. ok := matcher.MatchName(name)
  368. if ok {
  369. secret, err := v.GetSecret(ctx, esv1beta1.ExternalSecretDataRemoteRef{Key: name})
  370. if err != nil {
  371. return nil, err
  372. }
  373. secrets[name] = secret
  374. }
  375. }
  376. return secrets, nil
  377. }
  378. func (v *client) listSecrets(ctx context.Context, path string) ([]string, error) {
  379. secrets := make([]string, 0)
  380. url, err := v.buildMetadataPath(path)
  381. if err != nil {
  382. return nil, err
  383. }
  384. secret, err := v.logical.ListWithContext(ctx, url)
  385. if err != nil {
  386. return nil, fmt.Errorf(errReadSecret, err)
  387. }
  388. if secret == nil {
  389. return nil, fmt.Errorf("provided path %v does not contain any secrets", url)
  390. }
  391. t, ok := secret.Data["keys"]
  392. if !ok {
  393. return nil, nil
  394. }
  395. paths := t.([]interface{})
  396. for _, p := range paths {
  397. strPath := p.(string)
  398. fullPath := path + strPath // because path always ends with a /
  399. if path == "" {
  400. fullPath = strPath
  401. }
  402. // Recurrently find secrets
  403. if !strings.HasSuffix(p.(string), "/") {
  404. secrets = append(secrets, fullPath)
  405. } else {
  406. partial, err := v.listSecrets(ctx, fullPath)
  407. if err != nil {
  408. return nil, err
  409. }
  410. secrets = append(secrets, partial...)
  411. }
  412. }
  413. return secrets, nil
  414. }
  415. func (v *client) readSecretMetadata(ctx context.Context, path string) (map[string]string, error) {
  416. metadata := make(map[string]string)
  417. url, err := v.buildMetadataPath(path)
  418. if err != nil {
  419. return nil, err
  420. }
  421. secret, err := v.logical.ReadWithDataWithContext(ctx, url, nil)
  422. if err != nil {
  423. return nil, fmt.Errorf(errReadSecret, err)
  424. }
  425. if secret == nil {
  426. return nil, errors.New(errNotFound)
  427. }
  428. t, ok := secret.Data["custom_metadata"]
  429. if !ok {
  430. return nil, nil
  431. }
  432. d, ok := t.(map[string]interface{})
  433. if !ok {
  434. return metadata, nil
  435. }
  436. for k, v := range d {
  437. metadata[k] = v.(string)
  438. }
  439. return metadata, nil
  440. }
  441. // GetSecret supports two types:
  442. // 1. get the full secret as json-encoded value
  443. // by leaving the ref.Property empty.
  444. // 2. get a key from the secret.
  445. // Nested values are supported by specifying a gjson expression
  446. func (v *client) GetSecret(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) ([]byte, error) {
  447. data, err := v.readSecret(ctx, ref.Key, ref.Version)
  448. if err != nil {
  449. return nil, err
  450. }
  451. jsonStr, err := json.Marshal(data)
  452. if err != nil {
  453. return nil, err
  454. }
  455. // (1): return raw json if no property is defined
  456. if ref.Property == "" {
  457. return jsonStr, nil
  458. }
  459. // For backwards compatibility we want the
  460. // actual keys to take precedence over gjson syntax
  461. // (2): extract key from secret with property
  462. if _, ok := data[ref.Property]; ok {
  463. return getTypedKey(data, ref.Property)
  464. }
  465. // (3): extract key from secret using gjson
  466. val := gjson.Get(string(jsonStr), ref.Property)
  467. if !val.Exists() {
  468. return nil, fmt.Errorf(errSecretKeyFmt, ref.Property)
  469. }
  470. return []byte(val.String()), nil
  471. }
  472. // GetSecretMap supports two modes of operation:
  473. // 1. get the full secret from the vault data payload (by leaving .property empty).
  474. // 2. extract key/value pairs from a (nested) object.
  475. func (v *client) GetSecretMap(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) (map[string][]byte, error) {
  476. data, err := v.GetSecret(ctx, ref)
  477. if err != nil {
  478. return nil, err
  479. }
  480. var secretData map[string]interface{}
  481. err = json.Unmarshal(data, &secretData)
  482. if err != nil {
  483. return nil, err
  484. }
  485. byteMap := make(map[string][]byte, len(secretData))
  486. for k := range secretData {
  487. byteMap[k], err = getTypedKey(secretData, k)
  488. if err != nil {
  489. return nil, err
  490. }
  491. }
  492. return byteMap, nil
  493. }
  494. func getTypedKey(data map[string]interface{}, key string) ([]byte, error) {
  495. v, ok := data[key]
  496. if !ok {
  497. return nil, fmt.Errorf(errUnexpectedKey, key)
  498. }
  499. switch t := v.(type) {
  500. case string:
  501. return []byte(t), nil
  502. case map[string]interface{}:
  503. return json.Marshal(t)
  504. case []byte:
  505. return t, nil
  506. // also covers int and float32 due to json.Marshal
  507. case float64:
  508. return []byte(strconv.FormatFloat(t, 'f', -1, 64)), nil
  509. case bool:
  510. return []byte(strconv.FormatBool(t)), nil
  511. case nil:
  512. return []byte(nil), nil
  513. default:
  514. return nil, errors.New(errSecretFormat)
  515. }
  516. }
  517. func (v *client) Close(ctx context.Context) error {
  518. // Revoke the token if we have one set and it wasn't sourced from a TokenSecretRef
  519. if v.client.Token() != "" && v.store.Auth.TokenSecretRef == nil {
  520. revoke, err := checkToken(ctx, v)
  521. if err != nil {
  522. return fmt.Errorf(errVaultRevokeToken, err)
  523. }
  524. if revoke {
  525. err = v.token.RevokeSelfWithContext(ctx, v.client.Token())
  526. if err != nil {
  527. return fmt.Errorf(errVaultRevokeToken, err)
  528. }
  529. v.client.ClearToken()
  530. }
  531. }
  532. return nil
  533. }
  534. func isReferentSpec(prov *esv1beta1.VaultProvider) bool {
  535. if prov.Auth.TokenSecretRef != nil && prov.Auth.TokenSecretRef.Namespace == nil {
  536. return true
  537. }
  538. if prov.Auth.AppRole != nil && prov.Auth.AppRole.SecretRef.Namespace == nil {
  539. return true
  540. }
  541. if prov.Auth.Kubernetes != nil && prov.Auth.Kubernetes.SecretRef != nil && prov.Auth.Kubernetes.SecretRef.Namespace == nil {
  542. return true
  543. }
  544. if prov.Auth.Kubernetes != nil && prov.Auth.Kubernetes.ServiceAccountRef != nil && prov.Auth.Kubernetes.ServiceAccountRef.Namespace == nil {
  545. return true
  546. }
  547. if prov.Auth.Ldap != nil && prov.Auth.Ldap.SecretRef.Namespace == nil {
  548. return true
  549. }
  550. if prov.Auth.Jwt != nil && prov.Auth.Jwt.SecretRef != nil && prov.Auth.Jwt.SecretRef.Namespace == nil {
  551. return true
  552. }
  553. if prov.Auth.Jwt != nil && prov.Auth.Jwt.KubernetesServiceAccountToken != nil && prov.Auth.Jwt.KubernetesServiceAccountToken.ServiceAccountRef.Namespace == nil {
  554. return true
  555. }
  556. if prov.Auth.Cert != nil && prov.Auth.Cert.SecretRef.Namespace == nil {
  557. return true
  558. }
  559. return false
  560. }
  561. func (v *client) Validate() (esv1beta1.ValidationResult, error) {
  562. // when using referent namespace we can not validate the token
  563. // because the namespace is not known yet when Validate() is called
  564. // from the SecretStore controller.
  565. if v.storeKind == esv1beta1.ClusterSecretStoreKind && isReferentSpec(v.store) {
  566. return esv1beta1.ValidationResultUnknown, nil
  567. }
  568. _, err := checkToken(context.Background(), v)
  569. if err != nil {
  570. return esv1beta1.ValidationResultError, fmt.Errorf(errInvalidCredentials, err)
  571. }
  572. return esv1beta1.ValidationResultReady, nil
  573. }
  574. func (v *client) buildMetadataPath(path string) (string, error) {
  575. var url string
  576. if v.store.Path == nil && !strings.Contains(path, "data") {
  577. return "", fmt.Errorf(errPathInvalid)
  578. }
  579. if v.store.Path == nil {
  580. path = strings.Replace(path, "data", "metadata", 1)
  581. url = path
  582. } else {
  583. url = fmt.Sprintf("%s/metadata/%s", *v.store.Path, path)
  584. }
  585. return url, nil
  586. }
  587. func (v *client) buildPath(path string) string {
  588. optionalMount := v.store.Path
  589. origPath := strings.Split(path, "/")
  590. newPath := make([]string, 0)
  591. cursor := 0
  592. if optionalMount != nil && origPath[0] != *optionalMount {
  593. // Default case before path was optional
  594. // Ensure that the requested path includes the SecretStores paths as prefix
  595. newPath = append(newPath, *optionalMount)
  596. } else {
  597. newPath = append(newPath, origPath[cursor])
  598. cursor++
  599. }
  600. if v.store.Version == esv1beta1.VaultKVStoreV2 {
  601. // Add the required `data` part of the URL for the v2 API
  602. if len(origPath) < 2 || origPath[1] != "data" {
  603. newPath = append(newPath, "data")
  604. }
  605. }
  606. newPath = append(newPath, origPath[cursor:]...)
  607. returnPath := strings.Join(newPath, "/")
  608. return returnPath
  609. }
  610. func (v *client) readSecret(ctx context.Context, path, version string) (map[string]interface{}, error) {
  611. dataPath := v.buildPath(path)
  612. // path formated according to vault docs for v1 and v2 API
  613. // v1: https://www.vaultproject.io/api-docs/secret/kv/kv-v1#read-secret
  614. // v2: https://www.vaultproject.io/api/secret/kv/kv-v2#read-secret-version
  615. var params map[string][]string
  616. if version != "" {
  617. params = make(map[string][]string)
  618. params["version"] = []string{version}
  619. }
  620. vaultSecret, err := v.logical.ReadWithDataWithContext(ctx, dataPath, params)
  621. if err != nil {
  622. return nil, fmt.Errorf(errReadSecret, err)
  623. }
  624. if vaultSecret == nil {
  625. return nil, errors.New(errNotFound)
  626. }
  627. secretData := vaultSecret.Data
  628. if v.store.Version == esv1beta1.VaultKVStoreV2 {
  629. // Vault KV2 has data embedded within sub-field
  630. // reference - https://www.vaultproject.io/api/secret/kv/kv-v2#read-secret-version
  631. dataInt, ok := vaultSecret.Data["data"]
  632. if !ok {
  633. return nil, errors.New(errDataField)
  634. }
  635. secretData, ok = dataInt.(map[string]interface{})
  636. if !ok {
  637. return nil, errors.New(errJSONUnmarshall)
  638. }
  639. }
  640. return secretData, nil
  641. }
  642. func (v *client) newConfig() (*vault.Config, error) {
  643. cfg := vault.DefaultConfig()
  644. cfg.Address = v.store.Server
  645. // In a controller-runtime context, we rely on the reconciliation process for retrying
  646. cfg.MaxRetries = 0
  647. if len(v.store.CABundle) == 0 && v.store.CAProvider == nil {
  648. return cfg, nil
  649. }
  650. caCertPool := x509.NewCertPool()
  651. if len(v.store.CABundle) > 0 {
  652. ok := caCertPool.AppendCertsFromPEM(v.store.CABundle)
  653. if !ok {
  654. return nil, errors.New(errVaultCert)
  655. }
  656. }
  657. if v.store.CAProvider != nil && v.storeKind == esv1beta1.ClusterSecretStoreKind && v.store.CAProvider.Namespace == nil {
  658. return nil, errors.New(errCANamespace)
  659. }
  660. if v.store.CAProvider != nil {
  661. var cert []byte
  662. var err error
  663. switch v.store.CAProvider.Type {
  664. case esv1beta1.CAProviderTypeSecret:
  665. cert, err = getCertFromSecret(v)
  666. case esv1beta1.CAProviderTypeConfigMap:
  667. cert, err = getCertFromConfigMap(v)
  668. default:
  669. return nil, errors.New(errUnknownCAProvider)
  670. }
  671. if err != nil {
  672. return nil, err
  673. }
  674. ok := caCertPool.AppendCertsFromPEM(cert)
  675. if !ok {
  676. return nil, errors.New(errVaultCert)
  677. }
  678. }
  679. if transport, ok := cfg.HttpClient.Transport.(*http.Transport); ok {
  680. transport.TLSClientConfig.RootCAs = caCertPool
  681. }
  682. // If either read-after-write consistency feature is enabled, enable ReadYourWrites
  683. cfg.ReadYourWrites = v.store.ReadYourWrites || v.store.ForwardInconsistent
  684. return cfg, nil
  685. }
  686. func getCertFromSecret(v *client) ([]byte, error) {
  687. secretRef := esmeta.SecretKeySelector{
  688. Name: v.store.CAProvider.Name,
  689. Key: v.store.CAProvider.Key,
  690. }
  691. if v.store.CAProvider.Namespace != nil {
  692. secretRef.Namespace = v.store.CAProvider.Namespace
  693. }
  694. ctx := context.Background()
  695. res, err := v.secretKeyRef(ctx, &secretRef)
  696. if err != nil {
  697. return nil, fmt.Errorf(errVaultCert, err)
  698. }
  699. return []byte(res), nil
  700. }
  701. func getCertFromConfigMap(v *client) ([]byte, error) {
  702. objKey := types.NamespacedName{
  703. Name: v.store.CAProvider.Name,
  704. }
  705. if v.store.CAProvider.Namespace != nil {
  706. objKey.Namespace = *v.store.CAProvider.Namespace
  707. }
  708. configMapRef := &corev1.ConfigMap{}
  709. ctx := context.Background()
  710. err := v.kube.Get(ctx, objKey, configMapRef)
  711. if err != nil {
  712. return nil, fmt.Errorf(errVaultCert, err)
  713. }
  714. val, ok := configMapRef.Data[v.store.CAProvider.Key]
  715. if !ok {
  716. return nil, fmt.Errorf(errConfigMapFmt, v.store.CAProvider.Key)
  717. }
  718. return []byte(val), nil
  719. }
  720. func (v *client) setAuth(ctx context.Context, cfg *vault.Config) error {
  721. tokenExists, err := setSecretKeyToken(ctx, v)
  722. if tokenExists {
  723. return err
  724. }
  725. tokenExists, err = setAppRoleToken(ctx, v)
  726. if tokenExists {
  727. return err
  728. }
  729. tokenExists, err = setKubernetesAuthToken(ctx, v)
  730. if tokenExists {
  731. return err
  732. }
  733. tokenExists, err = setLdapAuthToken(ctx, v)
  734. if tokenExists {
  735. return err
  736. }
  737. tokenExists, err = setJwtAuthToken(ctx, v)
  738. if tokenExists {
  739. return err
  740. }
  741. tokenExists, err = setCertAuthToken(ctx, v, cfg)
  742. if tokenExists {
  743. return err
  744. }
  745. return errors.New(errAuthFormat)
  746. }
  747. func setAppRoleToken(ctx context.Context, v *client) (bool, error) {
  748. tokenRef := v.store.Auth.TokenSecretRef
  749. if tokenRef != nil {
  750. token, err := v.secretKeyRef(ctx, tokenRef)
  751. if err != nil {
  752. return true, err
  753. }
  754. v.client.SetToken(token)
  755. return true, nil
  756. }
  757. return false, nil
  758. }
  759. func setSecretKeyToken(ctx context.Context, v *client) (bool, error) {
  760. appRole := v.store.Auth.AppRole
  761. if appRole != nil {
  762. err := v.requestTokenWithAppRoleRef(ctx, appRole)
  763. if err != nil {
  764. return true, err
  765. }
  766. return true, nil
  767. }
  768. return false, nil
  769. }
  770. func setKubernetesAuthToken(ctx context.Context, v *client) (bool, error) {
  771. kubernetesAuth := v.store.Auth.Kubernetes
  772. if kubernetesAuth != nil {
  773. err := v.requestTokenWithKubernetesAuth(ctx, kubernetesAuth)
  774. if err != nil {
  775. return true, err
  776. }
  777. return true, nil
  778. }
  779. return false, nil
  780. }
  781. func setLdapAuthToken(ctx context.Context, v *client) (bool, error) {
  782. ldapAuth := v.store.Auth.Ldap
  783. if ldapAuth != nil {
  784. err := v.requestTokenWithLdapAuth(ctx, ldapAuth)
  785. if err != nil {
  786. return true, err
  787. }
  788. return true, nil
  789. }
  790. return false, nil
  791. }
  792. func setJwtAuthToken(ctx context.Context, v *client) (bool, error) {
  793. jwtAuth := v.store.Auth.Jwt
  794. if jwtAuth != nil {
  795. err := v.requestTokenWithJwtAuth(ctx, jwtAuth)
  796. if err != nil {
  797. return true, err
  798. }
  799. return true, nil
  800. }
  801. return false, nil
  802. }
  803. func setCertAuthToken(ctx context.Context, v *client, cfg *vault.Config) (bool, error) {
  804. certAuth := v.store.Auth.Cert
  805. if certAuth != nil {
  806. err := v.requestTokenWithCertAuth(ctx, certAuth, cfg)
  807. if err != nil {
  808. return true, err
  809. }
  810. return true, nil
  811. }
  812. return false, nil
  813. }
  814. func (v *client) secretKeyRefForServiceAccount(ctx context.Context, serviceAccountRef *esmeta.ServiceAccountSelector) (string, error) {
  815. serviceAccount := &corev1.ServiceAccount{}
  816. ref := types.NamespacedName{
  817. Namespace: v.namespace,
  818. Name: serviceAccountRef.Name,
  819. }
  820. if (v.storeKind == esv1beta1.ClusterSecretStoreKind) &&
  821. (serviceAccountRef.Namespace != nil) {
  822. ref.Namespace = *serviceAccountRef.Namespace
  823. }
  824. err := v.kube.Get(ctx, ref, serviceAccount)
  825. if err != nil {
  826. return "", fmt.Errorf(errGetKubeSA, ref.Name, err)
  827. }
  828. if len(serviceAccount.Secrets) == 0 {
  829. return "", fmt.Errorf(errGetKubeSASecrets, ref.Name)
  830. }
  831. for _, tokenRef := range serviceAccount.Secrets {
  832. retval, err := v.secretKeyRef(ctx, &esmeta.SecretKeySelector{
  833. Name: tokenRef.Name,
  834. Namespace: &ref.Namespace,
  835. Key: "token",
  836. })
  837. if err != nil {
  838. continue
  839. }
  840. return retval, nil
  841. }
  842. return "", fmt.Errorf(errGetKubeSANoToken, ref.Name)
  843. }
  844. func (v *client) secretKeyRef(ctx context.Context, secretRef *esmeta.SecretKeySelector) (string, error) {
  845. secret := &corev1.Secret{}
  846. ref := types.NamespacedName{
  847. Namespace: v.namespace,
  848. Name: secretRef.Name,
  849. }
  850. if (v.storeKind == esv1beta1.ClusterSecretStoreKind) &&
  851. (secretRef.Namespace != nil) {
  852. ref.Namespace = *secretRef.Namespace
  853. }
  854. err := v.kube.Get(ctx, ref, secret)
  855. if err != nil {
  856. return "", fmt.Errorf(errGetKubeSecret, ref.Name, err)
  857. }
  858. keyBytes, ok := secret.Data[secretRef.Key]
  859. if !ok {
  860. return "", fmt.Errorf(errSecretKeyFmt, secretRef.Key)
  861. }
  862. value := string(keyBytes)
  863. valueStr := strings.TrimSpace(value)
  864. return valueStr, nil
  865. }
  866. func (v *client) serviceAccountToken(ctx context.Context, serviceAccountRef esmeta.ServiceAccountSelector, additionalAud []string, expirationSeconds int64) (string, error) {
  867. audiences := serviceAccountRef.Audiences
  868. if len(additionalAud) > 0 {
  869. audiences = append(audiences, additionalAud...)
  870. }
  871. tokenRequest := &authenticationv1.TokenRequest{
  872. ObjectMeta: metav1.ObjectMeta{
  873. Namespace: v.namespace,
  874. },
  875. Spec: authenticationv1.TokenRequestSpec{
  876. Audiences: audiences,
  877. ExpirationSeconds: &expirationSeconds,
  878. },
  879. }
  880. if (v.storeKind == esv1beta1.ClusterSecretStoreKind) &&
  881. (serviceAccountRef.Namespace != nil) {
  882. tokenRequest.Namespace = *serviceAccountRef.Namespace
  883. }
  884. tokenResponse, err := v.corev1.ServiceAccounts(tokenRequest.Namespace).CreateToken(ctx, serviceAccountRef.Name, tokenRequest, metav1.CreateOptions{})
  885. if err != nil {
  886. return "", fmt.Errorf(errGetKubeSATokenRequest, serviceAccountRef.Name, err)
  887. }
  888. return tokenResponse.Status.Token, nil
  889. }
  890. // checkToken does a lookup and checks if the provided token exists.
  891. func checkToken(ctx context.Context, vStore *client) (bool, error) {
  892. // https://www.vaultproject.io/api-docs/auth/token#lookup-a-token-self
  893. resp, err := vStore.token.LookupSelfWithContext(ctx)
  894. if err != nil {
  895. return false, err
  896. }
  897. t, ok := resp.Data["type"]
  898. if !ok {
  899. return false, fmt.Errorf("could not assert token type")
  900. }
  901. tokenType := t.(string)
  902. if tokenType == "batch" {
  903. return false, nil
  904. }
  905. return true, nil
  906. }
  907. func (v *client) requestTokenWithAppRoleRef(ctx context.Context, appRole *esv1beta1.VaultAppRole) error {
  908. roleID := strings.TrimSpace(appRole.RoleID)
  909. secretID, err := v.secretKeyRef(ctx, &appRole.SecretRef)
  910. if err != nil {
  911. return err
  912. }
  913. secret := approle.SecretID{FromString: secretID}
  914. appRoleClient, err := approle.NewAppRoleAuth(roleID, &secret, approle.WithMountPath(appRole.Path))
  915. if err != nil {
  916. return err
  917. }
  918. _, err = v.auth.Login(ctx, appRoleClient)
  919. if err != nil {
  920. return err
  921. }
  922. return nil
  923. }
  924. func (v *client) requestTokenWithKubernetesAuth(ctx context.Context, kubernetesAuth *esv1beta1.VaultKubernetesAuth) error {
  925. jwtString, err := getJwtString(ctx, v, kubernetesAuth)
  926. if err != nil {
  927. return err
  928. }
  929. k, err := authkubernetes.NewKubernetesAuth(kubernetesAuth.Role, authkubernetes.WithServiceAccountToken(jwtString), authkubernetes.WithMountPath(kubernetesAuth.Path))
  930. if err != nil {
  931. return err
  932. }
  933. _, err = v.auth.Login(ctx, k)
  934. if err != nil {
  935. return err
  936. }
  937. return nil
  938. }
  939. func getJwtString(ctx context.Context, v *client, kubernetesAuth *esv1beta1.VaultKubernetesAuth) (string, error) {
  940. if kubernetesAuth.ServiceAccountRef != nil {
  941. // Kubernetes <v1.24 fetch token via ServiceAccount.Secrets[]
  942. // this behavior was removed in v1.24 and we must use TokenRequest API (see below)
  943. jwt, err := v.secretKeyRefForServiceAccount(ctx, kubernetesAuth.ServiceAccountRef)
  944. if jwt != "" {
  945. return jwt, err
  946. }
  947. if err != nil {
  948. v.log.V(1).Info("unable to fetch jwt from service account secret")
  949. }
  950. // Kubernetes >=v1.24: fetch token via TokenRequest API
  951. // note: this is a massive change from vault perspective: the `iss` claim will very likely change.
  952. // Vault 1.9 deprecated issuer validation by default, and authentication with Vault clusters <1.9 will likely fail.
  953. jwt, err = v.serviceAccountToken(ctx, *kubernetesAuth.ServiceAccountRef, nil, 600)
  954. if err != nil {
  955. return "", err
  956. }
  957. return jwt, nil
  958. } else if kubernetesAuth.SecretRef != nil {
  959. tokenRef := kubernetesAuth.SecretRef
  960. if tokenRef.Key == "" {
  961. tokenRef = kubernetesAuth.SecretRef.DeepCopy()
  962. tokenRef.Key = "token"
  963. }
  964. jwt, err := v.secretKeyRef(ctx, tokenRef)
  965. if err != nil {
  966. return "", err
  967. }
  968. return jwt, nil
  969. } else {
  970. // Kubernetes authentication is specified, but without a referenced
  971. // Kubernetes secret. We check if the file path for in-cluster service account
  972. // exists and attempt to use the token for Vault Kubernetes auth.
  973. if _, err := os.Stat(serviceAccTokenPath); err != nil {
  974. return "", fmt.Errorf(errServiceAccount, err)
  975. }
  976. jwtByte, err := os.ReadFile(serviceAccTokenPath)
  977. if err != nil {
  978. return "", fmt.Errorf(errServiceAccount, err)
  979. }
  980. return string(jwtByte), nil
  981. }
  982. }
  983. func (v *client) requestTokenWithLdapAuth(ctx context.Context, ldapAuth *esv1beta1.VaultLdapAuth) error {
  984. username := strings.TrimSpace(ldapAuth.Username)
  985. password, err := v.secretKeyRef(ctx, &ldapAuth.SecretRef)
  986. if err != nil {
  987. return err
  988. }
  989. pass := authldap.Password{FromString: password}
  990. l, err := authldap.NewLDAPAuth(username, &pass, authldap.WithMountPath(ldapAuth.Path))
  991. if err != nil {
  992. return err
  993. }
  994. _, err = v.auth.Login(ctx, l)
  995. if err != nil {
  996. return err
  997. }
  998. return nil
  999. }
  1000. func (v *client) requestTokenWithJwtAuth(ctx context.Context, jwtAuth *esv1beta1.VaultJwtAuth) error {
  1001. role := strings.TrimSpace(jwtAuth.Role)
  1002. var jwt string
  1003. var err error
  1004. if jwtAuth.SecretRef != nil {
  1005. jwt, err = v.secretKeyRef(ctx, jwtAuth.SecretRef)
  1006. } else if k8sServiceAccountToken := jwtAuth.KubernetesServiceAccountToken; k8sServiceAccountToken != nil {
  1007. audiences := k8sServiceAccountToken.Audiences
  1008. if audiences == nil {
  1009. audiences = &[]string{"vault"}
  1010. }
  1011. expirationSeconds := k8sServiceAccountToken.ExpirationSeconds
  1012. if expirationSeconds == nil {
  1013. tmp := int64(600)
  1014. expirationSeconds = &tmp
  1015. }
  1016. jwt, err = v.serviceAccountToken(ctx, k8sServiceAccountToken.ServiceAccountRef, *audiences, *expirationSeconds)
  1017. } else {
  1018. err = fmt.Errorf(errJwtNoTokenSource)
  1019. }
  1020. if err != nil {
  1021. return err
  1022. }
  1023. parameters := map[string]interface{}{
  1024. "role": role,
  1025. "jwt": jwt,
  1026. }
  1027. url := strings.Join([]string{"auth", jwtAuth.Path, "login"}, "/")
  1028. vaultResult, err := v.logical.WriteWithContext(ctx, url, parameters)
  1029. if err != nil {
  1030. return err
  1031. }
  1032. token, err := vaultResult.TokenID()
  1033. if err != nil {
  1034. return fmt.Errorf(errVaultToken, err)
  1035. }
  1036. v.client.SetToken(token)
  1037. return nil
  1038. }
  1039. func (v *client) requestTokenWithCertAuth(ctx context.Context, certAuth *esv1beta1.VaultCertAuth, cfg *vault.Config) error {
  1040. clientKey, err := v.secretKeyRef(ctx, &certAuth.SecretRef)
  1041. if err != nil {
  1042. return err
  1043. }
  1044. clientCert, err := v.secretKeyRef(ctx, &certAuth.ClientCert)
  1045. if err != nil {
  1046. return err
  1047. }
  1048. cert, err := tls.X509KeyPair([]byte(clientCert), []byte(clientKey))
  1049. if err != nil {
  1050. return fmt.Errorf(errClientTLSAuth, err)
  1051. }
  1052. if transport, ok := cfg.HttpClient.Transport.(*http.Transport); ok {
  1053. transport.TLSClientConfig.Certificates = []tls.Certificate{cert}
  1054. }
  1055. url := strings.Join([]string{"auth", "cert", "login"}, "/")
  1056. vaultResult, err := v.logical.WriteWithContext(ctx, url, nil)
  1057. if err != nil {
  1058. return fmt.Errorf(errVaultRequest, err)
  1059. }
  1060. token, err := vaultResult.TokenID()
  1061. if err != nil {
  1062. return fmt.Errorf(errVaultToken, err)
  1063. }
  1064. v.client.SetToken(token)
  1065. return nil
  1066. }