secretsmanager.go 24 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770
  1. /*
  2. Copyright © 2025 ESO Maintainer Team
  3. Licensed under the Apache License, Version 2.0 (the "License");
  4. you may not use this file except in compliance with the License.
  5. You may obtain a copy of the License at
  6. https://www.apache.org/licenses/LICENSE-2.0
  7. Unless required by applicable law or agreed to in writing, software
  8. distributed under the License is distributed on an "AS IS" BASIS,
  9. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  10. See the License for the specific language governing permissions and
  11. limitations under the License.
  12. */
  13. package secretsmanager
  14. import (
  15. "bytes"
  16. "context"
  17. "encoding/json"
  18. "errors"
  19. "fmt"
  20. "slices"
  21. "strings"
  22. "github.com/aws/aws-sdk-go-v2/aws"
  23. awssm "github.com/aws/aws-sdk-go-v2/service/secretsmanager"
  24. "github.com/aws/aws-sdk-go-v2/service/secretsmanager/types"
  25. "github.com/aws/smithy-go"
  26. "github.com/external-secrets/external-secrets/pkg/esutils/metadata"
  27. "github.com/google/uuid"
  28. "github.com/tidwall/gjson"
  29. "github.com/tidwall/sjson"
  30. corev1 "k8s.io/api/core/v1"
  31. apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
  32. utilpointer "k8s.io/utils/ptr"
  33. ctrl "sigs.k8s.io/controller-runtime"
  34. esv1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1"
  35. "github.com/external-secrets/external-secrets/pkg/constants"
  36. "github.com/external-secrets/external-secrets/pkg/esutils"
  37. "github.com/external-secrets/external-secrets/pkg/find"
  38. "github.com/external-secrets/external-secrets/pkg/metrics"
  39. "github.com/external-secrets/external-secrets/pkg/provider/aws/util"
  40. )
  41. // PushSecretMetadataSpec contains metadata information for pushing secrets to AWS Secret Manager.
  42. type PushSecretMetadataSpec struct {
  43. Tags map[string]string `json:"tags,omitempty"`
  44. Description string `json:"description,omitempty"`
  45. SecretPushFormat string `json:"secretPushFormat,omitempty"`
  46. KMSKeyID string `json:"kmsKeyId,omitempty"`
  47. }
  48. // Declares metadata information for pushing secrets to AWS Secret Store.
  49. const (
  50. SecretPushFormatKey = "secretPushFormat"
  51. SecretPushFormatString = "string"
  52. SecretPushFormatBinary = "binary"
  53. ResourceNotFoundException = "ResourceNotFoundException"
  54. )
  55. // https://github.com/external-secrets/external-secrets/issues/644
  56. var _ esv1.SecretsClient = &SecretsManager{}
  57. // SecretsManager is a provider for AWS SecretsManager.
  58. type SecretsManager struct {
  59. cfg *aws.Config
  60. client SMInterface // Keep the interface
  61. referentAuth bool
  62. cache map[string]*awssm.GetSecretValueOutput
  63. config *esv1.SecretsManager
  64. prefix string
  65. newUUID func() string
  66. }
  67. // SMInterface is a subset of the smiface api.
  68. // see: https://docs.aws.amazon.com/sdk-for-go/api/service/secretsmanager/secretsmanageriface/
  69. type SMInterface interface {
  70. BatchGetSecretValue(ctx context.Context, params *awssm.BatchGetSecretValueInput, optFuncs ...func(*awssm.Options)) (*awssm.BatchGetSecretValueOutput, error)
  71. ListSecrets(ctx context.Context, params *awssm.ListSecretsInput, optFuncs ...func(*awssm.Options)) (*awssm.ListSecretsOutput, error)
  72. GetSecretValue(ctx context.Context, params *awssm.GetSecretValueInput, optFuncs ...func(*awssm.Options)) (*awssm.GetSecretValueOutput, error)
  73. CreateSecret(ctx context.Context, params *awssm.CreateSecretInput, optFuncs ...func(*awssm.Options)) (*awssm.CreateSecretOutput, error)
  74. PutSecretValue(ctx context.Context, params *awssm.PutSecretValueInput, optFuncs ...func(*awssm.Options)) (*awssm.PutSecretValueOutput, error)
  75. DescribeSecret(ctx context.Context, params *awssm.DescribeSecretInput, optFuncs ...func(*awssm.Options)) (*awssm.DescribeSecretOutput, error)
  76. DeleteSecret(ctx context.Context, params *awssm.DeleteSecretInput, optFuncs ...func(*awssm.Options)) (*awssm.DeleteSecretOutput, error)
  77. TagResource(ctx context.Context, params *awssm.TagResourceInput, optFuncs ...func(*awssm.Options)) (*awssm.TagResourceOutput, error)
  78. UntagResource(ctx context.Context, params *awssm.UntagResourceInput, optFuncs ...func(*awssm.Options)) (*awssm.UntagResourceOutput, error)
  79. }
  80. const (
  81. errUnexpectedFindOperator = "unexpected find operator"
  82. managedBy = "managed-by"
  83. externalSecrets = "external-secrets"
  84. initialVersion = "00000000-0000-0000-0000-000000000001"
  85. )
  86. var log = ctrl.Log.WithName("provider").WithName("aws").WithName("secretsmanager")
  87. // New creates a new SecretsManager client.
  88. func New(_ context.Context, cfg *aws.Config, secretsManagerCfg *esv1.SecretsManager, prefix string, referentAuth bool) (*SecretsManager, error) {
  89. return &SecretsManager{
  90. cfg: cfg,
  91. client: awssm.NewFromConfig(*cfg, func(o *awssm.Options) {
  92. o.EndpointResolverV2 = customEndpointResolver{}
  93. }),
  94. referentAuth: referentAuth,
  95. cache: make(map[string]*awssm.GetSecretValueOutput),
  96. config: secretsManagerCfg,
  97. prefix: prefix,
  98. }, nil
  99. }
  100. func (sm *SecretsManager) fetch(ctx context.Context, ref esv1.ExternalSecretDataRemoteRef) (*awssm.GetSecretValueOutput, error) {
  101. ver := "AWSCURRENT"
  102. valueFrom := "SECRET"
  103. if ref.Version != "" {
  104. ver = ref.Version
  105. }
  106. if ref.MetadataPolicy == esv1.ExternalSecretMetadataPolicyFetch {
  107. valueFrom = "TAG"
  108. }
  109. key := sm.prefix + ref.Key
  110. log.Info("fetching secret value", "key", key, "version", ver, "value", valueFrom)
  111. cacheKey := fmt.Sprintf("%s#%s#%s", key, ver, valueFrom)
  112. if secretOut, found := sm.cache[cacheKey]; found {
  113. log.Info("found secret in cache", "key", key, "version", ver)
  114. return secretOut, nil
  115. }
  116. secretOut, err := sm.constructSecretValue(ctx, key, ver, ref.MetadataPolicy)
  117. if err != nil {
  118. return nil, err
  119. }
  120. sm.cache[cacheKey] = secretOut
  121. return secretOut, nil
  122. }
  123. // DeleteSecret deletes a secret from AWS Secrets Manager.
  124. func (sm *SecretsManager) DeleteSecret(ctx context.Context, remoteRef esv1.PushSecretRemoteRef) error {
  125. secretName := sm.prefix + remoteRef.GetRemoteKey()
  126. secretValue := awssm.GetSecretValueInput{
  127. SecretId: &secretName,
  128. }
  129. secretInput := awssm.DescribeSecretInput{
  130. SecretId: &secretName,
  131. }
  132. awsSecret, err := sm.client.GetSecretValue(ctx, &secretValue)
  133. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMGetSecretValue, err)
  134. var aerr smithy.APIError
  135. if err != nil {
  136. if ok := errors.As(err, &aerr); !ok {
  137. return err
  138. }
  139. if aerr.ErrorCode() == ResourceNotFoundException {
  140. return nil
  141. }
  142. return err
  143. }
  144. data, err := sm.client.DescribeSecret(ctx, &secretInput)
  145. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMDescribeSecret, err)
  146. if err != nil {
  147. return err
  148. }
  149. if !isManagedByESO(data) {
  150. return nil
  151. }
  152. deleteInput := &awssm.DeleteSecretInput{
  153. SecretId: awsSecret.ARN,
  154. }
  155. if sm.config != nil && sm.config.ForceDeleteWithoutRecovery {
  156. deleteInput.ForceDeleteWithoutRecovery = &sm.config.ForceDeleteWithoutRecovery
  157. }
  158. if sm.config != nil && sm.config.RecoveryWindowInDays > 0 {
  159. deleteInput.RecoveryWindowInDays = &sm.config.RecoveryWindowInDays
  160. }
  161. err = awsutil.ValidateDeleteSecretInput(*deleteInput)
  162. if err != nil {
  163. return err
  164. }
  165. _, err = sm.client.DeleteSecret(ctx, deleteInput)
  166. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMDeleteSecret, err)
  167. return err
  168. }
  169. // SecretExists checks if a secret exists in AWS Secrets Manager.
  170. func (sm *SecretsManager) SecretExists(ctx context.Context, pushSecretRef esv1.PushSecretRemoteRef) (bool, error) {
  171. secretName := sm.prefix + pushSecretRef.GetRemoteKey()
  172. secretValue := awssm.GetSecretValueInput{
  173. SecretId: &secretName,
  174. }
  175. _, err := sm.client.GetSecretValue(ctx, &secretValue)
  176. if err != nil {
  177. return sm.handleSecretError(err)
  178. }
  179. return true, nil
  180. }
  181. func (sm *SecretsManager) handleSecretError(err error) (bool, error) {
  182. var aerr smithy.APIError
  183. if ok := errors.As(err, &aerr); !ok {
  184. return false, err
  185. }
  186. if aerr.ErrorCode() == ResourceNotFoundException {
  187. return false, nil
  188. }
  189. return false, err
  190. }
  191. // PushSecret pushes a secret to AWS Secrets Manager.
  192. func (sm *SecretsManager) PushSecret(ctx context.Context, secret *corev1.Secret, psd esv1.PushSecretData) error {
  193. value, err := esutils.ExtractSecretData(psd, secret)
  194. if err != nil {
  195. return fmt.Errorf("failed to extract secret data: %w", err)
  196. }
  197. secretName := sm.prefix + psd.GetRemoteKey()
  198. describeSecretInput := awssm.DescribeSecretInput{SecretId: &secretName}
  199. describeSecretOutput, err := sm.client.DescribeSecret(ctx, &describeSecretInput)
  200. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMDescribeSecret, err)
  201. var aerr smithy.APIError
  202. if err != nil {
  203. if ok := errors.As(err, &aerr); !ok {
  204. return err
  205. }
  206. if aerr.ErrorCode() == ResourceNotFoundException {
  207. finalValue, err := sm.getNewSecretValue(value, psd.GetProperty(), nil)
  208. if err != nil {
  209. return err
  210. }
  211. return sm.createSecretWithContext(ctx, secretName, psd, finalValue)
  212. }
  213. return err
  214. } else if !isManagedByESO(describeSecretOutput) {
  215. return errors.New("secret not managed by external-secrets")
  216. }
  217. if len(describeSecretOutput.VersionIdsToStages) == 0 {
  218. finalValue, err := sm.getNewSecretValue(value, psd.GetProperty(), nil)
  219. if err != nil {
  220. return err
  221. }
  222. return sm.putSecretValueWithContext(ctx, secretName, nil, psd, finalValue, describeSecretOutput.Tags)
  223. }
  224. getSecretValueInput := awssm.GetSecretValueInput{SecretId: &secretName}
  225. getSecretValueOutput, err := sm.client.GetSecretValue(ctx, &getSecretValueInput)
  226. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMGetSecretValue, err)
  227. if err != nil {
  228. return err
  229. }
  230. finalValue, err := sm.getNewSecretValue(value, psd.GetProperty(), getSecretValueOutput)
  231. if err != nil {
  232. return err
  233. }
  234. return sm.putSecretValueWithContext(ctx, secretName, getSecretValueOutput, psd, finalValue, describeSecretOutput.Tags)
  235. }
  236. func (sm *SecretsManager) getNewSecretValue(value []byte, property string, existingSecret *awssm.GetSecretValueOutput) ([]byte, error) {
  237. if property == "" {
  238. return value, nil
  239. }
  240. if existingSecret == nil {
  241. value, _ = sjson.SetBytes([]byte{}, property, value)
  242. return value, nil
  243. }
  244. currentSecret := sm.retrievePayload(existingSecret)
  245. if currentSecret != "" && !gjson.Valid(currentSecret) {
  246. return nil, errors.New("PushSecret for aws secrets manager with a pushSecretData property requires a json secret")
  247. }
  248. value, _ = sjson.SetBytes([]byte(currentSecret), property, value)
  249. return value, nil
  250. }
  251. func isManagedByESO(data *awssm.DescribeSecretOutput) bool {
  252. managedBy := managedBy
  253. externalSecrets := externalSecrets
  254. for _, tag := range data.Tags {
  255. if *tag.Key == managedBy && *tag.Value == externalSecrets {
  256. return true
  257. }
  258. }
  259. return false
  260. }
  261. // GetAllSecrets syncs multiple secrets from aws provider into a single Kubernetes Secret.
  262. func (sm *SecretsManager) GetAllSecrets(ctx context.Context, ref esv1.ExternalSecretFind) (map[string][]byte, error) {
  263. if ref.Name != nil {
  264. return sm.findByName(ctx, ref)
  265. }
  266. if len(ref.Tags) > 0 {
  267. return sm.findByTags(ctx, ref)
  268. }
  269. return nil, errors.New(errUnexpectedFindOperator)
  270. }
  271. func (sm *SecretsManager) findByName(ctx context.Context, ref esv1.ExternalSecretFind) (map[string][]byte, error) {
  272. matcher, err := find.New(*ref.Name)
  273. if err != nil {
  274. return nil, err
  275. }
  276. filters := make([]types.Filter, 0)
  277. if ref.Path != nil {
  278. filters = append(filters, types.Filter{
  279. Key: types.FilterNameStringTypeName,
  280. Values: []string{
  281. *ref.Path,
  282. },
  283. })
  284. return sm.fetchWithBatch(ctx, filters, matcher)
  285. }
  286. data := make(map[string][]byte)
  287. var nextToken *string
  288. for {
  289. // I put this into the for loop on purpose.
  290. log.V(0).Info("using ListSecret to fetch all secrets; this is a costly operations, please use batching by defining a _path_")
  291. it, err := sm.client.ListSecrets(ctx, &awssm.ListSecretsInput{
  292. Filters: filters,
  293. NextToken: nextToken,
  294. })
  295. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMListSecrets, err)
  296. if err != nil {
  297. return nil, err
  298. }
  299. log.V(1).Info("aws sm findByName found", "secrets", len(it.SecretList))
  300. for _, secret := range it.SecretList {
  301. if !matcher.MatchName(*secret.Name) {
  302. continue
  303. }
  304. log.V(1).Info("aws sm findByName matches", "name", *secret.Name)
  305. if err := sm.fetchAndSet(ctx, data, *secret.Name); err != nil {
  306. return nil, err
  307. }
  308. }
  309. nextToken = it.NextToken
  310. if nextToken == nil {
  311. break
  312. }
  313. }
  314. return data, nil
  315. }
  316. func (sm *SecretsManager) findByTags(ctx context.Context, ref esv1.ExternalSecretFind) (map[string][]byte, error) {
  317. filters := make([]types.Filter, 0)
  318. for k, v := range ref.Tags {
  319. filters = append(filters, types.Filter{
  320. Key: types.FilterNameStringTypeTagKey,
  321. Values: []string{
  322. k,
  323. },
  324. }, types.Filter{
  325. Key: types.FilterNameStringTypeTagValue,
  326. Values: []string{
  327. v,
  328. },
  329. })
  330. }
  331. if ref.Path != nil {
  332. filters = append(filters, types.Filter{
  333. Key: types.FilterNameStringTypeName,
  334. Values: []string{
  335. *ref.Path,
  336. },
  337. })
  338. }
  339. return sm.fetchWithBatch(ctx, filters, nil)
  340. }
  341. func (sm *SecretsManager) fetchAndSet(ctx context.Context, data map[string][]byte, name string) error {
  342. sec, err := sm.fetch(ctx, esv1.ExternalSecretDataRemoteRef{
  343. Key: name,
  344. })
  345. if err != nil {
  346. return err
  347. }
  348. if sec.SecretString != nil {
  349. data[name] = []byte(*sec.SecretString)
  350. }
  351. if sec.SecretBinary != nil {
  352. data[name] = sec.SecretBinary
  353. }
  354. return nil
  355. }
  356. // GetSecret returns a single secret from the provider.
  357. func (sm *SecretsManager) GetSecret(ctx context.Context, ref esv1.ExternalSecretDataRemoteRef) ([]byte, error) {
  358. secretOut, err := sm.fetch(ctx, ref)
  359. if errors.Is(err, esv1.NoSecretErr) {
  360. return nil, err
  361. }
  362. if err != nil {
  363. return nil, awsutil.SanitizeErr(err)
  364. }
  365. if ref.Property == "" {
  366. if secretOut.SecretString != nil {
  367. return []byte(*secretOut.SecretString), nil
  368. }
  369. if secretOut.SecretBinary != nil {
  370. return secretOut.SecretBinary, nil
  371. }
  372. return nil, fmt.Errorf("invalid secret received. no secret string nor binary for key: %s", ref.Key)
  373. }
  374. val := sm.mapSecretToGjson(secretOut, ref.Property)
  375. if !val.Exists() {
  376. return nil, fmt.Errorf("key %s does not exist in secret %s", ref.Property, ref.Key)
  377. }
  378. return []byte(val.String()), nil
  379. }
  380. func (sm *SecretsManager) mapSecretToGjson(secretOut *awssm.GetSecretValueOutput, property string) gjson.Result {
  381. payload := sm.retrievePayload(secretOut)
  382. refProperty := sm.escapeDotsIfRequired(property, payload)
  383. val := gjson.Get(payload, refProperty)
  384. return val
  385. }
  386. func (sm *SecretsManager) retrievePayload(secretOut *awssm.GetSecretValueOutput) string {
  387. if secretOut == nil {
  388. return ""
  389. }
  390. var payload string
  391. if secretOut.SecretString != nil {
  392. payload = *secretOut.SecretString
  393. }
  394. if secretOut.SecretBinary != nil {
  395. payload = string(secretOut.SecretBinary)
  396. }
  397. return payload
  398. }
  399. func (sm *SecretsManager) escapeDotsIfRequired(currentRefProperty, payload string) string {
  400. // We need to search if a given key with a . exists before using gjson operations.
  401. idx := strings.Index(currentRefProperty, ".")
  402. refProperty := currentRefProperty
  403. if idx > -1 {
  404. refProperty = strings.ReplaceAll(currentRefProperty, ".", "\\.")
  405. val := gjson.Get(payload, refProperty)
  406. if !val.Exists() {
  407. refProperty = currentRefProperty
  408. }
  409. }
  410. return refProperty
  411. }
  412. // GetSecretMap returns multiple k/v pairs from the provider.
  413. func (sm *SecretsManager) GetSecretMap(ctx context.Context, ref esv1.ExternalSecretDataRemoteRef) (map[string][]byte, error) {
  414. log.Info("fetching secret map", "key", ref.Key)
  415. data, err := sm.GetSecret(ctx, ref)
  416. if err != nil {
  417. return nil, err
  418. }
  419. kv := make(map[string]json.RawMessage)
  420. err = json.Unmarshal(data, &kv)
  421. if err != nil {
  422. return nil, fmt.Errorf("unable to unmarshal secret %s: %w", ref.Key, err)
  423. }
  424. secretData := make(map[string][]byte)
  425. for k, v := range kv {
  426. var strVal string
  427. err = json.Unmarshal(v, &strVal)
  428. if err == nil {
  429. secretData[k] = []byte(strVal)
  430. } else {
  431. secretData[k] = v
  432. }
  433. }
  434. return secretData, nil
  435. }
  436. // Close closes the provider client connection.
  437. func (sm *SecretsManager) Close(_ context.Context) error {
  438. return nil
  439. }
  440. // Validate validates the provider configuration.
  441. func (sm *SecretsManager) Validate() (esv1.ValidationResult, error) {
  442. // skip validation stack because it depends on the namespace
  443. // of the ExternalSecret
  444. if sm.referentAuth {
  445. return esv1.ValidationResultUnknown, nil
  446. }
  447. _, err := sm.cfg.Credentials.Retrieve(context.Background())
  448. if err != nil {
  449. return esv1.ValidationResultError, awsutil.SanitizeErr(err)
  450. }
  451. return esv1.ValidationResultReady, nil
  452. }
  453. // Capabilities returns the provider's esv1.SecretStoreCapabilities.
  454. func (sm *SecretsManager) Capabilities() esv1.SecretStoreCapabilities {
  455. return esv1.SecretStoreReadWrite
  456. }
  457. func (sm *SecretsManager) createSecretWithContext(ctx context.Context, secretName string, psd esv1.PushSecretData, value []byte) error {
  458. mdata, err := sm.constructMetadataWithDefaults(psd.GetMetadata())
  459. if err != nil {
  460. return fmt.Errorf("failed to parse push secret metadata: %w", err)
  461. }
  462. tags := make([]types.Tag, 0)
  463. for k, v := range mdata.Spec.Tags {
  464. tags = append(tags, types.Tag{
  465. Key: utilpointer.To(k),
  466. Value: utilpointer.To(v),
  467. })
  468. }
  469. input := &awssm.CreateSecretInput{
  470. Name: &secretName,
  471. SecretBinary: value,
  472. Tags: tags,
  473. Description: utilpointer.To(mdata.Spec.Description),
  474. ClientRequestToken: utilpointer.To(initialVersion),
  475. KmsKeyId: utilpointer.To(mdata.Spec.KMSKeyID),
  476. }
  477. if mdata.Spec.SecretPushFormat == SecretPushFormatString {
  478. input.SecretBinary = nil
  479. input.SecretString = aws.String(string(value))
  480. }
  481. _, err = sm.client.CreateSecret(ctx, input)
  482. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMCreateSecret, err)
  483. return err
  484. }
  485. func (sm *SecretsManager) putSecretValueWithContext(ctx context.Context, secretArn string, awsSecret *awssm.GetSecretValueOutput, psd esv1.PushSecretData, value []byte, tags []types.Tag) error {
  486. if awsSecret != nil && (bytes.Equal(awsSecret.SecretBinary, value) || esutils.CompareStringAndByteSlices(awsSecret.SecretString, value)) {
  487. return nil
  488. }
  489. newVersionNumber := initialVersion
  490. if awsSecret != nil {
  491. if sm.newUUID == nil {
  492. newVersionNumber = uuid.NewString()
  493. } else {
  494. newVersionNumber = sm.newUUID()
  495. }
  496. }
  497. input := &awssm.PutSecretValueInput{
  498. SecretId: &secretArn,
  499. SecretBinary: value,
  500. ClientRequestToken: aws.String(newVersionNumber),
  501. }
  502. secretPushFormat, err := esutils.FetchValueFromMetadata(SecretPushFormatKey, psd.GetMetadata(), SecretPushFormatBinary)
  503. if err != nil {
  504. return fmt.Errorf("failed to parse metadata: %w", err)
  505. }
  506. if secretPushFormat == SecretPushFormatString {
  507. input.SecretBinary = nil
  508. input.SecretString = aws.String(string(value))
  509. }
  510. _, err = sm.client.PutSecretValue(ctx, input)
  511. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMPutSecretValue, err)
  512. if err != nil {
  513. return err
  514. }
  515. currentTags := make(map[string]string, len(tags))
  516. for _, tag := range tags {
  517. currentTags[*tag.Key] = *tag.Value
  518. }
  519. return sm.patchTags(ctx, psd.GetMetadata(), &secretArn, currentTags)
  520. }
  521. func (sm *SecretsManager) patchTags(ctx context.Context, metadata *apiextensionsv1.JSON, secretID *string, tags map[string]string) error {
  522. meta, err := sm.constructMetadataWithDefaults(metadata)
  523. if err != nil {
  524. return err
  525. }
  526. tagKeysToRemove := awsutil.FindTagKeysToRemove(tags, meta.Spec.Tags)
  527. if len(tagKeysToRemove) > 0 {
  528. _, err = sm.client.UntagResource(ctx, &awssm.UntagResourceInput{
  529. SecretId: secretID,
  530. TagKeys: tagKeysToRemove,
  531. })
  532. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMUntagResource, err)
  533. if err != nil {
  534. return err
  535. }
  536. }
  537. tagsToUpdate, isModified := computeTagsToUpdate(tags, meta.Spec.Tags)
  538. if isModified {
  539. _, err = sm.client.TagResource(ctx, &awssm.TagResourceInput{
  540. SecretId: secretID,
  541. Tags: tagsToUpdate,
  542. })
  543. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMTagResource, err)
  544. if err != nil {
  545. return err
  546. }
  547. }
  548. return nil
  549. }
  550. func (sm *SecretsManager) fetchWithBatch(ctx context.Context, filters []types.Filter, matcher *find.Matcher) (map[string][]byte, error) {
  551. data := make(map[string][]byte)
  552. var nextToken *string
  553. for {
  554. it, err := sm.client.BatchGetSecretValue(ctx, &awssm.BatchGetSecretValueInput{
  555. Filters: filters,
  556. NextToken: nextToken,
  557. })
  558. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMBatchGetSecretValue, err)
  559. if err != nil {
  560. return nil, err
  561. }
  562. log.V(1).Info("aws sm findByName found", "secrets", len(it.SecretValues))
  563. for _, secret := range it.SecretValues {
  564. if matcher != nil && !matcher.MatchName(*secret.Name) {
  565. continue
  566. }
  567. log.V(1).Info("aws sm findByName matches", "name", *secret.Name)
  568. sm.setSecretValues(&secret, data)
  569. }
  570. nextToken = it.NextToken
  571. if nextToken == nil {
  572. break
  573. }
  574. }
  575. return data, nil
  576. }
  577. func (sm *SecretsManager) setSecretValues(secret *types.SecretValueEntry, data map[string][]byte) {
  578. if secret.SecretString != nil {
  579. data[*secret.Name] = []byte(*secret.SecretString)
  580. }
  581. if secret.SecretBinary != nil {
  582. data[*secret.Name] = secret.SecretBinary
  583. }
  584. }
  585. func (sm *SecretsManager) constructSecretValue(ctx context.Context, key, ver string, metadataPolicy esv1.ExternalSecretMetadataPolicy) (*awssm.GetSecretValueOutput, error) {
  586. if metadataPolicy == esv1.ExternalSecretMetadataPolicyFetch {
  587. describeSecretInput := &awssm.DescribeSecretInput{
  588. SecretId: &key,
  589. }
  590. descOutput, err := sm.client.DescribeSecret(ctx, describeSecretInput)
  591. if err != nil {
  592. return nil, err
  593. }
  594. log.Info("found metadata secret", "key", key, "output", descOutput)
  595. jsonTags, err := awsutil.SecretTagsToJSONString(descOutput.Tags)
  596. if err != nil {
  597. return nil, err
  598. }
  599. return &awssm.GetSecretValueOutput{
  600. ARN: descOutput.ARN,
  601. CreatedDate: descOutput.CreatedDate,
  602. Name: descOutput.Name,
  603. SecretString: &jsonTags,
  604. VersionId: &ver,
  605. }, nil
  606. }
  607. var getSecretValueInput *awssm.GetSecretValueInput
  608. if strings.HasPrefix(ver, "uuid/") {
  609. versionID := strings.TrimPrefix(ver, "uuid/")
  610. getSecretValueInput = &awssm.GetSecretValueInput{
  611. SecretId: &key,
  612. VersionId: &versionID,
  613. }
  614. } else {
  615. getSecretValueInput = &awssm.GetSecretValueInput{
  616. SecretId: &key,
  617. VersionStage: &ver,
  618. }
  619. }
  620. secretOut, err := sm.client.GetSecretValue(ctx, getSecretValueInput)
  621. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMGetSecretValue, err)
  622. var (
  623. nf *types.ResourceNotFoundException
  624. ie *types.InvalidParameterException
  625. )
  626. if errors.As(err, &nf) {
  627. return nil, esv1.NoSecretErr
  628. }
  629. if errors.As(err, &ie) && strings.Contains(ie.Error(), "was marked for deletion") {
  630. return nil, esv1.NoSecretErr
  631. }
  632. return secretOut, err
  633. }
  634. func (sm *SecretsManager) constructMetadataWithDefaults(data *apiextensionsv1.JSON) (*metadata.PushSecretMetadata[PushSecretMetadataSpec], error) {
  635. var (
  636. meta *metadata.PushSecretMetadata[PushSecretMetadataSpec]
  637. err error
  638. )
  639. meta, err = metadata.ParseMetadataParameters[PushSecretMetadataSpec](data)
  640. if err != nil {
  641. return nil, fmt.Errorf("failed to parse metadata: %w", err)
  642. }
  643. if meta == nil {
  644. meta = &metadata.PushSecretMetadata[PushSecretMetadataSpec]{}
  645. }
  646. if meta.Spec.SecretPushFormat == "" {
  647. meta.Spec.SecretPushFormat = SecretPushFormatBinary
  648. } else if !slices.Contains([]string{SecretPushFormatBinary, SecretPushFormatString}, meta.Spec.SecretPushFormat) {
  649. return nil, fmt.Errorf("invalid secret push format: %s", meta.Spec.SecretPushFormat)
  650. }
  651. if meta.Spec.Description == "" {
  652. meta.Spec.Description = fmt.Sprintf("secret '%s:%s'", managedBy, externalSecrets)
  653. }
  654. if meta.Spec.KMSKeyID == "" {
  655. meta.Spec.KMSKeyID = "alias/aws/secretsmanager"
  656. }
  657. if len(meta.Spec.Tags) > 0 {
  658. if _, exists := meta.Spec.Tags[managedBy]; exists {
  659. return nil, fmt.Errorf("error parsing tags in metadata: Cannot specify a '%s' tag", managedBy)
  660. }
  661. } else {
  662. meta.Spec.Tags = make(map[string]string)
  663. }
  664. meta.Spec.Tags[managedBy] = externalSecrets
  665. return meta, nil
  666. }
  667. // computeTagsToUpdate compares the current tags with the desired metaTags and returns a slice of ssmTypes.Tag
  668. // that should be set on the resource. It also returns a boolean indicating if any tag was added or modified.
  669. func computeTagsToUpdate(tags, metaTags map[string]string) ([]types.Tag, bool) {
  670. result := make([]types.Tag, 0, len(metaTags))
  671. modified := false
  672. for k, v := range metaTags {
  673. if _, exists := tags[k]; !exists || tags[k] != v {
  674. if k != managedBy {
  675. modified = true
  676. }
  677. }
  678. result = append(result, types.Tag{
  679. Key: utilpointer.To(k),
  680. Value: utilpointer.To(v),
  681. })
  682. }
  683. return result, modified
  684. }