pushsecret_controller.go 14 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411
  1. /*
  2. Licensed under the Apache License, Version 2.0 (the "License");
  3. you may not use this file except in compliance with the License.
  4. You may obtain a copy of the License at
  5. http://www.apache.org/licenses/LICENSE-2.0
  6. Unless required by applicable law or agreed to in writing, software
  7. distributed under the License is distributed on an "AS IS" BASIS,
  8. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  9. See the License for the specific language governing permissions and
  10. limitations under the License.
  11. */
  12. package pushsecret
  13. import (
  14. "context"
  15. "fmt"
  16. "strings"
  17. "time"
  18. "github.com/go-logr/logr"
  19. v1 "k8s.io/api/core/v1"
  20. apierrors "k8s.io/apimachinery/pkg/api/errors"
  21. metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
  22. "k8s.io/apimachinery/pkg/runtime"
  23. "k8s.io/apimachinery/pkg/types"
  24. "k8s.io/client-go/tools/record"
  25. ctrl "sigs.k8s.io/controller-runtime"
  26. "sigs.k8s.io/controller-runtime/pkg/client"
  27. "sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
  28. esapi "github.com/external-secrets/external-secrets/apis/externalsecrets/v1alpha1"
  29. v1beta1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1beta1"
  30. "github.com/external-secrets/external-secrets/pkg/controllers/secretstore"
  31. "github.com/external-secrets/external-secrets/pkg/remote"
  32. )
  33. const (
  34. errFailedGetSecret = "could not get source secret"
  35. errPatchStatus = "error merging"
  36. errGetSecretStore = "could not get SecretStore %q, %w"
  37. errGetClusterSecretStore = "could not get ClusterSecretStore %q, %w"
  38. errGetProviderFailed = "could not start provider"
  39. errGetSecretsClientFailed = "could not start secrets client"
  40. errCloseStoreClient = "error when calling provider close method"
  41. errSetSecretFailed = "could not write remote ref %v to target secretstore %v: %v"
  42. errFailedSetSecret = "set secret failed: %v"
  43. pushSecretFinalizer = "pushsecret.externalsecrets.io/finalizer"
  44. )
  45. type Reconciler struct {
  46. client.Client
  47. Log logr.Logger
  48. Scheme *runtime.Scheme
  49. recorder record.EventRecorder
  50. RequeueInterval time.Duration
  51. ControllerClass string
  52. }
  53. func (r *Reconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
  54. log := r.Log.WithValues("pushsecret", req.NamespacedName)
  55. var ps esapi.PushSecret
  56. err := r.Get(ctx, req.NamespacedName, &ps)
  57. getProvider := v1beta1.GetProvider
  58. if true {
  59. getProvider = remote.GetProvider
  60. }
  61. mgr := secretstore.NewManager(r.Client, r.ControllerClass, false, getProvider)
  62. defer mgr.Close(ctx)
  63. if apierrors.IsNotFound(err) {
  64. return ctrl.Result{}, nil
  65. } else if err != nil {
  66. msg := "unable to get PushSecret"
  67. r.recorder.Event(&ps, v1.EventTypeWarning, esapi.ReasonErrored, msg)
  68. log.Error(err, msg)
  69. return ctrl.Result{}, fmt.Errorf("get resource: %w", err)
  70. }
  71. refreshInt := r.RequeueInterval
  72. if ps.Spec.RefreshInterval != nil {
  73. refreshInt = ps.Spec.RefreshInterval.Duration
  74. }
  75. p := client.MergeFrom(ps.DeepCopy())
  76. defer func() {
  77. err := r.Client.Status().Patch(ctx, &ps, p)
  78. if err != nil {
  79. log.Error(err, errPatchStatus)
  80. }
  81. }()
  82. switch ps.Spec.DeletionPolicy {
  83. case esapi.PushSecretDeletionPolicyDelete:
  84. // finalizer logic. Only added if we should delete the secrets
  85. if ps.ObjectMeta.DeletionTimestamp.IsZero() {
  86. if !controllerutil.ContainsFinalizer(&ps, pushSecretFinalizer) {
  87. controllerutil.AddFinalizer(&ps, pushSecretFinalizer)
  88. err := r.Client.Update(ctx, &ps, &client.UpdateOptions{})
  89. if err != nil {
  90. return ctrl.Result{}, fmt.Errorf("could not update finalizers: %w", err)
  91. }
  92. return ctrl.Result{}, nil
  93. }
  94. } else {
  95. if controllerutil.ContainsFinalizer(&ps, pushSecretFinalizer) {
  96. // trigger a cleanup with no Synced Map
  97. badState, err := r.DeleteSecretFromProviders(ctx, &ps, esapi.SyncedPushSecretsMap{}, mgr)
  98. if err != nil {
  99. msg := fmt.Sprintf("Failed to Delete Secrets from Provider: %v", err)
  100. cond := NewPushSecretCondition(esapi.PushSecretReady, v1.ConditionFalse, esapi.ReasonErrored, msg)
  101. ps = SetPushSecretCondition(ps, *cond)
  102. r.SetSyncedSecrets(&ps, badState)
  103. r.recorder.Event(&ps, v1.EventTypeWarning, esapi.ReasonErrored, msg)
  104. return ctrl.Result{}, err
  105. }
  106. controllerutil.RemoveFinalizer(&ps, pushSecretFinalizer)
  107. err = r.Client.Update(ctx, &ps, &client.UpdateOptions{})
  108. if err != nil {
  109. return ctrl.Result{}, fmt.Errorf("could not update finalizers: %w", err)
  110. }
  111. return ctrl.Result{}, nil
  112. }
  113. }
  114. case esapi.PushSecretDeletionPolicyNone:
  115. default:
  116. }
  117. secret, err := r.GetSecret(ctx, ps)
  118. if err != nil {
  119. cond := NewPushSecretCondition(esapi.PushSecretReady, v1.ConditionFalse, esapi.ReasonErrored, errFailedGetSecret)
  120. ps = SetPushSecretCondition(ps, *cond)
  121. r.recorder.Event(&ps, v1.EventTypeWarning, esapi.ReasonErrored, errFailedGetSecret)
  122. return ctrl.Result{}, err
  123. }
  124. secretStores, err := r.GetSecretStores(ctx, ps)
  125. if err != nil {
  126. cond := NewPushSecretCondition(esapi.PushSecretReady, v1.ConditionFalse, esapi.ReasonErrored, err.Error())
  127. ps = SetPushSecretCondition(ps, *cond)
  128. r.recorder.Event(&ps, v1.EventTypeWarning, esapi.ReasonErrored, err.Error())
  129. return ctrl.Result{}, err
  130. }
  131. syncedSecrets, err := r.PushSecretToProviders(ctx, secretStores, ps, secret, mgr)
  132. if err != nil {
  133. msg := fmt.Sprintf(errFailedSetSecret, err)
  134. cond := NewPushSecretCondition(esapi.PushSecretReady, v1.ConditionFalse, esapi.ReasonErrored, msg)
  135. ps = SetPushSecretCondition(ps, *cond)
  136. totalSecrets := mergeSecretState(syncedSecrets, ps.Status.SyncedPushSecrets)
  137. r.SetSyncedSecrets(&ps, totalSecrets)
  138. r.recorder.Event(&ps, v1.EventTypeWarning, esapi.ReasonErrored, msg)
  139. return ctrl.Result{}, err
  140. }
  141. switch ps.Spec.DeletionPolicy {
  142. case esapi.PushSecretDeletionPolicyDelete:
  143. badSyncState, err := r.DeleteSecretFromProviders(ctx, &ps, syncedSecrets, mgr)
  144. if err != nil {
  145. msg := fmt.Sprintf("Failed to Delete Secrets from Provider: %v", err)
  146. cond := NewPushSecretCondition(esapi.PushSecretReady, v1.ConditionFalse, esapi.ReasonErrored, msg)
  147. ps = SetPushSecretCondition(ps, *cond)
  148. r.SetSyncedSecrets(&ps, badSyncState)
  149. r.recorder.Event(&ps, v1.EventTypeWarning, esapi.ReasonErrored, msg)
  150. return ctrl.Result{}, err
  151. }
  152. case esapi.PushSecretDeletionPolicyNone:
  153. default:
  154. }
  155. msg := "PushSecret synced successfully"
  156. cond := NewPushSecretCondition(esapi.PushSecretReady, v1.ConditionTrue, esapi.ReasonSynced, msg)
  157. ps = SetPushSecretCondition(ps, *cond)
  158. r.SetSyncedSecrets(&ps, syncedSecrets)
  159. r.recorder.Event(&ps, v1.EventTypeNormal, esapi.ReasonSynced, msg)
  160. return ctrl.Result{RequeueAfter: refreshInt}, nil
  161. }
  162. func (r *Reconciler) SetSyncedSecrets(ps *esapi.PushSecret, status esapi.SyncedPushSecretsMap) {
  163. ps.Status.SyncedPushSecrets = status
  164. }
  165. func mergeSecretState(newMap, old esapi.SyncedPushSecretsMap) esapi.SyncedPushSecretsMap {
  166. out := newMap.DeepCopy()
  167. for k, v := range old {
  168. _, ok := out[k]
  169. if !ok {
  170. out[k] = make(map[string]esapi.PushSecretData)
  171. }
  172. for kk, vv := range v {
  173. out[k][kk] = vv
  174. }
  175. }
  176. return out
  177. }
  178. func (r *Reconciler) DeleteSecretFromProviders(ctx context.Context, ps *esapi.PushSecret, newMap esapi.SyncedPushSecretsMap, mgr *secretstore.Manager) (esapi.SyncedPushSecretsMap, error) {
  179. out := mergeSecretState(newMap, ps.Status.SyncedPushSecrets)
  180. for storeName, oldData := range ps.Status.SyncedPushSecrets {
  181. storeRef := v1beta1.SecretStoreRef{
  182. Name: strings.Split(storeName, "/")[1],
  183. Kind: strings.Split(storeName, "/")[0],
  184. }
  185. client, err := mgr.Get(ctx, storeRef, ps.Namespace, nil)
  186. if err != nil {
  187. return out, fmt.Errorf("could not get secrets client for store %v: %w", storeName, err)
  188. }
  189. newData, ok := newMap[storeName]
  190. if !ok {
  191. err = r.DeleteAllSecretsFromStore(ctx, client, oldData)
  192. if err != nil {
  193. return out, err
  194. }
  195. delete(out, storeName)
  196. continue
  197. }
  198. for oldEntry, oldRef := range oldData {
  199. _, ok := newData[oldEntry]
  200. if !ok {
  201. err = r.DeleteSecretFromStore(ctx, client, oldRef)
  202. if err != nil {
  203. return out, err
  204. }
  205. delete(out[storeName], oldRef.Match.RemoteRef.RemoteKey)
  206. }
  207. }
  208. }
  209. return out, nil
  210. }
  211. func (r *Reconciler) DeleteAllSecretsFromStore(ctx context.Context, client v1beta1.SecretsClient, data map[string]esapi.PushSecretData) error {
  212. for _, v := range data {
  213. err := r.DeleteSecretFromStore(ctx, client, v)
  214. if err != nil {
  215. return err
  216. }
  217. }
  218. return nil
  219. }
  220. func (r *Reconciler) DeleteSecretFromStore(ctx context.Context, client v1beta1.SecretsClient, data esapi.PushSecretData) error {
  221. return client.DeleteSecret(ctx, data.Match.RemoteRef)
  222. }
  223. func (r *Reconciler) PushSecretToProviders(ctx context.Context, stores map[esapi.PushSecretStoreRef]v1beta1.GenericStore, ps esapi.PushSecret, secret *v1.Secret, mgr *secretstore.Manager) (esapi.SyncedPushSecretsMap, error) {
  224. out := esapi.SyncedPushSecretsMap{}
  225. for ref, store := range stores {
  226. storeKey := fmt.Sprintf("%v/%v", ref.Kind, store.GetName())
  227. out[storeKey] = make(map[string]esapi.PushSecretData)
  228. storeRef := v1beta1.SecretStoreRef{
  229. Name: store.GetName(),
  230. Kind: ref.Kind,
  231. }
  232. client, err := mgr.Get(ctx, storeRef, ps.GetNamespace(), nil)
  233. if err != nil {
  234. return out, fmt.Errorf("could not get secrets client for store %v: %w", store.GetName(), err)
  235. }
  236. for _, ref := range ps.Spec.Data {
  237. secretValue, ok := secret.Data[ref.Match.SecretKey]
  238. if !ok {
  239. return out, fmt.Errorf("secret key %v does not exist", ref.Match.SecretKey)
  240. }
  241. err := client.PushSecret(ctx, secretValue, ref.Match.RemoteRef)
  242. if err != nil {
  243. return out, fmt.Errorf(errSetSecretFailed, ref.Match.SecretKey, store.GetName(), err)
  244. }
  245. out[storeKey][statusRef(ref.Match.RemoteRef)] = ref
  246. }
  247. }
  248. return out, nil
  249. }
  250. func (r *Reconciler) GetSecret(ctx context.Context, ps esapi.PushSecret) (*v1.Secret, error) {
  251. secretName := types.NamespacedName{Name: ps.Spec.Selector.Secret.Name, Namespace: ps.Namespace}
  252. secret := &v1.Secret{}
  253. err := r.Client.Get(ctx, secretName, secret)
  254. if err != nil {
  255. return nil, err
  256. }
  257. return secret, nil
  258. }
  259. func (r *Reconciler) GetSecretStores(ctx context.Context, ps esapi.PushSecret) (map[esapi.PushSecretStoreRef]v1beta1.GenericStore, error) {
  260. stores := make(map[esapi.PushSecretStoreRef]v1beta1.GenericStore)
  261. for _, refStore := range ps.Spec.SecretStoreRefs {
  262. if refStore.LabelSelector != nil {
  263. labelSelector, err := metav1.LabelSelectorAsSelector(refStore.LabelSelector)
  264. if err != nil {
  265. return nil, fmt.Errorf("could not convert labels: %w", err)
  266. }
  267. if refStore.Kind == v1beta1.ClusterSecretStoreKind {
  268. clusterSecretStoreList := v1beta1.ClusterSecretStoreList{}
  269. err = r.List(ctx, &clusterSecretStoreList, &client.ListOptions{LabelSelector: labelSelector})
  270. if err != nil {
  271. return nil, fmt.Errorf("could not list cluster Secret Stores: %w", err)
  272. }
  273. for k, v := range clusterSecretStoreList.Items {
  274. key := esapi.PushSecretStoreRef{
  275. Name: v.Name,
  276. Kind: v1beta1.ClusterSecretStoreKind,
  277. }
  278. stores[key] = &clusterSecretStoreList.Items[k]
  279. }
  280. } else {
  281. secretStoreList := v1beta1.SecretStoreList{}
  282. err = r.List(ctx, &secretStoreList, &client.ListOptions{LabelSelector: labelSelector})
  283. if err != nil {
  284. return nil, fmt.Errorf("could not list Secret Stores: %w", err)
  285. }
  286. for k, v := range secretStoreList.Items {
  287. key := esapi.PushSecretStoreRef{
  288. Name: v.Name,
  289. Kind: v1beta1.SecretStoreKind,
  290. }
  291. stores[key] = &secretStoreList.Items[k]
  292. }
  293. }
  294. } else {
  295. store, err := r.getSecretStoreFromName(ctx, refStore, ps.Namespace)
  296. if err != nil {
  297. return nil, err
  298. }
  299. stores[refStore] = store
  300. }
  301. }
  302. return stores, nil
  303. }
  304. func (r *Reconciler) getSecretStoreFromName(ctx context.Context, refStore esapi.PushSecretStoreRef, ns string) (v1beta1.GenericStore, error) {
  305. if refStore.Name == "" {
  306. return nil, fmt.Errorf("refStore Name must be provided")
  307. }
  308. ref := types.NamespacedName{
  309. Name: refStore.Name,
  310. }
  311. if refStore.Kind == v1beta1.ClusterSecretStoreKind {
  312. var store v1beta1.ClusterSecretStore
  313. err := r.Get(ctx, ref, &store)
  314. if err != nil {
  315. return nil, fmt.Errorf(errGetClusterSecretStore, ref.Name, err)
  316. }
  317. return &store, nil
  318. }
  319. ref.Namespace = ns
  320. var store v1beta1.SecretStore
  321. err := r.Get(ctx, ref, &store)
  322. if err != nil {
  323. return nil, fmt.Errorf(errGetSecretStore, ref.Name, err)
  324. }
  325. return &store, nil
  326. }
  327. func (r *Reconciler) SetupWithManager(mgr ctrl.Manager) error {
  328. r.recorder = mgr.GetEventRecorderFor("pushsecret")
  329. return ctrl.NewControllerManagedBy(mgr).
  330. For(&esapi.PushSecret{}).
  331. Complete(r)
  332. }
  333. func NewPushSecretCondition(condType esapi.PushSecretConditionType, status v1.ConditionStatus, reason, message string) *esapi.PushSecretStatusCondition {
  334. return &esapi.PushSecretStatusCondition{
  335. Type: condType,
  336. Status: status,
  337. LastTransitionTime: metav1.Now(),
  338. Reason: reason,
  339. Message: message,
  340. }
  341. }
  342. func SetPushSecretCondition(gs esapi.PushSecret, condition esapi.PushSecretStatusCondition) esapi.PushSecret {
  343. status := gs.Status
  344. currentCond := GetPushSecretCondition(status, condition.Type)
  345. if currentCond != nil && currentCond.Status == condition.Status &&
  346. currentCond.Reason == condition.Reason && currentCond.Message == condition.Message {
  347. return gs
  348. }
  349. // Do not update lastTransitionTime if the status of the condition doesn't change.
  350. if currentCond != nil && currentCond.Status == condition.Status {
  351. condition.LastTransitionTime = currentCond.LastTransitionTime
  352. }
  353. status.Conditions = append(filterOutCondition(status.Conditions, condition.Type), condition)
  354. gs.Status = status
  355. return gs
  356. }
  357. // filterOutCondition returns an empty set of conditions with the provided type.
  358. func filterOutCondition(conditions []esapi.PushSecretStatusCondition, condType esapi.PushSecretConditionType) []esapi.PushSecretStatusCondition {
  359. newConditions := make([]esapi.PushSecretStatusCondition, 0, len(conditions))
  360. for _, c := range conditions {
  361. if c.Type == condType {
  362. continue
  363. }
  364. newConditions = append(newConditions, c)
  365. }
  366. return newConditions
  367. }
  368. // GetSecretStoreCondition returns the condition with the provided type.
  369. func GetPushSecretCondition(status esapi.PushSecretStatus, condType esapi.PushSecretConditionType) *esapi.PushSecretStatusCondition {
  370. for i := range status.Conditions {
  371. c := status.Conditions[i]
  372. if c.Type == condType {
  373. return &c
  374. }
  375. }
  376. return nil
  377. }
  378. func statusRef(ref v1beta1.PushRemoteRef) string {
  379. if ref.GetProperty() != "" {
  380. return ref.GetRemoteKey() + "/" + ref.GetProperty()
  381. }
  382. return ref.GetRemoteKey()
  383. }