Browse Source

Address Divoom prompt review feedback

Alvin Unreal 3 months ago
parent
commit
0b13e01280
2 changed files with 9 additions and 9 deletions
  1. 5 5
      src/divoom/manager.ts
  2. 4 4
      src/index.ts

+ 5 - 5
src/divoom/manager.ts

@@ -216,11 +216,11 @@ export class DivoomManager {
     if (!sessionId) return;
     if (input.isOrchestrator) this.orchestratorBusy = false;
     this.parentStates.delete(sessionId);
-    for (const key of this.pendingUserInputs) {
-      if (key.startsWith(`${sessionId}:`)) {
-        this.pendingUserInputs.delete(key);
-      }
-    }
+    this.pendingUserInputs = new Set(
+      Array.from(this.pendingUserInputs).filter(
+        (key) => !key.startsWith(`${sessionId}:`),
+      ),
+    );
     this.render();
   }
 

+ 4 - 4
src/index.ts

@@ -803,11 +803,11 @@ const OhMyOpenCodeLite: Plugin = async (ctx) => {
         event.type === 'question.asked'
       ) {
         const props = event.properties as
-          | { sessionID?: string; id?: string }
+          | { sessionID?: string; id?: string; requestID?: string }
           | undefined;
         divoomManager.onUserInputRequired({
           sessionId: props?.sessionID,
-          requestId: props?.id,
+          requestId: props?.id ?? props?.requestID,
         });
       }
 
@@ -817,11 +817,11 @@ const OhMyOpenCodeLite: Plugin = async (ctx) => {
         event.type === 'question.rejected'
       ) {
         const props = event.properties as
-          | { sessionID?: string; requestID?: string }
+          | { sessionID?: string; requestID?: string; id?: string }
           | undefined;
         divoomManager.onUserInputResolved({
           sessionId: props?.sessionID,
-          requestId: props?.requestID,
+          requestId: props?.requestID ?? props?.id,
         });
       }