Explorar el Código

fix(opencode-go): remove dead mcps property from librarian mapping

createAgentConfig uses DEFAULT_AGENT_MCPS, so the hardcoded mcps in
MODEL_MAPPINGS was dead code. Add orchestartor variants to kimi, copilot,
and zai-plan presets for consistency. Fix doc claim about per-agent skills/mcps.
Michael Henke hace 2 meses
padre
commit
5d1107b761
Se han modificado 3 ficheros con 7 adiciones y 5 borrados
  1. 1 1
      docs/opencode-go-preset.md
  2. 2 0
      src/cli/providers.test.ts
  3. 4 4
      src/cli/providers.ts

+ 1 - 1
docs/opencode-go-preset.md

@@ -103,7 +103,7 @@ setting the top-level `preset` field:
 
 ## Skill Reference
 
-This preset defines no per-agent `skills` or `mcps`. All agents use whatever skills are globally installed (the `*` wildcard).
+This preset defines per-agent `skills` and `mcps` via `generateLiteConfig`. The generated config includes `skills: ["*"]` for Orchestrator and agent-specific MCP lists (e.g., Librarian gets `websearch`, `context7`, `gh_grep`).
 
 | Skill | Description | Source |
 | --- | --- | --- |

+ 2 - 0
src/cli/providers.test.ts

@@ -82,6 +82,8 @@ describe('providers', () => {
     expect(agents.oracle.variant).toBe('max');
     expect(agents.council).toBeUndefined();
     expect(agents.librarian.model).toBe('opencode-go/deepseek-v4-flash');
+    expect(agents.librarian.variant).toBe('high');
+    expect(agents.librarian.mcps).toEqual(['websearch', 'context7', 'gh_grep']);
     expect(agents.explorer.model).toBe('opencode-go/deepseek-v4-flash');
     expect(agents.designer.model).toBe('opencode-go/kimi-k2.7-code');
     expect(agents.fixer.model).toBe('opencode-go/deepseek-v4-flash');

+ 4 - 4
src/cli/providers.ts

@@ -18,7 +18,7 @@ export const MODEL_MAPPINGS = {
     fixer: { model: 'openai/gpt-5.6-luna', variant: 'medium' },
   },
   kimi: {
-    orchestrator: { model: 'kimi-for-coding/k2p5' },
+    orchestrator: { model: 'kimi-for-coding/k2p5', variant: 'max' },
     oracle: { model: 'kimi-for-coding/k2p5', variant: 'high' },
     librarian: { model: 'kimi-for-coding/k2p5', variant: 'low' },
     explorer: { model: 'kimi-for-coding/k2p5', variant: 'low' },
@@ -26,7 +26,7 @@ export const MODEL_MAPPINGS = {
     fixer: { model: 'kimi-for-coding/k2p5', variant: 'low' },
   },
   copilot: {
-    orchestrator: { model: 'github-copilot/claude-opus-4.6' },
+    orchestrator: { model: 'github-copilot/claude-opus-4.6', variant: 'max' },
     oracle: { model: 'github-copilot/claude-opus-4.6', variant: 'high' },
     librarian: { model: 'github-copilot/grok-code-fast-1', variant: 'low' },
     explorer: { model: 'github-copilot/grok-code-fast-1', variant: 'low' },
@@ -37,7 +37,7 @@ export const MODEL_MAPPINGS = {
     fixer: { model: 'github-copilot/claude-sonnet-4.6', variant: 'low' },
   },
   'zai-plan': {
-    orchestrator: { model: 'zai-coding-plan/glm-5' },
+    orchestrator: { model: 'zai-coding-plan/glm-5', variant: 'max' },
     oracle: { model: 'zai-coding-plan/glm-5', variant: 'high' },
     librarian: { model: 'zai-coding-plan/glm-5', variant: 'low' },
     explorer: { model: 'zai-coding-plan/glm-5', variant: 'low' },
@@ -48,7 +48,7 @@ export const MODEL_MAPPINGS = {
     orchestrator: { model: 'opencode-go/minimax-m3', variant: 'max' },
     oracle: { model: 'opencode-go/qwen3.7-max', variant: 'max' },
     explorer: { model: 'opencode-go/deepseek-v4-flash', variant: 'max' },
-    librarian: { model: 'opencode-go/deepseek-v4-flash', variant: 'high', mcps: ['websearch', 'context7', 'gh_grep'] },
+    librarian: { model: 'opencode-go/deepseek-v4-flash', variant: 'high' },
     designer: { model: 'opencode-go/kimi-k2.7-code', variant: 'medium' },
     fixer: { model: 'opencode-go/deepseek-v4-flash', variant: 'high' },
     observer: { model: 'opencode-go/mimo-v2.5', variant: 'max' },