session-manager.test.ts 70 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610161116121613161416151616161716181619162016211622162316241625162616271628162916301631163216331634163516361637163816391640164116421643164416451646164716481649165016511652165316541655165616571658165916601661166216631664166516661667166816691670167116721673167416751676167716781679168016811682168316841685168616871688168916901691169216931694169516961697169816991700170117021703170417051706170717081709171017111712171317141715171617171718171917201721172217231724172517261727172817291730173117321733173417351736173717381739174017411742174317441745174617471748174917501751175217531754175517561757175817591760176117621763176417651766176717681769177017711772177317741775177617771778177917801781178217831784178517861787178817891790179117921793179417951796179717981799180018011802180318041805180618071808180918101811181218131814181518161817181818191820182118221823182418251826182718281829183018311832183318341835183618371838183918401841184218431844184518461847184818491850185118521853185418551856185718581859186018611862186318641865186618671868186918701871187218731874187518761877187818791880188118821883188418851886188718881889189018911892189318941895189618971898189919001901190219031904190519061907190819091910191119121913191419151916191719181919192019211922192319241925192619271928192919301931193219331934193519361937193819391940194119421943194419451946194719481949195019511952195319541955195619571958195919601961196219631964196519661967196819691970197119721973197419751976197719781979198019811982198319841985198619871988198919901991199219931994199519961997199819992000200120022003200420052006200720082009201020112012201320142015201620172018201920202021202220232024202520262027202820292030203120322033203420352036203720382039204020412042204320442045204620472048204920502051205220532054205520562057205820592060206120622063206420652066206720682069207020712072207320742075207620772078207920802081208220832084208520862087208820892090209120922093209420952096209720982099210021012102210321042105210621072108210921102111211221132114211521162117211821192120212121222123212421252126212721282129213021312132213321342135213621372138213921402141214221432144214521462147214821492150215121522153215421552156215721582159216021612162216321642165216621672168216921702171217221732174217521762177217821792180218121822183218421852186218721882189219021912192219321942195219621972198219922002201220222032204220522062207220822092210221122122213221422152216221722182219222022212222222322242225222622272228222922302231223222332234223522362237223822392240224122422243224422452246224722482249225022512252225322542255225622572258225922602261226222632264226522662267
  1. import { afterEach, beforeEach, describe, expect, mock, test } from 'bun:test';
  2. import { BackgroundJobBoard } from '../utils/background-job-board';
  3. import { BackgroundJobCoordinator } from '../utils/background-job-coordinator';
  4. import {
  5. MultiplexerSessionManager,
  6. resetMultiplexerSessionManagerState,
  7. } from './session-manager';
  8. const originalFetch = globalThis.fetch;
  9. let mockSessionStatuses: Record<string, { type: string }> = {};
  10. const mockFetch = mock(
  11. async () =>
  12. new Response(JSON.stringify(mockSessionStatuses), {
  13. headers: { 'content-type': 'application/json' },
  14. status: 200,
  15. }),
  16. );
  17. // Define the mock multiplexer
  18. let mockMultiplexerType: 'tmux' | 'cmux' = 'tmux';
  19. const mockMultiplexer = {
  20. get type() {
  21. return mockMultiplexerType;
  22. },
  23. isAvailable: mock(async () => true),
  24. isInsideSession: mock(() => true),
  25. spawnPane: mock(async () => ({
  26. success: true,
  27. paneId: '%mock-pane',
  28. })),
  29. closePane: mock(async () => true),
  30. applyLayout: mock(async () => {}),
  31. };
  32. const mockIsServerRunning = mock(async () => true);
  33. // Mock the multiplexer module
  34. mock.module('../multiplexer', () => ({
  35. getMultiplexer: () => mockMultiplexer,
  36. isServerRunning: mockIsServerRunning,
  37. startAvailabilityCheck: () => {},
  38. }));
  39. // Mock the plugin context
  40. function createMockContext(overrides?: {
  41. sessionStatusResult?: { data?: Record<string, { type: string }> };
  42. directory?: string;
  43. serverUrl?: string;
  44. }) {
  45. const defaultPort = process.env.OPENCODE_PORT ?? '4096';
  46. return {
  47. client: {
  48. session: {
  49. status: mock(
  50. async () => overrides?.sessionStatusResult ?? { data: {} },
  51. ),
  52. },
  53. },
  54. directory: overrides?.directory ?? '/test/directory',
  55. serverUrl: new URL(
  56. overrides?.serverUrl ?? `http://localhost:${defaultPort}`,
  57. ),
  58. } as any;
  59. }
  60. function setMockSessionStatuses(statuses: Record<string, { type: string }>) {
  61. mockSessionStatuses = statuses;
  62. }
  63. const defaultMultiplexerConfig = {
  64. type: 'tmux' as const,
  65. layout: 'main-vertical' as const,
  66. main_pane_size: 60,
  67. zellij_pane_mode: 'agent-tab' as const,
  68. };
  69. function createDeferred<T>() {
  70. let resolve!: (value: T) => void;
  71. let reject!: (reason?: unknown) => void;
  72. const promise = new Promise<T>((res, rej) => {
  73. resolve = res;
  74. reject = rej;
  75. });
  76. return { promise, resolve, reject };
  77. }
  78. async function flushPromises(count = 8): Promise<void> {
  79. for (let index = 0; index < count; index++) await Promise.resolve();
  80. }
  81. describe('MultiplexerSessionManager', () => {
  82. beforeEach(() => {
  83. resetMultiplexerSessionManagerState();
  84. mockSessionStatuses = {};
  85. mockFetch.mockClear();
  86. globalThis.fetch = mockFetch as typeof fetch;
  87. mockMultiplexer.spawnPane.mockReset();
  88. mockMultiplexer.spawnPane.mockResolvedValue({
  89. success: true,
  90. paneId: '%mock-pane',
  91. });
  92. mockMultiplexer.closePane.mockReset();
  93. mockMultiplexer.closePane.mockResolvedValue(true);
  94. mockMultiplexer.isInsideSession.mockReset();
  95. mockMultiplexer.isInsideSession.mockReturnValue(true);
  96. mockMultiplexerType = 'tmux';
  97. mockIsServerRunning.mockReset();
  98. mockIsServerRunning.mockResolvedValue(true);
  99. });
  100. afterEach(() => {
  101. globalThis.fetch = originalFetch;
  102. });
  103. describe('constructor', () => {
  104. test('initializes with config', () => {
  105. const ctx = createMockContext();
  106. const manager = new MultiplexerSessionManager(
  107. ctx,
  108. defaultMultiplexerConfig,
  109. );
  110. expect(manager).toBeDefined();
  111. });
  112. });
  113. describe('onSessionCreated', () => {
  114. test('spawns pane for child sessions', async () => {
  115. const ctx = createMockContext();
  116. const manager = new MultiplexerSessionManager(
  117. ctx,
  118. defaultMultiplexerConfig,
  119. );
  120. await manager.onSessionCreated({
  121. type: 'session.created',
  122. properties: {
  123. info: {
  124. id: 'child-123',
  125. parentID: 'parent-456',
  126. title: 'Test Worker',
  127. },
  128. },
  129. });
  130. expect(mockMultiplexer.spawnPane).toHaveBeenCalled();
  131. expect(mockMultiplexer.spawnPane).toHaveBeenCalledWith(
  132. 'child-123',
  133. 'Test Worker',
  134. `http://localhost:${process.env.OPENCODE_PORT ?? '4096'}/`,
  135. '/test/directory',
  136. );
  137. });
  138. test('ignores sessions without parentID', async () => {
  139. const ctx = createMockContext();
  140. const manager = new MultiplexerSessionManager(
  141. ctx,
  142. defaultMultiplexerConfig,
  143. );
  144. await manager.onSessionCreated({
  145. type: 'session.created',
  146. properties: {
  147. info: {
  148. id: 'root-session',
  149. title: 'Main Chat',
  150. },
  151. },
  152. });
  153. expect(mockMultiplexer.spawnPane).not.toHaveBeenCalled();
  154. });
  155. test('prefers child session directory when present', async () => {
  156. const ctx = createMockContext({ directory: '/parent/directory' });
  157. const manager = new MultiplexerSessionManager(
  158. ctx,
  159. defaultMultiplexerConfig,
  160. );
  161. await manager.onSessionCreated({
  162. type: 'session.created',
  163. properties: {
  164. info: {
  165. id: 'child-456',
  166. parentID: 'parent-456',
  167. title: 'Nested Worker',
  168. directory: '/child/directory',
  169. },
  170. },
  171. });
  172. expect(mockMultiplexer.spawnPane).toHaveBeenCalledWith(
  173. 'child-456',
  174. 'Nested Worker',
  175. `http://localhost:${process.env.OPENCODE_PORT ?? '4096'}/`,
  176. '/child/directory',
  177. );
  178. });
  179. test('ignores if disabled in config', async () => {
  180. const ctx = createMockContext();
  181. const manager = new MultiplexerSessionManager(ctx, {
  182. ...defaultMultiplexerConfig,
  183. type: 'none',
  184. });
  185. await manager.onSessionCreated({
  186. type: 'session.created',
  187. properties: {
  188. info: { id: 'child', parentID: 'parent' },
  189. },
  190. });
  191. expect(mockMultiplexer.spawnPane).not.toHaveBeenCalled();
  192. });
  193. test('does not spawn twice for duplicate create events while spawning', async () => {
  194. const ctx = createMockContext();
  195. const manager = new MultiplexerSessionManager(
  196. ctx,
  197. defaultMultiplexerConfig,
  198. );
  199. const deferred = createDeferred<{ success: true; paneId: string }>();
  200. mockMultiplexer.spawnPane.mockImplementationOnce(() => deferred.promise);
  201. const event = {
  202. type: 'session.created',
  203. properties: {
  204. info: {
  205. id: 'child-race',
  206. parentID: 'parent-race',
  207. title: 'Race Worker',
  208. },
  209. },
  210. };
  211. const firstCreate = manager.onSessionCreated(event);
  212. const secondCreate = manager.onSessionCreated(event);
  213. await Promise.resolve();
  214. expect(mockMultiplexer.spawnPane).toHaveBeenCalledTimes(1);
  215. deferred.resolve({ success: true, paneId: 'p-race' });
  216. await Promise.all([firstCreate, secondCreate]);
  217. expect(mockMultiplexer.spawnPane).toHaveBeenCalledTimes(1);
  218. });
  219. });
  220. describe('polling and closure', () => {
  221. test('closes pane when session becomes idle', async () => {
  222. const ctx = createMockContext();
  223. mockMultiplexer.spawnPane.mockResolvedValue({
  224. success: true,
  225. paneId: 'p-1',
  226. });
  227. const manager = new MultiplexerSessionManager(
  228. ctx,
  229. defaultMultiplexerConfig,
  230. );
  231. // Register session
  232. await manager.onSessionCreated({
  233. type: 'session.created',
  234. properties: { info: { id: 'c1', parentID: 'p1' } },
  235. });
  236. setMockSessionStatuses({ c1: { type: 'idle' } });
  237. await (manager as any).pollSessions();
  238. expect(mockMultiplexer.closePane).toHaveBeenCalledWith('p-1');
  239. });
  240. test('closes pane immediately on session.idle event', async () => {
  241. const ctx = createMockContext();
  242. mockMultiplexer.spawnPane.mockResolvedValue({
  243. success: true,
  244. paneId: 'p-idle-event',
  245. });
  246. const manager = new MultiplexerSessionManager(
  247. ctx,
  248. defaultMultiplexerConfig,
  249. );
  250. await manager.onSessionCreated({
  251. type: 'session.created',
  252. properties: { info: { id: 'idle-event-child', parentID: 'parent' } },
  253. });
  254. await manager.onSessionStatus({
  255. type: 'session.idle',
  256. properties: { sessionID: 'idle-event-child' },
  257. });
  258. expect(mockMultiplexer.closePane).toHaveBeenCalledWith('p-idle-event');
  259. expect(mockFetch).not.toHaveBeenCalled();
  260. });
  261. test('does not close another manager instance pane on idle event', async () => {
  262. const ctx = createMockContext();
  263. mockMultiplexer.spawnPane.mockResolvedValue({
  264. success: true,
  265. paneId: 'p-shared-idle',
  266. });
  267. const spawningManager = new MultiplexerSessionManager(
  268. ctx,
  269. defaultMultiplexerConfig,
  270. );
  271. const idleManager = new MultiplexerSessionManager(
  272. ctx,
  273. defaultMultiplexerConfig,
  274. );
  275. await spawningManager.onSessionCreated({
  276. type: 'session.created',
  277. properties: { info: { id: 'shared-child', parentID: 'parent' } },
  278. });
  279. await idleManager.onSessionStatus({
  280. type: 'session.idle',
  281. properties: { sessionID: 'shared-child' },
  282. });
  283. expect(mockMultiplexer.closePane).not.toHaveBeenCalled();
  284. });
  285. test('respawns resumed known session from a different manager instance', async () => {
  286. const ctx = createMockContext();
  287. mockMultiplexer.spawnPane
  288. .mockResolvedValueOnce({
  289. success: true,
  290. paneId: 'p-first',
  291. })
  292. .mockResolvedValueOnce({
  293. success: true,
  294. paneId: 'p-resumed',
  295. });
  296. const firstManager = new MultiplexerSessionManager(
  297. ctx,
  298. defaultMultiplexerConfig,
  299. );
  300. const secondManager = new MultiplexerSessionManager(
  301. ctx,
  302. defaultMultiplexerConfig,
  303. );
  304. await firstManager.onSessionCreated({
  305. type: 'session.created',
  306. properties: {
  307. info: {
  308. id: 'resumed-child',
  309. parentID: 'parent',
  310. title: 'Resumed Worker',
  311. directory: '/resumed/dir',
  312. },
  313. },
  314. });
  315. await firstManager.onSessionStatus({
  316. type: 'session.idle',
  317. properties: { sessionID: 'resumed-child' },
  318. });
  319. await secondManager.onSessionStatus({
  320. type: 'session.status',
  321. properties: {
  322. sessionID: 'resumed-child',
  323. status: { type: 'busy' },
  324. },
  325. });
  326. expect(mockMultiplexer.spawnPane).toHaveBeenCalledTimes(2);
  327. expect(mockMultiplexer.spawnPane).toHaveBeenLastCalledWith(
  328. 'resumed-child',
  329. 'Resumed Worker',
  330. `http://localhost:${process.env.OPENCODE_PORT ?? '4096'}/`,
  331. '/resumed/dir',
  332. );
  333. });
  334. test('does not close running background child pane on idle event', async () => {
  335. const ctx = createMockContext();
  336. const board = new BackgroundJobBoard();
  337. board.registerLaunch({
  338. taskID: 'running-idle-child',
  339. parentSessionID: 'parent-1',
  340. agent: 'explorer',
  341. });
  342. mockMultiplexer.spawnPane.mockResolvedValue({
  343. success: true,
  344. paneId: 'p-running-idle-child',
  345. });
  346. const manager = new MultiplexerSessionManager(
  347. ctx,
  348. defaultMultiplexerConfig,
  349. board,
  350. );
  351. await manager.onSessionCreated({
  352. type: 'session.created',
  353. properties: {
  354. info: { id: 'running-idle-child', parentID: 'parent-1' },
  355. },
  356. });
  357. await manager.onSessionStatus({
  358. type: 'session.status',
  359. properties: {
  360. sessionID: 'running-idle-child',
  361. status: { type: 'idle' },
  362. },
  363. });
  364. expect(mockMultiplexer.closePane).not.toHaveBeenCalled();
  365. });
  366. test('timed out running jobs still close after safe recovery and completion', async () => {
  367. const ctx = createMockContext();
  368. const board = new BackgroundJobBoard();
  369. const coordinator = new BackgroundJobCoordinator(board);
  370. board.registerLaunch({
  371. taskID: 'timedout-child',
  372. parentSessionID: 'parent-1',
  373. agent: 'explorer',
  374. });
  375. board.updateStatus({
  376. taskID: 'timedout-child',
  377. state: 'running',
  378. timedOut: true,
  379. now: 100,
  380. });
  381. mockMultiplexer.spawnPane.mockResolvedValue({
  382. success: true,
  383. paneId: 'p-timedout-child',
  384. });
  385. const manager = new MultiplexerSessionManager(
  386. ctx,
  387. defaultMultiplexerConfig,
  388. coordinator,
  389. );
  390. coordinator.addTerminalStateListener((sessionId) => {
  391. void manager.closeSessionFromCoordinator(sessionId);
  392. });
  393. await manager.onSessionCreated({
  394. type: 'session.created',
  395. properties: {
  396. info: { id: 'timedout-child', parentID: 'parent-1' },
  397. },
  398. });
  399. await manager.onSessionStatus({
  400. type: 'session.status',
  401. properties: {
  402. sessionID: 'timedout-child',
  403. status: { type: 'idle' },
  404. },
  405. });
  406. expect(mockMultiplexer.closePane).not.toHaveBeenCalled();
  407. await manager.onSessionStatus({
  408. type: 'session.status',
  409. properties: {
  410. sessionID: 'timedout-child',
  411. status: { type: 'busy' },
  412. },
  413. });
  414. expect(mockMultiplexer.closePane).not.toHaveBeenCalled();
  415. board.updateStatus({
  416. taskID: 'timedout-child',
  417. state: 'completed',
  418. resultSummary: 'done',
  419. });
  420. await Promise.resolve();
  421. expect(mockMultiplexer.closePane).toHaveBeenCalledWith(
  422. 'p-timedout-child',
  423. );
  424. });
  425. test('deferred idle closes retry on terminal status updates', async () => {
  426. for (const state of ['completed', 'error', 'cancelled'] as const) {
  427. resetMultiplexerSessionManagerState();
  428. mockMultiplexer.spawnPane.mockClear();
  429. mockMultiplexer.closePane.mockClear();
  430. const ctx = createMockContext();
  431. const board = new BackgroundJobBoard();
  432. const coordinator = new BackgroundJobCoordinator(board);
  433. const sessionId = `deferred-${state}`;
  434. board.registerLaunch({
  435. taskID: sessionId,
  436. parentSessionID: 'parent-1',
  437. agent: 'explorer',
  438. });
  439. mockMultiplexer.spawnPane.mockResolvedValueOnce({
  440. success: true,
  441. paneId: `p-${state}`,
  442. });
  443. const manager = new MultiplexerSessionManager(
  444. ctx,
  445. defaultMultiplexerConfig,
  446. coordinator,
  447. );
  448. coordinator.addTerminalStateListener((sessionId) => {
  449. void manager.closeSessionFromCoordinator(sessionId);
  450. });
  451. await manager.onSessionCreated({
  452. type: 'session.created',
  453. properties: { info: { id: sessionId, parentID: 'parent-1' } },
  454. });
  455. await manager.onSessionStatus({
  456. type: 'session.status',
  457. properties: { sessionID: sessionId, status: { type: 'idle' } },
  458. });
  459. expect(mockMultiplexer.closePane).not.toHaveBeenCalled();
  460. board.updateStatus({ taskID: sessionId, state });
  461. await Promise.resolve();
  462. expect(mockMultiplexer.closePane).toHaveBeenCalledWith(`p-${state}`);
  463. }
  464. });
  465. test('deferred idle close retries on markCancelled', async () => {
  466. const ctx = createMockContext();
  467. const board = new BackgroundJobBoard();
  468. const coordinator = new BackgroundJobCoordinator(board);
  469. board.registerLaunch({
  470. taskID: 'deferred-cancel',
  471. parentSessionID: 'parent-1',
  472. agent: 'explorer',
  473. });
  474. mockMultiplexer.spawnPane.mockResolvedValue({
  475. success: true,
  476. paneId: 'p-deferred-cancel',
  477. });
  478. const manager = new MultiplexerSessionManager(
  479. ctx,
  480. defaultMultiplexerConfig,
  481. coordinator,
  482. );
  483. coordinator.addTerminalStateListener((sessionId) => {
  484. void manager.closeSessionFromCoordinator(sessionId);
  485. });
  486. await manager.onSessionCreated({
  487. type: 'session.created',
  488. properties: { info: { id: 'deferred-cancel', parentID: 'parent-1' } },
  489. });
  490. await manager.onSessionStatus({
  491. type: 'session.status',
  492. properties: {
  493. sessionID: 'deferred-cancel',
  494. status: { type: 'idle' },
  495. },
  496. });
  497. board.markCancelled('deferred-cancel');
  498. await Promise.resolve();
  499. expect(mockMultiplexer.closePane).toHaveBeenCalledWith(
  500. 'p-deferred-cancel',
  501. );
  502. });
  503. test('terminal status without deferred idle close does not close pane', async () => {
  504. const ctx = createMockContext();
  505. const board = new BackgroundJobBoard();
  506. const coordinator = new BackgroundJobCoordinator(board);
  507. board.registerLaunch({
  508. taskID: 'terminal-without-defer',
  509. parentSessionID: 'parent-1',
  510. agent: 'explorer',
  511. });
  512. mockMultiplexer.spawnPane.mockResolvedValue({
  513. success: true,
  514. paneId: 'p-terminal-without-defer',
  515. });
  516. const manager = new MultiplexerSessionManager(
  517. ctx,
  518. defaultMultiplexerConfig,
  519. coordinator,
  520. );
  521. coordinator.addTerminalStateListener((sessionId) => {
  522. void manager.closeSessionFromCoordinator(sessionId);
  523. });
  524. await manager.onSessionCreated({
  525. type: 'session.created',
  526. properties: {
  527. info: { id: 'terminal-without-defer', parentID: 'parent-1' },
  528. },
  529. });
  530. board.updateStatus({
  531. taskID: 'terminal-without-defer',
  532. state: 'completed',
  533. });
  534. await Promise.resolve();
  535. expect(mockMultiplexer.closePane).not.toHaveBeenCalled();
  536. });
  537. test('deleted clears deferred idle close and later terminal update is no-op', async () => {
  538. const ctx = createMockContext();
  539. const board = new BackgroundJobBoard();
  540. const coordinator = new BackgroundJobCoordinator(board);
  541. board.registerLaunch({
  542. taskID: 'deleted-deferred',
  543. parentSessionID: 'parent-1',
  544. agent: 'explorer',
  545. });
  546. mockMultiplexer.spawnPane.mockResolvedValue({
  547. success: true,
  548. paneId: 'p-deleted-deferred',
  549. });
  550. const manager = new MultiplexerSessionManager(
  551. ctx,
  552. defaultMultiplexerConfig,
  553. coordinator,
  554. );
  555. coordinator.addTerminalStateListener((sessionId) => {
  556. void manager.closeSessionFromCoordinator(sessionId);
  557. });
  558. await manager.onSessionCreated({
  559. type: 'session.created',
  560. properties: { info: { id: 'deleted-deferred', parentID: 'parent-1' } },
  561. });
  562. await manager.onSessionStatus({
  563. type: 'session.status',
  564. properties: { sessionID: 'deleted-deferred', status: { type: 'idle' } },
  565. });
  566. await manager.onSessionDeleted({
  567. type: 'session.deleted',
  568. properties: { sessionID: 'deleted-deferred' },
  569. });
  570. board.updateStatus({ taskID: 'deleted-deferred', state: 'completed' });
  571. await Promise.resolve();
  572. expect(mockMultiplexer.closePane).toHaveBeenCalledTimes(1);
  573. expect(mockMultiplexer.closePane).toHaveBeenCalledWith(
  574. 'p-deleted-deferred',
  575. );
  576. });
  577. test('retry while still running keeps deferred idle close', async () => {
  578. const ctx = createMockContext();
  579. const board = new BackgroundJobBoard();
  580. const coordinator = new BackgroundJobCoordinator(board);
  581. board.registerLaunch({
  582. taskID: 'still-running-deferred',
  583. parentSessionID: 'parent-1',
  584. agent: 'explorer',
  585. });
  586. mockMultiplexer.spawnPane.mockResolvedValue({
  587. success: true,
  588. paneId: 'p-still-running-deferred',
  589. });
  590. const manager = new MultiplexerSessionManager(
  591. ctx,
  592. defaultMultiplexerConfig,
  593. coordinator,
  594. );
  595. coordinator.addTerminalStateListener((sessionId) => {
  596. void manager.closeSessionFromCoordinator(sessionId);
  597. });
  598. await manager.onSessionCreated({
  599. type: 'session.created',
  600. properties: {
  601. info: { id: 'still-running-deferred', parentID: 'parent-1' },
  602. },
  603. });
  604. await manager.onSessionStatus({
  605. type: 'session.status',
  606. properties: {
  607. sessionID: 'still-running-deferred',
  608. status: { type: 'idle' },
  609. },
  610. });
  611. // The coordinator's terminal state listener will handle the close
  612. // when the job completes, so we don't need to call retryDeferredIdleClose directly
  613. expect(mockMultiplexer.closePane).not.toHaveBeenCalled();
  614. board.updateStatus({
  615. taskID: 'still-running-deferred',
  616. state: 'completed',
  617. });
  618. await Promise.resolve();
  619. expect(mockMultiplexer.closePane).toHaveBeenCalledWith(
  620. 'p-still-running-deferred',
  621. );
  622. });
  623. test('disabled manager does not retry deferred idle close', async () => {
  624. const ctx = createMockContext();
  625. const board = new BackgroundJobBoard();
  626. const coordinator = new BackgroundJobCoordinator(board);
  627. board.registerLaunch({
  628. taskID: 'disabled-retry-deferred',
  629. parentSessionID: 'parent-1',
  630. agent: 'explorer',
  631. });
  632. mockMultiplexer.spawnPane.mockResolvedValue({
  633. success: true,
  634. paneId: 'p-disabled-retry-deferred',
  635. });
  636. const manager = new MultiplexerSessionManager(
  637. ctx,
  638. defaultMultiplexerConfig,
  639. coordinator,
  640. );
  641. await manager.onSessionCreated({
  642. type: 'session.created',
  643. properties: {
  644. info: { id: 'disabled-retry-deferred', parentID: 'parent-1' },
  645. },
  646. });
  647. await manager.onSessionStatus({
  648. type: 'session.status',
  649. properties: {
  650. sessionID: 'disabled-retry-deferred',
  651. status: { type: 'idle' },
  652. },
  653. });
  654. mockMultiplexer.isInsideSession.mockReturnValue(false);
  655. const _disabledManager = new MultiplexerSessionManager(
  656. ctx,
  657. defaultMultiplexerConfig,
  658. coordinator,
  659. );
  660. // The coordinator's terminal state listener will handle the close
  661. // when the job completes, but the disabled manager should not close
  662. expect(mockMultiplexer.closePane).not.toHaveBeenCalled();
  663. });
  664. test('explicit non-idle status event clears stale deferred idle close', async () => {
  665. const ctx = createMockContext();
  666. const board = new BackgroundJobBoard();
  667. const coordinator = new BackgroundJobCoordinator(board);
  668. board.registerLaunch({
  669. taskID: 'retry-event-deferred',
  670. parentSessionID: 'parent-1',
  671. agent: 'explorer',
  672. });
  673. mockMultiplexer.spawnPane.mockResolvedValue({
  674. success: true,
  675. paneId: 'p-retry-event-deferred',
  676. });
  677. const manager = new MultiplexerSessionManager(
  678. ctx,
  679. defaultMultiplexerConfig,
  680. coordinator,
  681. );
  682. coordinator.addTerminalStateListener((sessionId) => {
  683. void manager.closeSessionFromCoordinator(sessionId);
  684. });
  685. await manager.onSessionCreated({
  686. type: 'session.created',
  687. properties: {
  688. info: { id: 'retry-event-deferred', parentID: 'parent-1' },
  689. },
  690. });
  691. await manager.onSessionStatus({
  692. type: 'session.status',
  693. properties: {
  694. sessionID: 'retry-event-deferred',
  695. status: { type: 'idle' },
  696. },
  697. });
  698. await manager.onSessionStatus({
  699. type: 'session.status',
  700. properties: {
  701. sessionID: 'retry-event-deferred',
  702. status: { type: 'retry' },
  703. },
  704. });
  705. board.updateStatus({
  706. taskID: 'retry-event-deferred',
  707. state: 'completed',
  708. });
  709. await Promise.resolve();
  710. expect(mockMultiplexer.closePane).not.toHaveBeenCalled();
  711. await manager.onSessionStatus({
  712. type: 'session.status',
  713. properties: {
  714. sessionID: 'retry-event-deferred',
  715. status: { type: 'idle' },
  716. },
  717. });
  718. expect(mockMultiplexer.closePane).toHaveBeenCalledWith(
  719. 'p-retry-event-deferred',
  720. );
  721. });
  722. test('explicit non-idle poll clears stale deferred idle close', async () => {
  723. const ctx = createMockContext();
  724. const board = new BackgroundJobBoard();
  725. const coordinator = new BackgroundJobCoordinator(board);
  726. board.registerLaunch({
  727. taskID: 'resumed-deferred',
  728. parentSessionID: 'parent-1',
  729. agent: 'explorer',
  730. });
  731. mockMultiplexer.spawnPane.mockResolvedValue({
  732. success: true,
  733. paneId: 'p-resumed-deferred',
  734. });
  735. const manager = new MultiplexerSessionManager(
  736. ctx,
  737. defaultMultiplexerConfig,
  738. coordinator,
  739. );
  740. coordinator.addTerminalStateListener((sessionId) => {
  741. void manager.closeSessionFromCoordinator(sessionId);
  742. });
  743. await manager.onSessionCreated({
  744. type: 'session.created',
  745. properties: { info: { id: 'resumed-deferred', parentID: 'parent-1' } },
  746. });
  747. await manager.onSessionStatus({
  748. type: 'session.status',
  749. properties: {
  750. sessionID: 'resumed-deferred',
  751. status: { type: 'idle' },
  752. },
  753. });
  754. setMockSessionStatuses({ 'resumed-deferred': { type: 'busy' } });
  755. await (manager as any).pollSessions();
  756. board.updateStatus({ taskID: 'resumed-deferred', state: 'completed' });
  757. await Promise.resolve();
  758. expect(mockMultiplexer.closePane).not.toHaveBeenCalled();
  759. await manager.onSessionStatus({
  760. type: 'session.status',
  761. properties: {
  762. sessionID: 'resumed-deferred',
  763. status: { type: 'idle' },
  764. },
  765. });
  766. expect(mockMultiplexer.closePane).toHaveBeenCalledWith(
  767. 'p-resumed-deferred',
  768. );
  769. });
  770. test('does not close on transient status absence', async () => {
  771. const ctx = createMockContext();
  772. const manager = new MultiplexerSessionManager(
  773. ctx,
  774. defaultMultiplexerConfig,
  775. );
  776. await manager.onSessionCreated({
  777. type: 'session.created',
  778. properties: { info: { id: 'c1', parentID: 'p1' } },
  779. });
  780. setMockSessionStatuses({});
  781. await (manager as any).pollSessions();
  782. expect(mockMultiplexer.closePane).not.toHaveBeenCalled();
  783. });
  784. test('keeps background child pane open while status is running until deleted', async () => {
  785. const ctx = createMockContext();
  786. const manager = new MultiplexerSessionManager(
  787. ctx,
  788. defaultMultiplexerConfig,
  789. );
  790. mockMultiplexer.spawnPane.mockResolvedValueOnce({
  791. success: true,
  792. paneId: 'p-background-child',
  793. });
  794. await manager.onSessionCreated({
  795. type: 'session.created',
  796. properties: {
  797. info: {
  798. id: 'background-child',
  799. parentID: 'parent-1',
  800. title: 'Background Worker',
  801. },
  802. },
  803. });
  804. setMockSessionStatuses({ 'background-child': { type: 'running' } });
  805. await (manager as any).pollSessions();
  806. await (manager as any).pollSessions();
  807. expect(mockMultiplexer.closePane).not.toHaveBeenCalled();
  808. await manager.onSessionDeleted({
  809. type: 'session.deleted',
  810. properties: { info: { id: 'background-child' } },
  811. });
  812. expect(mockMultiplexer.closePane).toHaveBeenCalledTimes(1);
  813. expect(mockMultiplexer.closePane).toHaveBeenCalledWith(
  814. 'p-background-child',
  815. );
  816. });
  817. test('missing status does not close never-seen pane', async () => {
  818. const ctx = createMockContext();
  819. mockMultiplexer.spawnPane.mockResolvedValue({
  820. success: true,
  821. paneId: 'p-never-seen-orphan',
  822. });
  823. const manager = new MultiplexerSessionManager(
  824. ctx,
  825. defaultMultiplexerConfig,
  826. );
  827. await manager.onSessionCreated({
  828. type: 'session.created',
  829. properties: { info: { id: 'never-seen-orphan', parentID: 'p1' } },
  830. });
  831. setMockSessionStatuses({});
  832. await (manager as any).pollSessions();
  833. expect(mockMultiplexer.closePane).not.toHaveBeenCalled();
  834. });
  835. test('ignores empty session status response without closing panes', async () => {
  836. const ctx = createMockContext();
  837. mockMultiplexer.spawnPane.mockResolvedValue({
  838. success: true,
  839. paneId: 'p-empty-status',
  840. });
  841. const manager = new MultiplexerSessionManager(
  842. ctx,
  843. defaultMultiplexerConfig,
  844. );
  845. await manager.onSessionCreated({
  846. type: 'session.created',
  847. properties: { info: { id: 'empty-status', parentID: 'p1' } },
  848. });
  849. mockFetch.mockImplementationOnce(
  850. async () => new Response('', { status: 200 }),
  851. );
  852. await (manager as any).pollSessions();
  853. expect(mockMultiplexer.closePane).not.toHaveBeenCalled();
  854. });
  855. test('previously seen then missing does not close pane', async () => {
  856. const ctx = createMockContext();
  857. mockMultiplexer.spawnPane.mockResolvedValue({
  858. success: true,
  859. paneId: 'p-seen-before-missing',
  860. });
  861. const manager = new MultiplexerSessionManager(
  862. ctx,
  863. defaultMultiplexerConfig,
  864. );
  865. await manager.onSessionCreated({
  866. type: 'session.created',
  867. properties: { info: { id: 'seen-before-missing', parentID: 'p1' } },
  868. });
  869. setMockSessionStatuses({ 'seen-before-missing': { type: 'busy' } });
  870. await (manager as any).pollSessions();
  871. setMockSessionStatuses({});
  872. await (manager as any).pollSessions();
  873. expect(mockMultiplexer.closePane).not.toHaveBeenCalled();
  874. });
  875. test('missing then busy does not duplicate respawn', async () => {
  876. const ctx = createMockContext();
  877. mockMultiplexer.spawnPane.mockResolvedValue({
  878. success: true,
  879. paneId: 'p-missing-then-busy',
  880. });
  881. const manager = new MultiplexerSessionManager(
  882. ctx,
  883. defaultMultiplexerConfig,
  884. );
  885. await manager.onSessionCreated({
  886. type: 'session.created',
  887. properties: { info: { id: 'missing-then-busy', parentID: 'p1' } },
  888. });
  889. setMockSessionStatuses({});
  890. await (manager as any).pollSessions();
  891. await manager.onSessionStatus({
  892. type: 'session.status',
  893. properties: {
  894. sessionID: 'missing-then-busy',
  895. status: { type: 'busy' },
  896. },
  897. });
  898. expect(mockMultiplexer.closePane).not.toHaveBeenCalled();
  899. expect(mockMultiplexer.spawnPane).toHaveBeenCalledTimes(1);
  900. });
  901. test('polls the actual serverUrl instead of the plugin SDK default URL', async () => {
  902. const ctx = createMockContext({
  903. serverUrl: 'http://127.0.0.1:63871/',
  904. sessionStatusResult: { data: {} },
  905. });
  906. const manager = new MultiplexerSessionManager(
  907. ctx,
  908. defaultMultiplexerConfig,
  909. );
  910. await manager.onSessionCreated({
  911. type: 'session.created',
  912. properties: { info: { id: 'child-live', parentID: 'parent-live' } },
  913. });
  914. setMockSessionStatuses({ 'child-live': { type: 'busy' } });
  915. await (manager as any).pollSessions();
  916. expect(ctx.client.session.status).not.toHaveBeenCalled();
  917. expect(mockFetch).toHaveBeenCalledWith(
  918. new URL('http://127.0.0.1:63871/session/status'),
  919. expect.any(Object),
  920. );
  921. expect(mockMultiplexer.closePane).not.toHaveBeenCalled();
  922. });
  923. test('respawns pane on later busy after idle close for resumable session', async () => {
  924. const ctx = createMockContext();
  925. const manager = new MultiplexerSessionManager(
  926. ctx,
  927. defaultMultiplexerConfig,
  928. );
  929. mockMultiplexer.spawnPane
  930. .mockResolvedValueOnce({
  931. success: true,
  932. paneId: 'p-1',
  933. })
  934. .mockResolvedValueOnce({
  935. success: true,
  936. paneId: 'p-2',
  937. });
  938. await manager.onSessionCreated({
  939. type: 'session.created',
  940. properties: {
  941. info: {
  942. id: 'child-789',
  943. parentID: 'parent-789',
  944. title: 'Worker',
  945. directory: '/task/dir',
  946. },
  947. },
  948. });
  949. setMockSessionStatuses({ 'child-789': { type: 'idle' } });
  950. await (manager as any).pollSessions();
  951. await manager.onSessionStatus({
  952. type: 'session.status',
  953. properties: {
  954. sessionID: 'child-789',
  955. status: { type: 'busy' },
  956. },
  957. });
  958. expect(mockMultiplexer.spawnPane).toHaveBeenCalledTimes(2);
  959. expect(mockMultiplexer.spawnPane).toHaveBeenCalledWith(
  960. 'child-789',
  961. 'Worker',
  962. `http://localhost:${process.env.OPENCODE_PORT ?? '4096'}/`,
  963. '/task/dir',
  964. );
  965. expect(mockMultiplexer.closePane).toHaveBeenCalledWith('p-1');
  966. expect(mockMultiplexer.closePane).toHaveBeenCalledTimes(1);
  967. });
  968. test('respawns after in-flight idle close when busy resumes same session', async () => {
  969. const ctx = createMockContext();
  970. const manager = new MultiplexerSessionManager(
  971. ctx,
  972. defaultMultiplexerConfig,
  973. );
  974. const closeDeferred = createDeferred<boolean>();
  975. mockMultiplexer.spawnPane
  976. .mockResolvedValueOnce({
  977. success: true,
  978. paneId: 'p-close-race',
  979. })
  980. .mockResolvedValueOnce({
  981. success: true,
  982. paneId: 'p-close-race-resumed',
  983. });
  984. mockMultiplexer.closePane.mockImplementationOnce(
  985. () => closeDeferred.promise,
  986. );
  987. await manager.onSessionCreated({
  988. type: 'session.created',
  989. properties: {
  990. info: {
  991. id: 'child-close-race',
  992. parentID: 'parent-close-race',
  993. title: 'Worker',
  994. },
  995. },
  996. });
  997. const idlePromise = manager.onSessionStatus({
  998. type: 'session.status',
  999. properties: {
  1000. sessionID: 'child-close-race',
  1001. status: { type: 'idle' },
  1002. },
  1003. });
  1004. await Promise.resolve();
  1005. const busyPromise = manager.onSessionStatus({
  1006. type: 'session.status',
  1007. properties: {
  1008. sessionID: 'child-close-race',
  1009. status: { type: 'busy' },
  1010. },
  1011. });
  1012. expect(mockMultiplexer.spawnPane).toHaveBeenCalledTimes(1);
  1013. closeDeferred.resolve(true);
  1014. await Promise.all([idlePromise, busyPromise]);
  1015. expect(mockMultiplexer.closePane).toHaveBeenCalledTimes(1);
  1016. expect(mockMultiplexer.spawnPane).toHaveBeenCalledTimes(2);
  1017. expect(mockMultiplexer.spawnPane).toHaveBeenLastCalledWith(
  1018. 'child-close-race',
  1019. 'Worker',
  1020. `http://localhost:${process.env.OPENCODE_PORT ?? '4096'}/`,
  1021. '/test/directory',
  1022. );
  1023. });
  1024. test('does not respawn after in-flight close if session is deleted', async () => {
  1025. const ctx = createMockContext();
  1026. const manager = new MultiplexerSessionManager(
  1027. ctx,
  1028. defaultMultiplexerConfig,
  1029. );
  1030. const closeDeferred = createDeferred<boolean>();
  1031. mockMultiplexer.spawnPane
  1032. .mockResolvedValueOnce({
  1033. success: true,
  1034. paneId: 'p-delete-race',
  1035. })
  1036. .mockResolvedValueOnce({
  1037. success: true,
  1038. paneId: 'p-should-not-respawn',
  1039. });
  1040. mockMultiplexer.closePane.mockImplementationOnce(
  1041. () => closeDeferred.promise,
  1042. );
  1043. await manager.onSessionCreated({
  1044. type: 'session.created',
  1045. properties: {
  1046. info: {
  1047. id: 'child-delete-race',
  1048. parentID: 'parent-delete-race',
  1049. title: 'Worker',
  1050. },
  1051. },
  1052. });
  1053. const idlePromise = manager.onSessionStatus({
  1054. type: 'session.status',
  1055. properties: {
  1056. sessionID: 'child-delete-race',
  1057. status: { type: 'idle' },
  1058. },
  1059. });
  1060. await Promise.resolve();
  1061. const busyPromise = manager.onSessionStatus({
  1062. type: 'session.status',
  1063. properties: {
  1064. sessionID: 'child-delete-race',
  1065. status: { type: 'busy' },
  1066. },
  1067. });
  1068. const deletedPromise = manager.onSessionDeleted({
  1069. type: 'session.deleted',
  1070. properties: {
  1071. sessionID: 'child-delete-race',
  1072. },
  1073. });
  1074. closeDeferred.resolve(true);
  1075. await Promise.all([idlePromise, busyPromise, deletedPromise]);
  1076. expect(mockMultiplexer.closePane).toHaveBeenCalledTimes(1);
  1077. expect(mockMultiplexer.spawnPane).toHaveBeenCalledTimes(1);
  1078. });
  1079. test('closes pane on session.deleted using info.id', async () => {
  1080. const ctx = createMockContext();
  1081. const manager = new MultiplexerSessionManager(
  1082. ctx,
  1083. defaultMultiplexerConfig,
  1084. );
  1085. mockMultiplexer.spawnPane.mockResolvedValueOnce({
  1086. success: true,
  1087. paneId: 'p-info-id',
  1088. });
  1089. await manager.onSessionCreated({
  1090. type: 'session.created',
  1091. properties: {
  1092. info: {
  1093. id: 'child-info-id',
  1094. parentID: 'parent-info-id',
  1095. },
  1096. },
  1097. });
  1098. await manager.onSessionDeleted({
  1099. type: 'session.deleted',
  1100. properties: {
  1101. info: { id: 'child-info-id' },
  1102. },
  1103. });
  1104. expect(mockMultiplexer.closePane).toHaveBeenCalledWith('p-info-id');
  1105. await manager.onSessionStatus({
  1106. type: 'session.status',
  1107. properties: {
  1108. sessionID: 'child-info-id',
  1109. status: { type: 'busy' },
  1110. },
  1111. });
  1112. expect(mockMultiplexer.spawnPane).toHaveBeenCalledTimes(1);
  1113. });
  1114. test('closes deleted pane even when current instance is not owner', async () => {
  1115. const ctx = createMockContext();
  1116. const manager = new MultiplexerSessionManager(
  1117. ctx,
  1118. defaultMultiplexerConfig,
  1119. );
  1120. mockMultiplexer.spawnPane.mockResolvedValueOnce({
  1121. success: true,
  1122. paneId: 'p-non-owner-delete',
  1123. });
  1124. await manager.onSessionCreated({
  1125. type: 'session.created',
  1126. properties: {
  1127. info: {
  1128. id: 'child-non-owner-delete',
  1129. parentID: 'parent-non-owner-delete',
  1130. },
  1131. },
  1132. });
  1133. const tracked = (manager as any).sessions.get('child-non-owner-delete');
  1134. tracked.ownerInstanceId = 'other-instance';
  1135. await manager.onSessionDeleted({
  1136. type: 'session.deleted',
  1137. properties: { sessionID: 'child-non-owner-delete' },
  1138. });
  1139. expect(mockMultiplexer.closePane).toHaveBeenCalledWith(
  1140. 'p-non-owner-delete',
  1141. );
  1142. expect((manager as any).sessions.has('child-non-owner-delete')).toBe(
  1143. false,
  1144. );
  1145. });
  1146. test('closes pane returned by a stale spawn after session deleted', async () => {
  1147. const ctx = createMockContext();
  1148. const manager = new MultiplexerSessionManager(
  1149. ctx,
  1150. defaultMultiplexerConfig,
  1151. );
  1152. const spawnDeferred = createDeferred<{ success: true; paneId: string }>();
  1153. mockMultiplexer.spawnPane.mockImplementationOnce(
  1154. () => spawnDeferred.promise,
  1155. );
  1156. const createPromise = manager.onSessionCreated({
  1157. type: 'session.created',
  1158. properties: {
  1159. info: {
  1160. id: 'child-stale-spawn',
  1161. parentID: 'parent-stale-spawn',
  1162. },
  1163. },
  1164. });
  1165. await Promise.resolve();
  1166. await manager.onSessionDeleted({
  1167. type: 'session.deleted',
  1168. properties: {
  1169. info: { id: 'child-stale-spawn' },
  1170. },
  1171. });
  1172. spawnDeferred.resolve({ success: true, paneId: 'p-stale-spawn' });
  1173. await createPromise;
  1174. expect(mockMultiplexer.closePane).toHaveBeenCalledWith('p-stale-spawn');
  1175. });
  1176. test('does nothing on busy for unknown session', async () => {
  1177. const ctx = createMockContext();
  1178. const manager = new MultiplexerSessionManager(
  1179. ctx,
  1180. defaultMultiplexerConfig,
  1181. );
  1182. await manager.onSessionStatus({
  1183. type: 'session.status',
  1184. properties: {
  1185. sessionID: 'unknown-session',
  1186. status: { type: 'busy' },
  1187. },
  1188. });
  1189. expect(mockMultiplexer.spawnPane).not.toHaveBeenCalled();
  1190. });
  1191. test('does not respawn while initial pane spawn is still in progress', async () => {
  1192. const ctx = createMockContext();
  1193. const manager = new MultiplexerSessionManager(
  1194. ctx,
  1195. defaultMultiplexerConfig,
  1196. );
  1197. const deferred = createDeferred<{ success: true; paneId: string }>();
  1198. mockMultiplexer.spawnPane.mockImplementationOnce(() => deferred.promise);
  1199. const createPromise = manager.onSessionCreated({
  1200. type: 'session.created',
  1201. properties: {
  1202. info: {
  1203. id: 'child-busy-race',
  1204. parentID: 'parent-busy-race',
  1205. title: 'Busy Worker',
  1206. directory: '/task/dir',
  1207. },
  1208. },
  1209. });
  1210. await manager.onSessionStatus({
  1211. type: 'session.status',
  1212. properties: {
  1213. sessionID: 'child-busy-race',
  1214. status: { type: 'busy' },
  1215. },
  1216. });
  1217. expect(mockMultiplexer.spawnPane).toHaveBeenCalledTimes(1);
  1218. deferred.resolve({ success: true, paneId: 'p-busy-race' });
  1219. await createPromise;
  1220. expect(mockMultiplexer.spawnPane).toHaveBeenCalledTimes(1);
  1221. });
  1222. });
  1223. describe('cmux lifecycle', () => {
  1224. const cmuxConfig = { ...defaultMultiplexerConfig, type: 'cmux' as const };
  1225. test('resolves a dynamic serverUrl after manager construction', async () => {
  1226. mockMultiplexerType = 'cmux';
  1227. let serverUrl = new URL('http://localhost:4096/');
  1228. let getterCalls = 0;
  1229. const ctx = createMockContext();
  1230. Object.defineProperty(ctx, 'serverUrl', {
  1231. configurable: true,
  1232. get: () => {
  1233. getterCalls += 1;
  1234. return serverUrl;
  1235. },
  1236. });
  1237. const serverCheck = mock(async () => true);
  1238. const manager = new MultiplexerSessionManager(
  1239. ctx,
  1240. cmuxConfig,
  1241. undefined,
  1242. {
  1243. isServerRunning: serverCheck,
  1244. },
  1245. );
  1246. expect(getterCalls).toBe(0);
  1247. serverUrl = new URL('http://127.0.0.1:63871/');
  1248. await manager.onSessionCreated({
  1249. type: 'session.created',
  1250. properties: { info: { id: 'dynamic-port', parentID: 'parent' } },
  1251. });
  1252. setMockSessionStatuses({ 'dynamic-port': { type: 'busy' } });
  1253. await (manager as any).pollSessions();
  1254. expect(serverCheck).toHaveBeenCalledWith('http://127.0.0.1:63871/');
  1255. expect(mockMultiplexer.spawnPane).toHaveBeenCalledWith(
  1256. 'dynamic-port',
  1257. 'Subagent',
  1258. 'http://127.0.0.1:63871/',
  1259. '/test/directory',
  1260. );
  1261. expect(mockFetch).toHaveBeenCalledWith(
  1262. new URL('http://127.0.0.1:63871/session/status'),
  1263. expect.any(Object),
  1264. );
  1265. expect(serverCheck).not.toHaveBeenCalledWith('http://localhost:4096/');
  1266. expect(mockFetch).not.toHaveBeenCalledWith(
  1267. new URL('http://localhost:4096/session/status'),
  1268. expect.any(Object),
  1269. );
  1270. });
  1271. test('pins the URL selected before an awaited health check', async () => {
  1272. mockMultiplexerType = 'cmux';
  1273. let serverUrl = new URL('http://127.0.0.1:63871/');
  1274. const ctx = createMockContext();
  1275. Object.defineProperty(ctx, 'serverUrl', { get: () => serverUrl });
  1276. const health = createDeferred<boolean>();
  1277. const serverCheck = mock(() => health.promise);
  1278. const manager = new MultiplexerSessionManager(
  1279. ctx,
  1280. cmuxConfig,
  1281. undefined,
  1282. {
  1283. isServerRunning: serverCheck,
  1284. },
  1285. );
  1286. const creating = manager.onSessionCreated({
  1287. type: 'session.created',
  1288. properties: { info: { id: 'pinned-url', parentID: 'parent' } },
  1289. });
  1290. await Promise.resolve();
  1291. serverUrl = new URL('http://127.0.0.1:63872/');
  1292. health.resolve(true);
  1293. await creating;
  1294. expect(mockMultiplexer.spawnPane).toHaveBeenCalledWith(
  1295. 'pinned-url',
  1296. 'Subagent',
  1297. 'http://127.0.0.1:63871/',
  1298. '/test/directory',
  1299. );
  1300. });
  1301. test('deferred spawn retry resolves the latest URL', async () => {
  1302. mockMultiplexerType = 'cmux';
  1303. let serverUrl = new URL('http://127.0.0.1:63871/');
  1304. const ctx = createMockContext();
  1305. Object.defineProperty(ctx, 'serverUrl', { get: () => serverUrl });
  1306. const retry = createDeferred<void>();
  1307. const serverCheck = mock(async () => true);
  1308. mockMultiplexer.spawnPane
  1309. .mockResolvedValueOnce({ success: false, error: 'unavailable' })
  1310. .mockResolvedValueOnce({ success: true, paneId: 'retried-pane' });
  1311. const manager = new MultiplexerSessionManager(
  1312. ctx,
  1313. cmuxConfig,
  1314. undefined,
  1315. {
  1316. isServerRunning: serverCheck,
  1317. delay: () => retry.promise,
  1318. },
  1319. );
  1320. await manager.onSessionCreated({
  1321. type: 'session.created',
  1322. properties: { info: { id: 'deferred-url', parentID: 'parent' } },
  1323. });
  1324. serverUrl = new URL('http://127.0.0.1:63872/');
  1325. retry.resolve();
  1326. await flushPromises();
  1327. expect(serverCheck).toHaveBeenLastCalledWith('http://127.0.0.1:63872/');
  1328. expect(mockMultiplexer.spawnPane).toHaveBeenLastCalledWith(
  1329. 'deferred-url',
  1330. 'Subagent',
  1331. 'http://127.0.0.1:63872/',
  1332. '/test/directory',
  1333. );
  1334. });
  1335. test('busy respawn resolves the latest URL', async () => {
  1336. mockMultiplexerType = 'cmux';
  1337. let serverUrl = new URL('http://127.0.0.1:63871/');
  1338. const ctx = createMockContext();
  1339. Object.defineProperty(ctx, 'serverUrl', { get: () => serverUrl });
  1340. const manager = new MultiplexerSessionManager(ctx, cmuxConfig);
  1341. mockMultiplexer.spawnPane
  1342. .mockResolvedValueOnce({ success: true, paneId: 'first-pane' })
  1343. .mockResolvedValueOnce({ success: true, paneId: 'second-pane' });
  1344. await manager.onSessionCreated({
  1345. type: 'session.created',
  1346. properties: { info: { id: 'busy-url', parentID: 'parent' } },
  1347. });
  1348. await manager.closeSessionFromCoordinator('busy-url');
  1349. serverUrl = new URL('http://127.0.0.1:63872/');
  1350. await manager.onSessionStatus({
  1351. type: 'session.status',
  1352. properties: { sessionID: 'busy-url', status: { type: 'busy' } },
  1353. });
  1354. expect(mockMultiplexer.spawnPane).toHaveBeenCalledTimes(1);
  1355. });
  1356. test('each poll resolves the latest URL', async () => {
  1357. mockMultiplexerType = 'cmux';
  1358. let serverUrl = new URL('http://127.0.0.1:63871/');
  1359. const ctx = createMockContext();
  1360. Object.defineProperty(ctx, 'serverUrl', { get: () => serverUrl });
  1361. const manager = new MultiplexerSessionManager(ctx, cmuxConfig);
  1362. await manager.onSessionCreated({
  1363. type: 'session.created',
  1364. properties: { info: { id: 'poll-url', parentID: 'parent' } },
  1365. });
  1366. await (manager as any).pollSessions();
  1367. serverUrl = new URL('http://127.0.0.1:63872/');
  1368. await (manager as any).pollSessions();
  1369. expect(mockFetch.mock.calls.at(-2)?.[0]).toEqual(
  1370. new URL('http://127.0.0.1:63871/session/status'),
  1371. );
  1372. expect(mockFetch.mock.calls.at(-1)?.[0]).toEqual(
  1373. new URL('http://127.0.0.1:63872/session/status'),
  1374. );
  1375. });
  1376. test('temporary missing URL never advances missing grace or closes a pane', async () => {
  1377. mockMultiplexerType = 'cmux';
  1378. let now = 0;
  1379. let serverUrl: URL | undefined = new URL('http://127.0.0.1:63871/');
  1380. const ctx = createMockContext();
  1381. Object.defineProperty(ctx, 'serverUrl', { get: () => serverUrl });
  1382. const manager = new MultiplexerSessionManager(
  1383. ctx,
  1384. cmuxConfig,
  1385. undefined,
  1386. {
  1387. now: () => now,
  1388. missingGraceMs: 10,
  1389. },
  1390. );
  1391. await manager.onSessionCreated({
  1392. type: 'session.created',
  1393. properties: { info: { id: 'temporary-url', parentID: 'parent' } },
  1394. });
  1395. serverUrl = undefined;
  1396. for (now = 10; now <= 40; now += 10)
  1397. await (manager as any).pollSessions();
  1398. expect(mockMultiplexer.closePane).not.toHaveBeenCalled();
  1399. serverUrl = new URL('http://127.0.0.1:63872/');
  1400. setMockSessionStatuses({ 'temporary-url': { type: 'busy' } });
  1401. await (manager as any).pollSessions();
  1402. expect(mockFetch).toHaveBeenLastCalledWith(
  1403. new URL('http://127.0.0.1:63872/session/status'),
  1404. expect.any(Object),
  1405. );
  1406. expect(mockMultiplexer.closePane).not.toHaveBeenCalled();
  1407. });
  1408. test('uses the SDK client baseUrl when ctx.serverUrl is missing', async () => {
  1409. mockMultiplexerType = 'cmux';
  1410. const ctx = createMockContext();
  1411. ctx.serverUrl = undefined;
  1412. ctx.client._client = {
  1413. getConfig: () => ({ baseUrl: 'http://127.0.0.1:63872/' }),
  1414. };
  1415. const serverCheck = mock(async () => true);
  1416. const manager = new MultiplexerSessionManager(
  1417. ctx,
  1418. cmuxConfig,
  1419. undefined,
  1420. {
  1421. isServerRunning: serverCheck,
  1422. },
  1423. );
  1424. await manager.onSessionCreated({
  1425. type: 'session.created',
  1426. properties: { info: { id: 'client-url', parentID: 'parent' } },
  1427. });
  1428. expect(serverCheck).toHaveBeenCalledWith('http://127.0.0.1:63872/');
  1429. expect(mockMultiplexer.spawnPane).toHaveBeenCalledWith(
  1430. 'client-url',
  1431. 'Subagent',
  1432. 'http://127.0.0.1:63872/',
  1433. '/test/directory',
  1434. );
  1435. });
  1436. test('does not health check, spawn, or fall back to 4096 without a URL', async () => {
  1437. mockMultiplexerType = 'cmux';
  1438. const ctx = createMockContext();
  1439. ctx.serverUrl = undefined;
  1440. const manager = new MultiplexerSessionManager(ctx, cmuxConfig);
  1441. await manager.onSessionCreated({
  1442. type: 'session.created',
  1443. properties: { info: { id: 'no-url', parentID: 'parent' } },
  1444. });
  1445. await (manager as any).pollSessions();
  1446. expect(mockIsServerRunning).not.toHaveBeenCalled();
  1447. expect(mockMultiplexer.spawnPane).not.toHaveBeenCalled();
  1448. expect(mockFetch).not.toHaveBeenCalled();
  1449. });
  1450. test('malicious client reflection cannot break initialization or spawning', async () => {
  1451. mockMultiplexerType = 'cmux';
  1452. for (const client of [
  1453. new Proxy(
  1454. {},
  1455. {
  1456. has: () => true,
  1457. get: () => {
  1458. throw new Error('get');
  1459. },
  1460. },
  1461. ),
  1462. Object.defineProperty({}, '_client', {
  1463. get: () => {
  1464. throw new Error('accessor');
  1465. },
  1466. }),
  1467. {
  1468. _client: Object.defineProperty({}, 'getConfig', {
  1469. get: () => {
  1470. throw new Error('getConfig accessor');
  1471. },
  1472. }),
  1473. },
  1474. {
  1475. _client: {
  1476. getConfig: () =>
  1477. Object.defineProperty({}, 'baseUrl', {
  1478. get: () => {
  1479. throw new Error('baseUrl accessor');
  1480. },
  1481. }),
  1482. },
  1483. },
  1484. ]) {
  1485. const ctx = createMockContext();
  1486. ctx.serverUrl = undefined;
  1487. ctx.client = client;
  1488. const manager = new MultiplexerSessionManager(ctx, cmuxConfig);
  1489. await expect(
  1490. manager.onSessionCreated({
  1491. type: 'session.created',
  1492. properties: {
  1493. info: { id: `proxy-${Math.random()}`, parentID: 'p' },
  1494. },
  1495. }),
  1496. ).resolves.toBeUndefined();
  1497. }
  1498. expect(mockIsServerRunning).not.toHaveBeenCalled();
  1499. expect(mockMultiplexer.spawnPane).not.toHaveBeenCalled();
  1500. });
  1501. test('keeps an explicit fixed 4096 serverUrl working', async () => {
  1502. mockMultiplexerType = 'cmux';
  1503. const ctx = createMockContext({ serverUrl: 'http://localhost:4096/' });
  1504. const serverCheck = mock(async () => true);
  1505. const manager = new MultiplexerSessionManager(
  1506. ctx,
  1507. cmuxConfig,
  1508. undefined,
  1509. {
  1510. isServerRunning: serverCheck,
  1511. },
  1512. );
  1513. await manager.onSessionCreated({
  1514. type: 'session.created',
  1515. properties: { info: { id: 'fixed-port', parentID: 'parent' } },
  1516. });
  1517. expect(serverCheck).toHaveBeenCalledWith('http://localhost:4096/');
  1518. expect(mockMultiplexer.spawnPane).toHaveBeenCalledWith(
  1519. 'fixed-port',
  1520. 'Subagent',
  1521. 'http://localhost:4096/',
  1522. '/test/directory',
  1523. );
  1524. });
  1525. test('requires lifetime, three idle polls, and a final idle recheck', async () => {
  1526. mockMultiplexerType = 'cmux';
  1527. let now = 0;
  1528. const manager = new MultiplexerSessionManager(
  1529. createMockContext(),
  1530. cmuxConfig,
  1531. undefined,
  1532. { now: () => now },
  1533. );
  1534. await manager.onSessionCreated({
  1535. type: 'session.created',
  1536. properties: { info: { id: 'cmux-idle', parentID: 'parent' } },
  1537. });
  1538. await manager.onSessionStatus({
  1539. type: 'session.idle',
  1540. properties: { sessionID: 'cmux-idle' },
  1541. });
  1542. expect(mockMultiplexer.closePane).not.toHaveBeenCalled();
  1543. setMockSessionStatuses({ 'cmux-idle': { type: 'idle' } });
  1544. await (manager as any).pollSessions();
  1545. now = 10_000;
  1546. await (manager as any).pollSessions();
  1547. await (manager as any).pollSessions();
  1548. expect(mockMultiplexer.closePane).not.toHaveBeenCalled();
  1549. await (manager as any).pollSessions();
  1550. expect(mockFetch).toHaveBeenCalledTimes(5);
  1551. expect(mockMultiplexer.closePane).toHaveBeenCalledWith('%mock-pane');
  1552. });
  1553. test('activity resets idle stability and missing status is a grace', async () => {
  1554. mockMultiplexerType = 'cmux';
  1555. let now = 0;
  1556. const manager = new MultiplexerSessionManager(
  1557. createMockContext(),
  1558. cmuxConfig,
  1559. undefined,
  1560. { now: () => now },
  1561. );
  1562. await manager.onSessionCreated({
  1563. type: 'session.created',
  1564. properties: { info: { id: 'cmux-active', parentID: 'parent' } },
  1565. });
  1566. now = 10_000;
  1567. setMockSessionStatuses({ 'cmux-active': { type: 'idle' } });
  1568. await (manager as any).pollSessions();
  1569. await manager.onSessionStatus({
  1570. type: 'session.status',
  1571. properties: {
  1572. sessionID: 'cmux-active',
  1573. status: { type: 'message' },
  1574. },
  1575. });
  1576. now = 20_000;
  1577. setMockSessionStatuses({});
  1578. await (manager as any).pollSessions();
  1579. setMockSessionStatuses({ 'cmux-active': { type: 'idle' } });
  1580. await (manager as any).pollSessions();
  1581. await (manager as any).pollSessions();
  1582. expect(mockMultiplexer.closePane).not.toHaveBeenCalled();
  1583. await (manager as any).pollSessions();
  1584. expect(mockMultiplexer.closePane).toHaveBeenCalledTimes(1);
  1585. });
  1586. test('delete and cleanup cancel deferred retries', async () => {
  1587. for (const action of ['delete', 'cleanup'] as const) {
  1588. resetMultiplexerSessionManagerState();
  1589. mockMultiplexer.spawnPane.mockReset();
  1590. mockMultiplexer.spawnPane.mockResolvedValue({
  1591. success: false,
  1592. error: 'invalid_state',
  1593. });
  1594. mockMultiplexerType = 'cmux';
  1595. const retry = createDeferred<void>();
  1596. const manager = new MultiplexerSessionManager(
  1597. createMockContext(),
  1598. cmuxConfig,
  1599. undefined,
  1600. { delay: () => retry.promise },
  1601. );
  1602. await manager.onSessionCreated({
  1603. type: 'session.created',
  1604. properties: { info: { id: action, parentID: 'parent' } },
  1605. });
  1606. if (action === 'delete') {
  1607. await manager.onSessionDeleted({
  1608. type: 'session.deleted',
  1609. properties: { sessionID: action },
  1610. });
  1611. } else {
  1612. await manager.cleanup();
  1613. }
  1614. retry.resolve();
  1615. await Promise.resolve();
  1616. expect(mockMultiplexer.spawnPane).toHaveBeenCalledTimes(1);
  1617. }
  1618. });
  1619. test('hard spawn failures are not deferred', async () => {
  1620. mockMultiplexerType = 'cmux';
  1621. const delay = mock(async () => {});
  1622. mockMultiplexer.spawnPane.mockResolvedValue({
  1623. success: false,
  1624. error: 'hard',
  1625. });
  1626. const manager = new MultiplexerSessionManager(
  1627. createMockContext(),
  1628. cmuxConfig,
  1629. undefined,
  1630. { delay },
  1631. );
  1632. await manager.onSessionCreated({
  1633. type: 'session.created',
  1634. properties: { info: { id: 'hard', parentID: 'parent' } },
  1635. });
  1636. expect(delay).not.toHaveBeenCalled();
  1637. expect(mockMultiplexer.spawnPane).toHaveBeenCalledTimes(1);
  1638. });
  1639. test('server-down deferred retry recovers and expires at original TTL', async () => {
  1640. for (const recovers of [true, false]) {
  1641. resetMultiplexerSessionManagerState();
  1642. mockMultiplexer.spawnPane.mockReset();
  1643. mockMultiplexer.spawnPane
  1644. .mockResolvedValueOnce({ success: false, error: 'unavailable' })
  1645. .mockResolvedValue({ success: true, paneId: `server-${recovers}` });
  1646. mockIsServerRunning.mockReset();
  1647. mockIsServerRunning.mockResolvedValue(true);
  1648. mockMultiplexerType = 'cmux';
  1649. let now = 0;
  1650. const retries: Array<ReturnType<typeof createDeferred<void>>> = [];
  1651. const manager = new MultiplexerSessionManager(
  1652. createMockContext(),
  1653. cmuxConfig,
  1654. undefined,
  1655. {
  1656. now: () => now,
  1657. deferredTtlMs: 10,
  1658. delay: () => {
  1659. const retry = createDeferred<void>();
  1660. retries.push(retry);
  1661. return retry.promise;
  1662. },
  1663. },
  1664. );
  1665. await manager.onSessionCreated({
  1666. type: 'session.created',
  1667. properties: { info: { id: `down-${recovers}`, parentID: 'p' } },
  1668. });
  1669. mockIsServerRunning.mockResolvedValue(false);
  1670. now = 5;
  1671. retries[0]?.resolve();
  1672. await flushPromises();
  1673. if (recovers) mockIsServerRunning.mockResolvedValue(true);
  1674. else now = 10;
  1675. retries[1]?.resolve();
  1676. await flushPromises();
  1677. expect(mockMultiplexer.spawnPane).toHaveBeenCalledTimes(
  1678. recovers ? 2 : 1,
  1679. );
  1680. }
  1681. });
  1682. test('message events and close-list races reset cmux idle', async () => {
  1683. mockMultiplexerType = 'cmux';
  1684. let now = 0;
  1685. const manager = new MultiplexerSessionManager(
  1686. createMockContext(),
  1687. cmuxConfig,
  1688. undefined,
  1689. { now: () => now },
  1690. );
  1691. for (const id of ['message-a', 'message-b']) {
  1692. await manager.onSessionCreated({
  1693. type: 'session.created',
  1694. properties: { info: { id, parentID: 'parent' } },
  1695. });
  1696. }
  1697. now = 10_000;
  1698. setMockSessionStatuses({
  1699. 'message-a': { type: 'idle' },
  1700. 'message-b': { type: 'idle' },
  1701. });
  1702. await (manager as any).pollSessions();
  1703. await (manager as any).pollSessions();
  1704. const originalClose = mockMultiplexer.closePane;
  1705. originalClose.mockImplementationOnce(async () => {
  1706. await manager.onSessionStatus({
  1707. type: 'message.part.delta',
  1708. properties: { sessionID: 'message-b' },
  1709. });
  1710. return true;
  1711. });
  1712. await (manager as any).pollSessions();
  1713. expect(mockMultiplexer.closePane).toHaveBeenCalledTimes(1);
  1714. await manager.onSessionStatus({
  1715. type: 'message.updated',
  1716. properties: { info: { sessionID: 'message-b' } },
  1717. });
  1718. await manager.onSessionStatus({
  1719. type: 'message.removed',
  1720. properties: { sessionID: 'message-b' },
  1721. });
  1722. expect(mockMultiplexer.closePane).toHaveBeenCalledTimes(1);
  1723. });
  1724. test('deleted stale spawn and cleanup retry close failures', async () => {
  1725. mockMultiplexerType = 'cmux';
  1726. const spawn = createDeferred<{ success: true; paneId: string }>();
  1727. const retries: Array<ReturnType<typeof createDeferred<void>>> = [];
  1728. mockMultiplexer.spawnPane.mockImplementationOnce(() => spawn.promise);
  1729. mockMultiplexer.closePane
  1730. .mockResolvedValueOnce(false)
  1731. .mockRejectedValueOnce(new Error('socket'))
  1732. .mockResolvedValueOnce(true);
  1733. const manager = new MultiplexerSessionManager(
  1734. createMockContext(),
  1735. cmuxConfig,
  1736. undefined,
  1737. {
  1738. delay: () => {
  1739. const retry = createDeferred<void>();
  1740. retries.push(retry);
  1741. return retry.promise;
  1742. },
  1743. },
  1744. );
  1745. const creating = manager.onSessionCreated({
  1746. type: 'session.created',
  1747. properties: { info: { id: 'stale-cmux', parentID: 'parent' } },
  1748. });
  1749. await flushPromises();
  1750. await manager.onSessionDeleted({
  1751. type: 'session.deleted',
  1752. properties: { sessionID: 'stale-cmux' },
  1753. });
  1754. spawn.resolve({ success: true, paneId: 'stale-pane' });
  1755. await creating;
  1756. retries[0]?.resolve();
  1757. await flushPromises();
  1758. retries[1]?.resolve();
  1759. await flushPromises();
  1760. expect(mockMultiplexer.closePane).toHaveBeenCalledTimes(3);
  1761. });
  1762. test('retries false and thrown closes until success', async () => {
  1763. mockMultiplexerType = 'cmux';
  1764. const retries: Array<ReturnType<typeof createDeferred<void>>> = [];
  1765. mockMultiplexer.closePane
  1766. .mockResolvedValueOnce(false)
  1767. .mockRejectedValueOnce(new Error('socket'))
  1768. .mockResolvedValueOnce(true);
  1769. const manager = new MultiplexerSessionManager(
  1770. createMockContext(),
  1771. cmuxConfig,
  1772. undefined,
  1773. {
  1774. delay: () => {
  1775. const retry = createDeferred<void>();
  1776. retries.push(retry);
  1777. return retry.promise;
  1778. },
  1779. closeRetryMaxAttempts: 4,
  1780. },
  1781. );
  1782. await manager.onSessionCreated({
  1783. type: 'session.created',
  1784. properties: { info: { id: 'close-retry', parentID: 'parent' } },
  1785. });
  1786. await manager.onSessionDeleted({
  1787. type: 'session.deleted',
  1788. properties: { sessionID: 'close-retry' },
  1789. });
  1790. retries[0]?.resolve();
  1791. await flushPromises();
  1792. retries[1]?.resolve();
  1793. await flushPromises();
  1794. expect(mockMultiplexer.closePane).toHaveBeenCalledTimes(3);
  1795. await manager.onSessionDeleted({
  1796. type: 'session.deleted',
  1797. properties: { sessionID: 'close-retry' },
  1798. });
  1799. expect(mockMultiplexer.closePane).toHaveBeenCalledTimes(3);
  1800. });
  1801. test('activity during final recheck cancels close', async () => {
  1802. mockMultiplexerType = 'cmux';
  1803. let now = 10_000;
  1804. const finalFetch = createDeferred<Response>();
  1805. mockFetch
  1806. .mockResolvedValueOnce(Response.json({ race: { type: 'idle' } }))
  1807. .mockResolvedValueOnce(Response.json({ race: { type: 'idle' } }))
  1808. .mockResolvedValueOnce(Response.json({ race: { type: 'idle' } }))
  1809. .mockImplementationOnce(() => finalFetch.promise);
  1810. const manager = new MultiplexerSessionManager(
  1811. createMockContext(),
  1812. cmuxConfig,
  1813. undefined,
  1814. { now: () => now },
  1815. );
  1816. now = 0;
  1817. await manager.onSessionCreated({
  1818. type: 'session.created',
  1819. properties: { info: { id: 'race', parentID: 'parent' } },
  1820. });
  1821. now = 10_000;
  1822. await (manager as any).pollSessions();
  1823. await (manager as any).pollSessions();
  1824. const finalPoll = (manager as any).pollSessions();
  1825. await flushPromises();
  1826. await manager.onSessionStatus({
  1827. type: 'session.status',
  1828. properties: { sessionID: 'race', status: { type: 'message' } },
  1829. });
  1830. finalFetch.resolve(Response.json({ race: { type: 'idle' } }));
  1831. await finalPoll;
  1832. expect(mockMultiplexer.closePane).not.toHaveBeenCalled();
  1833. });
  1834. test('poll guard prevents overlapping status fetches', async () => {
  1835. mockMultiplexerType = 'cmux';
  1836. const slowFetch = createDeferred<Response>();
  1837. mockFetch.mockImplementationOnce(() => slowFetch.promise);
  1838. const manager = new MultiplexerSessionManager(
  1839. createMockContext(),
  1840. cmuxConfig,
  1841. );
  1842. await manager.onSessionCreated({
  1843. type: 'session.created',
  1844. properties: { info: { id: 'slow', parentID: 'parent' } },
  1845. });
  1846. const first = (manager as any).pollSessions();
  1847. const second = (manager as any).pollSessions();
  1848. expect(mockFetch).toHaveBeenCalledTimes(1);
  1849. slowFetch.resolve(Response.json({ slow: { type: 'idle' } }));
  1850. await Promise.all([first, second]);
  1851. });
  1852. test('missing resets idle streak and closes after grace expires', async () => {
  1853. mockMultiplexerType = 'cmux';
  1854. let now = 0;
  1855. const manager = new MultiplexerSessionManager(
  1856. createMockContext(),
  1857. cmuxConfig,
  1858. undefined,
  1859. { now: () => now, missingGraceMs: 30 },
  1860. );
  1861. await manager.onSessionCreated({
  1862. type: 'session.created',
  1863. properties: { info: { id: 'missing', parentID: 'parent' } },
  1864. });
  1865. now = 10_000;
  1866. setMockSessionStatuses({ missing: { type: 'idle' } });
  1867. await (manager as any).pollSessions();
  1868. setMockSessionStatuses({});
  1869. await (manager as any).pollSessions();
  1870. now += 29;
  1871. await (manager as any).pollSessions();
  1872. expect(mockMultiplexer.closePane).not.toHaveBeenCalled();
  1873. setMockSessionStatuses({ missing: { type: 'idle' } });
  1874. await (manager as any).pollSessions();
  1875. await (manager as any).pollSessions();
  1876. expect(mockMultiplexer.closePane).not.toHaveBeenCalled();
  1877. setMockSessionStatuses({});
  1878. await (manager as any).pollSessions();
  1879. now += 30;
  1880. await (manager as any).pollSessions();
  1881. await (manager as any).pollSessions();
  1882. await (manager as any).pollSessions();
  1883. expect(mockMultiplexer.closePane).toHaveBeenCalledTimes(1);
  1884. });
  1885. test('background job policy still gates stable cmux idle close', async () => {
  1886. mockMultiplexerType = 'cmux';
  1887. let now = 0;
  1888. const board = new BackgroundJobBoard();
  1889. const coordinator = new BackgroundJobCoordinator(board);
  1890. board.registerLaunch({
  1891. taskID: 'cmux-background',
  1892. parentSessionID: 'parent',
  1893. agent: 'explorer',
  1894. });
  1895. const manager = new MultiplexerSessionManager(
  1896. createMockContext(),
  1897. cmuxConfig,
  1898. coordinator,
  1899. { now: () => now },
  1900. );
  1901. coordinator.addTerminalStateListener((sessionId) => {
  1902. void manager.closeSessionFromCoordinator(sessionId);
  1903. });
  1904. await manager.onSessionCreated({
  1905. type: 'session.created',
  1906. properties: {
  1907. info: { id: 'cmux-background', parentID: 'parent' },
  1908. },
  1909. });
  1910. now = 10_000;
  1911. setMockSessionStatuses({ 'cmux-background': { type: 'idle' } });
  1912. await (manager as any).pollSessions();
  1913. await (manager as any).pollSessions();
  1914. await (manager as any).pollSessions();
  1915. expect(mockMultiplexer.closePane).not.toHaveBeenCalled();
  1916. board.updateStatus({ taskID: 'cmux-background', state: 'completed' });
  1917. await (manager as any).pollSessions();
  1918. expect(mockMultiplexer.closePane).toHaveBeenCalledTimes(1);
  1919. });
  1920. test('session.deleted closes immediately', async () => {
  1921. mockMultiplexerType = 'cmux';
  1922. const manager = new MultiplexerSessionManager(
  1923. createMockContext(),
  1924. cmuxConfig,
  1925. );
  1926. await manager.onSessionCreated({
  1927. type: 'session.created',
  1928. properties: { info: { id: 'cmux-deleted', parentID: 'parent' } },
  1929. });
  1930. await manager.onSessionDeleted({
  1931. type: 'session.deleted',
  1932. properties: { sessionID: 'cmux-deleted' },
  1933. });
  1934. expect(mockMultiplexer.closePane).toHaveBeenCalledWith('%mock-pane');
  1935. });
  1936. });
  1937. describe('cleanup', () => {
  1938. test('instance disposal cleanup is a no-op for non-cmux multiplexers', async () => {
  1939. const manager = new MultiplexerSessionManager(
  1940. createMockContext(),
  1941. defaultMultiplexerConfig,
  1942. );
  1943. await manager.onSessionCreated({
  1944. type: 'session.created',
  1945. properties: { info: { id: 'tmux-live', parentID: 'parent' } },
  1946. });
  1947. mockMultiplexer.closePane.mockClear();
  1948. await manager.cleanupOnInstanceDisposed();
  1949. expect(mockMultiplexer.closePane).not.toHaveBeenCalled();
  1950. });
  1951. test('cmux cleanup has a shutdown deadline for a hanging spawn', async () => {
  1952. mockMultiplexerType = 'cmux';
  1953. const spawn = createDeferred<{ success: true; paneId: string }>();
  1954. mockMultiplexer.spawnPane.mockImplementationOnce(() => spawn.promise);
  1955. const manager = new MultiplexerSessionManager(
  1956. createMockContext(),
  1957. { ...defaultMultiplexerConfig, type: 'cmux' },
  1958. undefined,
  1959. { shutdownTimeoutMs: 1 },
  1960. );
  1961. void manager.onSessionCreated({
  1962. type: 'session.created',
  1963. properties: { info: { id: 'hanging-cleanup', parentID: 'parent' } },
  1964. });
  1965. await flushPromises();
  1966. await manager.cleanup();
  1967. expect(mockMultiplexer.closePane).not.toHaveBeenCalled();
  1968. });
  1969. test('closes all tracked panes concurrently', async () => {
  1970. const ctx = createMockContext();
  1971. mockMultiplexer.spawnPane
  1972. .mockResolvedValueOnce({ success: true, paneId: 'p1' })
  1973. .mockResolvedValueOnce({ success: true, paneId: 'p2' });
  1974. const manager = new MultiplexerSessionManager(
  1975. ctx,
  1976. defaultMultiplexerConfig,
  1977. );
  1978. await manager.onSessionCreated({
  1979. type: 'session.created',
  1980. properties: { info: { id: 's1', parentID: 'p1' } },
  1981. });
  1982. await manager.onSessionCreated({
  1983. type: 'session.created',
  1984. properties: { info: { id: 's2', parentID: 'p2' } },
  1985. });
  1986. await manager.cleanup();
  1987. expect(mockMultiplexer.closePane).toHaveBeenCalledTimes(2);
  1988. expect(mockMultiplexer.closePane).toHaveBeenCalledWith('p1');
  1989. expect(mockMultiplexer.closePane).toHaveBeenCalledWith('p2');
  1990. });
  1991. test('clears spawning sessions during cleanup', async () => {
  1992. const ctx = createMockContext();
  1993. const manager = new MultiplexerSessionManager(
  1994. ctx,
  1995. defaultMultiplexerConfig,
  1996. );
  1997. const deferred = createDeferred<{ success: true; paneId: string }>();
  1998. mockMultiplexer.spawnPane.mockImplementationOnce(() => deferred.promise);
  1999. const event = {
  2000. type: 'session.created',
  2001. properties: {
  2002. info: {
  2003. id: 'cleanup-spawn',
  2004. parentID: 'parent-cleanup',
  2005. title: 'Cleanup Worker',
  2006. },
  2007. },
  2008. };
  2009. const createPromise = manager.onSessionCreated(event);
  2010. await Promise.resolve();
  2011. const cleanupPromise = manager.cleanup();
  2012. deferred.resolve({ success: true, paneId: 'p-cleanup' });
  2013. await Promise.all([createPromise, cleanupPromise]);
  2014. await manager.onSessionCreated(event);
  2015. expect(mockMultiplexer.spawnPane).toHaveBeenCalledTimes(2);
  2016. });
  2017. });
  2018. });
  2019. // Backward compatibility test
  2020. describe('TmuxSessionManager (backward compatibility)', () => {
  2021. test('TmuxSessionManager is alias for MultiplexerSessionManager', async () => {
  2022. const { TmuxSessionManager } = await import('./session-manager');
  2023. expect(TmuxSessionManager).toBe(MultiplexerSessionManager);
  2024. });
  2025. });