| 12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610161116121613161416151616161716181619162016211622162316241625162616271628162916301631163216331634163516361637163816391640164116421643164416451646164716481649165016511652165316541655165616571658165916601661166216631664166516661667166816691670167116721673167416751676167716781679168016811682168316841685168616871688168916901691169216931694169516961697169816991700170117021703170417051706170717081709171017111712171317141715171617171718171917201721172217231724172517261727172817291730173117321733173417351736173717381739174017411742174317441745174617471748174917501751175217531754175517561757175817591760176117621763176417651766176717681769177017711772177317741775177617771778177917801781178217831784178517861787178817891790179117921793179417951796179717981799180018011802180318041805180618071808180918101811181218131814181518161817181818191820182118221823182418251826182718281829183018311832183318341835183618371838183918401841184218431844184518461847184818491850185118521853185418551856185718581859186018611862186318641865186618671868186918701871187218731874187518761877187818791880188118821883188418851886188718881889189018911892189318941895189618971898189919001901190219031904190519061907190819091910191119121913191419151916191719181919192019211922192319241925192619271928192919301931193219331934193519361937193819391940194119421943194419451946194719481949195019511952195319541955195619571958195919601961196219631964196519661967196819691970197119721973197419751976197719781979198019811982198319841985198619871988198919901991199219931994199519961997199819992000200120022003200420052006200720082009201020112012201320142015201620172018201920202021202220232024202520262027202820292030203120322033203420352036203720382039204020412042204320442045204620472048204920502051205220532054205520562057205820592060206120622063206420652066206720682069207020712072207320742075207620772078207920802081208220832084208520862087208820892090209120922093209420952096209720982099210021012102210321042105210621072108210921102111211221132114211521162117211821192120212121222123212421252126212721282129213021312132213321342135213621372138213921402141214221432144214521462147214821492150215121522153215421552156215721582159216021612162216321642165216621672168216921702171217221732174217521762177217821792180218121822183218421852186218721882189219021912192219321942195219621972198219922002201220222032204 |
- import { describe, expect, mock, test } from 'bun:test';
- import { SLIM_INTERNAL_INITIATOR_MARKER } from '../../utils';
- import { createTodoContinuationHook } from './index';
- describe('createTodoContinuationHook', () => {
- function createMockContext(overrides?: {
- todoResult?: {
- data?: Array<{
- id: string;
- content: string;
- status: string;
- priority: string;
- }>;
- };
- messagesResult?: {
- data?: Array<{
- info?: { role?: string };
- parts?: Array<{ type?: string; text?: string }>;
- }>;
- };
- }) {
- return {
- client: {
- session: {
- todo: mock(async () => overrides?.todoResult ?? { data: [] }),
- messages: mock(async () => overrides?.messagesResult ?? { data: [] }),
- prompt: mock(async () => ({})),
- },
- },
- } as any;
- }
- async function delay(ms: number): Promise<void> {
- await new Promise((resolve) => setTimeout(resolve, ms));
- }
- // Notification prompts (noReply:true, no marker) fire immediately when
- // scheduling a continuation. These helpers check only for actual
- // continuation prompts (with SLIM_INTERNAL_INITIATOR_MARKER).
- function hasContinuation(m: ReturnType<typeof mock>): boolean {
- return m.mock.calls.some((c: any[]) =>
- (c[0]?.body?.parts as any[])?.some((p: any) =>
- p.text?.includes(SLIM_INTERNAL_INITIATOR_MARKER),
- ),
- );
- }
- function contCount(m: ReturnType<typeof mock>): number {
- return m.mock.calls.filter((c: any[]) =>
- (c[0]?.body?.parts as any[])?.some((p: any) =>
- p.text?.includes(SLIM_INTERNAL_INITIATOR_MARKER),
- ),
- ).length;
- }
- function contCall(m: ReturnType<typeof mock>): any[] {
- const call = m.mock.calls.find((c: any[]) =>
- (c[0]?.body?.parts as any[])?.some((p: any) =>
- p.text?.includes(SLIM_INTERNAL_INITIATOR_MARKER),
- ),
- );
- if (!call) {
- throw new Error('No continuation call found');
- }
- return call;
- }
- describe('tool toggle', () => {
- test('calling auto_continue execute with { enabled: true } sets state', async () => {
- const ctx = createMockContext();
- const hook = createTodoContinuationHook(ctx);
- const result = await hook.tool.auto_continue.execute({ enabled: true });
- expect(result).toContain('Auto-continue enabled');
- expect(result).toContain('up to 5');
- });
- test('calling auto_continue execute with { enabled: false } disables', async () => {
- const ctx = createMockContext();
- const hook = createTodoContinuationHook(ctx);
- const result = await hook.tool.auto_continue.execute({ enabled: false });
- expect(result).toBe('Auto-continue disabled.');
- });
- });
- describe('continuation scheduling', () => {
- test('session idle + enabled + incomplete todos → schedules continuation', async () => {
- const ctx = createMockContext({
- todoResult: {
- data: [
- { id: '1', content: 'todo1', status: 'pending', priority: 'high' },
- { id: '2', content: 'todo2', status: 'completed', priority: 'low' },
- ],
- },
- messagesResult: {
- data: [
- {
- info: { role: 'assistant' },
- parts: [{ type: 'text', text: 'Here is the result' }],
- },
- ],
- },
- });
- const hook = createTodoContinuationHook(ctx, {
- maxContinuations: 5,
- cooldownMs: 50,
- });
- // Enable auto-continue
- await hook.tool.auto_continue.execute({ enabled: true });
- // Fire session.idle event
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 'session-123' },
- },
- });
- // Wait for cooldown
- await delay(60);
- // Verify session.prompt was called with continuation prompt
- expect(hasContinuation(ctx.client.session.prompt)).toBe(true);
- const promptCall = contCall(ctx.client.session.prompt);
- expect(promptCall[0].path.id).toBe('session-123');
- expect(promptCall[0].body.parts[0].text).toContain(
- '[Auto-continue: enabled - there are incomplete todos remaining.',
- );
- expect(promptCall[0].body.parts[0].text).toContain(
- SLIM_INTERNAL_INITIATOR_MARKER,
- );
- });
- test('disabled → no continuation', async () => {
- const ctx = createMockContext({
- todoResult: {
- data: [
- { id: '1', content: 'todo1', status: 'pending', priority: 'high' },
- ],
- },
- messagesResult: {
- data: [
- {
- info: { role: 'assistant' },
- parts: [{ type: 'text', text: 'Done' }],
- },
- ],
- },
- });
- const hook = createTodoContinuationHook(ctx, { cooldownMs: 50 });
- // Do NOT enable auto-continue
- // Fire session.idle event
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 'session-123' },
- },
- });
- // Wait for cooldown
- await delay(60);
- // Verify session.prompt was NOT called
- expect(ctx.client.session.prompt).not.toHaveBeenCalled();
- });
- test('last message is a question → skip', async () => {
- const ctx = createMockContext({
- todoResult: {
- data: [
- { id: '1', content: 'todo1', status: 'pending', priority: 'high' },
- ],
- },
- messagesResult: {
- data: [
- {
- info: { role: 'assistant' },
- parts: [
- { type: 'text', text: 'Should I proceed with the next step?' },
- ],
- },
- ],
- },
- });
- const hook = createTodoContinuationHook(ctx, { cooldownMs: 50 });
- // Enable auto-continue
- await hook.tool.auto_continue.execute({ enabled: true });
- // Fire session.idle event
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 'session-123' },
- },
- });
- // Wait for cooldown
- await delay(60);
- // Verify continuation NOT scheduled
- expect(ctx.client.session.prompt).not.toHaveBeenCalled();
- });
- test('question detection with question mark → skip', async () => {
- const ctx = createMockContext({
- todoResult: {
- data: [
- { id: '1', content: 'todo1', status: 'pending', priority: 'high' },
- ],
- },
- messagesResult: {
- data: [
- {
- info: { role: 'assistant' },
- parts: [{ type: 'text', text: 'Ready to continue?' }],
- },
- ],
- },
- });
- const hook = createTodoContinuationHook(ctx, { cooldownMs: 50 });
- await hook.tool.auto_continue.execute({ enabled: true });
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 'session-123' },
- },
- });
- await delay(60);
- expect(ctx.client.session.prompt).not.toHaveBeenCalled();
- });
- test('question detection with "would you like" phrase → skip', async () => {
- const ctx = createMockContext({
- todoResult: {
- data: [
- { id: '1', content: 'todo1', status: 'pending', priority: 'high' },
- ],
- },
- messagesResult: {
- data: [
- {
- info: { role: 'assistant' },
- parts: [
- {
- type: 'text',
- text: 'Would you like me to proceed?',
- },
- ],
- },
- ],
- },
- });
- const hook = createTodoContinuationHook(ctx, { cooldownMs: 50 });
- await hook.tool.auto_continue.execute({ enabled: true });
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 'session-123' },
- },
- });
- await delay(60);
- expect(ctx.client.session.prompt).not.toHaveBeenCalled();
- });
- test('max continuations reached → skip', async () => {
- const ctx = createMockContext({
- todoResult: {
- data: [
- { id: '1', content: 'todo1', status: 'pending', priority: 'high' },
- ],
- },
- messagesResult: {
- data: [
- {
- info: { role: 'assistant' },
- parts: [{ type: 'text', text: 'Working...' }],
- },
- ],
- },
- });
- const hook = createTodoContinuationHook(ctx, {
- maxContinuations: 2,
- cooldownMs: 50,
- });
- await hook.tool.auto_continue.execute({ enabled: true });
- // Fire idle events up to maxContinuations
- for (let i = 0; i < 2; i++) {
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 'session-123' },
- },
- });
- await delay(60);
- }
- // Reset mock for the 3rd attempt
- ctx.client.session.prompt.mockClear();
- // On the N+1th idle, verify no continuation scheduled
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 'session-123' },
- },
- });
- await delay(60);
- expect(ctx.client.session.prompt).not.toHaveBeenCalled();
- });
- test('abort suppress window → skip', async () => {
- const ctx = createMockContext({
- todoResult: {
- data: [
- { id: '1', content: 'todo1', status: 'pending', priority: 'high' },
- ],
- },
- messagesResult: {
- data: [
- {
- info: { role: 'assistant' },
- parts: [{ type: 'text', text: 'Working...' }],
- },
- ],
- },
- });
- const hook = createTodoContinuationHook(ctx, { cooldownMs: 50 });
- // Seed orchestrator session
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 'session-123' },
- },
- });
- await hook.tool.auto_continue.execute({ enabled: true });
- // Fire session.error with MessageAbortedError
- await hook.handleEvent({
- event: {
- type: 'session.error',
- properties: {
- sessionID: 'session-123',
- error: { name: 'MessageAbortedError' },
- },
- },
- });
- // Immediately fire session.idle
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 'session-123' },
- },
- });
- // Wait less than suppress window (5s) - just enough to verify it's working
- await delay(100);
- // Verify no continuation within suppress window
- expect(ctx.client.session.prompt).not.toHaveBeenCalled();
- });
- test('session busy → cancel pending timer', async () => {
- const ctx = createMockContext({
- todoResult: {
- data: [
- { id: '1', content: 'todo1', status: 'pending', priority: 'high' },
- ],
- },
- messagesResult: {
- data: [
- {
- info: { role: 'assistant' },
- parts: [{ type: 'text', text: 'Working...' }],
- },
- ],
- },
- });
- const hook = createTodoContinuationHook(ctx, {
- maxContinuations: 5,
- cooldownMs: 100,
- });
- await hook.tool.auto_continue.execute({ enabled: true });
- // Schedule a continuation
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 'session-123' },
- },
- });
- // Before cooldown expires, fire session.status with busy
- await delay(50);
- await hook.handleEvent({
- event: {
- type: 'session.status',
- properties: {
- sessionID: 'session-123',
- status: { type: 'busy' },
- },
- },
- });
- // Advance past original cooldown
- await delay(60);
- // Verify timer was cancelled and prompt NOT called
- expect(hasContinuation(ctx.client.session.prompt)).toBe(false);
- });
- test('sub-agent session.busy does NOT cancel orchestrator timer', async () => {
- const ctx = createMockContext({
- todoResult: {
- data: [
- { id: '1', content: 'todo1', status: 'pending', priority: 'high' },
- ],
- },
- messagesResult: {
- data: [
- {
- info: { role: 'assistant' },
- parts: [{ type: 'text', text: 'Working...' }],
- },
- ],
- },
- });
- const hook = createTodoContinuationHook(ctx, {
- maxContinuations: 5,
- cooldownMs: 100,
- });
- await hook.tool.auto_continue.execute({ enabled: true });
- // Schedule a continuation for orchestrator session
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 'session-123' },
- },
- });
- // A sub-agent (different session) goes busy
- await delay(50);
- await hook.handleEvent({
- event: {
- type: 'session.status',
- properties: {
- sessionID: 'sub-agent-456',
- status: { type: 'busy' },
- },
- },
- });
- // Advance past original cooldown
- await delay(60);
- // Orchestrator timer should still fire — prompt was called
- expect(hasContinuation(ctx.client.session.prompt)).toBe(true);
- });
- test('all todos complete → skip', async () => {
- const ctx = createMockContext({
- todoResult: {
- data: [
- {
- id: '1',
- content: 'todo1',
- status: 'completed',
- priority: 'high',
- },
- { id: '2', content: 'todo2', status: 'cancelled', priority: 'low' },
- ],
- },
- messagesResult: {
- data: [
- {
- info: { role: 'assistant' },
- parts: [{ type: 'text', text: 'All done' }],
- },
- ],
- },
- });
- const hook = createTodoContinuationHook(ctx, { cooldownMs: 50 });
- await hook.tool.auto_continue.execute({ enabled: true });
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 'session-123' },
- },
- });
- await delay(60);
- expect(ctx.client.session.prompt).not.toHaveBeenCalled();
- });
- test('non-orchestrator session → skip', async () => {
- const ctx = createMockContext({
- todoResult: {
- data: [
- { id: '1', content: 'todo1', status: 'pending', priority: 'high' },
- ],
- },
- messagesResult: {
- data: [
- {
- info: { role: 'assistant' },
- parts: [{ type: 'text', text: 'Working...' }],
- },
- ],
- },
- });
- const hook = createTodoContinuationHook(ctx, { cooldownMs: 50 });
- await hook.tool.auto_continue.execute({ enabled: true });
- // First idle from session A (becomes orchestrator)
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 'session-A' },
- },
- });
- await delay(60);
- // Verify prompt was called for session A
- expect(hasContinuation(ctx.client.session.prompt)).toBe(true);
- // Reset mock
- ctx.client.session.prompt.mockClear();
- // Second idle from session B (different sessionID)
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 'session-B' },
- },
- });
- await delay(60);
- // Verify no continuation for session B
- expect(ctx.client.session.prompt).not.toHaveBeenCalled();
- });
- test('cooldownMs from config', async () => {
- const customCooldownMs = 100;
- const ctx = createMockContext({
- todoResult: {
- data: [
- { id: '1', content: 'todo1', status: 'pending', priority: 'high' },
- ],
- },
- messagesResult: {
- data: [
- {
- info: { role: 'assistant' },
- parts: [{ type: 'text', text: 'Working...' }],
- },
- ],
- },
- });
- const hook = createTodoContinuationHook(ctx, {
- maxContinuations: 5,
- cooldownMs: customCooldownMs,
- });
- await hook.tool.auto_continue.execute({ enabled: true });
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 'session-123' },
- },
- });
- // Advance timer by less than custom cooldown
- await delay(customCooldownMs - 1);
- // Verify prompt not called yet
- expect(hasContinuation(ctx.client.session.prompt)).toBe(false);
- // Advance timer by remaining 1ms
- await delay(1);
- // Now prompt should be called
- expect(hasContinuation(ctx.client.session.prompt)).toBe(true);
- });
- });
- describe('event handling - session.error', () => {
- test('MessageAbortedError sets suppress window', async () => {
- const ctx = createMockContext({
- todoResult: {
- data: [
- { id: '1', content: 'todo1', status: 'pending', priority: 'high' },
- ],
- },
- messagesResult: {
- data: [
- {
- info: { role: 'assistant' },
- parts: [{ type: 'text', text: 'Working...' }],
- },
- ],
- },
- });
- const hook = createTodoContinuationHook(ctx, { cooldownMs: 50 });
- // Seed orchestrator session
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 'session-123' },
- },
- });
- await hook.tool.auto_continue.execute({ enabled: true });
- // Fire session.error with MessageAbortedError
- await hook.handleEvent({
- event: {
- type: 'session.error',
- properties: {
- sessionID: 'session-123',
- error: { name: 'MessageAbortedError' },
- },
- },
- });
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 'session-123' },
- },
- });
- // Wait less than suppress window
- await delay(100);
- // Verify no continuation within suppress window
- expect(ctx.client.session.prompt).not.toHaveBeenCalled();
- });
- test('AbortError sets suppress window', async () => {
- const ctx = createMockContext({
- todoResult: {
- data: [
- { id: '1', content: 'todo1', status: 'pending', priority: 'high' },
- ],
- },
- messagesResult: {
- data: [
- {
- info: { role: 'assistant' },
- parts: [{ type: 'text', text: 'Working...' }],
- },
- ],
- },
- });
- const hook = createTodoContinuationHook(ctx, { cooldownMs: 50 });
- // Seed orchestrator session (disabled, so no continuation fires)
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 'session-123' },
- },
- });
- await hook.tool.auto_continue.execute({ enabled: true });
- await hook.handleEvent({
- event: {
- type: 'session.error',
- properties: {
- sessionID: 'session-123',
- error: { name: 'AbortError' },
- },
- },
- });
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 'session-123' },
- },
- });
- // Wait less than suppress window
- await delay(100);
- // Verify no continuation within suppress window
- expect(ctx.client.session.prompt).not.toHaveBeenCalled();
- });
- test('other errors do not set suppress window', async () => {
- const ctx = createMockContext({
- todoResult: {
- data: [
- { id: '1', content: 'todo1', status: 'pending', priority: 'high' },
- ],
- },
- messagesResult: {
- data: [
- {
- info: { role: 'assistant' },
- parts: [{ type: 'text', text: 'Working...' }],
- },
- ],
- },
- });
- const hook = createTodoContinuationHook(ctx, { cooldownMs: 50 });
- await hook.tool.auto_continue.execute({ enabled: true });
- await hook.handleEvent({
- event: {
- type: 'session.error',
- properties: {
- sessionID: 'session-123',
- error: { name: 'NetworkError' },
- },
- },
- });
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 'session-123' },
- },
- });
- await delay(60);
- // Prompt should be called immediately (no suppress window)
- expect(hasContinuation(ctx.client.session.prompt)).toBe(true);
- });
- });
- describe('event handling - session.deleted', () => {
- test('clears pending timer on session delete', async () => {
- const ctx = createMockContext({
- todoResult: {
- data: [
- { id: '1', content: 'todo1', status: 'pending', priority: 'high' },
- ],
- },
- messagesResult: {
- data: [
- {
- info: { role: 'assistant' },
- parts: [{ type: 'text', text: 'Working...' }],
- },
- ],
- },
- });
- const hook = createTodoContinuationHook(ctx, {
- maxContinuations: 5,
- cooldownMs: 100,
- });
- await hook.tool.auto_continue.execute({ enabled: true });
- // Schedule continuation
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 'session-123' },
- },
- });
- // Delete session before timer fires
- await delay(50);
- await hook.handleEvent({
- event: {
- type: 'session.deleted',
- properties: {
- sessionID: 'session-123',
- },
- },
- });
- // Advance past original cooldown
- await delay(60);
- // Verify timer was cancelled and prompt NOT called
- expect(hasContinuation(ctx.client.session.prompt)).toBe(false);
- });
- test('sub-agent session.deleted does NOT cancel orchestrator timer', async () => {
- const ctx = createMockContext({
- todoResult: {
- data: [
- { id: '1', content: 'todo1', status: 'pending', priority: 'high' },
- ],
- },
- messagesResult: {
- data: [
- {
- info: { role: 'assistant' },
- parts: [{ type: 'text', text: 'Working...' }],
- },
- ],
- },
- });
- const hook = createTodoContinuationHook(ctx, {
- maxContinuations: 5,
- cooldownMs: 100,
- });
- await hook.tool.auto_continue.execute({ enabled: true });
- // Schedule continuation for orchestrator session
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 'session-123' },
- },
- });
- // A sub-agent (different session) gets deleted
- await delay(50);
- await hook.handleEvent({
- event: {
- type: 'session.deleted',
- properties: {
- sessionID: 'sub-agent-456',
- },
- },
- });
- // Advance past original cooldown
- await delay(60);
- // Orchestrator timer should still fire — prompt was called
- expect(hasContinuation(ctx.client.session.prompt)).toBe(true);
- });
- test('resets orchestrator session when deleted session matches', async () => {
- const ctx = createMockContext({
- todoResult: {
- data: [
- { id: '1', content: 'todo1', status: 'pending', priority: 'high' },
- ],
- },
- messagesResult: {
- data: [
- {
- info: { role: 'assistant' },
- parts: [{ type: 'text', text: 'Working...' }],
- },
- ],
- },
- });
- const hook = createTodoContinuationHook(ctx, { cooldownMs: 50 });
- await hook.tool.auto_continue.execute({ enabled: true });
- // First idle sets orchestrator
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 'session-A' },
- },
- });
- await delay(60);
- // Delete orchestrator session
- await hook.handleEvent({
- event: {
- type: 'session.deleted',
- properties: {
- sessionID: 'session-A',
- },
- },
- });
- // Second idle from new session should become orchestrator
- ctx.client.session.prompt.mockClear();
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 'session-B' },
- },
- });
- await delay(60);
- // Prompt should be called for session-B (new orchestrator)
- expect(hasContinuation(ctx.client.session.prompt)).toBe(true);
- const promptCall = contCall(ctx.client.session.prompt);
- expect(promptCall[0].path.id).toBe('session-B');
- });
- });
- describe('error handling', () => {
- test('fetch todos failure → skips continuation', async () => {
- const ctx = createMockContext({
- todoResult: undefined as any,
- });
- ctx.client.session.todo = mock(async () => {
- throw new Error('Failed to fetch todos');
- });
- const hook = createTodoContinuationHook(ctx, { cooldownMs: 50 });
- await hook.tool.auto_continue.execute({ enabled: true });
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 'session-123' },
- },
- });
- await delay(60);
- expect(ctx.client.session.prompt).not.toHaveBeenCalled();
- });
- test('fetch messages failure → skips continuation', async () => {
- const ctx = createMockContext({
- todoResult: {
- data: [
- { id: '1', content: 'todo1', status: 'pending', priority: 'high' },
- ],
- },
- });
- ctx.client.session.messages = mock(async () => {
- throw new Error('Failed to fetch messages');
- });
- const hook = createTodoContinuationHook(ctx, { cooldownMs: 50 });
- await hook.tool.auto_continue.execute({ enabled: true });
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 'session-123' },
- },
- });
- await delay(60);
- expect(ctx.client.session.prompt).not.toHaveBeenCalled();
- });
- });
- describe('command.execute.before interception', () => {
- test('unrelated command → no interception', async () => {
- const ctx = createMockContext();
- const hook = createTodoContinuationHook(ctx);
- const output = { parts: [] as Array<{ type: string; text?: string }> };
- await hook.handleCommandExecuteBefore(
- { command: 'help', sessionID: 'session-123', arguments: '' },
- output,
- );
- expect(output.parts).toHaveLength(0);
- });
- test('/auto-continue enables and injects continuation when incomplete todos', async () => {
- const ctx = createMockContext({
- todoResult: {
- data: [
- {
- id: '1',
- content: 'todo1',
- status: 'pending',
- priority: 'high',
- },
- ],
- },
- });
- const hook = createTodoContinuationHook(ctx);
- const output = { parts: [] as Array<{ type: string; text?: string }> };
- await hook.handleCommandExecuteBefore(
- { command: 'auto-continue', sessionID: 'session-123', arguments: '' },
- output,
- );
- expect(output.parts).toHaveLength(1);
- expect(output.parts[0].text).toContain(
- '[Auto-continue: enabled - there are incomplete todos remaining.',
- );
- expect(output.parts[0].text).toContain(SLIM_INTERNAL_INITIATOR_MARKER);
- });
- test('/auto-continue enables but no continuation when all todos complete', async () => {
- const ctx = createMockContext({
- todoResult: {
- data: [
- {
- id: '1',
- content: 'todo1',
- status: 'completed',
- priority: 'high',
- },
- ],
- },
- });
- const hook = createTodoContinuationHook(ctx);
- const output = { parts: [] as Array<{ type: string; text?: string }> };
- await hook.handleCommandExecuteBefore(
- { command: 'auto-continue', sessionID: 'session-123', arguments: '' },
- output,
- );
- expect(output.parts).toHaveLength(1);
- expect(output.parts[0].text).toContain('No incomplete todos right now');
- });
- test('/auto-continue toggles off when already enabled', async () => {
- const ctx = createMockContext();
- const hook = createTodoContinuationHook(ctx);
- const output = { parts: [] as Array<{ type: string; text?: string }> };
- // Enable via tool
- await hook.tool.auto_continue.execute({ enabled: true });
- // Toggle off via command
- await hook.handleCommandExecuteBefore(
- { command: 'auto-continue', sessionID: 'session-123', arguments: '' },
- output,
- );
- expect(output.parts).toHaveLength(1);
- expect(output.parts[0].text).toContain('disabled by user command');
- });
- test('/auto-continue resets consecutive continuations on toggle', async () => {
- const ctx = createMockContext({
- todoResult: {
- data: [
- {
- id: '1',
- content: 'todo1',
- status: 'pending',
- priority: 'high',
- },
- ],
- },
- messagesResult: {
- data: [
- {
- info: { role: 'assistant' },
- parts: [{ type: 'text', text: 'Working...' }],
- },
- ],
- },
- });
- const hook = createTodoContinuationHook(ctx, {
- maxContinuations: 2,
- cooldownMs: 50,
- });
- // Enable and run up to max
- await hook.tool.auto_continue.execute({ enabled: true });
- for (let i = 0; i < 2; i++) {
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 'session-123' },
- },
- });
- await delay(60);
- }
- // Toggle off then on via command (resets count)
- const outputOff = {
- parts: [] as Array<{ type: string; text?: string }>,
- };
- await hook.handleCommandExecuteBefore(
- { command: 'auto-continue', sessionID: 'session-123', arguments: '' },
- outputOff,
- );
- expect(outputOff.parts[0].text).toContain('disabled');
- const outputOn = {
- parts: [] as Array<{ type: string; text?: string }>,
- };
- await hook.handleCommandExecuteBefore(
- { command: 'auto-continue', sessionID: 'session-123', arguments: '' },
- outputOn,
- );
- // Should have continuation prompt again (count was reset)
- expect(outputOn.parts[0].text).toContain(
- '[Auto-continue: enabled - there are incomplete todos remaining.',
- );
- });
- test('/auto-continue with todo fetch failure → enables without continuation', async () => {
- const ctx = createMockContext();
- ctx.client.session.todo = mock(async () => {
- throw new Error('Network error');
- });
- const hook = createTodoContinuationHook(ctx);
- const output = { parts: [] as Array<{ type: string; text?: string }> };
- await hook.handleCommandExecuteBefore(
- { command: 'auto-continue', sessionID: 'session-123', arguments: '' },
- output,
- );
- // Should still enable but skip continuation (no todos fetched)
- expect(output.parts).toHaveLength(1);
- expect(output.parts[0].text).toContain('No incomplete todos right now');
- });
- });
- describe('config defaults', () => {
- test('default config: maxContinuations = 5, cooldownMs = 3000', async () => {
- const ctx = createMockContext({
- todoResult: {
- data: [
- { id: '1', content: 'todo1', status: 'pending', priority: 'high' },
- ],
- },
- messagesResult: {
- data: [
- {
- info: { role: 'assistant' },
- parts: [{ type: 'text', text: 'Working...' }],
- },
- ],
- },
- });
- const hook = createTodoContinuationHook(ctx); // No config passed
- const result = await hook.tool.auto_continue.execute({ enabled: true });
- expect(result).toContain('up to 5');
- // Test default cooldown - we'll just verify it waits before calling
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 'session-123' },
- },
- });
- // Wait less than default cooldown
- await delay(100);
- expect(hasContinuation(ctx.client.session.prompt)).toBe(false);
- // Wait past default cooldown
- await delay(2900);
- expect(hasContinuation(ctx.client.session.prompt)).toBe(true);
- });
- });
- describe('council review findings', () => {
- describe('CRITICAL-1: counter bypass via session.status→busy', () => {
- test('counter persists when busy fires during auto-injection', async () => {
- let promptResolve!: () => void;
- const ctx = createMockContext({
- todoResult: {
- data: [
- {
- id: '1',
- content: 't1',
- status: 'pending',
- priority: 'high',
- },
- ],
- },
- messagesResult: {
- data: [
- {
- info: { role: 'assistant' },
- parts: [{ type: 'text', text: 'Work' }],
- },
- ],
- },
- });
- // Make prompt hang so isAutoInjecting stays true
- ctx.client.session.prompt = mock(async () => {
- await new Promise<void>((r) => {
- promptResolve = r;
- });
- });
- const hook = createTodoContinuationHook(ctx, {
- maxContinuations: 2,
- cooldownMs: 50,
- });
- await hook.tool.auto_continue.execute({ enabled: true });
- // Cycle 1: idle → timer → prompt hangs
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 's1' },
- },
- });
- await delay(60);
- // Session goes busy from prompt — isAutoInjecting is true,
- // so counter should NOT be reset
- await hook.handleEvent({
- event: {
- type: 'session.status',
- properties: {
- sessionID: 's1',
- status: { type: 'busy' },
- },
- },
- });
- // Resolve prompt → counter = 1
- promptResolve();
- await delay(10);
- // Cycle 2: idle → timer → prompt hangs
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 's1' },
- },
- });
- await delay(60);
- // Session goes busy again — counter still not reset
- await hook.handleEvent({
- event: {
- type: 'session.status',
- properties: {
- sessionID: 's1',
- status: { type: 'busy' },
- },
- },
- });
- // Resolve prompt → counter = 2
- promptResolve();
- await delay(10);
- // Cycle 3: counter = 2 >= maxContinuations = 2 → BLOCKED
- ctx.client.session.prompt = mock(async () => ({}));
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 's1' },
- },
- });
- await delay(60);
- expect(hasContinuation(ctx.client.session.prompt)).toBe(false);
- });
- });
- describe('CRITICAL-2: disable cancels pending timer', () => {
- test('tool disable during cooldown prevents injection', async () => {
- const ctx = createMockContext({
- todoResult: {
- data: [
- {
- id: '1',
- content: 't1',
- status: 'pending',
- priority: 'high',
- },
- ],
- },
- messagesResult: {
- data: [
- {
- info: { role: 'assistant' },
- parts: [{ type: 'text', text: 'Work' }],
- },
- ],
- },
- });
- const hook = createTodoContinuationHook(ctx, { cooldownMs: 100 });
- await hook.tool.auto_continue.execute({ enabled: true });
- // Fire idle → timer scheduled (100ms cooldown)
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 's1' },
- },
- });
- // Disable before timer fires
- await delay(50);
- await hook.tool.auto_continue.execute({ enabled: false });
- // Wait past original cooldown
- await delay(60);
- expect(hasContinuation(ctx.client.session.prompt)).toBe(false);
- });
- test('command disable during cooldown prevents injection', async () => {
- const ctx = createMockContext({
- todoResult: {
- data: [
- {
- id: '1',
- content: 't1',
- status: 'pending',
- priority: 'high',
- },
- ],
- },
- messagesResult: {
- data: [
- {
- info: { role: 'assistant' },
- parts: [{ type: 'text', text: 'Work' }],
- },
- ],
- },
- });
- const hook = createTodoContinuationHook(ctx, { cooldownMs: 100 });
- // Enable via command
- const outputOn = {
- parts: [] as Array<{ type: string; text?: string }>,
- };
- await hook.handleCommandExecuteBefore(
- {
- command: 'auto-continue',
- sessionID: 's1',
- arguments: 'on',
- },
- outputOn,
- );
- // Fire idle → timer scheduled
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 's1' },
- },
- });
- // Disable via command before timer fires
- await delay(50);
- const outputOff = {
- parts: [] as Array<{ type: string; text?: string }>,
- };
- await hook.handleCommandExecuteBefore(
- {
- command: 'auto-continue',
- sessionID: 's1',
- arguments: 'off',
- },
- outputOff,
- );
- // Wait past original cooldown
- await delay(60);
- expect(hasContinuation(ctx.client.session.prompt)).toBe(false);
- });
- });
- describe('MAJOR-1: session.deleted resets counter', () => {
- test('deleted orchestrator session resets counter for next session', async () => {
- const ctx = createMockContext({
- todoResult: {
- data: [
- {
- id: '1',
- content: 't1',
- status: 'pending',
- priority: 'high',
- },
- ],
- },
- messagesResult: {
- data: [
- {
- info: { role: 'assistant' },
- parts: [{ type: 'text', text: 'Work' }],
- },
- ],
- },
- });
- const hook = createTodoContinuationHook(ctx, {
- maxContinuations: 2,
- cooldownMs: 50,
- });
- await hook.tool.auto_continue.execute({ enabled: true });
- // Cycle 1: idle → inject → counter = 1
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 's1' },
- },
- });
- await delay(60);
- // Delete orchestrator session → counter should reset
- await hook.handleEvent({
- event: {
- type: 'session.deleted',
- properties: { sessionID: 's1' },
- },
- });
- // New session becomes orchestrator — counter starts from 0
- ctx.client.session.prompt.mockClear();
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 's2' },
- },
- });
- await delay(60); // counter = 1
- // One more cycle → counter = 2 (reaches max)
- ctx.client.session.prompt.mockClear();
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 's2' },
- },
- });
- await delay(60);
- // Third cycle blocked (counter = 2 >= max = 2)
- ctx.client.session.prompt.mockClear();
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 's2' },
- },
- });
- await delay(60);
- expect(ctx.client.session.prompt).not.toHaveBeenCalled();
- });
- });
- describe('MAJOR-2: suppressUntil cleared on re-enable', () => {
- test('tool re-enable clears suppress window', async () => {
- const ctx = createMockContext({
- todoResult: {
- data: [
- {
- id: '1',
- content: 't1',
- status: 'pending',
- priority: 'high',
- },
- ],
- },
- messagesResult: {
- data: [
- {
- info: { role: 'assistant' },
- parts: [{ type: 'text', text: 'Work' }],
- },
- ],
- },
- });
- const hook = createTodoContinuationHook(ctx, { cooldownMs: 50 });
- await hook.tool.auto_continue.execute({ enabled: true });
- // Fire abort → sets suppress window
- await hook.handleEvent({
- event: {
- type: 'session.error',
- properties: {
- sessionID: 's1',
- error: { name: 'AbortError' },
- },
- },
- });
- // Re-enable within suppress window → clears suppressUntil
- await hook.tool.auto_continue.execute({ enabled: true });
- // Fire idle → should NOT be suppressed
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 's1' },
- },
- });
- await delay(60);
- expect(hasContinuation(ctx.client.session.prompt)).toBe(true);
- });
- test('command re-enable clears suppress window', async () => {
- const ctx = createMockContext({
- todoResult: {
- data: [
- {
- id: '1',
- content: 't1',
- status: 'pending',
- priority: 'high',
- },
- ],
- },
- messagesResult: {
- data: [
- {
- info: { role: 'assistant' },
- parts: [{ type: 'text', text: 'Work' }],
- },
- ],
- },
- });
- const hook = createTodoContinuationHook(ctx, { cooldownMs: 50 });
- await hook.tool.auto_continue.execute({ enabled: true });
- // Fire abort → sets suppress window
- await hook.handleEvent({
- event: {
- type: 'session.error',
- properties: {
- sessionID: 's1',
- error: { name: 'AbortError' },
- },
- },
- });
- // Re-enable via command → clears suppressUntil
- const output = {
- parts: [] as Array<{ type: string; text?: string }>,
- };
- await hook.handleCommandExecuteBefore(
- {
- command: 'auto-continue',
- sessionID: 's1',
- arguments: 'on',
- },
- output,
- );
- // Fire idle → should NOT be suppressed
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 's1' },
- },
- });
- await delay(60);
- expect(hasContinuation(ctx.client.session.prompt)).toBe(true);
- });
- });
- describe('error paths', () => {
- test('prompt failure in timer callback is handled gracefully', async () => {
- const ctx = createMockContext({
- todoResult: {
- data: [
- {
- id: '1',
- content: 't1',
- status: 'pending',
- priority: 'high',
- },
- ],
- },
- messagesResult: {
- data: [
- {
- info: { role: 'assistant' },
- parts: [{ type: 'text', text: 'Work' }],
- },
- ],
- },
- });
- ctx.client.session.prompt = mock(async () => {
- throw new Error('API error');
- });
- const hook = createTodoContinuationHook(ctx, { cooldownMs: 50 });
- // Seed orchestrator session
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 's1' },
- },
- });
- await hook.tool.auto_continue.execute({ enabled: true });
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 's1' },
- },
- });
- await delay(60);
- // Error caught; isAutoInjecting should be cleared via finally.
- // Verify by checking a second idle still works.
- ctx.client.session.prompt = mock(async () => ({}));
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 's1' },
- },
- });
- await delay(60);
- expect(hasContinuation(ctx.client.session.prompt)).toBe(true);
- });
- });
- describe('edge cases', () => {
- test('session.idle with missing sessionID returns early', async () => {
- const ctx = createMockContext();
- const hook = createTodoContinuationHook(ctx);
- await hook.tool.auto_continue.execute({ enabled: true });
- // Fire idle without sessionID — should not throw
- await hook.handleEvent({
- event: { type: 'session.idle', properties: {} },
- });
- expect(ctx.client.session.todo).not.toHaveBeenCalled();
- });
- test('session.deleted with properties.info.id path', async () => {
- const ctx = createMockContext({
- todoResult: {
- data: [
- {
- id: '1',
- content: 't1',
- status: 'pending',
- priority: 'high',
- },
- ],
- },
- messagesResult: {
- data: [
- {
- info: { role: 'assistant' },
- parts: [{ type: 'text', text: 'Work' }],
- },
- ],
- },
- });
- const hook = createTodoContinuationHook(ctx, { cooldownMs: 50 });
- await hook.tool.auto_continue.execute({ enabled: true });
- // Set orchestrator via idle
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 's1' },
- },
- });
- await delay(60);
- expect(hasContinuation(ctx.client.session.prompt)).toBe(true);
- // Delete via info.id path (alternative shape from session store)
- await hook.handleEvent({
- event: {
- type: 'session.deleted',
- properties: { info: { id: 's1' } },
- },
- });
- // New session should become orchestrator
- ctx.client.session.prompt.mockClear();
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 's2' },
- },
- });
- await delay(60);
- expect(hasContinuation(ctx.client.session.prompt)).toBe(true);
- expect(contCall(ctx.client.session.prompt)[0].path.id).toBe('s2');
- });
- test('cooldownMs = 0 fires on next tick', async () => {
- const ctx = createMockContext({
- todoResult: {
- data: [
- {
- id: '1',
- content: 't1',
- status: 'pending',
- priority: 'high',
- },
- ],
- },
- messagesResult: {
- data: [
- {
- info: { role: 'assistant' },
- parts: [{ type: 'text', text: 'Work' }],
- },
- ],
- },
- });
- const hook = createTodoContinuationHook(ctx, {
- cooldownMs: 0,
- maxContinuations: 5,
- });
- await hook.tool.auto_continue.execute({ enabled: true });
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 's1' },
- },
- });
- await delay(10);
- expect(hasContinuation(ctx.client.session.prompt)).toBe(true);
- });
- });
- describe('MAJOR-3: double-fire prevention', () => {
- test('rapid idle events during prompt delivery — single continuation', async () => {
- let promptResolve!: () => void;
- const ctx = createMockContext({
- todoResult: {
- data: [
- {
- id: '1',
- content: 't1',
- status: 'pending',
- priority: 'high',
- },
- ],
- },
- messagesResult: {
- data: [
- {
- info: { role: 'assistant' },
- parts: [{ type: 'text', text: 'Work' }],
- },
- ],
- },
- });
- ctx.client.session.prompt = mock(async () => {
- await new Promise<void>((r) => {
- promptResolve = r;
- });
- });
- const hook = createTodoContinuationHook(ctx, { cooldownMs: 50 });
- await hook.tool.auto_continue.execute({ enabled: true });
- // Fire idle → timer → prompt hangs (isAutoInjecting = true)
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 's1' },
- },
- });
- await delay(60);
- // Fire another idle while prompt is in flight
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 's1' },
- },
- });
- // Only one prompt call (blocked by isAutoInjecting gate)
- expect(contCount(ctx.client.session.prompt)).toBe(1);
- // Resolve prompt
- promptResolve();
- await delay(10);
- // Now idle should schedule a new timer
- ctx.client.session.prompt = mock(async () => ({}));
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 's1' },
- },
- });
- await delay(60);
- expect(contCount(ctx.client.session.prompt)).toBe(1);
- });
- });
- describe('MAJOR-4: command explicit on|off arguments', () => {
- test('command "on" keeps enabled state when already enabled', async () => {
- const ctx = createMockContext();
- const hook = createTodoContinuationHook(ctx);
- // Enable via tool
- await hook.tool.auto_continue.execute({ enabled: true });
- // /auto-continue on → should KEEP enabled (not toggle to off)
- const output = {
- parts: [] as Array<{ type: string; text?: string }>,
- };
- await hook.handleCommandExecuteBefore(
- {
- command: 'auto-continue',
- sessionID: 's1',
- arguments: 'on',
- },
- output,
- );
- expect(output.parts[0].text).not.toContain('disabled');
- });
- test('command "off" keeps disabled state when already disabled', async () => {
- const ctx = createMockContext();
- const hook = createTodoContinuationHook(ctx);
- // Start disabled (default)
- const output = {
- parts: [] as Array<{ type: string; text?: string }>,
- };
- await hook.handleCommandExecuteBefore(
- {
- command: 'auto-continue',
- sessionID: 's1',
- arguments: 'off',
- },
- output,
- );
- expect(output.parts[0].text).toContain('disabled');
- });
- test('command with no argument toggles state', async () => {
- const ctx = createMockContext();
- const hook = createTodoContinuationHook(ctx);
- // First toggle: disabled → enabled
- const output1 = {
- parts: [] as Array<{ type: string; text?: string }>,
- };
- await hook.handleCommandExecuteBefore(
- {
- command: 'auto-continue',
- sessionID: 's1',
- arguments: '',
- },
- output1,
- );
- expect(output1.parts[0].text).not.toContain('disabled');
- // Second toggle: enabled → disabled
- const output2 = {
- parts: [] as Array<{ type: string; text?: string }>,
- };
- await hook.handleCommandExecuteBefore(
- {
- command: 'auto-continue',
- sessionID: 's1',
- arguments: '',
- },
- output2,
- );
- expect(output2.parts[0].text).toContain('disabled');
- });
- });
- });
- describe('auto-enable on todo count', () => {
- function createAutoEnableCtx(
- todos: Array<{
- id: string;
- content: string;
- status: string;
- priority: string;
- }>,
- ) {
- return createMockContext({
- todoResult: { data: todos },
- messagesResult: {
- data: [
- {
- info: { role: 'assistant' },
- parts: [{ type: 'text', text: 'Working...' }],
- },
- ],
- },
- });
- }
- test('autoEnable=true, todos >= threshold → auto-enables and continues', async () => {
- const ctx = createAutoEnableCtx([
- { id: '1', content: 't1', status: 'pending', priority: 'high' },
- { id: '2', content: 't2', status: 'pending', priority: 'high' },
- { id: '3', content: 't3', status: 'pending', priority: 'high' },
- { id: '4', content: 't4', status: 'pending', priority: 'high' },
- ]);
- const hook = createTodoContinuationHook(ctx, {
- maxContinuations: 5,
- cooldownMs: 50,
- autoEnable: true,
- autoEnableThreshold: 4,
- });
- // Do NOT manually enable — auto-enable should trigger
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 's1' },
- },
- });
- await delay(60);
- // Should have scheduled continuation (auto-enabled)
- expect(hasContinuation(ctx.client.session.prompt)).toBe(true);
- });
- test('autoEnable=true, todos < threshold → does NOT auto-enable', async () => {
- const ctx = createAutoEnableCtx([
- { id: '1', content: 't1', status: 'pending', priority: 'high' },
- { id: '2', content: 't2', status: 'pending', priority: 'high' },
- { id: '3', content: 't3', status: 'pending', priority: 'high' },
- ]);
- const hook = createTodoContinuationHook(ctx, {
- maxContinuations: 5,
- cooldownMs: 50,
- autoEnable: true,
- autoEnableThreshold: 4,
- });
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 's1' },
- },
- });
- await delay(60);
- // Should NOT auto-enable or continue
- expect(ctx.client.session.prompt).not.toHaveBeenCalled();
- });
- test('autoEnable=false (default) → never auto-enables regardless of todo count', async () => {
- const ctx = createAutoEnableCtx(
- Array.from({ length: 10 }, (_, i) => ({
- id: String(i),
- content: `t${i}`,
- status: 'pending',
- priority: 'high',
- })),
- );
- const hook = createTodoContinuationHook(ctx, {
- maxContinuations: 5,
- cooldownMs: 50,
- // autoEnable defaults to false
- });
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 's1' },
- },
- });
- await delay(60);
- expect(ctx.client.session.prompt).not.toHaveBeenCalled();
- });
- test('auto-enable does not re-enable if already manually enabled', async () => {
- const ctx = createAutoEnableCtx([
- { id: '1', content: 't1', status: 'pending', priority: 'high' },
- { id: '2', content: 't2', status: 'pending', priority: 'high' },
- ]);
- const hook = createTodoContinuationHook(ctx, {
- maxContinuations: 5,
- cooldownMs: 50,
- autoEnable: true,
- autoEnableThreshold: 4,
- });
- // Manually enable first
- await hook.tool.auto_continue.execute({ enabled: true });
- // Only 2 todos (< threshold) — but already enabled, so should continue
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 's1' },
- },
- });
- await delay(60);
- // Continues because already manually enabled (auto-enable check skipped)
- expect(hasContinuation(ctx.client.session.prompt)).toBe(true);
- });
- test('auto-enable respects custom threshold', async () => {
- const ctx = createAutoEnableCtx([
- { id: '1', content: 't1', status: 'pending', priority: 'high' },
- { id: '2', content: 't2', status: 'pending', priority: 'high' },
- ]);
- const hook = createTodoContinuationHook(ctx, {
- maxContinuations: 5,
- cooldownMs: 50,
- autoEnable: true,
- autoEnableThreshold: 2,
- });
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 's1' },
- },
- });
- await delay(60);
- // 2 todos >= threshold 2 → auto-enables
- expect(hasContinuation(ctx.client.session.prompt)).toBe(true);
- });
- test('auto-enable skipped for non-orchestrator session', async () => {
- const ctx = createAutoEnableCtx([
- { id: '1', content: 't1', status: 'pending', priority: 'high' },
- { id: '2', content: 't2', status: 'pending', priority: 'high' },
- { id: '3', content: 't3', status: 'pending', priority: 'high' },
- { id: '4', content: 't4', status: 'pending', priority: 'high' },
- ]);
- const hook = createTodoContinuationHook(ctx, {
- maxContinuations: 5,
- cooldownMs: 50,
- autoEnable: true,
- autoEnableThreshold: 4,
- });
- // First idle sets orchestrator to session-A
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 'session-A' },
- },
- });
- await delay(60);
- // Reset mock
- ctx.client.session.prompt.mockClear();
- // Second idle from session-B — not orchestrator, should skip
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 'session-B' },
- },
- });
- await delay(60);
- expect(ctx.client.session.prompt).not.toHaveBeenCalled();
- });
- test('auto-enable with todo fetch failure → no auto-enable, no crash', async () => {
- const ctx = createMockContext();
- ctx.client.session.todo = mock(async () => {
- throw new Error('Network error');
- });
- const hook = createTodoContinuationHook(ctx, {
- maxContinuations: 5,
- cooldownMs: 50,
- autoEnable: true,
- autoEnableThreshold: 4,
- });
- // Should not throw
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 's1' },
- },
- });
- await delay(60);
- // No auto-enable, no continuation
- expect(ctx.client.session.prompt).not.toHaveBeenCalled();
- });
- test('auto-enable resets consecutive counter and suppress window', async () => {
- const ctx = createAutoEnableCtx([
- { id: '1', content: 't1', status: 'pending', priority: 'high' },
- { id: '2', content: 't2', status: 'pending', priority: 'high' },
- { id: '3', content: 't3', status: 'pending', priority: 'high' },
- { id: '4', content: 't4', status: 'pending', priority: 'high' },
- ]);
- const hook = createTodoContinuationHook(ctx, {
- maxContinuations: 5,
- cooldownMs: 50,
- autoEnable: true,
- autoEnableThreshold: 4,
- });
- // Manually enable, run a continuation, disable
- await hook.tool.auto_continue.execute({ enabled: true });
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 's1' },
- },
- });
- await delay(60);
- // Fire abort to set suppress window
- await hook.handleEvent({
- event: {
- type: 'session.error',
- properties: {
- sessionID: 's1',
- error: { name: 'AbortError' },
- },
- },
- });
- // Disable
- await hook.tool.auto_continue.execute({ enabled: false });
- // Reset mock
- ctx.client.session.prompt.mockClear();
- // Fire idle again — auto-enable should trigger (4 todos >= 4),
- // resetting counter and suppress window
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 's1' },
- },
- });
- await delay(60);
- // Should continue (suppressed window was cleared by auto-enable)
- expect(hasContinuation(ctx.client.session.prompt)).toBe(true);
- });
- test('auto-enable counts incomplete todos only, not completed', async () => {
- const ctx = createAutoEnableCtx([
- { id: '1', content: 't1', status: 'completed', priority: 'high' },
- { id: '2', content: 't2', status: 'completed', priority: 'high' },
- { id: '3', content: 't3', status: 'pending', priority: 'high' },
- { id: '4', content: 't4', status: 'pending', priority: 'high' },
- ]);
- const hook = createTodoContinuationHook(ctx, {
- maxContinuations: 5,
- cooldownMs: 50,
- autoEnable: true,
- autoEnableThreshold: 4,
- });
- await hook.handleEvent({
- event: {
- type: 'session.idle',
- properties: { sessionID: 's1' },
- },
- });
- await delay(60);
- // Only 2 incomplete todos < threshold 4 → does NOT auto-enable
- expect(ctx.client.session.prompt).not.toHaveBeenCalled();
- });
- });
- });
|