Browse Source

[503] Tasks that run when changed should likely be handlers

Signed-off-by: Jared Ledvina <jared@techsmix.net>
Jared Ledvina 6 năm trước cách đây
mục cha
commit
c71d862380

+ 1 - 1
tasks/Amazon/rabbit.yml

@@ -36,7 +36,7 @@
 
 
 # HACK: https://github.com/ansible/ansible/issues/20711#issuecomment-306260869
 # HACK: https://github.com/ansible/ansible/issues/20711#issuecomment-306260869
 # Can be removed once we're running w/ a version of Ansible that has https://github.com/ansible/ansible/pull/35989
 # Can be removed once we're running w/ a version of Ansible that has https://github.com/ansible/ansible/pull/35989
-- name: Make yum cache to import GPG keys
+- name: Make yum cache to import GPG keys # noqa 503 - Order really matters here and flush handlers is too much for this
   tags: rabbitmq
   tags: rabbitmq
   command: "yum -q makecache -y --disablerepo='*' --enablerepo='{{ item }}'"
   command: "yum -q makecache -y --disablerepo='*' --enablerepo='{{ item }}'"
   args:
   args:

+ 1 - 1
tasks/CentOS/rabbit.yml

@@ -36,7 +36,7 @@
 
 
 # HACK: https://github.com/ansible/ansible/issues/20711#issuecomment-306260869
 # HACK: https://github.com/ansible/ansible/issues/20711#issuecomment-306260869
 # Can be removed once we're running w/ a version of Ansible that has https://github.com/ansible/ansible/pull/35989
 # Can be removed once we're running w/ a version of Ansible that has https://github.com/ansible/ansible/pull/35989
-- name: Make yum cache to import GPG keys
+- name: Make yum cache to import GPG keys # noqa 503 - Order really matters here and flush handlers is too much for this
   tags: rabbitmq
   tags: rabbitmq
   command: "yum -q makecache -y --disablerepo='*' --enablerepo='{{ item }}'"
   command: "yum -q makecache -y --disablerepo='*' --enablerepo='{{ item }}'"
   args:
   args:

+ 1 - 1
tasks/Fedora/rabbit.yml

@@ -36,7 +36,7 @@
 
 
 # HACK: https://github.com/ansible/ansible/issues/20711#issuecomment-306260869
 # HACK: https://github.com/ansible/ansible/issues/20711#issuecomment-306260869
 # Can be removed once we're running w/ a version of Ansible that has https://github.com/ansible/ansible/pull/35989
 # Can be removed once we're running w/ a version of Ansible that has https://github.com/ansible/ansible/pull/35989
-- name: Make yum cache to import GPG keys
+- name: Make yum cache to import GPG keys # noqa 503 - Order really matters here and flush handlers is too much for this
   tags: rabbitmq
   tags: rabbitmq
   command: "yum -q makecache -y --disablerepo='*' --enablerepo='{{ item }}'"
   command: "yum -q makecache -y --disablerepo='*' --enablerepo='{{ item }}'"
   args:
   args: